[{"id":3681488,"web_url":"http://patchwork.ozlabs.org/comment/3681488/","msgid":"<0a99894e-48d3-413b-84ef-48bc754345b9@linaro.org>","list_archive_url":null,"date":"2026-04-23T14:13:33","subject":"Re: [PATCH 6/9] target/s390x: Compile vec_helper.c as common unit","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 23/4/26 15:50, Philippe Mathieu-Daudé wrote:\n> In order do build vec_helper.c as a common unit we need to\n> replace:\n> \n> \"accel/tcg/cpu-ldst.h\" -> \"accel/tcg/cpu-ldst-common.h\"\n> \n> and update the cpu_ld/st_be_data_ra() API by cpu_ld/st_mmu() one.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> Unrelated but could VLL / VSTL leverage the Int128 type?\n\nSelf-answered:\nhttps://lore.kernel.org/qemu-devel/20260423141245.51344-1-philmd@linaro.org/\n\n> ---\n> target/s390x/tcg/vec_helper.c | 34 +++++++++++++++++++++++-----------\n> target/s390x/tcg/meson.build | 2 +-\n> 2 files changed, 24 insertions(+), 12 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CF1KJ+e3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1dPw3SNnz1yD5\n\tfor ; Fri, 24 Apr 2026 00:14:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFuop-0002Gc-9F; Thu, 23 Apr 2026 10:14:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFuoG-00025u-EI\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 10:13:45 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFuoE-0004hH-OF\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 10:13:40 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so109745565e9.2\n for ; Thu, 23 Apr 2026 07:13:38 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-44123d23e0bsm14438127f8f.15.2026.04.23.07.13.35\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 07:13:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776953617; x=1777558417; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=TvH65QbAvp8B/9Rqo95l65ztoKih/x1ELMtq4S1ebzU=;\n b=CF1KJ+e31CDp+2ui6XgXehC7egZ6xezB5Q4oigTYfsB4Qj6wUvzoxq4HfEjri+lzQP\n R+zdSRC/2jxF+GFlUFENK8CeeRKCNysH6mMOafcqp0xGmPexVsizFZ5+T7scig4+ic23\n AZr5ol++CuRgcvb/C2ctZ/5KbNeVjlv9BP+dLRZiRDff+ywa7XFWz91LzIcUiv+7hRqD\n 7sF1fr14BLQe3eKBzZZZzJwiX1XNFlF+at6gUwfABxQGHGawmNE/AWWNMQa4PbWMmNNR\n jo35C4VR5lGxrb0ElFm/4j6iyWqgvocS4NUMExkFUwvWl7QQpgO/qMOQBMW4eefhzjPF\n Twzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776953617; x=1777558417;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=TvH65QbAvp8B/9Rqo95l65ztoKih/x1ELMtq4S1ebzU=;\n b=svo6qn5abO8zJ36VHrDjKJOp73bvu1JWQ3jFSI3zMQIhz6OIQHNbMKwnJ0+dQeUPcm\n ErmRk++AcTcM/8zzCpSJVZ0KRyU1Qr+b+zzxe4lYh3QQe6UXZ+b79sAFa8WxoVv3GVyk\n RpHfjkYj0xjuzSER9ADjAyADEs6P5dQaF79rImiNgFqvmZZ9q8lw/eIGpN4Sfbawmx8Z\n tSnP0F7mYP7d0aiOioNl4Ekxq97+5h58br4fZVHu1e3BYD9YLRzCtZ919z3642oYmUzH\n UoIoWb4vo5Pbi/RUqiY1Ahfr0j9SQsfrlxbYsuuLFAf1ruoMjKCc5Iqv9UUaNaXFBxRC\n 6M9w==","X-Gm-Message-State":"AOJu0YynShYB+eK/j10B97Rg6sZ/r7bTndFwWBOC16dDCxCw/84A9REI\n K4Hl0MhUBhACdfW9ShvneZaQkt5rBdgyzqvyMh9p1O2pw7QV6k7ENgVEbSonitlyJlfsuyEJRHo\n wdutka8Y=","X-Gm-Gg":"AeBDieuIKkBFE1LyMGk8yj6zqWWvTcMdhpRuomIQZiakPwKad6oQ3JC1ij23+4jpvCs\n 2m9/HOSdNbOMGBFfB/DayjEQMO/7q8+Utz93qVEDTx9R+eGRYbjGfsZhDN0q4U8ZozaCORxWfhx\n UPAVpnnN47budNDElcR4ZCZBPj4BcRjw4qbLlYGGNIH/FyWXDfXnxIx7WEFrrIQudYxzfP23y5X\n ULjhQL1BN+0j0AP8ZhGZQIYaOD9tHSx6SsJirra6u76XmYSKRH1JbUZ8Rz6DwOkxKLCDZjqp5nO\n 10fS3CBMJRPQO8+37OZ2nXyQ5ow42mlm1DcgvxV3fMlejIU5a3K3mFSnNv7vvSNKssqj04pBrF3\n /TdHs89cqvILeSwnvXJhm7flC6cReSTfT1BzK1ehRmZfIKWidqQQhpA1ELS6TYM9t+zt5zR5bI+\n aqPmOuqG72XMyyHVFzdUbVPaVhzKAXgslrwhZEWJm3ruZuYCTPZUnbg4LqH5PblvA+TUdcPCp1f\n tHR","X-Received":"by 2002:a05:600c:1da1:b0:488:f453:b976 with SMTP id\n 5b1f17b1804b1-488fb7844c5mr430918455e9.27.1776953616647;\n Thu, 23 Apr 2026 07:13:36 -0700 (PDT)","Message-ID":"<0a99894e-48d3-413b-84ef-48bc754345b9@linaro.org>","Date":"Thu, 23 Apr 2026 16:13:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/9] target/s390x: Compile vec_helper.c as common unit","Content-Language":"en-US","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Ilya Leoshkevich , qemu-s390x@nongnu.org,\n Matthew Rosato , David Hildenbrand\n , Richard Henderson ,\n Halil Pasic , Cornelia Huck ,\n Eric Farman ,\n Christian Borntraeger ,\n Anton Johansson ","References":"<20260423135035.50126-1-philmd@linaro.org>\n <20260423135035.50126-7-philmd@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260423135035.50126-7-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681534,"web_url":"http://patchwork.ozlabs.org/comment/3681534/","msgid":"<967885ce-9a05-42b3-b2ca-b228c8bebd55@linux.ibm.com>","list_archive_url":null,"date":"2026-04-23T15:31:11","subject":"Re: [PATCH 6/9] target/s390x: Compile vec_helper.c as common unit","submitter":{"id":74525,"url":"http://patchwork.ozlabs.org/api/people/74525/","name":"Ilya Leoshkevich","email":"iii@linux.ibm.com"},"content":"On 4/23/26 14:50, Philippe Mathieu-Daudé wrote:\n> In order do build vec_helper.c as a common unit we need to\n> replace:\n>\n> \"accel/tcg/cpu-ldst.h\" -> \"accel/tcg/cpu-ldst-common.h\"\n>\n> and update the cpu_ld/st_be_data_ra() API by cpu_ld/st_mmu() one.\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> Unrelated but could VLL / VSTL leverage the Int128 type?\n> ---\n> target/s390x/tcg/vec_helper.c | 34 +++++++++++++++++++++++-----------\n> target/s390x/tcg/meson.build | 2 +-\n> 2 files changed, 24 insertions(+), 12 deletions(-)\n\nReviewed-by: Ilya Leoshkevich \n\n\nIIUC, we are open-coding these functions because the wrappers refer to \ntarget-specific abi_ptr and are therefore effectively deprecated.\n\nDoes docs/devel/loads-stores.rst need to be updated to reflect \nthis? Currently it states:\n\n\n``cpu_{ld,st}*_data_ra``\n~~~~~~~~~~~~~~~~~~~~~~~~\n[...]\n\nThese are generally the preferred way to do accesses by guest\nvirtual address from helper functions, unless the access should\nbe performed with a context other than the default, or alignment\nshould be enforced for the access.\n\n\nAnd it's a pleasant surprise to learn that `for (int i` is in fact \nallowed by docs/devel/style.rst.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=dv1iuhW3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1g8T19qZz1yD5\n\tfor ; Fri, 24 Apr 2026 01:32:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFw1x-0000XF-Si; Thu, 23 Apr 2026 11:31:53 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFw1V-0000Sq-2Q; Thu, 23 Apr 2026 11:31:30 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFw1S-0004lq-Jk; Thu, 23 Apr 2026 11:31:24 -0400","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63N6g4jj3516951; Thu, 23 Apr 2026 15:31:17 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dpeu29e8p-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 15:31:17 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63NFKPTq017161;\n Thu, 23 Apr 2026 15:31:16 GMT","from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dpjkyf5yh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 15:31:16 +0000 (GMT)","from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com\n [10.20.54.104])\n by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63NFVCBR51315128\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 23 Apr 2026 15:31:12 GMT","from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 7E5C420043;\n Thu, 23 Apr 2026 15:31:12 +0000 (GMT)","from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 024E520040;\n Thu, 23 Apr 2026 15:31:12 +0000 (GMT)","from [0.0.0.0] (unknown [9.111.71.73])\n by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 23 Apr 2026 15:31:11 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=iwXSsO\n DN2+7boj8NrskZGZiiqiFSUbQvG+2m7uNCH3g=; b=dv1iuhW3vXACorQIWURLqt\n Y9YyurHa1PP0buKhV01vbVpG4fU0rlMO/pVVTt64PhhGIc3CejlV5Cc9nVGaNcRh\n xMeJaOPHHovxJpWrur5tWwBlp44M5dARrEr5Jc2LQ/Oe9516yXieWBDMllVpYolI\n WegdOQlRQRsfjyrm5+1U7xZZUAWuvhaqrnZXovD9wWIE6HiFXxg9yFclArTzGSIV\n 5EzmIOrv54A/qGBDyXrTgGFrEQiUFNs2zaKp+pe+lt6eAwS7JJ396ZAlwLWOiM+U\n eUzskd1LL+vYLwkUF2GEFZfl61PgJmxL/URtXReq9K8xUo9YNE1S05006IA802zQ\n ==","Message-ID":"<967885ce-9a05-42b3-b2ca-b228c8bebd55@linux.ibm.com>","Date":"Thu, 23 Apr 2026 17:31:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/9] target/s390x: Compile vec_helper.c as common unit","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n qemu-s390x@nongnu.org, Matthew Rosato ,\n David Hildenbrand ,\n Richard Henderson ,\n Halil Pasic , Cornelia Huck ,\n Eric Farman ,\n Christian Borntraeger ,\n Anton Johansson ","References":"<20260423135035.50126-1-philmd@linaro.org>\n <20260423135035.50126-7-philmd@linaro.org>","Content-Language":"en-US","From":"Ilya Leoshkevich ","In-Reply-To":"<20260423135035.50126-7-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDE1MyBTYWx0ZWRfX7SIYGc7ke6nT\n 5d6YVdTh6lBx4q4uW4WvRTZlrM+JOWpm3bmzDJ74WR2/vDpcTS6vgadvfzAn56rnoBohXPRZbXC\n lKT4LDyyVfit/QeUi3paLXgkzDLRD+5aBD2WOn7B61mPQT2O4pW8/c25rx3KAO7hGby0cJyjhrJ\n kj2ZNS4WMcTg0LzeF+zwwwl7pmnoEUggUolJOEVWw51CJy7VcM+HDYh00H38gtnUMqqy0hHU/j/\n r092yHMvawm6uBgvOVbOc0Ly8i8HO1Z+ByKSyCnFonma4VimU3lV69PrMeQtN21LGcamSX4zLsq\n 2n6F1dmUc6mcbrFt06kGOjZRdThjfHdlQ+RiESmfSodhT3ZcUpBSWiTG7DKXsYN+JUjPK99UaAZ\n uqS2l3Fe+x0Iyaa6+d+AdfmhcRJBZndU/JjPUW+QkxR0iEsTOtuuR1XOyVuPpCxCscDcHoABQ1t\n w4mX56Pb7e+go46Au4w==","X-Proofpoint-ORIG-GUID":"ZkEAfFCVth3asf5gxLcPnhP9DgdiOM1l","X-Proofpoint-GUID":"ZkEAfFCVth3asf5gxLcPnhP9DgdiOM1l","X-Authority-Analysis":"v=2.4 cv=XMUAjwhE c=1 sm=1 tr=0 ts=69ea3b45 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=KKAkSRfTAAAA:8\n a=VnNF1IyMAAAA:8 a=UX6aIm688bfipJbzXcUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0\n spamscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230153","Received-SPF":"pass client-ip=148.163.156.1; envelope-from=iii@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]