Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2225020/?format=api
{ "id": 2225020, "url": "http://patchwork.ozlabs.org/api/patches/2225020/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260420093856.123681-1-lgs201920130244@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260420093856.123681-1-lgs201920130244@gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260420093856.123681-1-lgs201920130244@gmail.com/", "date": "2026-04-20T09:38:56", "name": "powerpc/pseries/papr-hvpipe: fix NULL dereference in handle creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "59e99ac7f2632b262ba945e450c16f114637861f", "submitter": { "id": 91722, "url": "http://patchwork.ozlabs.org/api/people/91722/?format=api", "name": "Guangshuo Li", "email": "lgs201920130244@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260420093856.123681-1-lgs201920130244@gmail.com/mbox/", "series": [ { "id": 500574, "url": "http://patchwork.ozlabs.org/api/series/500574/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500574", "date": "2026-04-20T09:38:56", "name": "powerpc/pseries/papr-hvpipe: fix NULL dereference in handle creation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500574/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225020/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2225020/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19846-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=q448WtmU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19846-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::52e\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=q448WtmU;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::52e; helo=mail-pg1-x52e.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzgRk5gzWz1yD4\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 19:39:14 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fzgRj6HHxz2yr0;\n\tMon, 20 Apr 2026 19:39:13 +1000 (AEST)", "from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n [IPv6:2607:f8b0:4864:20::52e])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fzgRg53twz2ynn\n\tfor <linuxppc-dev@lists.ozlabs.org>; Mon, 20 Apr 2026 19:39:10 +1000 (AEST)", "by mail-pg1-x52e.google.com with SMTP id\n 41be03b00d2f7-c736261ee8dso918655a12.1\n for <linuxppc-dev@lists.ozlabs.org>;\n Mon, 20 Apr 2026 02:39:10 -0700 (PDT)", "from lgs.. ([2408:8417:d50:4775:2038:6723:d0d:eba3])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8ebb33fcsm9681407b3a.33.2026.04.20.02.39.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 02:39:07 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776677953;\n\tcv=none;\n b=okZOCNaal8OBVP0Soe4xNnP3LiUHIoJG9hEYnT69Y2xBVnTHIxHoZor2Xfy6KCt0eah24jAhT7Ev3c58K/knNQ6+QmzWHDZH584iMS/gvD/BwP3AZX9bb9zhzBVudMjuKOlYYPr2Md2XPnH5SRhoglxPLZo7C1/WT1b4uOpLvLeG0f0LiWSsEzzuzgjChcFBiSfWL2/Cq+8K7odd3W3ntVIeDlX+Re05Uc2nQT2ThVU0BVOW7CvVZQLmOJ9K3vQS/F0y3QxWhUFdMznwwkiCangixjXBATqqeNIN3EHR8Hx9GEecYo45C/BBKXC5u5UiR1nAM4q3Hc0NwemdvZqmrw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776677953; c=relaxed/relaxed;\n\tbh=KCVZolkJ/jGGZ3sp1HB4+a9dT+5CyB5mH+bc98lNAj8=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=WL0tv78ZSBs9tOE8dWAYFS89jUjDOKZxgxoWSE5CxXeuR8klUTgZO+0yBW4r8x8uCu9mwWa8Hz280j2dCt7cVZIhyASOlKfbXpd7KnjXZtB5QOp5M7MCK8QYFSRPsKfZbR0g7sjnNpgcILw8q6nc/d7nYm0CT9kJLigoL7qjb0rB0JSzBPeVZXFFLK9g3+uqXWzDUCqU8CeZvtguzq2yILr+y7oQf6cSv35HQXqilY7ErII12k/aQeO+Tokes7XsNH73VOyUHhgVnOdgT22xIE8T3IuirzsmX58q8c0LmKIFmJ1h3j9+vPoXC55IADgxAoUHMkc67wTodDzm3lWWxA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=q448WtmU; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::52e; helo=mail-pg1-x52e.google.com;\n envelope-from=lgs201920130244@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776677948; x=1777282748;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=KCVZolkJ/jGGZ3sp1HB4+a9dT+5CyB5mH+bc98lNAj8=;\n b=q448WtmUcdboHoDAwPeyv+tliQ6CZMK/5WKuSLASFvn2lvvyG5Tfm22haGV/YE2s+M\n DpQBMIWpxSuI3Baksb5VszWEHp8SxsI7Y1O8ynUFsZCGTWVQ1STj0ja1lOfEsQiYqRBh\n t9IOMLd0qkxaW1ANMmqQ/Kz4DYhTrzWQX/xvWUuOJBX0Mb3aBnkz4s8WB7WdfQltl7ly\n UosMNbi8c6tqyNYWppKYzmoPyDIerbJvcVsg0RKCwi4nv/uyUb54nspWRjjxblObNKIQ\n rEhuNnrwKATbrZT/BK0RQDeIOB36BeVT0jEM9fou3cG9Lmy1PG8jvgSAiXJ89SbpS2Tb\n mOew==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776677948; x=1777282748;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KCVZolkJ/jGGZ3sp1HB4+a9dT+5CyB5mH+bc98lNAj8=;\n b=qse/NaGxCLNE/8/xMc7KYOo13UpvbiY3NH3c+9CxSy3QqIOsdyv2sp/CiKPWoLQW1p\n 1sJfloMSnovjmyTxGgLFQyLqFRUOZYVzqSg6XeZiIzjJQMZDn6FgQX2wMlT2pXnBLI0T\n 7iixTsf3YPUwkYWu/0jQ2J9jcl7bWkSVI80cCirB37lckBO9/8lT5+3QQIGQrCWY1JL0\n vr3aYv9e4YAHnRbNXKnNa5ASRDfCzKoVOxdSY/yculW37uB/ir+19Sgl59FLaQsMiRAC\n RaR4SI19kpYQ5Jcubsg/PLFxWCekIWvTQ25jBepxv1cHWPLPVQ2PqMv4crC8aQc38WdY\n nNug==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ98Hv7Qv9IBlSM085UKpRnm+ZmkptzPom9tA0DU172xmvYze6Ic7pzpoPIEM7iTb8DsuKZhzRCA6Lc6Src=@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YwbDULiSa5pXpkD1TAdQBPabSIvQ6hCYhJ3EiewlpsjX3q7KlC5\n\tuasfCKd10izkv7OkB+u65RKekHu84X5arhQGAzJJ8ZbrNgS4TIHGAmuA", "X-Gm-Gg": "AeBDieshD3zFmh+k3VzGvBYCtP6VJ0aVl7PU8ZBBb9p5yS1lnzmWwUT/aB2m5NK41pQ\n\tdaqjNFD3OrAad4uquqOTnnrp8ZTRaamI+5QBumWwsNNsd3KHH1Wg0qpWlVBDFrQ9Dl5u+4DkVPB\n\tzkfzK5r7RWaxZ8VPA1oMJSVV7SH4VnEUS3Rn9CxASd5z+zKSeIJvzLxAnF49FsWOMFEGpRyBA9j\n\tgE2KTUOZcUcxLG2ljL1JAUlEOQqnOgZ75j+wGOu7nEUSJzjTe8k16oLJidizYNJhHFG7d8sXZgT\n\tqnKEPgSvXDO8VHhJRREkSYWeo2WIEB1ZkbfMZ4QngdKY+TeSdGGPEhV5GbvP0p+Jgq4LgNxbuM2\n\tTPkldpd2ox2ThLVx9J2FSIbzeotT4K25ukbn7rY+Dc8V4gy0Gzx9UmY1+2LuCIUyA1mpcISYeRh\n\tUvrgeDA41ZA6s3hJ5u+tW1iFHLfZ9clr/U", "X-Received": "by 2002:a05:6a00:340e:b0:82a:fc5:fb81 with SMTP id\n d2e1a72fcca58-82f8c7d109emr13729867b3a.5.1776677947512;\n Mon, 20 Apr 2026 02:39:07 -0700 (PDT)", "From": "Guangshuo Li <lgs201920130244@gmail.com>", "To": "Madhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tMahesh Salgaonkar <mahesh@linux.ibm.com>,\n\tTyrel Datwyler <tyreld@linux.ibm.com>,\n\tHaren Myneni <haren@linux.ibm.com>,\n\tGuangshuo Li <lgs201920130244@gmail.com>,\n\tChristian Brauner <brauner@kernel.org>,\n\tKees Cook <kees@kernel.org>,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org", "Cc": "stable@vger.kernel.org", "Subject": "[PATCH] powerpc/pseries/papr-hvpipe: fix NULL dereference in handle\n creation", "Date": "Mon, 20 Apr 2026 17:38:56 +0800", "Message-ID": "<20260420093856.123681-1-lgs201920130244@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,\n\tFROM_LOCAL_DIGITS,FROM_LOCAL_HEX,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "papr_hvpipe_dev_create_handle() transfers ownership of src_info with\nretain_and_null_ptr(src_info) after anon_inode_getfile() succeeds.\nHowever, retain_and_null_ptr() clears src_info immediately, and the\nfunction then still dereferences src_info in the subsequent list_add().\n\nStore the transferred pointer in a separate variable and use that for\nthe list insertion.\n\nManually identified during code review.\n\nFixes: 6d3789d347a7af5c4b0b2da3af47b8d9da607ab2 (\"papr-hvpipe: convert papr_hvpipe_dev_create_handle() to FD_PREPARE()\")\nCc: stable@vger.kernel.org\nSigned-off-by: Guangshuo Li <lgs201920130244@gmail.com>\n---\n arch/powerpc/platforms/pseries/papr-hvpipe.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/platforms/pseries/papr-hvpipe.c\nindex 14ae480d060a..497eb967611b 100644\n--- a/arch/powerpc/platforms/pseries/papr-hvpipe.c\n+++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c\n@@ -480,6 +480,7 @@ static const struct file_operations papr_hvpipe_handle_ops = {\n static int papr_hvpipe_dev_create_handle(u32 srcID)\n {\n \tstruct hvpipe_source_info *src_info __free(kfree) = NULL;\n+\tstruct hvpipe_source_info *owned_src_info;\n \n \tspin_lock(&hvpipe_src_list_lock);\n \t/*\n@@ -509,7 +510,7 @@ static int papr_hvpipe_dev_create_handle(u32 srcID)\n \tif (fdf.err)\n \t\treturn fdf.err;\n \n-\tretain_and_null_ptr(src_info);\n+\towned_src_info = retain_and_null_ptr(src_info);\n \tspin_lock(&hvpipe_src_list_lock);\n \t/*\n \t * If two processes are executing ioctl() for the same\n@@ -520,7 +521,7 @@ static int papr_hvpipe_dev_create_handle(u32 srcID)\n \t\tspin_unlock(&hvpipe_src_list_lock);\n \t\treturn -EALREADY;\n \t}\n-\tlist_add(&src_info->list, &hvpipe_src_list);\n+\tlist_add(&owned_src_info->list, &hvpipe_src_list);\n \tspin_unlock(&hvpipe_src_list_lock);\n \treturn fd_publish(fdf);\n }\n", "prefixes": [] }