[{"id":3679329,"web_url":"http://patchwork.ozlabs.org/comment/3679329/","msgid":"<2026042009-lesser-refrain-c154@gregkh>","date":"2026-04-20T09:44:24","subject":"Re: [PATCH] powerpc/pseries/papr-hvpipe: fix NULL dereference in\n handle creation","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Mon, Apr 20, 2026 at 05:38:56PM +0800, Guangshuo Li wrote:\n> papr_hvpipe_dev_create_handle() transfers ownership of src_info with\n> retain_and_null_ptr(src_info) after anon_inode_getfile() succeeds.\n> However, retain_and_null_ptr() clears src_info immediately, and the\n> function then still dereferences src_info in the subsequent list_add().\n> \n> Store the transferred pointer in a separate variable and use that for\n> the list insertion.\n> \n> Manually identified during code review.\n> \n> Fixes: 6d3789d347a7af5c4b0b2da3af47b8d9da607ab2 (\"papr-hvpipe: convert papr_hvpipe_dev_create_handle() to FD_PREPARE()\")\n\nPlease use the proper notation here, as the documentation asks you to.\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org\n header.a=rsa-sha256 header.s=korg header.b=On12/JsX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19847-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linuxfoundation.org","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org\n header.a=rsa-sha256 header.s=korg header.b=On12/JsX;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzgYr2DLcz1yGs\n\tfor ; Mon, 20 Apr 2026 19:44:32 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fzgYq3YW1z2yr0;\n\tMon, 20 Apr 2026 19:44:31 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fzgYp1VnGz2ynn\n\tfor ; Mon, 20 Apr 2026 19:44:29 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 58CDA440EF;\n\tMon, 20 Apr 2026 09:44:27 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B5F6FC19425;\n\tMon, 20 Apr 2026 09:44:26 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776678271;\n\tcv=none;\n b=OnKCwPdhK4udmgjX/i+SrTUfJUHab8NEtyRyYs5soM9ASEzSa7aqPcQ8btIWt+H47FszYPTOmOeK4JGbBQ1o7CjyY3IXJHZ2ip+huivvwr1qyHDzF9Axms0iMALXc3AjhmDWNS1btq16A3KPwxQbDPPzVF4kwfqTLTaDnJB7rcqLk4c5SEYL5dBNiXe7E+Mis0sjnO67uiPSVIQ2U4YGDN4NKfo+R2J4roj2wc5h3TfevP7xvCVa7iSIArgyrnd8bz9ciIG6W7Ny7r8KqDhL8D55DBEiXHfsqURFO/HJDsleh8ELQB/I6iLhuINTB33v63B9hm+LgEA90HDmMV16ig==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776678271; c=relaxed/relaxed;\n\tbh=hd7TGTt0cqbghqHMxHsJzLIh7KbXXHCIVomHjKuP7KA=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=d/CCEbhmLPwPSHXvgC8p7M+Pgyv1Q+t5fBd/2QmVT/1OXMPUxUROnHmrx4RvmyhZHTkgh9yYaPmurnXbucyQYQghnBVos7thJAX9+g4TWiqDrHgkfDwGeScljiyji0mJdJ6WiLlJQrvtAtRcKIUOsjGfb3+VziqgX58HkhXsLNZL8CqVoumkGa68LjnY4Ba6VzfYeha2fbf4J/QV0Z7M5e4YJ9XQeCouJjlnXJLdV3791Kibybs3P0PBGr16LgtzLQagTmUFnYnamoDclB0AEMyJaEgBcbXNfCKvXEB+1jQWK9OAdEhh2sL7JSiQBgj8Y3IfmAz4b1Qc0z0ZogwyiQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linuxfoundation.org;\n dkim=pass (1024-bit key;\n unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org\n header.a=rsa-sha256 header.s=korg header.b=On12/JsX; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=gregkh@linuxfoundation.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=linuxfoundation.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;\n\ts=korg; t=1776678267;\n\tbh=orVQQAkokr/ZgckLno97Wt1TCs0NqYT9zlpZ/LTDeX0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=On12/JsX+i3fpguYVx+6aKWBA0+2Scgbv6LSEOxAV+u2KOK1nNpbXBsMoySfGYkvj\n\t CPuuFEe3gLujpHyyHjFkL5v+2gImBBbvR5ri2bfaogKzIIM/zaH+Z/Fa4hX3OtM0Yj\n\t LXhC4vzROD0sD1jJuTMJB1fp64nZV7y3YkOI/bGk=","Date":"Mon, 20 Apr 2026 11:44:24 +0200","From":"Greg KH ","To":"Guangshuo Li ","Cc":"Madhavan Srinivasan ,\n\tMichael Ellerman ,\n\tNicholas Piggin ,\n\t\"Christophe Leroy (CS GROUP)\" ,\n\tMahesh Salgaonkar ,\n\tTyrel Datwyler ,\n\tHaren Myneni ,\n\tChristian Brauner , Kees Cook ,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org","Subject":"Re: [PATCH] powerpc/pseries/papr-hvpipe: fix NULL dereference in\n handle creation","Message-ID":"<2026042009-lesser-refrain-c154@gregkh>","References":"<20260420093856.123681-1-lgs201920130244@gmail.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260420093856.123681-1-lgs201920130244@gmail.com>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]