Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224889/?format=api
{ "id": 2224889, "url": "http://patchwork.ozlabs.org/api/patches/2224889/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260419110304.8661-1-viking4@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260419110304.8661-1-viking4@gmail.com>", "list_archive_url": null, "date": "2026-04-19T11:03:04", "name": "tests/qtest/migration: fix fd leak in ufd_version_check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "abf0418a2ad4c5fc5bbf895d8b81d237c0efb40d", "submitter": { "id": 92831, "url": "http://patchwork.ozlabs.org/api/people/92831/?format=api", "name": "Trieu Huynh", "email": "vikingtc4@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260419110304.8661-1-viking4@gmail.com/mbox/", "series": [ { "id": 500495, "url": "http://patchwork.ozlabs.org/api/series/500495/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500495", "date": "2026-04-19T11:03:04", "name": "tests/qtest/migration: fix fd leak in ufd_version_check", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500495/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224889/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Ckxnd7PA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fz5NG5n3Nz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 21:04:13 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEPw1-0006gR-5M; Sun, 19 Apr 2026 07:03:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1wEPvr-0006f9-GW\n for qemu-devel@nongnu.org; Sun, 19 Apr 2026 07:03:20 -0400", "from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1wEPvo-0004yq-Uw\n for qemu-devel@nongnu.org; Sun, 19 Apr 2026 07:03:19 -0400", "by mail-pl1-x635.google.com with SMTP id\n d9443c01a7336-2aaf59c4f7cso8823615ad.1\n for <qemu-devel@nongnu.org>; Sun, 19 Apr 2026 04:03:16 -0700 (PDT)", "from localhost.localdomain ([123.19.199.205])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5faa30134sm73517525ad.30.2026.04.19.04.03.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 04:03:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776596595; x=1777201395; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=o8V6NT2glw/+GQHYipF/OBuuyIZO/jJlJfWL/hU7am8=;\n b=Ckxnd7PAmGdVfoE0GbRQIBElPYttWrkCo+1AodrsXOVzN08T2/7wZ8duL3xCRHpShb\n x6N3HWFGoGITgcO6CXILMNByeoUFDEANpeoivkDbWahahUKN1oQdJp7ofX8q+K8h7zhM\n e87yoFBYj8R/fcDoRKaHQEJa7ueSpruqJRw4EeHcUsxwl+M1pewCKZ+00dxY59rCOPR0\n SOyEpVP1v261wbkIz15nmGRFE0qf5WSZLG8Xiw8ZvW4iwFOSIaM55IU7Z/ai346ACw+B\n rmk0u2OE1deXVVZrkXiEbLQRTmDoQdqOTS2xzty2NuCJV2YY1jjxBFWRgweaM0QIrlob\n o3OQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776596595; x=1777201395;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=o8V6NT2glw/+GQHYipF/OBuuyIZO/jJlJfWL/hU7am8=;\n b=PVdfKzb6KmrpSjZNPuXRuJBpH4TgrTjrhVkrvgJPxkuc/edWawPXc8Mz55HW8LvGgL\n ZGkAJV1CaAPPZJ4FDod4Cig1DPQdxpMzr9IjOyL5DfxPMrJTy4X+bVjlmR0G8e8QyXeS\n FRg1g86yNkk6p3hqNp3SeGGjUSBDHLGmvXY6k4G6vSpLl19xlNeUvneiAMGC8naJs0Q/\n V2Z3qRMTxrlTTR7A/6YLqNdLm7rexRo/znC7I4OOuwBxdzFrp9rRfqdxuVL715ww1Zvf\n wRtJdTH2WKQEo1tVVchxsbHKKZnsJv1hgoHbit2iq7fI1SPacreDfh2mH/7VXEKwq6aP\n nn6A==", "X-Gm-Message-State": "AOJu0YxXwcBIoVU4Wd5rdVpCzK2gpYpYvgmKZucVUYtTM2LDp6I84pid\n hvNd1m8v1/XnELVV50ZeBfz46kJmv8+wHlhvGrzSdWzgkAybMpdec1oe98OeBkxa", "X-Gm-Gg": "AeBDieucKHpWbUPwtH2gCOBR27FVx94bq7PAB+gVreP0LNiK55yxptcHtF8f60Yr604\n qCTedIyecZwDEeIvt+AySPqhBASoHwug5/XpgOLDapOpZeALfCV+vSIJwf7B6ccbb+jdvCqkfod\n hcdRTQIF/Brfs7jo8zTsOQtfVKiLfsLhvdw/nKSMDxAodQuyZrHJTdtzDoyCghT3oKvTX1tKTgn\n u7By7hH5/0qyfCKZaQDH3K0MDlH7joVbGmZW55oXUIvwPNwqTOZJwZMxvyrgsZkF1KoFwGcYgSP\n IwTKkCbxLK4uCAGJeCNv7nN1/zsuYvR7nbfkSxmss4JaqXhzxkAT4yC8YedgzY81wj0hD3I+Jy6\n VGKwiUKj2DCh1fW5ObqTbaruty7pj9M/NLQQ9txyzU32kEEM3GlW+6BcPm0htB9AUVoyOJOaQ1S\n Mzdj3BS/Q1Xp2eOtkjpNnRDjoKqrLrR7jJydXHqISwEW/4jO9M5ZbLTkgFWV4ghwMqsjcs", "X-Received": "by 2002:a17:902:f652:b0:2b0:beb4:3bb with SMTP id\n d9443c01a7336-2b5f9e7f300mr97170915ad.10.1776596594922;\n Sun, 19 Apr 2026 04:03:14 -0700 (PDT)", "From": "Trieu Huynh <vikingtc4@gmail.com>", "X-Google-Original-From": "Trieu Huynh <viking4@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Trieu Huynh <vikingtc4@gmail.com>, Peter Xu <peterx@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH] tests/qtest/migration: fix fd leak in ufd_version_check", "Date": "Sun, 19 Apr 2026 18:03:04 +0700", "Message-ID": "<20260419110304.8661-1-viking4@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::635;\n envelope-from=vikingtc4@gmail.com; helo=mail-pl1-x635.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Trieu Huynh <vikingtc4@gmail.com>\n\nufd_version_check() opens a userfaultfd via uffd_open() but never closes\nit on any path where the open succeeded: the UFFDIO_API failure path,\nthe missing-ioctls path, and the success path all returned without\ncalling close(ufd).\n\nConvert to a goto-out pattern consistent with uffd_open() used in\nutil/userfaultfd.c and migration/postcopy-ram.c, ensuring the fd is\nalways closed before returning.\n\nSigned-off-by: Trieu Huynh <vikingtc4@gmail.com>\n---\n tests/qtest/migration/migration-util.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/tests/qtest/migration/migration-util.c b/tests/qtest/migration/migration-util.c\nindex 2648ad7f61..db66d8b24f 100644\n--- a/tests/qtest/migration/migration-util.c\n+++ b/tests/qtest/migration/migration-util.c\n@@ -343,6 +343,7 @@ bool ufd_version_check(bool *uffd_feature_thread_id)\n {\n struct uffdio_api api_struct;\n uint64_t ioctl_mask;\n+ bool ret = false;\n \n int ufd = uffd_open(O_CLOEXEC);\n \n@@ -355,7 +356,7 @@ bool ufd_version_check(bool *uffd_feature_thread_id)\n api_struct.features = 0;\n if (ioctl(ufd, UFFDIO_API, &api_struct)) {\n g_test_message(\"Skipping test: UFFDIO_API failed\");\n- return false;\n+ goto release_ufd;\n }\n \n if (uffd_feature_thread_id) {\n@@ -366,10 +367,13 @@ bool ufd_version_check(bool *uffd_feature_thread_id)\n 1ULL << _UFFDIO_UNREGISTER);\n if ((api_struct.ioctls & ioctl_mask) != ioctl_mask) {\n g_test_message(\"Skipping test: Missing userfault feature\");\n- return false;\n+ goto release_ufd;\n }\n \n- return true;\n+ ret = true;\n+release_ufd:\n+ close(ufd);\n+ return ret;\n }\n #else\n bool ufd_version_check(bool *uffd_feature_thread_id)\n", "prefixes": [] }