[{"id":3679564,"web_url":"http://patchwork.ozlabs.org/comment/3679564/","msgid":"","list_archive_url":null,"date":"2026-04-20T19:57:56","subject":"Re: [PATCH] tests/qtest/migration: fix fd leak in ufd_version_check","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Sun, Apr 19, 2026 at 06:03:04PM +0700, Trieu Huynh wrote:\n> From: Trieu Huynh \n> \n> ufd_version_check() opens a userfaultfd via uffd_open() but never closes\n> it on any path where the open succeeded: the UFFDIO_API failure path,\n> the missing-ioctls path, and the success path all returned without\n> calling close(ufd).\n> \n> Convert to a goto-out pattern consistent with uffd_open() used in\n> util/userfaultfd.c and migration/postcopy-ram.c, ensuring the fd is\n> always closed before returning.\n> \n> Signed-off-by: Trieu Huynh \n\nThanks,\n\nReviewed-by: Peter Xu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NQivlnRe;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=b2+XJkZD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxBM1jnZz1yCv\n\tfor ; Tue, 21 Apr 2026 05:58:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEukw-00075Z-4v; Mon, 20 Apr 2026 15:58:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wEukt-00075R-IB\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 15:58:04 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wEuks-0000F7-81\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 15:58:03 -0400","from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-250-e4VS1E4nOBGUArdHMXXdlA-1; Mon, 20 Apr 2026 15:57:59 -0400","by mail-qk1-f200.google.com with SMTP id\n af79cd13be357-8ead5ab474bso258340885a.1\n for ; Mon, 20 Apr 2026 12:57:59 -0700 (PDT)","from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8e7d64caf37sm865965185a.11.2026.04.20.12.57.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 12:57:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776715080;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=6LEuJrRCyRLrRNrDolQSQM9HgiZhjIAZ2005yhE8W/8=;\n b=NQivlnReopQEncPB2k5tzqTI/Xw4/QkKy3Tb1GCUkzmWprqSRvcvXcP2yxq/FKaJRO1vCY\n Nt9PfAB41mNVK9UewJwLa8DlUZ86/SRbleZPVJj/VcGcAW7I7ZV3JA7oCA2iQ1tp34orzb\n 1MzoFaJTpt/7Ejs17oKcBmG5GcreglE=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776715078; x=1777319878; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=6LEuJrRCyRLrRNrDolQSQM9HgiZhjIAZ2005yhE8W/8=;\n b=b2+XJkZDNwyl+0Z7qpFaJ+Podx6OcFWpCBfA1zYS5VxTqxvAe9WkrJoNU43h5g9J+8\n O81M8eMQmNalGu5fJCwCgX8rx9p1OHenwwTe0qVSByig09InyDtuuu7NEmZEdGL4Rivq\n ebHfRSyRYnltQjzEGQ2/GU+oStU/Y0jbjng+boodwgANxYAhl0kVA64Vvz1YxJSdq/pq\n 5uzsvBZPDHHoxLKNknmXT+MQa6pcYEwu1Ow/5vyJjUeOSl3Efzn3XBjrSpKGPzbpjrOX\n a38GEOPHAHXX5dkA7vEDVgICtgdQ5CQTBTRG6y9Si2mmswk5eHW4dF/Sf+e5uysJaIYs\n nkBA=="],"X-MC-Unique":"e4VS1E4nOBGUArdHMXXdlA-1","X-Mimecast-MFC-AGG-ID":"e4VS1E4nOBGUArdHMXXdlA_1776715078","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776715078; x=1777319878;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6LEuJrRCyRLrRNrDolQSQM9HgiZhjIAZ2005yhE8W/8=;\n b=DGefTR3oe70tpaqaiN12KW2W0iOIRtSuGtvNhCmYWy52MwhzciP+pXIIQu4FhQhY60\n CYrQfaRUsb/UbmOF74jEUXtx6iFMzm0F5j9qU6A9Gg1NsXgNVynzjRWtbUdxzo/PbBRI\n DVTrZJNYSxbBsuk8wqBSylXqfz6AiySO16JBhwWSMsK2s8pRI0DA/dI/n3LXToI2USJx\n iyJXUtApUWMmdfazmYjALndPL8zrT032yWQSlBVqbb+wsXkGmjhRugunsSYo6zMGyKja\n Ec0nGDpGgRQ0exvrUjXgY/mOs8Bp2XUizBhfNyBBSvhryxW5VZ5gOH5DF86YncgZjDrW\n KWiw==","X-Gm-Message-State":"AOJu0YyDqVX9RraiisGETXwlPIEs9RE/SiwwLTwkmOqMPiR5Fa1+Cjl1\n e5/NtcWZoEZ1JSc20bzREKyZu0f5spco0gLsTZxep0HVie8SjieKFFEAchI36W/izlNGpu2D8A9\n WnML+BqVGuD/NBejNh3lSbR7REtqNaqbt/3KBnTUemxENAqLLHy9DnqsJ","X-Gm-Gg":"AeBDietYjHLFkvxrDdARnWyMHhoRd8Co1F+9fsoLzp7co9ZSzcRG31XduQ9/KHHCXst\n e6mSbOxpGthuEYrv7TujH6LzVxd39pxwBFOjHO3ITdhNuuBmbO8eDvByTmPqtYwLbY/0fyMAuMn\n CVDMsCXG4eUeNDnyX7SDRVe/OezfTzPcwrGInL5zbLGFstlZOujob4J/wbr5oqDMeYmzTmUxDCp\n zEqFSgpH4txpDpIHuWWskIiGWvrX8/NynvuCJo8Rnw3npwdVZe/USTpLbvqO0tdnzHZ1rEtLng6\n p8Sag6jmhFy7sSwQUkREtsc1+1aCSoFHArrGy7Kl0sHt9ENgA5Qto2Kr6v03hKIc/95EQLO3Ryr\n NFN32/vFB0//7TiBqTnsCnngXsdRt15vZZAEFhUYDh7Kui+AuuwoAFuReKQ==","X-Received":["by 2002:a05:620a:4502:b0:8cd:8785:eff4 with SMTP id\n af79cd13be357-8e78fe208c1mr2358026285a.15.1776715078445;\n Mon, 20 Apr 2026 12:57:58 -0700 (PDT)","by 2002:a05:620a:4502:b0:8cd:8785:eff4 with SMTP id\n af79cd13be357-8e78fe208c1mr2358019685a.15.1776715077639;\n Mon, 20 Apr 2026 12:57:57 -0700 (PDT)"],"Date":"Mon, 20 Apr 2026 15:57:56 -0400","From":"Peter Xu ","To":"Trieu Huynh ","Cc":"qemu-devel@nongnu.org, Fabiano Rosas ,\n Laurent Vivier , Paolo Bonzini ","Subject":"Re: [PATCH] tests/qtest/migration: fix fd leak in ufd_version_check","Message-ID":"","References":"<20260419110304.8661-1-viking4@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260419110304.8661-1-viking4@gmail.com>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]