Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223912/?format=api
{ "id": 2223912, "url": "http://patchwork.ozlabs.org/api/patches/2223912/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/8f9a2e2ccfd2eeda73a63d1a6abbfd6e5458b44c.1776339451.git.matheus.bernardino@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<8f9a2e2ccfd2eeda73a63d1a6abbfd6e5458b44c.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-04-16T11:38:53", "name": "[v5,04/16] hexagon: group cpu configurations in their own struct", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "26ea5c655d2a38ecce9ddea56cc0a310ee537ac3", "submitter": { "id": 90606, "url": "http://patchwork.ozlabs.org/api/people/90606/?format=api", "name": "Matheus Tavares Bernardino", "email": "matheus.bernardino@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/8f9a2e2ccfd2eeda73a63d1a6abbfd6e5458b44c.1776339451.git.matheus.bernardino@oss.qualcomm.com/mbox/", "series": [ { "id": 500137, "url": "http://patchwork.ozlabs.org/api/series/500137/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500137", "date": "2026-04-16T11:38:50", "name": "hexagon: add missing HVX float instructions", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/500137/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223912/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223912/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=NRreBNDX;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=e7r13KwR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxGKQ0kKdz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 21:40:26 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDL45-00056S-UU; Thu, 16 Apr 2026 07:39:21 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <matheus.bernardino@oss.qualcomm.com>)\n id 1wDL44-00055t-4d\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 07:39:20 -0400", "from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <matheus.bernardino@oss.qualcomm.com>)\n id 1wDL3y-00039y-Tr\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 07:39:19 -0400", "from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63G90YD22979251\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 11:39:13 GMT", "from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djvru8hmn-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 11:39:13 +0000 (GMT)", "by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2cc75e79b97so30180117eec.1\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 04:39:13 -0700 (PDT)", "from hu-mathbern-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2de8c10a65asm6845391eec.6.2026.04.16.04.39.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 04:39:11 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=qcppdkim1; bh=Deo326n2qmw\n FTkLiBkqpjqgcq8M3rSAS5nM+pXYoWxY=; b=NRreBNDXiUH/0MBBNFYzSvMC0l2\n eYOuX4Gt3F7C354/6F+siRNJyCcYusFr/k9EQEvEFVy6Fb2SHbwkiyH+XH62HJcP\n /VXGy+E4wsMeDY2kcPAb/b8iNJ9rn3C/MWr6X16rlgousEWKxBKKFnz3q/7lmptx\n nhJyUGDVYbzrLRi7x613pAUkdMRF4DXshRYO0voY8FUVepHzrviy46NImPWVnwwv\n 0PVGT7EYNgXtAAks69gEuSafUrejum4nejG3chaoWtS7Da+nTk36zvNZvH33WX4w\n 7gnzrgnUU3be5Z6nvKamLz5uUtfllBH/vcNxSxN2sUv+BKi5EWqkU6XO/Pw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776339553; x=1776944353; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Deo326n2qmwFTkLiBkqpjqgcq8M3rSAS5nM+pXYoWxY=;\n b=e7r13KwRwTs3YUaYBtMmg5oNuakoSqwPQCuVEbh+0hQjl9OXWH6AWfSio3GzapJzkL\n ghSGBqXXKbkfs1E6Hp/4r/UkfSyogFZI7IBwD6Wj4OH7seBDJcvqJwO1oDfqi3mAF/Gs\n DzY2HdyFpSEGvzrYWJgLIQBPHoHvQ9q+M0iBRPvHJ82zY062tdvwwXYdnoxtRbbnAngK\n RH6/DRRfzZ9ndtO2UHWeKPlL+sySwkyhvcGz0QP0SJvJDL9Os2ipWwTxI9drE7uUL+iL\n LHkLw4tszGzar5TR9jXcwZt0tybD1w10qrPM8poqqGLlyewjSVwjlLJKZ8aTG3vWZYeO\n mVAw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776339553; x=1776944353;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Deo326n2qmwFTkLiBkqpjqgcq8M3rSAS5nM+pXYoWxY=;\n b=iNXeMoSpEHFeB0ty0cN6IzYliO1QxITBnjDucYMEvc9ce9/VhbtLx/YKD87fZH+g56\n RvZDS6juZJ3tV0EZhzfymgGkFNnuBOx8XaXd42FEjyIfs7hpLnWBFMm75zq6RQS4mDEb\n CFUrL9olwyJ8DQTfvV0UNg3JVIMNsWYuzpi08M1+wWWc3pNfXXNFDh4N7cEsVXQ1yAV8\n AV09EaWUcCadC6Jio+DWwWNe1f0ZyFiM71+CQkEYZsgVMmfrbkzQ3b0SwyXVtRAqDnSQ\n m/yup8tZpAyyXQW5lEYSq5zTejotW6tHB2epNzDPgWDnXx8jpGMqJ3JkkxEVSVS1Gtnd\n gAbQ==", "X-Gm-Message-State": "AOJu0YzrpO5dlrbQ0JJJ8fZM9DNLF2cxE13A59BHQeVvc7uZS49LAfO/\n 2R5b67vWYHOwOr6NczfmgfvgANekmK1nYs+qXXfK1snh4CCFqAavETcUWklfRo5HA8yy05nu/NA\n l9uMQZbWXIBz+Fwft972WWdhijyMgD6ZIJoEtaOsvLcGzDfMj/Q4nB72PVTbkunJH1nJl", "X-Gm-Gg": "AeBDiesZMCQbAIPgaY5oan7x9WRPalcwa+bE7MBweIFgGO4kSKEgp3TKe8QajLklXtt\n zJP41aqeG1/QuTg6aYPMfKOsI6PcjmJA7TpPtD/LXo5KuOGZ8T7HZYwxYu23R77wrUKy+B6/+UF\n fl+1tc7Eso9dXgo6dZnSK+P1dz+KaVh7NTNVD8+haQ2QgoMlVlDLKi/mdRSDXH/wPBZeX6jGRK9\n UsRL8Uh7UztcWoVf+StWe0ZppN0+2Ie3bMwttHwjKomCtdITzhbH+gyUYf4VXCcavSDyhaVO6vK\n 4rgNwaK/6tXDDUOtwEZvwqcKNwvkbF0Wsi1nKQth/lNMrZYJmBHxZ1p6e7/sz6wR+/Uze8Hln0B\n XcHO38/akSajYDlemK9UUQMjocd1Gr6gZkJhnqdueaFD0wjZZCrLg4Q0Fn22eK+VLAG7oaP2h1t\n oLrxCqh47Nijhg08Jt3fE=", "X-Received": [ "by 2002:a05:7300:a284:b0:2da:4216:7ea3 with SMTP id\n 5a478bee46e88-2da42169606mr8509845eec.14.1776339552640;\n Thu, 16 Apr 2026 04:39:12 -0700 (PDT)", "by 2002:a05:7300:a284:b0:2da:4216:7ea3 with SMTP id\n 5a478bee46e88-2da42169606mr8509824eec.14.1776339552104;\n Thu, 16 Apr 2026 04:39:12 -0700 (PDT)" ], "From": "Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "richard.henderson@linaro.org, ale@rev.ng, anjo@rev.ng,\n brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com,\n marco.liebel@oss.qualcomm.com, philmd@linaro.org,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com", "Subject": "[PATCH v5 04/16] hexagon: group cpu configurations in their own\n struct", "Date": "Thu, 16 Apr 2026 04:38:53 -0700", "Message-Id": "\n <8f9a2e2ccfd2eeda73a63d1a6abbfd6e5458b44c.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<cover.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "References": "<cover.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDE2MDExMCBTYWx0ZWRfX27yTu/YaTXpV\n nj6RWIgkKuNplm610I80sqK29d2cQq5dd9533yGjHdmzVg9lDR0DacETb6rK+7zKUuGCIPSQcD1\n bry1nYH+047OADH7rGiGMTrIOns+yNwqaXC4gFbQjvOAS7HNhbRnKPJ/TIKpSu2L0WRq30AgPFr\n w3aKKks+7ja4mfuRbgZK4L56BloJy8bujzO+G1kgGfijk5HXNYDSuCbcIOhe0cV5lZy2Tjstn+/\n 8qHX/veBbqu29uhjFc0QVKKKhV5YTR+if+qJA0DO8b2H8/WXy6v/NMYJo8rgeGnPRLownuy5ztN\n MxwH5RSAJe5BssHArHluNX++9LybNyhSMAB+TbdYhHp6BgKdi0bImt/bp2KONgaiDIEG94t8gfQ\n xC8SwrQMyFtsIyjHFGzAQltj2EI76uMLEwhRw1BA26x4Jj2Ia0Be0gydzC6K6Ac5sn2r9Y6Glx0\n ncysHNufBenoMhZtlQw==", "X-Proofpoint-GUID": "2mz1PFc3c2E69X2nPpsGjO1t7JimMrlS", "X-Proofpoint-ORIG-GUID": "2mz1PFc3c2E69X2nPpsGjO1t7JimMrlS", "X-Authority-Analysis": "v=2.4 cv=GcInWwXL c=1 sm=1 tr=0 ts=69e0ca61 cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=pGLkceISAAAA:8\n a=EUspDBNiAAAA:8 a=AHWWR7nXwgbOQO2z_T8A:9 a=PxkB5W3o20Ba91AHUih5:22", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0\n impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0\n clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604160110", "Received-SPF": "pass client-ip=205.220.168.131;\n envelope-from=matheus.bernardino@oss.qualcomm.com;\n helo=mx0a-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This will be used in a follow up commit.\n\nReviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>\nSigned-off-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>\n---\n target/hexagon/cpu.h | 10 +++-------\n target/hexagon/cpu_bits.h | 7 +++++++\n target/hexagon/cpu.c | 14 +++++++-------\n target/hexagon/translate.c | 6 +++---\n 4 files changed, 20 insertions(+), 17 deletions(-)", "diff": "diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h\nindex 77822a48b6..d28beaa92f 100644\n--- a/target/hexagon/cpu.h\n+++ b/target/hexagon/cpu.h\n@@ -119,19 +119,15 @@ typedef struct HexagonCPUClass {\n ResettablePhases parent_phases;\n } HexagonCPUClass;\n \n+#include \"cpu_bits.h\"\n+\n struct ArchCPU {\n CPUState parent_obj;\n \n CPUHexagonState env;\n-\n- bool lldb_compat;\n- target_ulong lldb_stack_adjust;\n- bool short_circuit;\n- bool ieee_fp_extension;\n+ HexagonCPUConfig cfg;\n };\n \n-#include \"cpu_bits.h\"\n-\n FIELD(TB_FLAGS, IS_TIGHT_LOOP, 0, 1)\n \n G_NORETURN void hexagon_raise_exception_err(CPUHexagonState *env,\ndiff --git a/target/hexagon/cpu_bits.h b/target/hexagon/cpu_bits.h\nindex 19beca81c0..83d13de569 100644\n--- a/target/hexagon/cpu_bits.h\n+++ b/target/hexagon/cpu_bits.h\n@@ -20,6 +20,13 @@\n \n #include \"qemu/bitops.h\"\n \n+typedef struct HexagonCPUConfig {\n+ bool lldb_compat;\n+ uint32_t lldb_stack_adjust;\n+ bool short_circuit;\n+ bool ieee_fp_extension;\n+} HexagonCPUConfig;\n+\n #define PCALIGN 4\n #define PCALIGN_MASK (PCALIGN - 1)\n \ndiff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c\nindex 8b72a5d3c8..5470d9c7ce 100644\n--- a/target/hexagon/cpu.c\n+++ b/target/hexagon/cpu.c\n@@ -50,11 +50,11 @@ static ObjectClass *hexagon_cpu_class_by_name(const char *cpu_model)\n }\n \n static const Property hexagon_cpu_properties[] = {\n- DEFINE_PROP_BOOL(\"lldb-compat\", HexagonCPU, lldb_compat, false),\n- DEFINE_PROP_UNSIGNED(\"lldb-stack-adjust\", HexagonCPU, lldb_stack_adjust, 0,\n- qdev_prop_uint32, target_ulong),\n- DEFINE_PROP_BOOL(\"short-circuit\", HexagonCPU, short_circuit, true),\n- DEFINE_PROP_BOOL(\"ieee-fp\", HexagonCPU, ieee_fp_extension, true),\n+ DEFINE_PROP_BOOL(\"lldb-compat\", HexagonCPU, cfg.lldb_compat, false),\n+ DEFINE_PROP_UNSIGNED(\"lldb-stack-adjust\", HexagonCPU, cfg.lldb_stack_adjust,\n+ 0, qdev_prop_uint32, target_ulong),\n+ DEFINE_PROP_BOOL(\"short-circuit\", HexagonCPU, cfg.short_circuit, true),\n+ DEFINE_PROP_BOOL(\"ieee-fp\", HexagonCPU, cfg.ieee_fp_extension, true),\n };\n \n const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS] = {\n@@ -77,7 +77,7 @@ const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS] = {\n static target_ulong adjust_stack_ptrs(CPUHexagonState *env, target_ulong addr)\n {\n HexagonCPU *cpu = env_archcpu(env);\n- target_ulong stack_adjust = cpu->lldb_stack_adjust;\n+ target_ulong stack_adjust = cpu->cfg.lldb_stack_adjust;\n target_ulong stack_start = env->stack_start;\n target_ulong stack_size = 0x10000;\n \n@@ -181,7 +181,7 @@ static void hexagon_dump(CPUHexagonState *env, FILE *f, int flags)\n {\n HexagonCPU *cpu = env_archcpu(env);\n \n- if (cpu->lldb_compat) {\n+ if (cpu->cfg.lldb_compat) {\n /*\n * When comparing with LLDB, it doesn't step through single-cycle\n * hardware loops the same way. So, we just skip them here\ndiff --git a/target/hexagon/translate.c b/target/hexagon/translate.c\nindex fa8f615a9e..ce3af96675 100644\n--- a/target/hexagon/translate.c\n+++ b/target/hexagon/translate.c\n@@ -987,8 +987,8 @@ static void hexagon_tr_init_disas_context(DisasContextBase *dcbase,\n ctx->num_hvx_insns = 0;\n ctx->branch_cond = TCG_COND_NEVER;\n ctx->is_tight_loop = FIELD_EX32(hex_flags, TB_FLAGS, IS_TIGHT_LOOP);\n- ctx->short_circuit = hex_cpu->short_circuit;\n- ctx->ieee_fp_extension = hex_cpu->ieee_fp_extension;\n+ ctx->short_circuit = hex_cpu->cfg.short_circuit;\n+ ctx->ieee_fp_extension = hex_cpu->cfg.ieee_fp_extension;\n }\n \n static void hexagon_tr_tb_start(DisasContextBase *db, CPUState *cpu)\n@@ -1041,7 +1041,7 @@ static void hexagon_tr_translate_packet(DisasContextBase *dcbase, CPUState *cpu)\n * so end the TLB after every packet.\n */\n HexagonCPU *hex_cpu = env_archcpu(env);\n- if (hex_cpu->lldb_compat && qemu_loglevel_mask(CPU_LOG_TB_CPU)) {\n+ if (hex_cpu->cfg.lldb_compat && qemu_loglevel_mask(CPU_LOG_TB_CPU)) {\n ctx->base.is_jmp = DISAS_TOO_MANY;\n }\n }\n", "prefixes": [ "v5", "04/16" ] }