[{"id":3678401,"web_url":"http://patchwork.ozlabs.org/comment/3678401/","msgid":"","list_archive_url":null,"date":"2026-04-16T21:37:16","subject":"Re: [PATCH v5 04/16] hexagon: group cpu configurations in their own\n struct","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 13:38, Matheus Tavares Bernardino wrote:\n> This will be used in a follow up commit.\n> \n> Reviewed-by: Taylor Simpson \n> Signed-off-by: Matheus Tavares Bernardino \n> ---\n> target/hexagon/cpu.h | 10 +++-------\n> target/hexagon/cpu_bits.h | 7 +++++++\n> target/hexagon/cpu.c | 14 +++++++-------\n> target/hexagon/translate.c | 6 +++---\n> 4 files changed, 20 insertions(+), 17 deletions(-)\n> \n> diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h\n> index 77822a48b6..d28beaa92f 100644\n> --- a/target/hexagon/cpu.h\n> +++ b/target/hexagon/cpu.h\n> @@ -119,19 +119,15 @@ typedef struct HexagonCPUClass {\n> ResettablePhases parent_phases;\n> } HexagonCPUClass;\n> \n> +#include \"cpu_bits.h\"\n\nPre-existing but preferably \"target/hexagon/cpu_bits.h\".\n\n> struct ArchCPU {\n> CPUState parent_obj;\n> \n> CPUHexagonState env;\n> -\n> - bool lldb_compat;\n> - target_ulong lldb_stack_adjust;\n> - bool short_circuit;\n> - bool ieee_fp_extension;\n> + HexagonCPUConfig cfg;\n> };\n> \n> -#include \"cpu_bits.h\"\n> -\n> FIELD(TB_FLAGS, IS_TIGHT_LOOP, 0, 1)\n> \n> G_NORETURN void hexagon_raise_exception_err(CPUHexagonState *env,\n> diff --git a/target/hexagon/cpu_bits.h b/target/hexagon/cpu_bits.h\n> index 19beca81c0..83d13de569 100644\n> --- a/target/hexagon/cpu_bits.h\n> +++ b/target/hexagon/cpu_bits.h\n> @@ -20,6 +20,13 @@\n> \n> #include \"qemu/bitops.h\"\n> \n> +typedef struct HexagonCPUConfig {\n> + bool lldb_compat;\n> + uint32_t lldb_stack_adjust;\n> + bool short_circuit;\n> + bool ieee_fp_extension;\n\nMaybe group boolean together?\n\n> +} HexagonCPUConfig;\n\nMinor nitpicking comments, otherwise:\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IFvnksi1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxWZP1zPSz1yCv\n\tfor ; Fri, 17 Apr 2026 07:37:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDUOq-0005V0-Fs; Thu, 16 Apr 2026 17:37:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDUOo-0005Uj-L7\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 17:37:22 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDUOn-0001q8-7A\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 17:37:22 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-4852b81c73aso70885e9.3\n for ; Thu, 16 Apr 2026 14:37:20 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f581b9fbsm80913295e9.5.2026.04.16.14.37.17\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 14:37:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776375438; x=1776980238; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=eK1uuOg3zE6b5HYZ4Scrak5zX4QkXhqcS38nPiKEfO4=;\n b=IFvnksi15uupYPztiAq9qDemMar/rBI3IAbwjrX+IMjTfb21e1MPisfZFC5bs1JGPz\n M9OHVZOzBjEZz4QeQlSzHjAXBhs8GXbq3zoWo5wTuPklaStUwUUD832RFR8kDqBZNnyp\n WgbPiiKKL9x8KOJw3d/c1BiWv+oXTd5ZKYt5ge5W6b3jQQAUGYSZIK8gNSlruOwy69UC\n 7ybM3r4T8SuKuGU7R8w6EvVT0aZml8j+QlRDCz7K8h/WmjNQeKSAoErEPR4304YHkgV0\n iaEBctSbbchz8DnCB/DlsTpDI8CgL1bZRooAUNtsiqgF7C1cEZaVG8W5uOn2VE7+0i+K\n u+3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776375438; x=1776980238;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=eK1uuOg3zE6b5HYZ4Scrak5zX4QkXhqcS38nPiKEfO4=;\n b=phKRfcWBB0rENta0xfDzXgRZXPjA905R538kCkeVzta4F6JvRg3ARSC5LiomkNJWNB\n wvRy56veTTFBHNa0PCdUJhX0mx7azlJoLvdZj35KlhMMlJJmAgbGy7khqQ7uUb1Yf29L\n 1ffMfqZ2IbmugBufIvympyD/dLHc6cdpO+Zkm5D20ScOUdc7dVyziOeeebMHAzuyeUo/\n mLZ1fzckAPhR13rdYbP58ZsEZzbUVoyoLJxT3dKuZznCb7alN3rYHg3/eZ9P7dd+CGj4\n JPAYC2mMmUmXBUQGnGi1ZcOS8GJMKhKC04P81go9PMSSIp8I+dc+oG5MsAaXfpf0pkCC\n QAFA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/mMsQyAhaYAG4NTV2j6OjJ2P9e4WOD32v82FyxOmmrhhWGmxAwvKGQSNacIuDHGDDZ0fTjj3eeFe8U@nongnu.org","X-Gm-Message-State":"AOJu0YxAoJjH/GddYKN6TN87yb5lqzVloeiZoRJtIui97MI5JPlvT3Te\n /4jy0azk9dBDbQzS4iJwQ7fV1n5Ta4qtZefkq06WE9gxsLe+IwW6lwA0T066truZrVw=","X-Gm-Gg":"AeBDievKxsyD66xVHPEvWF6WX2QerlUFhAzFwoFhmCmCELEEm1n18eFmhtpIJ2E4Bi3\n nC6vxmMXrCm0n6Jv+PRul5NhqV7gKkwwvjhTHw1hpFexZ+ygcHs2ojRTaGbPH59DkTQwrmNiXdI\n NpNwxuDHjAQZOcO2loxSEzhON7l9o3cM8tS1k4Wv+r1DemmDCvThW8Iim8x5UeQigHaXgTbRP5Y\n VANiz9P+Kr7Xognhh4cnnDQKzfokRmFNr7e0jTiygVE1uyeS+HDIb/E+8DXV1yRkIrf6iaJjjF1\n CMgV3zlQl5ZOLt0d9KDjUD/MGN08pxHJUIM4b0xveFWfK/cK4Ef0Cruq86vZGe/UFXpkDvxYtvj\n E+Rub/sIolgeQX2cNCxgrBM/A6oPAwpe4G1LRXu34bxyEwyqJU/S5MjmGXsHn9+yh7+BjXnVo8k\n ijTVRKOclBLDMW8RnVIK24dG7uBlpzJmu/VFzrbsaqJBFR+GNvaIDSfa2f/P4+XNjV9BqLrw8us\n X9GCCbjcU4il20=","X-Received":"by 2002:a05:600c:4515:b0:488:c282:e77e with SMTP id\n 5b1f17b1804b1-488fb7879b0mr3383565e9.28.1776375438289;\n Thu, 16 Apr 2026 14:37:18 -0700 (PDT)","Message-ID":"","Date":"Thu, 16 Apr 2026 23:37:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 04/16] hexagon: group cpu configurations in their own\n struct","Content-Language":"en-US","To":"Matheus Tavares Bernardino ,\n qemu-devel@nongnu.org","Cc":"richard.henderson@linaro.org, ale@rev.ng, anjo@rev.ng,\n brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com,\n marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com,\n sid.manning@oss.qualcomm.com","References":"\n <8f9a2e2ccfd2eeda73a63d1a6abbfd6e5458b44c.1776339451.git.matheus.bernardino@oss.qualcomm.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n <8f9a2e2ccfd2eeda73a63d1a6abbfd6e5458b44c.1776339451.git.matheus.bernardino@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]