Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218978/?format=api
{ "id": 2218978, "url": "http://patchwork.ozlabs.org/api/patches/2218978/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20260402082510.1417440-3-amusil@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260402082510.1417440-3-amusil@redhat.com>", "list_archive_url": null, "date": "2026-04-02T08:25:06", "name": "[ovs-dev,2/6] controller: Make sure we free the route_data during change check.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "62acef597f84942003fe884d7d00016f3d5b54b3", "submitter": { "id": 83634, "url": "http://patchwork.ozlabs.org/api/people/83634/?format=api", "name": "Ales Musil", "email": "amusil@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20260402082510.1417440-3-amusil@redhat.com/mbox/", "series": [ { "id": 498451, "url": "http://patchwork.ozlabs.org/api/series/498451/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=498451", "date": "2026-04-02T08:25:04", "name": "Netlink notifier consolidation and nexthop table support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498451/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218978/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2218978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=OWM3qPUU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=OWM3qPUU", "smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=OWM3qPUU" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmZfz2DnBz1yGJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 19:25:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id AFBA98142F;\n\tThu, 2 Apr 2026 08:25:24 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MHXt5uh_NR4b; Thu, 2 Apr 2026 08:25:23 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id C8FE9813EA;\n\tThu, 2 Apr 2026 08:25:22 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id B2688C0070;\n\tThu, 2 Apr 2026 08:25:22 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 1122BC003D\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id EBC3660BFF\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:21 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id l1Bd_BQaDpYX for <dev@openvswitch.org>;\n Thu, 2 Apr 2026 08:25:21 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id D1947608E8\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:20 +0000 (UTC)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-Ez6UM5kkMJSQykzNBLfJTg-1; Thu,\n 02 Apr 2026 04:25:18 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3DD7B1955F27\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:17 +0000 (UTC)", "from amusil.brq.redhat.com (unknown [10.43.17.233])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 39A8630002D2; Thu, 2 Apr 2026 08:25:16 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org C8FE9813EA", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org D1947608E8" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=amusil@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org D1947608E8", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775118319;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GuTxghRtUVsiE+i/SLVhPqAE0MkWsbhXcCkyaihBHlY=;\n b=OWM3qPUUMMf+UFAljux8VQdMoYgXFq59r7UP+4P5Z2Dpmf0UKAVSubPBh/b/rdAVLEIz/v\n Z1KSppZBkeQ29Dgek/sxsDGltUQjka0INE8swPmWyjMtaT8TPOtGtV2EWxe5gKiH2Dwdwh\n +axITPPjKSDQZ44GYAbvo4+ZiWL68VI=", "X-MC-Unique": "Ez6UM5kkMJSQykzNBLfJTg-1", "X-Mimecast-MFC-AGG-ID": "Ez6UM5kkMJSQykzNBLfJTg_1775118317", "To": "dev@openvswitch.org", "Date": "Thu, 2 Apr 2026 10:25:06 +0200", "Message-ID": "<20260402082510.1417440-3-amusil@redhat.com>", "In-Reply-To": "<20260402082510.1417440-1-amusil@redhat.com>", "References": "<20260402082510.1417440-1-amusil@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "gbUTrw5uYZZO55Dh7sRfrqFZBFB4zw67oSj4cAfYXOc_1775118317", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Ales Musil via dev <ovs-dev@openvswitch.org>", "Reply-To": "Ales Musil <amusil@redhat.com>", "Cc": "dceara@redhat.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "The route_table_parse() can allocate data related to the nexthop\nlist. Those data need to be freed when we are done with the message.\nMake sure we call route_data_destroy() when we are done with the\nchange.\n\nFixes: 673d90f1173f (\"controller: Watch for route changes.\")\nSigned-off-by: Ales Musil <amusil@redhat.com>\n---\n controller/route-table-notify.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/controller/route-table-notify.c b/controller/route-table-notify.c\nindex 1fa182ea5..9fa2e0ea6 100644\n--- a/controller/route-table-notify.c\n+++ b/controller/route-table-notify.c\n@@ -134,19 +134,22 @@ find_watch_entry(uint32_t table_id)\n static void\n route_table_change(const void *change_, void *aux OVS_UNUSED)\n {\n- /* We currently track whether at least one recent route table change\n- * was detected. If that's the case already there's no need to\n- * continue. */\n- if (any_route_table_changed) {\n+ if (!change_) {\n return;\n }\n \n- const struct route_table_msg *change = change_;\n- if (change && change->rd.rtm_protocol != RTPROT_OVN) {\n+ /* We currently track whether at least one recent route table change\n+ * was detected. If that's the case already there's no need to\n+ * continue. */\n+ struct route_table_msg *change =\n+ CONST_CAST(struct route_table_msg *, change_);\n+ if (!any_route_table_changed && change->rd.rtm_protocol != RTPROT_OVN) {\n if (find_watch_entry(change->rd.rta_table_id)) {\n any_route_table_changed = true;\n }\n }\n+\n+ route_data_destroy(&change->rd);\n }\n \n static void\n", "prefixes": [ "ovs-dev", "2/6" ] }