[{"id":3675909,"web_url":"http://patchwork.ozlabs.org/comment/3675909/","msgid":"<715acbbd-72c1-4dee-abaf-f7bb81a2b27e@redhat.com>","list_archive_url":null,"date":"2026-04-10T14:39:56","subject":"Re: [ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.","submitter":{"id":76591,"url":"http://patchwork.ozlabs.org/api/people/76591/","name":"Dumitru Ceara","email":"dceara@redhat.com"},"content":"On 4/2/26 10:25 AM, Ales Musil wrote:\n> The route_table_parse() can allocate data related to the nexthop\n> list. Those data need to be freed when we are done with the message.\n> Make sure we call route_data_destroy() when we are done with the\n> change.\n> \n> Fixes: 673d90f1173f (\"controller: Watch for route changes.\")\n> Signed-off-by: Ales Musil \n> ---\n\nHi Ales,\n\nThis looks good to me, thanks!\n\nAcked-by: Dumitru Ceara \n\nRegards,\nDumitru","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UGOOS/Ws;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UGOOS/Ws","smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=UGOOS/Ws"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsfbW3lkGz1y2d\n\tfor ; Sat, 11 Apr 2026 00:40:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id EEBA180B37;\n\tFri, 10 Apr 2026 14:40:05 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HJMZgViM9VRf; Fri, 10 Apr 2026 14:40:05 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id F0D8480A52;\n\tFri, 10 Apr 2026 14:40:04 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id D9E7DC054A;\n\tFri, 10 Apr 2026 14:40:04 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id CBA9FC0549\n for ; Fri, 10 Apr 2026 14:40:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id B1ED240143\n for ; Fri, 10 Apr 2026 14:40:03 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bAwRMO3zYSU9 for ;\n Fri, 10 Apr 2026 14:40:02 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id A3AB44005B\n for ; Fri, 10 Apr 2026 14:40:02 +0000 (UTC)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-189-UocLPFFpMdqL8dibOX_Uhg-1; Fri, 10 Apr 2026 10:39:59 -0400","by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-488dcaf2f2fso98605e9.0\n for ; Fri, 10 Apr 2026 07:39:59 -0700 (PDT)","from ?IPV6:2001:1c05:1417:d800:d1ef:9817:2a26:625d?\n (2001-1c05-1417-d800-d1ef-9817-2a26-625d.cable.dynamic.v6.ziggo.nl.\n [2001:1c05:1417:d800:d1ef:9817:2a26:625d])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d531f229sm106866065e9.3.2026.04.10.07.39.56\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 10 Apr 2026 07:39:56 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org F0D8480A52","OpenDKIM Filter v2.11.0 smtp2.osuosl.org A3AB44005B"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=dceara@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org A3AB44005B","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775832001;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Lqj933xrWR30Q70tBcaonv3dq2Ppd/5nDvuYjIwh4q4=;\n b=UGOOS/WsgoD08iRfswgLC9ambcO5Qb9MisjrlA+cGnE0sgOsnFrcSnFX8xRC//WlB7xpIR\n gw6udXOsItJEsxdO9mee4ZLxCYPpWO1vnaOcaYNQWwJGEPxgb/qRwDWFpRwWhr/rYkEU/8\n rEXRtQl1EMyBWbA/GmEjZf/8Hp/0ags=","X-MC-Unique":"UocLPFFpMdqL8dibOX_Uhg-1","X-Mimecast-MFC-AGG-ID":"UocLPFFpMdqL8dibOX_Uhg_1775831998","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775831998; x=1776436798;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Lqj933xrWR30Q70tBcaonv3dq2Ppd/5nDvuYjIwh4q4=;\n b=gGSww1NljhywUSs2qoLbQ5YHBCWdrcr2CBUHf1A7wd+Gye+ZE8eEquFK1cvGz7xEiA\n ND8g6r/rVF9nGauu1CoOE44BjzRUgvNLmdyyswN/PGIh6+Rtx/zp0P7EpxxRxSe4AVmB\n eVDjavdw/ahXXa9PqPBfAt+Un3SQeaVA2vLx6l6akGfFf5RS7IQsrhuKDqn41Ktn3CS6\n ZYVXRHZDcFpf/fP7erU/s+TlgH+Wnn0HbW1/7Hx2R5wgL/UPw9IDaXzBrvaBxn3HOtki\n wCNlya9UJ0ZmxBrs0yRHmq2ML7eL4TbZ/DRMElpk3veZlz4OSJ9TYvK8ymkdzPXmUaO+\n UNGw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXOYASMiGHYGkRZkDsmpmLjGJyvlifacd+MopKojFVFR+1F0wqslKO93DkvdNY2FFBtvzY=@openvswitch.org","X-Gm-Message-State":"AOJu0YxhLaryH89liSoBI1RRv+G23eV2BZEqiyR1bXV5/d07xWNOy3zu\n 9oX8p59rwYYkvlozSaTP/xijDxXbUa47sUp7nwMkxpc+KK0Y6f83wM7Q2lBQPBAqa5LPK6IP6k4\n jUnDuXVlSWX2CjEMkNLikrkINwhVSxfLG8mPedby8PoL12ZI6H9y/q0i4JVA0Dg==","X-Gm-Gg":"AeBDietGPiuoJHwfAXsiH7sh2fPxWKTLrXvrYARDK0amvOtkCvvSObiJmKC51LLSGhS\n vEy6EcHAQHt/hBfVYR9Gx95kDvW3tN5c2sOaDsieKbZELnfusX8NfxH/3KShCspT2awPlX6sydd\n /VW1/8DF3IbYqGQFyFdvHXoMug4DKeASGrDJmrrHWF4Akz5xTCHA0CkiFLXTXC+SxLpAaUDDeDE\n FuxPAiOaJWXCAJNimT/ZG7e+fucGyrcX9XYbzcdOrAsmZuWN5TLZr2e1MK8qhf7ptiOC/yqfiwg\n GT/pIT5FFjz4LvImznXSQHTEs0hyatZj9bWS/WJnUU9FNbhB9W2gMjasYgLi51ajqXSYWw9+IyK\n x/xw60rFF/TQLCQ39C1tI8rfuRSBfJrkXhm1/OwCYFwqKKGlbLulleHGk5YIdrhycccKBW7I6m4\n qDr/ae9V2+THblsOMgPoB59AwTE8/R0xRHNsFT7sFvm+sEZjwwgSM7swqS/YcRCKZu8BIsqMRy","X-Received":["by 2002:a05:600c:4443:b0:488:8577:d9cc with SMTP id\n 5b1f17b1804b1-488d686be7bmr44026435e9.20.1775831997701;\n Fri, 10 Apr 2026 07:39:57 -0700 (PDT)","by 2002:a05:600c:4443:b0:488:8577:d9cc with SMTP id\n 5b1f17b1804b1-488d686be7bmr44026065e9.20.1775831997251;\n Fri, 10 Apr 2026 07:39:57 -0700 (PDT)"],"Message-ID":"<715acbbd-72c1-4dee-abaf-f7bb81a2b27e@redhat.com>","Date":"Fri, 10 Apr 2026 16:39:56 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Ales Musil , dev@openvswitch.org","References":"<20260402082510.1417440-1-amusil@redhat.com>\n <20260402082510.1417440-3-amusil@redhat.com>","In-Reply-To":"<20260402082510.1417440-3-amusil@redhat.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"txhDE7g1Av-X2xcvevQA-vTJD00YzuUS06L3pEc-MqA_1775831998","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Subject":"Re: [ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Dumitru Ceara via dev ","Reply-To":"Dumitru Ceara ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}},{"id":3675956,"web_url":"http://patchwork.ozlabs.org/comment/3675956/","msgid":"","list_archive_url":null,"date":"2026-04-10T15:52:43","subject":"Re: [ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.","submitter":{"id":73083,"url":"http://patchwork.ozlabs.org/api/people/73083/","name":"Lorenzo Bianconi","email":"lorenzo.bianconi@redhat.com"},"content":"> The route_table_parse() can allocate data related to the nexthop\n> list. Those data need to be freed when we are done with the message.\n> Make sure we call route_data_destroy() when we are done with the\n> change.\n> \n> Fixes: 673d90f1173f (\"controller: Watch for route changes.\")\n> Signed-off-by: Ales Musil \n\nAcked-by: Lorenzo Bianconi \n\n> ---\n> controller/route-table-notify.c | 15 +++++++++------\n> 1 file changed, 9 insertions(+), 6 deletions(-)\n> \n> diff --git a/controller/route-table-notify.c b/controller/route-table-notify.c\n> index 1fa182ea5..9fa2e0ea6 100644\n> --- a/controller/route-table-notify.c\n> +++ b/controller/route-table-notify.c\n> @@ -134,19 +134,22 @@ find_watch_entry(uint32_t table_id)\n> static void\n> route_table_change(const void *change_, void *aux OVS_UNUSED)\n> {\n> - /* We currently track whether at least one recent route table change\n> - * was detected. If that's the case already there's no need to\n> - * continue. */\n> - if (any_route_table_changed) {\n> + if (!change_) {\n> return;\n> }\n> \n> - const struct route_table_msg *change = change_;\n> - if (change && change->rd.rtm_protocol != RTPROT_OVN) {\n> + /* We currently track whether at least one recent route table change\n> + * was detected. If that's the case already there's no need to\n> + * continue. */\n> + struct route_table_msg *change =\n> + CONST_CAST(struct route_table_msg *, change_);\n> + if (!any_route_table_changed && change->rd.rtm_protocol != RTPROT_OVN) {\n> if (find_watch_entry(change->rd.rta_table_id)) {\n> any_route_table_changed = true;\n> }\n> }\n> +\n> + route_data_destroy(&change->rd);\n> }\n> \n> static void\n> -- \n> 2.53.0\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MKoMh8GD;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Rx7FdW4B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MKoMh8GD;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google\n header.b=Rx7FdW4B","smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=MKoMh8GD;\n dkim=pass (2048-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Rx7FdW4B"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fshCY0TKKz1yGS\n\tfor ; Sat, 11 Apr 2026 01:52:56 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1E9F141080;\n\tFri, 10 Apr 2026 15:52:54 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qct2hLMKT4f9; Fri, 10 Apr 2026 15:52:53 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 1763241071;\n\tFri, 10 Apr 2026 15:52:53 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id EF5FAC054A;\n\tFri, 10 Apr 2026 15:52:52 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id EA841C0549\n for ; Fri, 10 Apr 2026 15:52:51 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id D63DA40175\n for ; Fri, 10 Apr 2026 15:52:51 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id OsiOhDOsIcm7 for ;\n Fri, 10 Apr 2026 15:52:51 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B5CE340143\n for ; Fri, 10 Apr 2026 15:52:50 +0000 (UTC)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-286-UXwJSvD9MwaVtHayXHRQIA-1; Fri, 10 Apr 2026 11:52:47 -0400","by mail-wr1-f71.google.com with SMTP id\n ffacd0b85a97d-43d00dd913cso2272739f8f.1\n for ; Fri, 10 Apr 2026 08:52:47 -0700 (PDT)","from localhost (net-37-119-153-93.cust.vodafonedsl.it.\n [37.119.153.93]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5b56d1asm83422435e9.15.2026.04.10.08.52.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Apr 2026 08:52:44 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1763241071","OpenDKIM Filter v2.11.0 smtp2.osuosl.org B5CE340143"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com;\n envelope-from=lorenzo.bianconi@redhat.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org B5CE340143","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775836369;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=hG9M2FA3UGwV5fK9LLubEKnXzU1nrAFCUkjSW4rCWWY=;\n b=MKoMh8GDAP9HvNCq5rjZIrMhDH2YiElM/KOSriKMyjseraTUaCMInH548jpg+07pEbqlUK\n 2vhKZ6+o2kTG76gX1TJibKFSQ3HXht0dLKYheSNCfAtALNKey4VuvfsKrT4cSb2no2ia53\n 5MksSnPE+37wU/gdJmjH4DdDfJjO63U=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775836365; x=1776441165; darn=openvswitch.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=hG9M2FA3UGwV5fK9LLubEKnXzU1nrAFCUkjSW4rCWWY=;\n b=Rx7FdW4BWs4Q3Vbxub+YFGxKhKGAU556ClDEYPrv8cU+32hbw+ppoJg2wnhe2lFDIE\n Y5Fbq8c135T3sWTQFIvFUO8kIYm8wQTHtcEJSyi7BU4UAtV5OFL3f4BSQdLzZVwQHy0q\n r2KI/EyaRq+2bi+0hojW46cBQ1eyimhofN9uulSCCTg5vA6vIe2mSEmEFZghsX8KB0dg\n T1QOBvTWWJyLostVAYBcJfYVyxyusbuPHNSqhzYfUMsPga7pSPAUie2pwcrc7BqoNuQ3\n DkuM4nkBWva5guw6Z2d39jovS/qfJFsuzqzYaB8EchkVsovQO/dMhASWqJ/ajy8YdoQG\n Pv9g=="],"X-MC-Unique":"UXwJSvD9MwaVtHayXHRQIA-1","X-Mimecast-MFC-AGG-ID":"UXwJSvD9MwaVtHayXHRQIA_1775836366","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775836365; x=1776441165;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hG9M2FA3UGwV5fK9LLubEKnXzU1nrAFCUkjSW4rCWWY=;\n b=KJ12fMAVqHwXkmjbXjtahhoRU9b4k7hvhKfsxO3XC6vs+KRJPxO6H+yGahVT/TbTOv\n IfFIEuIQfb/DhFVEyIxX9zpvmbxwqjqAd9hU4Ttm6bs2ybBlADC0nQNrpD2gCvidFFzN\n aAtTElbuVvAwUnoXbXjugx1cTJpmvkXbT+ScryjZtc4znYlz3xSePDPEA8W0kKYNESlD\n 9w/gMI61S+qARquIYS31iR4gISmniKNEwmpeZgLJYKzPY+sfpuobF+IQ9DVoGW2ABbmY\n EtKq8hFLqJwyM5RY6mUfb+XoggT+vUq+zYSikAy39MscujIlEtM0iDWoGxSV+/gHk4hu\n K3xA==","X-Gm-Message-State":"AOJu0Yx5Cy0AuXguNUlr7Y0nEO/Jjis6cVds32Eu7Xy9MEka4rWQV2F5\n OYBH1kraraUz8brSuj0ayuhH1kVWp7XagaAeVURZ8/HVSd3Id5xQBL9oMR8lrUTGyS1n7as74W1\n TwKlr3l0ERmxqjZZ00kBOaZTE0Dpr8F865dKopxVg3gAdFdOs5f4F5DrEQgtljw==","X-Gm-Gg":"AeBDiet4q9Sj/NC9dsnK98g7dUx7Vufx+VL/GsCNe4yWdasHEhKtbG9A1gCqlGWeE6o\n HNX4xk05ORmGV5zrWGw6zXnqk0mkLKwOcUvh9Bf+uB9wc8RW06hcJxTvt/I9siJ0yEG6Y4sWJE1\n Ib+ZN7n8dd67D0fhoxkgoaunLHhVw+69AR9zM4cuwpb4xaL93vmurlaZ3/ghpKMrbkPzQTv+uaX\n xq7Dy8Hx7zl8aXrYJbRg5yyV5vzqHx3xUdSeXSuk9LiA1HjvjkwC8Ff/r/amLHUqAeI+SUzMzAZ\n ZhaacZEnu98ouoKcoNmLsZa7rn4EeV6OzkKq7OE31DUB4Ucy3mcb8ad2CcUppJq5mc6k++jPjUD\n LzVfU9Pkh2X3VJ+wyiXn7PpsxB3dl6mqJ1Jgv7DtiPf7UPAFg7uEoQCraamkCYGTbTzXPVQ==","X-Received":["by 2002:a05:600c:3149:b0:488:acbc:b2e with SMTP id\n 5b1f17b1804b1-488d68431f6mr47057545e9.17.1775836365568;\n Fri, 10 Apr 2026 08:52:45 -0700 (PDT)","by 2002:a05:600c:3149:b0:488:acbc:b2e with SMTP id\n 5b1f17b1804b1-488d68431f6mr47057125e9.17.1775836365043;\n Fri, 10 Apr 2026 08:52:45 -0700 (PDT)"],"Date":"Fri, 10 Apr 2026 17:52:43 +0200","To":"Ales Musil ","Cc":"dev@openvswitch.org, dceara@redhat.com","Message-ID":"","References":"<20260402082510.1417440-1-amusil@redhat.com>\n <20260402082510.1417440-3-amusil@redhat.com>","MIME-Version":"1.0","In-Reply-To":"<20260402082510.1417440-3-amusil@redhat.com>","X-Content-Filtered-By":"Mailman/MimeDel 2.1.30","Subject":"Re: [ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Lorenzo Bianconi via dev ","Reply-To":"Lorenzo Bianconi ","Content-Type":"multipart/mixed; boundary=\"===============7183399985364965300==\"","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}},{"id":3676724,"web_url":"http://patchwork.ozlabs.org/comment/3676724/","msgid":"","list_archive_url":null,"date":"2026-04-13T13:00:04","subject":"Re: [ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.","submitter":{"id":83634,"url":"http://patchwork.ozlabs.org/api/people/83634/","name":"Ales Musil","email":"amusil@redhat.com"},"content":"On Fri, Apr 10, 2026 at 5:52 PM Lorenzo Bianconi <\nlorenzo.bianconi@redhat.com> wrote:\n\n> > The route_table_parse() can allocate data related to the nexthop\n> > list. Those data need to be freed when we are done with the message.\n> > Make sure we call route_data_destroy() when we are done with the\n> > change.\n> >\n> > Fixes: 673d90f1173f (\"controller: Watch for route changes.\")\n> > Signed-off-by: Ales Musil \n>\n> Acked-by: Lorenzo Bianconi \n>\n> > ---\n> > controller/route-table-notify.c | 15 +++++++++------\n> > 1 file changed, 9 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/controller/route-table-notify.c\n> b/controller/route-table-notify.c\n> > index 1fa182ea5..9fa2e0ea6 100644\n> > --- a/controller/route-table-notify.c\n> > +++ b/controller/route-table-notify.c\n> > @@ -134,19 +134,22 @@ find_watch_entry(uint32_t table_id)\n> > static void\n> > route_table_change(const void *change_, void *aux OVS_UNUSED)\n> > {\n> > - /* We currently track whether at least one recent route table change\n> > - * was detected. If that's the case already there's no need to\n> > - * continue. */\n> > - if (any_route_table_changed) {\n> > + if (!change_) {\n> > return;\n> > }\n> >\n> > - const struct route_table_msg *change = change_;\n> > - if (change && change->rd.rtm_protocol != RTPROT_OVN) {\n> > + /* We currently track whether at least one recent route table change\n> > + * was detected. If that's the case already there's no need to\n> > + * continue. */\n> > + struct route_table_msg *change =\n> > + CONST_CAST(struct route_table_msg *, change_);\n> > + if (!any_route_table_changed && change->rd.rtm_protocol !=\n> RTPROT_OVN) {\n> > if (find_watch_entry(change->rd.rta_table_id)) {\n> > any_route_table_changed = true;\n> > }\n> > }\n> > +\n> > + route_data_destroy(&change->rd);\n> > }\n> >\n> > static void\n> > --\n> > 2.53.0\n> >\n> > _______________________________________________\n> > dev mailing list\n> > dev@openvswitch.org\n> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n> >\n>\n\nThank you Lorenzo and Dumitru,\n\napplied to main and backported down to 25.03.\n\nRegards,\nAles","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BBLSEWj4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BBLSEWj4","smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvSF608fvz1yDG\n\tfor ; Mon, 13 Apr 2026 23:00:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id E237D403F7;\n\tMon, 13 Apr 2026 13:00:23 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id s5bZm65Zc4l7; Mon, 13 Apr 2026 13:00:23 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 0F49340382;\n\tMon, 13 Apr 2026 13:00:23 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id DB19BC054A;\n\tMon, 13 Apr 2026 13:00:22 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 1F9BDC0549\n for ; Mon, 13 Apr 2026 13:00:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 118EC40057\n for ; Mon, 13 Apr 2026 13:00:21 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qU_sju3mmlvW for ;\n Mon, 13 Apr 2026 13:00:20 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id E259740133\n for ; Mon, 13 Apr 2026 13:00:19 +0000 (UTC)","from mail-yx1-f72.google.com (mail-yx1-f72.google.com\n [74.125.224.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-255-uG3SFeAmMaa8Taze9MGt0A-1; Mon, 13 Apr 2026 09:00:16 -0400","by mail-yx1-f72.google.com with SMTP id\n 956f58d0204a3-65079af1ee9so7323982d50.1\n for ; Mon, 13 Apr 2026 06:00:16 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0F49340382","OpenDKIM Filter v2.11.0 smtp2.osuosl.org E259740133"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=amusil@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org E259740133","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776085218;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=zlZ9PNy6vGdXKmLuWIcOuSA0zM3v5f+HGKpuq3AxsA4=;\n b=BBLSEWj4ZK3ZQPQd0Av15VqDKmRNtMbiUv45ZC8HhnzgdNRf/qTaT3hM9ywzByuzZal1iq\n b+/MifL1XHkZwFY6IzysdrWCbt31/3PG2N+BKs1xAPvT7AFOulrkOmK6OYqMFXcgW8/xBd\n 91ONf1qqNfH7RMRvqy2jP2F8ox/LSVg=","X-MC-Unique":"uG3SFeAmMaa8Taze9MGt0A-1","X-Mimecast-MFC-AGG-ID":"uG3SFeAmMaa8Taze9MGt0A_1776085216","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776085216; x=1776690016;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zlZ9PNy6vGdXKmLuWIcOuSA0zM3v5f+HGKpuq3AxsA4=;\n b=N4wThEVWe17Tua1DG8RoRwaknb0scVtNMV4ezKODEHBsePhNUQkokxiz0ZlBIxQPkn\n OUWf+yuEWQvTh3l8uke1PuvAcC50mPaatC2cib61AjWgjmpdf9l6lxRJRoWUmitu7Wm4\n lfW1LAMeWLvz5O9P/+BlMD0WRVLk7raJMjDMFauqspIFTR58ZrP/dPtR/+3azaHFCEUM\n fwM4ocBK+L6WLV/RTB63x/S5iovo08DMRwP7Smqg5lydCSNEPJy6JJgLGhaOpmWhLWgZ\n cnnKZVV5od4x1Ze/LtHqz1MsYRjk6yEOkJSSqRdt/W9RiyaiGtLecaS8t+l70yfYf/fK\n DGDQ==","X-Gm-Message-State":"AOJu0YzbzeGTlGgLK2+lQBGb1L+QXB4UeedCnPQQ5glQ25lmll5d4Kek\n nTHOWMmJOnRXjau3YQHX+S93BhiyrZlxT49SggGcEqqqss11zDFRGPsolG+XfJNXl9fCy1kKlFf\n MO2LIVwT+5yD45RHVk7+i+p6TVpo227C64OO68MJpxp1YlFub2LNUD8754TxiUNwZqjJuLJ8uHk\n l4iD4jR4Ntemwn21SU1Ap2Ny1Laawl","X-Gm-Gg":"AeBDieuqSn/obrWJc7VfPdplq66/ohSbJQ6B9lsYLmKHKf/2r/4mKUfNsgAZXCm0b1z\n 6uy6k0cG2gru4DroxLAYLTx5lsqqQZSWAq+srxOlRwbGIHAPWo34zHZnLTgqsAIKSq6Ifl7vIzs\n TWq29IWRLn+6/0U/0rinAASfpk9CaU0ZznSk1vqw3lYmnuthWxvvt3Wlx/hbQUPdodq2/ysv2Aj\n 9pGi2liD6owfAo0v967k27mzIYbBkLfQJUFkkNNxB9C+ZQsugCXNRYtCC0d6/YUrZINJgqM938j\n w5FeGJsc8ANDTAO0q+NqMocBkmJVOG7vv1a6zcMLL4E3NP9yLqDg3t3A5IBg51k7FaKZlm+IOh4\n QcnqvOxT4gdup8IJBJtJd1cYEo1DzyUlpiFhxddpif0oPM/U=","X-Received":["by 2002:a05:690e:13c4:b0:651:b896:8a66 with SMTP id\n 956f58d0204a3-651b896b63amr7742834d50.68.1776085216206;\n Mon, 13 Apr 2026 06:00:16 -0700 (PDT)","by 2002:a05:690e:13c4:b0:651:b896:8a66 with SMTP id\n 956f58d0204a3-651b896b63amr7742773d50.68.1776085215605; Mon, 13 Apr 2026\n 06:00:15 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260402082510.1417440-1-amusil@redhat.com>\n <20260402082510.1417440-3-amusil@redhat.com>\n ","In-Reply-To":"","Date":"Mon, 13 Apr 2026 15:00:04 +0200","X-Gm-Features":"AQROBzChsMaQYwWi1vY_3dAFzTtVOgZaIE2gxbZRlI5-vjXrxHnV6wkDtFPqdsQ","Message-ID":"\n ","To":"Lorenzo Bianconi ","Cc":"dev@openvswitch.org, dceara@redhat.com","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9Yy7Tc0VW6NqPJLpVvSGL2dXWzU8flxLdBDArfDSO6I_1776085216","X-Mimecast-Originator":"redhat.com","X-Content-Filtered-By":"Mailman/MimeDel 2.1.30","Subject":"Re: [ovs-dev] [PATCH ovn 2/6] controller: Make sure we free the\n route_data during change check.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Ales Musil via dev ","Reply-To":"Ales Musil ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]