Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215500/?format=api
{ "id": 2215500, "url": "http://patchwork.ozlabs.org/api/patches/2215500/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260324-deverr-v1-3-7e591cce33a3@gmail.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260324-deverr-v1-3-7e591cce33a3@gmail.com>", "list_archive_url": null, "date": "2026-03-24T18:26:51", "name": "[03/10] i2c: sun6i-p2wi: Replace dev_err() with dev_err_probe() in probe function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "bed12a4d6cf1a80641b3c24f5fca81d5db2bc78e", "submitter": { "id": 92959, "url": "http://patchwork.ozlabs.org/api/people/92959/?format=api", "name": "Atharv Dubey", "email": "atharvd440@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260324-deverr-v1-3-7e591cce33a3@gmail.com/mbox/", "series": [ { "id": 497326, "url": "http://patchwork.ozlabs.org/api/series/497326/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=497326", "date": "2026-03-24T18:26:49", "name": "i2c: Replace dev_err() with dev_err_probe()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497326/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215500/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13129-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=WuMmfs9X;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13129-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"WuMmfs9X\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.51", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJXC5kkGz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 05:31:23 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D43B030528BC\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 18:27:43 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A8311224AF2;\n\tTue, 24 Mar 2026 18:27:43 +0000 (UTC)", "from mail-pj1-f51.google.com (mail-pj1-f51.google.com\n [209.85.216.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF173A383C\n\tfor <linux-tegra@vger.kernel.org>; Tue, 24 Mar 2026 18:27:41 +0000 (UTC)", "by mail-pj1-f51.google.com with SMTP id\n 98e67ed59e1d1-35b88a4f123so69536a91.1\n for <linux-tegra@vger.kernel.org>;\n Tue, 24 Mar 2026 11:27:41 -0700 (PDT)", "from [127.0.1.1] ([103.216.213.160])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 11:27:40 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774376863; cv=none;\n b=uWl2PDHFzbuki1UVYM/AmXUbp9cBD9P+pS78/KGpt314piO8PjbpdbkZB0pO35faQFntOmmsbWCzF3am5/+bzlH37uYHS39vLkGPIY9d+SGxSQT6293h7HhEeN3h8Du39u43GUjuaovC5azcm8ihSJIEhebLJRAvHnmvamGg1oE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774376863; c=relaxed/simple;\n\tbh=Gi4d0M5a+5Q4+n74Mmna9wNg+TAzJTOOC5zaGKNgvh0=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=efLbrjvgdlpKsWa32YA///OfQXUssnseb2owrU6Cjfh4CiMt69fomKQvw7kiBASN9DbHICeW4L8E28oVe4gHP62cjHB7ezZzTvTidQSItVDO/8CVx5q+tbWzKXPsubOvxYlXiKEZVIqdhKqHcmvn0Rx+U/8t61upbJRLcBy6XvU=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=WuMmfs9X; arc=none smtp.client-ip=209.85.216.51", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774376861; x=1774981661;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=;\n b=WuMmfs9Xmqa9GVDNOZjmNUordZmBGAfWmTmNyhu7SWk9d1fBi9J7mmm9H+nbdWmyJg\n 1oV4WrXltAPUWBmWaeV3MF4z9LIcaBBXfv27e1H5aTbrXLiuOTVeZeUYNA5dqXvE2MJU\n jKDBjTnHVysLF9BRylvs0wLrbkMhnJnBIY8fAsyHFm9e2/GeZG9+RWskGeeOCCs+x4OS\n +oI8wsXi7Q9xh/s1oFEFJGFFoeYKQ4Alkq/jd94/q9rk/kkg/p24Y+cfxQ4QsIYX6Oyb\n fAPXNU1TkvhBWDY7i11v2l9jys2jwmTGmn69A9e4gFsaKPPsObTfJRlijFVXWYkNVOzG\n H5SQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774376861; x=1774981661;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=;\n b=RycBgCkIyv8EAlpVfUf4KoKiafTitXnoq5B3u5pZ1GCah+WWbBYu3FGxhFy7T45lZt\n 3Te5v7jxv1Yb8uXT60Z6UMHl7ad/OVeLApLKdwREGujgv6taxwzOS+N+ZClbLU84EGR6\n V6ff2I/qwZcMwY3pga5kbtqB3CxbI3MThpd0vu4HH9jPi6xaNTqnoCj94dXczyLGlyA+\n iXQ9GdaKEjJ0uiJ1VyIyY9PA3OKggXFz1kRfkpnALyG075FRTwgzwdF8F4QuCF9QEGL3\n Sr/hFzX51ak1nOxAvQnAPc6xefgwCkiXS73BhxHJXHdQhOE/NpL99VNtM/VLdAKuWvk5\n 6oEA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWDVwLEZzInyvNsDlWPw3PdCQclD+FW2Zhf8+QAAj9ukgKiNpjj2foLZy1C8KcZZFSW+THX4LmBPLmKUQ==@vger.kernel.org", "X-Gm-Message-State": "AOJu0YwyziYUAaZR9Yvi7cwJ1lLVH1P4z4vr/gdYc/IBK07RRMtnL3JB\n\tCn+rerCqADX21Q34eZp8btHFTAoAQSk61O66YisNPMXI5/wbEUnMdpui", "X-Gm-Gg": "ATEYQzymAW8s6svevFDb37mhfeOoMvjrBU11DRDiQ8XdSjJJGTlch0dXMjTlB+KoDRt\n\tgBqXLi+HJoSHHSyM4f6xwd2eo2URfpJ4YBMTbjUFll+AJAxVi8XmTihBZ2kbkb8guHx9Z6lDtGC\n\tHvTpQSJZSDqn9qXd7n5BNd51X/vtT9uy02qT6QZe+W/QBXzN0CcQahbD3syeFy9RLpkPb+zUASr\n\tpag0fu/SSClw+DeWRBND/BHX8dKl3jpq3Ldj1cDOyhZym+Ett/lUQpwLSd4T4yNEsfRb90izWiU\n\t27zElBscy6Y3T6iZ9ZxkjYoTBeVDCrD/xdXh0ArXhl0U3zncY0IqSHHPuD0ZWRWnkoTyasO4pcO\n\tM1+hymI1kc8enS12UBpZxpBi8pNdRALv2TNdAtxIkwAr5diMzXz4w523+pBDKg1WfNJnBpZZatZ\n\tqjlpaTfEzBnpVI3OitCoH5tK2t5A==", "X-Received": "by 2002:a17:90b:57c4:b0:35b:9703:7664 with SMTP id\n 98e67ed59e1d1-35c008d38f1mr4197956a91.10.1774376860812;\n Tue, 24 Mar 2026 11:27:40 -0700 (PDT)", "From": "Atharv Dubey <atharvd440@gmail.com>", "Date": "Tue, 24 Mar 2026 23:56:51 +0530", "Subject": "[PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with\n dev_err_probe() in probe function", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260324-deverr-v1-3-7e591cce33a3@gmail.com>", "References": "<20260324-deverr-v1-0-7e591cce33a3@gmail.com>", "In-Reply-To": "<20260324-deverr-v1-0-7e591cce33a3@gmail.com>", "To": "Till Harbaum <till@harbaum.org>, Andi Shyti <andi.shyti@kernel.org>,\n Laxman Dewangan <ldewangan@nvidia.com>, Dmitry Osipenko <digetx@gmail.com>,\n Thierry Reding <thierry.reding@gmail.com>,\n Jonathan Hunter <jonathanh@nvidia.com>, Chen-Yu Tsai <wens@kernel.org>,\n Jernej Skrabec <jernej.skrabec@gmail.com>,\n Samuel Holland <samuel@sholland.org>,\n Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>,\n Alain Volmat <alain.volmat@foss.st.com>,\n Maxime Coquelin <mcoquelin.stm32@gmail.com>,\n Alexandre Torgue <alexandre.torgue@foss.st.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>,\n Orson Zhai <orsonzhai@gmail.com>,\n Baolin Wang <baolin.wang@linux.alibaba.com>,\n Chunyan Zhang <zhang.lyra@gmail.com>, Jean Delvare <jdelvare@suse.com>", "Cc": "linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda <e.zanda1@gmail.com>, Atharv Dubey <atharvd440@gmail.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1774376818; l=3450;\n i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id;\n bh=mGoeA4RoMr6oMafJS8Wz9uEiYGmdoZGvaadkVl07Ac4=;\n b=mqDXFTn7P7YKfYZq5yfTqBReywbYSNkXTrDiQ10Gxn0U4N3AcD22e4px2/bKmxQtkFRLFhMV5\n D6Rwa2VObbECiZHEiSRVGIVnkT5nDLR0wDkwvKuXdMmJb12BQQQ/qlI", "X-Developer-Key": "i=atharvd440@gmail.com; a=ed25519;\n pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk=" }, "content": "From: Enrico Zanda <e.zanda1@gmail.com>\n\nThis simplifies the code while improving log.\n\nSigned-off-by: Enrico Zanda <e.zanda1@gmail.com>\nSigned-off-by: Atharv Dubey <atharvd440@gmail.com>\n---\n drivers/i2c/busses/i2c-sun6i-p2wi.c | 55 ++++++++++++++-----------------------\n 1 file changed, 20 insertions(+), 35 deletions(-)", "diff": "diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c\nindex fb5280b8cf7f..dffbe776a195 100644\n--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c\n+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c\n@@ -194,22 +194,16 @@ static int p2wi_probe(struct platform_device *pdev)\n \tint ret;\n \n \tof_property_read_u32(np, \"clock-frequency\", &clk_freq);\n-\tif (clk_freq > P2WI_MAX_FREQ) {\n-\t\tdev_err(dev,\n-\t\t\t\"required clock-frequency (%u Hz) is too high (max = 6MHz)\",\n-\t\t\tclk_freq);\n-\t\treturn -EINVAL;\n-\t}\n+\tif (clk_freq > P2WI_MAX_FREQ)\n+\t\treturn dev_err_probe(dev, -EINVAL,\n+\t\t\t\t \"required clock-frequency (%u Hz) is too high (max = 6MHz)\",\n+\t\t\t\t clk_freq);\n \n-\tif (clk_freq == 0) {\n-\t\tdev_err(dev, \"clock-frequency is set to 0 in DT\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (clk_freq == 0)\n+\t\treturn dev_err_probe(dev, -EINVAL, \"clock-frequency is set to 0 in DT\\n\");\n \n-\tif (of_get_child_count(np) > 1) {\n-\t\tdev_err(dev, \"P2WI only supports one target device\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (of_get_child_count(np) > 1)\n+\t\treturn dev_err_probe(dev, -EINVAL, \"P2WI only supports one target device\\n\");\n \n \tp2wi = devm_kzalloc(dev, sizeof(struct p2wi), GFP_KERNEL);\n \tif (!p2wi)\n@@ -226,11 +220,9 @@ static int p2wi_probe(struct platform_device *pdev)\n \tchildnp = of_get_next_available_child(np, NULL);\n \tif (childnp) {\n \t\tret = of_property_read_u32(childnp, \"reg\", &target_addr);\n-\t\tif (ret) {\n-\t\t\tdev_err(dev, \"invalid target address on node %pOF\\n\",\n-\t\t\t\tchildnp);\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\t\tif (ret)\n+\t\t\treturn dev_err_probe(dev, -EINVAL,\n+\t\t\t\t\t \"invalid target address on node %pOF\\n\", childnp);\n \n \t\tp2wi->target_addr = target_addr;\n \t}\n@@ -245,26 +237,20 @@ static int p2wi_probe(struct platform_device *pdev)\n \t\treturn irq;\n \n \tp2wi->clk = devm_clk_get_enabled(dev, NULL);\n-\tif (IS_ERR(p2wi->clk)) {\n-\t\tret = PTR_ERR(p2wi->clk);\n-\t\tdev_err(dev, \"failed to enable clk: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+\tif (IS_ERR(p2wi->clk))\n+\t\treturn dev_err_probe(dev, PTR_ERR(p2wi->clk),\n+\t\t\t\t \"failed to enable clk\\n\");\n \n \tparent_clk_freq = clk_get_rate(p2wi->clk);\n \n \tp2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);\n-\tif (IS_ERR(p2wi->rstc)) {\n-\t\tdev_err(dev, \"failed to retrieve reset controller: %pe\\n\",\n-\t\t\tp2wi->rstc);\n-\t\treturn PTR_ERR(p2wi->rstc);\n-\t}\n+\tif (IS_ERR(p2wi->rstc))\n+\t\treturn dev_err_probe(dev, PTR_ERR(p2wi->rstc),\n+\t\t\t\t \"failed to retrieve reset controller\\n\");\n \n \tret = reset_control_deassert(p2wi->rstc);\n-\tif (ret) {\n-\t\tdev_err(dev, \"failed to deassert reset line: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\treturn dev_err_probe(dev, ret, \"failed to deassert reset line\\n\");\n \n \tinit_completion(&p2wi->complete);\n \tp2wi->adapter.dev.parent = dev;\n@@ -276,8 +262,7 @@ static int p2wi_probe(struct platform_device *pdev)\n \n \tret = devm_request_irq(dev, irq, p2wi_interrupt, 0, pdev->name, p2wi);\n \tif (ret) {\n-\t\tdev_err(dev, \"can't register interrupt handler irq%d: %d\\n\",\n-\t\t\tirq, ret);\n+\t\tdev_err_probe(dev, ret, \"can't register interrupt handler irq%d\\n\", irq);\n \t\tgoto err_reset_assert;\n \t}\n \n", "prefixes": [ "03/10" ] }