[{"id":3669176,"web_url":"http://patchwork.ozlabs.org/comment/3669176/","msgid":"","list_archive_url":null,"date":"2026-03-25T16:01:31","subject":"Re: [PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with\n dev_err_probe() in probe function","submitter":{"id":76129,"url":"http://patchwork.ozlabs.org/api/people/76129/","name":"Chen-Yu Tsai","email":"wens@kernel.org"},"content":"On Wed, Mar 25, 2026 at 2:27 AM Atharv Dubey wrote:\n>\n> From: Enrico Zanda \n>\n> This simplifies the code while improving log.\n>\n> Signed-off-by: Enrico Zanda \n> Signed-off-by: Atharv Dubey \n> ---\n> drivers/i2c/busses/i2c-sun6i-p2wi.c | 55 ++++++++++++++-----------------------\n> 1 file changed, 20 insertions(+), 35 deletions(-)\n>\n> diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c\n> index fb5280b8cf7f..dffbe776a195 100644\n> --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c\n> +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c\n> @@ -194,22 +194,16 @@ static int p2wi_probe(struct platform_device *pdev)\n> int ret;\n>\n> of_property_read_u32(np, \"clock-frequency\", &clk_freq);\n> - if (clk_freq > P2WI_MAX_FREQ) {\n> - dev_err(dev,\n> - \"required clock-frequency (%u Hz) is too high (max = 6MHz)\",\n> - clk_freq);\n> - return -EINVAL;\n> - }\n> + if (clk_freq > P2WI_MAX_FREQ)\n> + return dev_err_probe(dev, -EINVAL,\n> + \"required clock-frequency (%u Hz) is too high (max = 6MHz)\",\n> + clk_freq);\n>\n> - if (clk_freq == 0) {\n> - dev_err(dev, \"clock-frequency is set to 0 in DT\\n\");\n> - return -EINVAL;\n> - }\n> + if (clk_freq == 0)\n> + return dev_err_probe(dev, -EINVAL, \"clock-frequency is set to 0 in DT\\n\");\n>\n> - if (of_get_child_count(np) > 1) {\n> - dev_err(dev, \"P2WI only supports one target device\\n\");\n> - return -EINVAL;\n> - }\n> + if (of_get_child_count(np) > 1)\n> + return dev_err_probe(dev, -EINVAL, \"P2WI only supports one target device\\n\");\n>\n> p2wi = devm_kzalloc(dev, sizeof(struct p2wi), GFP_KERNEL);\n> if (!p2wi)\n> @@ -226,11 +220,9 @@ static int p2wi_probe(struct platform_device *pdev)\n> childnp = of_get_next_available_child(np, NULL);\n> if (childnp) {\n> ret = of_property_read_u32(childnp, \"reg\", &target_addr);\n> - if (ret) {\n> - dev_err(dev, \"invalid target address on node %pOF\\n\",\n> - childnp);\n> - return -EINVAL;\n> - }\n> + if (ret)\n> + return dev_err_probe(dev, -EINVAL,\n> + \"invalid target address on node %pOF\\n\", childnp);\n>\n> p2wi->target_addr = target_addr;\n> }\n> @@ -245,26 +237,20 @@ static int p2wi_probe(struct platform_device *pdev)\n> return irq;\n>\n> p2wi->clk = devm_clk_get_enabled(dev, NULL);\n> - if (IS_ERR(p2wi->clk)) {\n> - ret = PTR_ERR(p2wi->clk);\n> - dev_err(dev, \"failed to enable clk: %d\\n\", ret);\n> - return ret;\n> - }\n> + if (IS_ERR(p2wi->clk))\n> + return dev_err_probe(dev, PTR_ERR(p2wi->clk),\n> + \"failed to enable clk\\n\");\n>\n> parent_clk_freq = clk_get_rate(p2wi->clk);\n>\n> p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);\n> - if (IS_ERR(p2wi->rstc)) {\n> - dev_err(dev, \"failed to retrieve reset controller: %pe\\n\",\n> - p2wi->rstc);\n> - return PTR_ERR(p2wi->rstc);\n> - }\n> + if (IS_ERR(p2wi->rstc))\n> + return dev_err_probe(dev, PTR_ERR(p2wi->rstc),\n> + \"failed to retrieve reset controller\\n\");\n>\n> ret = reset_control_deassert(p2wi->rstc);\n> - if (ret) {\n> - dev_err(dev, \"failed to deassert reset line: %d\\n\", ret);\n> - return ret;\n> - }\n> + if (ret)\n> + return dev_err_probe(dev, ret, \"failed to deassert reset line\\n\");\n\nYou could also simplify this whole block with\ndevm_reset_control_get_exclusive_deasserted().\n\nEither way,\n\nReviewed-by: Chen-Yu Tsai \n\n\n> init_completion(&p2wi->complete);\n> p2wi->adapter.dev.parent = dev;\n> @@ -276,8 +262,7 @@ static int p2wi_probe(struct platform_device *pdev)\n>\n> ret = devm_request_irq(dev, irq, p2wi_interrupt, 0, pdev->name, p2wi);\n> if (ret) {\n> - dev_err(dev, \"can't register interrupt handler irq%d: %d\\n\",\n> - irq, ret);\n> + dev_err_probe(dev, ret, \"can't register interrupt handler irq%d\\n\", irq);\n> goto err_reset_assert;\n> }\n>\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Gk0/ZngP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13239-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Gk0/ZngP\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgs9w1JSlz1xy3\n\tfor ; Thu, 26 Mar 2026 03:02:28 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0AD2D3004608\n\tfor ; Wed, 25 Mar 2026 16:01:48 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EE3DE3E8664;\n\tWed, 25 Mar 2026 16:01:46 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB0B3E275D\n\tfor ; Wed, 25 Mar 2026 16:01:46 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8E624C2BCB9\n\tfor ; Wed, 25 Mar 2026 16:01:46 +0000 (UTC)","by mail-lj1-f178.google.com with SMTP id\n 38308e7fff4ca-38bf47a6f02so21100561fa.3\n for ;\n Wed, 25 Mar 2026 09:01:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774454506; cv=none;\n b=hEk9YCJqjPlaHCVM/mEtbqHxsoYSVkqnSob594ogjlObiuRZu8eg+aQL9/CTTPJ0pzBraopQ0WvC6J/ZzqronN5OH5625hMxeLFcELzNOAb/DW0ym2vhEnnGvF5OxPCtubO7OyGiAucNiHVVWHEiUQ/RfY1SC7LDYv/sETmPyE4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774454506; c=relaxed/simple;\n\tbh=aldmRPDOiiniGw503t8LDK2MsDSx7z+uZZ/KCfzSBN4=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=rZ+9yOsO3XpYVZQfYRC1WRhs5x25WniB666wtTmNxZweNlUfN8XBeZ3DKGPG6MkTKnrKyImaCHoy5Otyabb0EePp5Mzd4u6KI4OdUxi4F4agbf6EUPEDoTdBMBrr54Z09J2z57IMfxJOK3hkEnmg+5hDVEIo8eH66eUhPHrl8ys=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Gk0/ZngP; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774454506;\n\tbh=aldmRPDOiiniGw503t8LDK2MsDSx7z+uZZ/KCfzSBN4=;\n\th=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc:From;\n\tb=Gk0/ZngPQjeGn36eOsdWZQWLWprEWy3AkR5hni/lE8ONxCfP3wN9iJXuu5vn2pyMJ\n\t nJiG+ExwL18ilB8uMi+50Px+48WLD35cA/KJzXl30cOrLm1XHkP6/u7CfzuhuMgYBp\n\t DDxza3CMzAS8sMQyLGYMo2oiYPpT8nggzBl8focYuTSXEM2IAcs5OZqZ1j3YzIY+XT\n\t 1I001RKPlZrVl+U7XDdwRzb6asn8XwzNOGgT85IMqibPiISmDfL5M3GvsTJxSjcZ3J\n\t RB4byEEi8D5lGMQp3KZ85qQNPUmFfiaaLH5yO8GZd2D+YWbKD3ud9QCm4xCljSwmLN\n\t AM82iX3FkN6qw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWtVCxkHHVB2lyKrqSdueI0qjrvo+YYIpI4Jg8ENTwfFMAxP5rjNzsKlVpIra4R2nVv7vt99RRPeKfZpA==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yzbkyv/RCdqWeuEudeQsJTX9jN56G2RLB303Rqg1H5b63TOf/qJ\n\t4W7eZ0cPEqIkzP1kToI2Kj3CL8LyAE950IYkQt0yM0al7yQ7R+oVwWIcaJNmVrQWAn6pdfGHcOR\n\t49Ktsyf76/lutWIlo+R0EB9lDe3/7LlM=","X-Received":"by 2002:a05:651c:1469:b0:38c:6b7:ad47 with SMTP id\n 38308e7fff4ca-38c43072d48mr15879491fa.7.1774454504493; Wed, 25 Mar 2026\n 09:01:44 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>\n <20260324-deverr-v1-3-7e591cce33a3@gmail.com>","In-Reply-To":"<20260324-deverr-v1-3-7e591cce33a3@gmail.com>","Reply-To":"wens@kernel.org","From":"Chen-Yu Tsai ","Date":"Thu, 26 Mar 2026 00:01:31 +0800","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzDy-rsBXq4Ru9U4FVjZxHD70RtzjKuDaTmPj80U_CHIL3nYWTBGwt2KYN8","Message-ID":"\n ","Subject":"Re: [PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with\n dev_err_probe() in probe function","To":"Atharv Dubey ","Cc":"Till Harbaum , Andi Shyti ,\n\tLaxman Dewangan , Dmitry Osipenko ,\n\tThierry Reding ,\n Jonathan Hunter ,\n\tJernej Skrabec ,\n Samuel Holland ,\n\tPierre-Yves MORDRET ,\n Alain Volmat ,\n\tMaxime Coquelin ,\n Alexandre Torgue ,\n\tPatrice Chotard ,\n Orson Zhai ,\n\tBaolin Wang ,\n Chunyan Zhang ,\n\tJean Delvare , linux-i2c@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n\tEnrico Zanda ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]