Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215459/?format=api
{ "id": 2215459, "url": "http://patchwork.ozlabs.org/api/patches/2215459/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324165705.785605-1-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260324165705.785605-1-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-24T16:57:05", "name": "treewide: replace qemu_hw_version() with QEMU_HW_VERSION", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c20548464818e7876189410db48575a21b216d66", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324165705.785605-1-pbonzini@redhat.com/mbox/", "series": [ { "id": 497316, "url": "http://patchwork.ozlabs.org/api/series/497316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497316", "date": "2026-03-24T16:57:05", "name": "treewide: replace qemu_hw_version() with QEMU_HW_VERSION", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497316/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215459/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215459/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RUFmmKwb;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=M8F5OvFJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGSY2rtsz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 03:58:05 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w554L-0004tR-4y; Tue, 24 Mar 2026 12:57:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w5548-0004iN-Lr\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 12:57:18 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w5546-0000YR-61\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 12:57:15 -0400", "from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-185-eijSrHk7OiCssKBec6J6qg-1; Tue, 24 Mar 2026 12:57:09 -0400", "by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-485375aa56eso38397175e9.1\n for <qemu-devel@nongnu.org>; Tue, 24 Mar 2026 09:57:09 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4871174f2desm79948305e9.9.2026.03.24.09.57.05\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 09:57:06 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774371431;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=qolVXTErP3rEARxzso+7cA4ZsYaKcIoCUVPKfyGf30s=;\n b=RUFmmKwbIWlbqmKnWX9tiXkMzRjsP7FKJtZVGfkH72lSRR17tC9cIjDaknVNAiMa0iaKl+\n 3bcZoqOPIBPPTkKYvvCxnoRjkUsXAugHvSpxkcRsE7ugyLWmIBzH6g715m0SRd2jIr2ZVi\n IB48vxKRMP6gQR1xRxddfuFYjgA1oU4=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774371428; x=1774976228; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=qolVXTErP3rEARxzso+7cA4ZsYaKcIoCUVPKfyGf30s=;\n b=M8F5OvFJku4qzydFfRor8pXV8By6qpz17Y/rWfDvBgElK/o9kbp/ESvnh8PbBHBRQI\n tEGV9ol3bKu9Iz6383UY3RTHq7P9cJrqNr4e/5zcez8vVRuoXCz0cwzjPtvTsQNg+nPW\n KJqHi8rFIMRDdy0hRaR5xywmXECKubaVXd3Gg561gQfPWMmo2TlzpXyUoANd205jscp6\n t54+JzOvFz0GS+0+djFANHoEuKTdIB31FHiS2zYVv7IPvDuE7wMcR7LeC42PGnSz9usR\n gwdKo9YehYJLSWVXBsXBNH8R9vXVE6+xlcpa0itBctB+yz++E/bG3MwSTjNWRQk0OkJ8\n sHdA==" ], "X-MC-Unique": "eijSrHk7OiCssKBec6J6qg-1", "X-Mimecast-MFC-AGG-ID": "eijSrHk7OiCssKBec6J6qg_1774371428", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774371428; x=1774976228;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=qolVXTErP3rEARxzso+7cA4ZsYaKcIoCUVPKfyGf30s=;\n b=TyNpH5Q18Yawv/Jwf0y8WEybPmJes3sAS8OuyBkXbY8WtNtMb2R/2BfBHy3e80EuL4\n uU2zuREhzrCDTvM2NfEyrA75U52Iio3FgAOqdyW9bnlll0cRabOREDpK+WVz3J2W0AFX\n TqDdw9JHT+UGsUOtHKxSmwvm/QCeEJyVj8DoaD/vG8TT48e8ak5NpYxJr5xHH9IFqq8t\n YAvnZ2hPjB3HlpNIXKknQkVDy+4yoERbqeRXJlsM+JaBV8NeLk3odrNNhSY83wC+htp4\n 8ClX7hw9nyk4TEw36J/sIbDbs19x5q45jlYrOteC93PVCFCkWbg3zCyh/3289ej30g1f\n ZPSw==", "X-Gm-Message-State": "AOJu0Yy1cc+T7Kd2JtaIybV3BpGOI75PgtcbLWCCdP5SbijG49QiAOvB\n L8j9V72tC7y3etM2ufX2y/USFq7fO12S10XdtJW3UNQGimMm8UJuWrSdGq6WL9Zm+OCNtvPfCkk\n QkM9tbXjfiFKjUQSDvSjgdG9ovYQCjd2EAO9vpRQyYn1dZ8Lk9YF2qmexffVcamBiQzpS6o9n53\n 3LbWMtT/nSiBjtfSpI8+bPAsQewZvc69seXLeeeM1t", "X-Gm-Gg": "ATEYQzwK2USVNlCWLFTbig61ZhtON+4DpVba6fk9S6bxrWiuG6sFUMHCpZ1ov3wdiFZ\n wx7xae2vgKyacNtnpBChL6nyzS71u24pGw20wQFiMMH3a7gUnXgu0T6AeVlEfcwP5zIGhTXWJqf\n D2PTOJ3+hHIzlLbjw799CP3lSuTCMgNn1qNIU+H43hd7x6viRVVqQZSWSVZofbEIr1LXaHc3cBL\n kez4pMiO0MYFfvWMoJ0WnylCHovV1Js/NO77cSxBxPuwwFPakBf7TEvoHFsmkxsYNk8KbJRX3iJ\n NUFGxhyj5cLUwTKjnrD+5ofnbJk8oDFlMoVeVt372eRk1htNNfb5bn7Y6XoawHepU/NgVxQaGcu\n AWkT1dfcpm8Od7ELK9dYv2QafwAu3fmzc2gv3JwC3LxN4UeInWVTFzO2Y1pmTw/NBXjZ9gipafH\n U1sUSM70vrXmlb9fNia9OwNQEL", "X-Received": [ "by 2002:a05:600c:a40e:b0:485:4136:99a8 with SMTP id\n 5b1f17b1804b1-48716042b35mr5058505e9.22.1774371427458;\n Tue, 24 Mar 2026 09:57:07 -0700 (PDT)", "by 2002:a05:600c:a40e:b0:485:4136:99a8 with SMTP id\n 5b1f17b1804b1-48716042b35mr5058145e9.22.1774371426698;\n Tue, 24 Mar 2026 09:57:06 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION", "Date": "Tue, 24 Mar 2026 17:57:05 +0100", "Message-ID": "<20260324165705.785605-1-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The version is never set on 2.5+ machine types, so qemu_hw_version() and\nqemu_set_hw_version() are not needed anymore.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n include/hw/core/boards.h | 6 ------\n include/qemu/hw-version.h | 15 ---------------\n hw/ide/core.c | 2 +-\n hw/scsi/megasas.c | 2 +-\n hw/scsi/scsi-bus.c | 2 +-\n hw/scsi/scsi-disk.c | 2 +-\n system/vl.c | 4 ----\n target/s390x/cpu_models.c | 2 +-\n util/osdep.c | 12 ------------\n 9 files changed, 5 insertions(+), 42 deletions(-)", "diff": "diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h\nindex f85f31bd90d..b8dad0a1074 100644\n--- a/include/hw/core/boards.h\n+++ b/include/hw/core/boards.h\n@@ -197,11 +197,6 @@ typedef struct {\n * used to provide @cpu_index to socket number mapping, allowing\n * a machine to group CPU threads belonging to the same socket/package\n * Returns: socket number given cpu_index belongs to.\n- * @hw_version:\n- * Value of QEMU_VERSION when the machine was added to QEMU.\n- * Set only by old machines because they need to keep\n- * compatibility on code that exposed QEMU_VERSION to guests in\n- * the past (and now use qemu_hw_version()).\n * @possible_cpu_arch_ids:\n * Returns an array of @CPUArchId architecture-dependent CPU IDs\n * which includes CPU IDs for present and possible to hotplug CPUs.\n@@ -297,7 +292,6 @@ struct MachineClass {\n const char *default_display;\n const char *default_nic;\n GPtrArray *compat_props;\n- const char *hw_version;\n ram_addr_t default_ram_size;\n const char *default_cpu_type;\n bool default_kernel_irqchip_split;\ndiff --git a/include/qemu/hw-version.h b/include/qemu/hw-version.h\nindex 730a8c904d9..a40a6c204a6 100644\n--- a/include/qemu/hw-version.h\n+++ b/include/qemu/hw-version.h\n@@ -7,21 +7,6 @@\n #ifndef QEMU_HW_VERSION_H\n #define QEMU_HW_VERSION_H\n \n-/*\n- * Starting on QEMU 2.5, qemu_hw_version() returns \"2.5+\" by default\n- * instead of QEMU_VERSION, so setting hw_version on MachineClass\n- * is no longer mandatory.\n- *\n- * Do NOT change this string, or it will break compatibility on all\n- * machine classes that don't set hw_version.\n- */\n #define QEMU_HW_VERSION \"2.5+\"\n \n-/* QEMU \"hardware version\" setting. Used to replace code that exposed\n- * QEMU_VERSION to guests in the past and need to keep compatibility.\n- * Do not use qemu_hw_version() in new code.\n- */\n-void qemu_set_hw_version(const char *);\n-const char *qemu_hw_version(void);\n-\n #endif\ndiff --git a/hw/ide/core.c b/hw/ide/core.c\nindex b45abf067b2..d6719dbf31d 100644\n--- a/hw/ide/core.c\n+++ b/hw/ide/core.c\n@@ -2660,7 +2660,7 @@ int ide_init_drive(IDEState *s, IDEDevice *dev, IDEDriveKind kind, Error **errp)\n if (dev->version) {\n pstrcpy(s->version, sizeof(s->version), dev->version);\n } else {\n- pstrcpy(s->version, sizeof(s->version), qemu_hw_version());\n+ pstrcpy(s->version, sizeof(s->version), QEMU_HW_VERSION);\n }\n \n ide_reset(s);\ndiff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c\nindex f62e420a91e..0276886d594 100644\n--- a/hw/scsi/megasas.c\n+++ b/hw/scsi/megasas.c\n@@ -782,7 +782,7 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)\n \n memcpy(info.product_name, base_class->product_name, 24);\n snprintf(info.serial_number, 32, \"%s\", s->hba_serial);\n- snprintf(info.package_version, 0x60, \"%s-QEMU\", qemu_hw_version());\n+ snprintf(info.package_version, 0x60, \"%s-QEMU\", QEMU_HW_VERSION);\n memcpy(info.image_component[0].name, \"APP\", 3);\n snprintf(info.image_component[0].version, 10, \"%s-QEMU\",\n base_class->product_version);\ndiff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c\nindex 9b8656dd832..1a6b181b9d6 100644\n--- a/hw/scsi/scsi-bus.c\n+++ b/hw/scsi/scsi-bus.c\n@@ -703,7 +703,7 @@ static bool scsi_target_emulate_inquiry(SCSITargetReq *r)\n r->buf[7] = 0x10 | (r->req.bus->info->tcq ? 0x02 : 0); /* Sync, TCQ. */\n memcpy(&r->buf[8], \"QEMU \", 8);\n memcpy(&r->buf[16], \"QEMU TARGET \", 16);\n- pstrcpy((char *) &r->buf[32], 4, qemu_hw_version());\n+ pstrcpy((char *) &r->buf[32], 4, QEMU_HW_VERSION);\n }\n return true;\n }\ndiff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c\nindex a5201855352..5ba5b46c4f4 100644\n--- a/hw/scsi/scsi-disk.c\n+++ b/hw/scsi/scsi-disk.c\n@@ -2543,7 +2543,7 @@ static void scsi_realize(SCSIDevice *dev, Error **errp)\n }\n \n if (!s->version) {\n- s->version = g_strdup(qemu_hw_version());\n+ s->version = g_strdup(QEMU_HW_VERSION);\n }\n if (!s->vendor) {\n s->vendor = g_strdup(\"QEMU\");\ndiff --git a/system/vl.c b/system/vl.c\nindex 38d7b849e0a..246623b3196 100644\n--- a/system/vl.c\n+++ b/system/vl.c\n@@ -2212,10 +2212,6 @@ static void qemu_create_machine(QDict *qdict)\n \n cpu_exec_init_all();\n \n- if (machine_class->hw_version) {\n- qemu_set_hw_version(machine_class->hw_version);\n- }\n-\n /*\n * Get the default machine options from the machine if it is not already\n * specified either by the configuration file or by the command line.\ndiff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c\nindex 954a7a99a9e..0b88868289b 100644\n--- a/target/s390x/cpu_models.c\n+++ b/target/s390x/cpu_models.c\n@@ -955,7 +955,7 @@ static void s390_qemu_cpu_model_class_init(ObjectClass *oc, const void *data)\n \n xcc->is_migration_safe = true;\n xcc->desc = g_strdup_printf(\"QEMU Virtual CPU version %s\",\n- qemu_hw_version());\n+ QEMU_HW_VERSION);\n }\n \n static void s390_max_cpu_model_class_init(ObjectClass *oc, const void *data)\ndiff --git a/util/osdep.c b/util/osdep.c\nindex 000e7daac8b..4a8b8b5a90f 100644\n--- a/util/osdep.c\n+++ b/util/osdep.c\n@@ -31,8 +31,6 @@\n #include \"qemu/hw-version.h\"\n #include \"monitor/monitor.h\"\n \n-static const char *hw_version = QEMU_HW_VERSION;\n-\n int socket_set_cork(int fd, int v)\n {\n #if defined(SOL_TCP) && defined(TCP_CORK)\n@@ -533,16 +531,6 @@ ssize_t qemu_send_full(int s, const void *buf, size_t count)\n return total;\n }\n \n-void qemu_set_hw_version(const char *version)\n-{\n- hw_version = version;\n-}\n-\n-const char *qemu_hw_version(void)\n-{\n- return hw_version;\n-}\n-\n #ifdef _WIN32\n static void socket_cleanup(void)\n {\n", "prefixes": [] }