[{"id":3668583,"web_url":"http://patchwork.ozlabs.org/comment/3668583/","msgid":"","list_archive_url":null,"date":"2026-03-24T17:02:30","subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Tue, Mar 24, 2026 at 05:57:05PM +0100, Paolo Bonzini wrote:\n> The version is never set on 2.5+ machine types, so qemu_hw_version() and\n> qemu_set_hw_version() are not needed anymore.\n> \n> Signed-off-by: Paolo Bonzini \n> ---\n> include/hw/core/boards.h | 6 ------\n> include/qemu/hw-version.h | 15 ---------------\n> hw/ide/core.c | 2 +-\n> hw/scsi/megasas.c | 2 +-\n> hw/scsi/scsi-bus.c | 2 +-\n> hw/scsi/scsi-disk.c | 2 +-\n> system/vl.c | 4 ----\n> target/s390x/cpu_models.c | 2 +-\n> util/osdep.c | 12 ------------\n> 9 files changed, 5 insertions(+), 42 deletions(-)\n> \n> diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h\n> index f85f31bd90d..b8dad0a1074 100644\n> --- a/include/hw/core/boards.h\n> +++ b/include/hw/core/boards.h\n> @@ -197,11 +197,6 @@ typedef struct {\n> * used to provide @cpu_index to socket number mapping, allowing\n> * a machine to group CPU threads belonging to the same socket/package\n> * Returns: socket number given cpu_index belongs to.\n> - * @hw_version:\n> - * Value of QEMU_VERSION when the machine was added to QEMU.\n> - * Set only by old machines because they need to keep\n> - * compatibility on code that exposed QEMU_VERSION to guests in\n> - * the past (and now use qemu_hw_version()).\n> * @possible_cpu_arch_ids:\n> * Returns an array of @CPUArchId architecture-dependent CPU IDs\n> * which includes CPU IDs for present and possible to hotplug CPUs.\n> @@ -297,7 +292,6 @@ struct MachineClass {\n> const char *default_display;\n> const char *default_nic;\n> GPtrArray *compat_props;\n> - const char *hw_version;\n> ram_addr_t default_ram_size;\n> const char *default_cpu_type;\n> bool default_kernel_irqchip_split;\n> diff --git a/include/qemu/hw-version.h b/include/qemu/hw-version.h\n> index 730a8c904d9..a40a6c204a6 100644\n> --- a/include/qemu/hw-version.h\n> +++ b/include/qemu/hw-version.h\n> @@ -7,21 +7,6 @@\n> #ifndef QEMU_HW_VERSION_H\n> #define QEMU_HW_VERSION_H\n> \n> -/*\n> - * Starting on QEMU 2.5, qemu_hw_version() returns \"2.5+\" by default\n> - * instead of QEMU_VERSION, so setting hw_version on MachineClass\n> - * is no longer mandatory.\n> - *\n> - * Do NOT change this string, or it will break compatibility on all\n> - * machine classes that don't set hw_version.\n> - */\n\nI feel like we should be keeping a comment statement that\nthis must never be changed due to ABI compat.\n\n> #define QEMU_HW_VERSION \"2.5+\"\n\nAlso, is there any better place this can live now that this\nheader file has a single #define and nothing else ?\n\n> \n> -/* QEMU \"hardware version\" setting. Used to replace code that exposed\n> - * QEMU_VERSION to guests in the past and need to keep compatibility.\n> - * Do not use qemu_hw_version() in new code.\n> - */\n> -void qemu_set_hw_version(const char *);\n> -const char *qemu_hw_version(void);\n> -\n> #endif\n> diff --git a/hw/ide/core.c b/hw/ide/core.c\n> index b45abf067b2..d6719dbf31d 100644\n> --- a/hw/ide/core.c\n> +++ b/hw/ide/core.c\n> @@ -2660,7 +2660,7 @@ int ide_init_drive(IDEState *s, IDEDevice *dev, IDEDriveKind kind, Error **errp)\n> if (dev->version) {\n> pstrcpy(s->version, sizeof(s->version), dev->version);\n> } else {\n> - pstrcpy(s->version, sizeof(s->version), qemu_hw_version());\n> + pstrcpy(s->version, sizeof(s->version), QEMU_HW_VERSION);\n> }\n> \n> ide_reset(s);\n> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c\n> index f62e420a91e..0276886d594 100644\n> --- a/hw/scsi/megasas.c\n> +++ b/hw/scsi/megasas.c\n> @@ -782,7 +782,7 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)\n> \n> memcpy(info.product_name, base_class->product_name, 24);\n> snprintf(info.serial_number, 32, \"%s\", s->hba_serial);\n> - snprintf(info.package_version, 0x60, \"%s-QEMU\", qemu_hw_version());\n> + snprintf(info.package_version, 0x60, \"%s-QEMU\", QEMU_HW_VERSION);\n> memcpy(info.image_component[0].name, \"APP\", 3);\n> snprintf(info.image_component[0].version, 10, \"%s-QEMU\",\n> base_class->product_version);\n> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c\n> index 9b8656dd832..1a6b181b9d6 100644\n> --- a/hw/scsi/scsi-bus.c\n> +++ b/hw/scsi/scsi-bus.c\n> @@ -703,7 +703,7 @@ static bool scsi_target_emulate_inquiry(SCSITargetReq *r)\n> r->buf[7] = 0x10 | (r->req.bus->info->tcq ? 0x02 : 0); /* Sync, TCQ. */\n> memcpy(&r->buf[8], \"QEMU \", 8);\n> memcpy(&r->buf[16], \"QEMU TARGET \", 16);\n> - pstrcpy((char *) &r->buf[32], 4, qemu_hw_version());\n> + pstrcpy((char *) &r->buf[32], 4, QEMU_HW_VERSION);\n> }\n> return true;\n> }\n> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c\n> index a5201855352..5ba5b46c4f4 100644\n> --- a/hw/scsi/scsi-disk.c\n> +++ b/hw/scsi/scsi-disk.c\n> @@ -2543,7 +2543,7 @@ static void scsi_realize(SCSIDevice *dev, Error **errp)\n> }\n> \n> if (!s->version) {\n> - s->version = g_strdup(qemu_hw_version());\n> + s->version = g_strdup(QEMU_HW_VERSION);\n> }\n> if (!s->vendor) {\n> s->vendor = g_strdup(\"QEMU\");\n> diff --git a/system/vl.c b/system/vl.c\n> index 38d7b849e0a..246623b3196 100644\n> --- a/system/vl.c\n> +++ b/system/vl.c\n> @@ -2212,10 +2212,6 @@ static void qemu_create_machine(QDict *qdict)\n> \n> cpu_exec_init_all();\n> \n> - if (machine_class->hw_version) {\n> - qemu_set_hw_version(machine_class->hw_version);\n> - }\n> -\n> /*\n> * Get the default machine options from the machine if it is not already\n> * specified either by the configuration file or by the command line.\n> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c\n> index 954a7a99a9e..0b88868289b 100644\n> --- a/target/s390x/cpu_models.c\n> +++ b/target/s390x/cpu_models.c\n> @@ -955,7 +955,7 @@ static void s390_qemu_cpu_model_class_init(ObjectClass *oc, const void *data)\n> \n> xcc->is_migration_safe = true;\n> xcc->desc = g_strdup_printf(\"QEMU Virtual CPU version %s\",\n> - qemu_hw_version());\n> + QEMU_HW_VERSION);\n> }\n> \n> static void s390_max_cpu_model_class_init(ObjectClass *oc, const void *data)\n> diff --git a/util/osdep.c b/util/osdep.c\n> index 000e7daac8b..4a8b8b5a90f 100644\n> --- a/util/osdep.c\n> +++ b/util/osdep.c\n> @@ -31,8 +31,6 @@\n> #include \"qemu/hw-version.h\"\n> #include \"monitor/monitor.h\"\n> \n> -static const char *hw_version = QEMU_HW_VERSION;\n> -\n> int socket_set_cork(int fd, int v)\n> {\n> #if defined(SOL_TCP) && defined(TCP_CORK)\n> @@ -533,16 +531,6 @@ ssize_t qemu_send_full(int s, const void *buf, size_t count)\n> return total;\n> }\n> \n> -void qemu_set_hw_version(const char *version)\n> -{\n> - hw_version = version;\n> -}\n> -\n> -const char *qemu_hw_version(void)\n> -{\n> - return hw_version;\n> -}\n> -\n> #ifdef _WIN32\n> static void socket_cleanup(void)\n> {\n> -- \n> 2.53.0\n> \n> \n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=getxeTSQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGZC3Rrmz1xy1\n\tfor ; Wed, 25 Mar 2026 04:02:59 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w559O-0006i0-Cv; Tue, 24 Mar 2026 13:02:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w559M-0006hZ-LK\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:02:40 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w559K-0001Nh-Nf\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:02:40 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-zgawfDQ2PSeumiaVtgZPIQ-1; Tue,\n 24 Mar 2026 13:02:36 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 348311954B10\n for ; Tue, 24 Mar 2026 17:02:35 +0000 (UTC)","from redhat.com (unknown [10.44.33.93])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id DB7541955D71; Tue, 24 Mar 2026 17:02:33 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774371757;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=ieuV7lGd4eCsU/pyXDsr8lPONGdhfmYX1g6NYVWP87k=;\n b=getxeTSQ2uyVxpBoxEyy5z4f+EpxETuF4vpynwabn1Y7iL/e0bwRT8EmCLDoqqB9+/aXPF\n Tt8dQKJ+DbSxFwI15JAUelIiVXh1yn1b0AZLj31BHNWKgqxe1z/wUqKEkC4TLQAfFxEM+I\n TXdK1lw9++sRLRmrBcwxHadJiEjFq+0=","X-MC-Unique":"zgawfDQ2PSeumiaVtgZPIQ-1","X-Mimecast-MFC-AGG-ID":"zgawfDQ2PSeumiaVtgZPIQ_1774371755","Date":"Tue, 24 Mar 2026 17:02:30 +0000","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Paolo Bonzini ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","Message-ID":"","References":"<20260324165705.785605-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260324165705.785605-1-pbonzini@redhat.com>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3668585,"web_url":"http://patchwork.ozlabs.org/comment/3668585/","msgid":"","list_archive_url":null,"date":"2026-03-24T17:04:45","subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 24 Mar 2026 at 17:02, Daniel P. Berrangé wrote:\n> Also, is there any better place this can live now that this\n> header file has a single #define and nothing else ?\n\nIt's used in half a dozen files -- I think that generally\n\"used by only a few things\" is quite a good candidate for\ngoing in its own header, rather than putting it in some\nother header that gets pulled in by a lot more C files than\njust the half dozen that need it.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=OkYgQVBc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGcz06vBz1y1G\n\tfor ; Wed, 25 Mar 2026 04:05:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w55Bg-0000CZ-Uz; Tue, 24 Mar 2026 13:05:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w55Bd-000061-SL\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:05:02 -0400","from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w55Bc-0001fX-42\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:05:01 -0400","by mail-yw1-x112e.google.com with SMTP id\n 00721157ae682-797ab169454so44329647b3.3\n for ; Tue, 24 Mar 2026 10:04:58 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1774371898; cv=none;\n d=google.com; s=arc-20240605;\n b=bX8vYkOj9lFbVJV3XxE1ZFvoW2HTJzJLG9lKSn7UgOSiq91qi5asOX7e3KRD7VxWe7\n YZoPtP8nt2quJZ85dt6pMdyATVG+Ei2f4ePIZ4DgcEN43WO+/6ieShMRK561UZDNaJhV\n gij3pRH/UNmpWv89MDEJY0ukCZiLIFP4TU2naGlgQz/in8LXbIbgZQ8yMHr37iWi4GBb\n JTDq4DKa7lIxYGmYMsShEp0s69ok2M5puBrZoG3PFaeWQVlhzYkfaD25INVQyO9TVPe8\n xEWgfWXyxXeceRwJNlQIXxN7uBUQWcypHJq3kzyWduWqGBoIRMSX03zcxl6zgOiSOkqI\n H/Wg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=oQzj8rdeZMv0F7O1sRbox6Ujt8ujtPq8+oNcjiyDO/c=;\n fh=8EqW8ptiFroiMunud588LTyXANxgV4vUbXxoMyNhrzQ=;\n b=Z0o74uHGZTiiS9HuWUUwedr4yQrfpXNboNSLoC+hy5TcfakRyYa6IJLEH2nT7EUknG\n w27fCJEG5ZXMXISnP60BpfYZ7jKSrZXWbuvuZwP8+qwo3y+J3JOGFG7DP9E1RvoeICpb\n nMwq/Az/yd38CDasYheHRxgjkYCjJXOSjkSy+bI6/Wl3Z0+OUxW66cYhbRKfwKaeraoF\n 9SgQ8whcSmUP+nJ79Ac8zg4hOIGE+f5KcbKrbN9+NPrYAfA33tWswtpD2Ij+ljGJHLvQ\n uvw4h13kJgm9yEf4C+ZBhS1tSJtpXzLSKF5GNtFV+uEY8rfQpXWmMi8UgcEMcp4Kt1Aa\n WfDA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774371898; x=1774976698; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oQzj8rdeZMv0F7O1sRbox6Ujt8ujtPq8+oNcjiyDO/c=;\n b=OkYgQVBcFGLrNaATMQtKoLqA1uReW562HZ7BVp+IMeKWvv7SrUys3fAlPFh0x3rWmb\n kx92iraMNrNTmnL/a2it0fu6xkmnPkXaMP46Xnbp4ruHfq3tyLDnqqIgc7r0VWnkpIoC\n lwDsn/Dj8+NoWqBuP1dS9mOYeeAKDdHiAkcjL4vAl9EGOJeWesSATXFz12zP3/vldLKC\n e+ZsNsLc6C5f/bIfaj8y4CTcJ8zp135jaYw/5TuUOBU4czYYyMeH6ivuXBkr4m+w3X2n\n 0MeAaK+98D3W0Mvs1pcXMgOq3GQH65/tG+1piqw9eRm2YS72Texo4Q+1/zyxFkYOwizV\n O60w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774371898; x=1774976698;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=oQzj8rdeZMv0F7O1sRbox6Ujt8ujtPq8+oNcjiyDO/c=;\n b=ssud9xuTRlHJx2zuYakjKQcF7n4SjZszORznC7EU5lPvL+EUOLUfeQHFTDlxpgzQfl\n KOCJkqZCwAveEIh4A7wChq3LUA0DdUxbOdWs/x5YV9ZS16NAMh1T6/Ptj7jCqgzGzGEx\n 6ZMJAgLPYw3b03uzyWJVzG9Wtuy7GKPIwz0QLdLn6dXYBOTYGzLKvItTPXbs3x0wh+O4\n qislqvuGhGA1hzYY75KqJfD/xWyQTEmYEtSbbCzodUwVrZIeO5IGDQ4uEz3uK9XCCwW1\n slElovhGmF4Dr8LKoRuG+cowWXsJJ1rQNyK/Pl9ugWLRKDzVwNMnuNcW3opCiEl+whoG\n IC/w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV6nT6gPQ+F/0Ulr/ye6CUn9jehU7NPNc+BlCM11j+qJSnxsGRcuIv7quYBmQKDngj3X9iF510D46qg@nongnu.org","X-Gm-Message-State":"AOJu0YwaqL/TDWLmjkAXoTP8I6Xwp9FZwgp0pTp7JRuInEWL+e0ddtCH\n JaGsL1ZeI8EjXyv+FkFtJXZNZ5fppK+eh32YNSgKZ6r8kk8FD38ltfde/+e+/V3chGET8vxphDf\n 3Q8T7JV5pm5XjjIrH1llBpxvkaGAI6XxJgeytNq62gA==","X-Gm-Gg":"ATEYQzyvqIrpK3oUtr5MvDhvbICzUqUkLrXq/sGUzQDbBBZy66QSq8CfFxPN/UEqi7U\n zadfplU2n8QqrapYm+cWUsELmDgK4Og6or+HbQsZ2uGzJV2fNJAoV6WowldV61qQQfYo1EClyz2\n w4nR5mgjNTCuKkm0yqBWtnmDSLEvRtrkLjxjtiLD43LCgW6jT3+rmmk/MsH3Vgtn04M+GRkwZBU\n hf9M9tAaRi22QVqFDPaTH9+6Afp/jwcdtDZR+sHE1DJJYEk/gcas9UzmHyEfBCpS7QkdudRXIre\n 3TOn6Kd3u2j9AMfmRelSS9PCN41MgN7fbH0GzZmru50oE/bl7OIJvLGM7oTy5LteVSo=","X-Received":"by 2002:a05:690c:31e:b0:79a:2ef2:833 with SMTP id\n 00721157ae682-79acf397b28mr5421677b3.20.1774371897498; Tue, 24 Mar 2026\n 10:04:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20260324165705.785605-1-pbonzini@redhat.com>\n ","In-Reply-To":"","From":"Peter Maydell ","Date":"Tue, 24 Mar 2026 17:04:45 +0000","X-Gm-Features":"AaiRm51kc9hidfL-DKOnRtYfagBpJoWoEWCHfkTAYU7RlJzwhdkj_z9y0xpdjhA","Message-ID":"\n ","Subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"Paolo Bonzini , qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::112e;\n envelope-from=peter.maydell@linaro.org; helo=mail-yw1-x112e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3668588,"web_url":"http://patchwork.ozlabs.org/comment/3668588/","msgid":"","list_archive_url":null,"date":"2026-03-24T17:11:04","subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On Tue, Mar 24, 2026 at 6:02 PM Daniel P. Berrangé wrote:\n>\n> On Tue, Mar 24, 2026 at 05:57:05PM +0100, Paolo Bonzini wrote:\n> > The version is never set on 2.5+ machine types, so qemu_hw_version() and\n> > qemu_set_hw_version() are not needed anymore.\n> >\n> > Signed-off-by: Paolo Bonzini \n> > ---\n> > include/hw/core/boards.h | 6 ------\n> > include/qemu/hw-version.h | 15 ---------------\n> > hw/ide/core.c | 2 +-\n> > hw/scsi/megasas.c | 2 +-\n> > hw/scsi/scsi-bus.c | 2 +-\n> > hw/scsi/scsi-disk.c | 2 +-\n> > system/vl.c | 4 ----\n> > target/s390x/cpu_models.c | 2 +-\n> > util/osdep.c | 12 ------------\n> > 9 files changed, 5 insertions(+), 42 deletions(-)\n> >\n> > diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h\n> > index f85f31bd90d..b8dad0a1074 100644\n> > --- a/include/hw/core/boards.h\n> > +++ b/include/hw/core/boards.h\n> > @@ -197,11 +197,6 @@ typedef struct {\n> > * used to provide @cpu_index to socket number mapping, allowing\n> > * a machine to group CPU threads belonging to the same socket/package\n> > * Returns: socket number given cpu_index belongs to.\n> > - * @hw_version:\n> > - * Value of QEMU_VERSION when the machine was added to QEMU.\n> > - * Set only by old machines because they need to keep\n> > - * compatibility on code that exposed QEMU_VERSION to guests in\n> > - * the past (and now use qemu_hw_version()).\n> > * @possible_cpu_arch_ids:\n> > * Returns an array of @CPUArchId architecture-dependent CPU IDs\n> > * which includes CPU IDs for present and possible to hotplug CPUs.\n> > @@ -297,7 +292,6 @@ struct MachineClass {\n> > const char *default_display;\n> > const char *default_nic;\n> > GPtrArray *compat_props;\n> > - const char *hw_version;\n> > ram_addr_t default_ram_size;\n> > const char *default_cpu_type;\n> > bool default_kernel_irqchip_split;\n> > diff --git a/include/qemu/hw-version.h b/include/qemu/hw-version.h\n> > index 730a8c904d9..a40a6c204a6 100644\n> > --- a/include/qemu/hw-version.h\n> > +++ b/include/qemu/hw-version.h\n> > @@ -7,21 +7,6 @@\n> > #ifndef QEMU_HW_VERSION_H\n> > #define QEMU_HW_VERSION_H\n> >\n> > -/*\n> > - * Starting on QEMU 2.5, qemu_hw_version() returns \"2.5+\" by default\n> > - * instead of QEMU_VERSION, so setting hw_version on MachineClass\n> > - * is no longer mandatory.\n> > - *\n> > - * Do NOT change this string, or it will break compatibility on all\n> > - * machine classes that don't set hw_version.\n> > - */\n>\n> I feel like we should be keeping a comment statement that\n> this must never be changed due to ABI compat.\n>\n> > #define QEMU_HW_VERSION \"2.5+\"\n\nOk, what about this:\n\n * Starting on QEMU 2.5, devices with a version string in their\n * identification data return \"2.5+\" instead of QEMU_VERSION. Do\n * NOT change this string as it is visible to guests.\n\n> Also, is there any better place this can live now that this\n> header file has a single #define and nothing else ?\n\nI could put it in a random qdev header that everyone includes already\n- but I agree with Peter that it's better that it stays isolated, so\nthat it does not grow more uses.\n\nPaolo\n\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Vr/OFCo+;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=fTf25mF3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGmN4bzxz1y1g\n\tfor ; Wed, 25 Mar 2026 04:11:48 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w55I0-0002Wv-Be; Tue, 24 Mar 2026 13:11:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w55Hm-0002Vk-Pj\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:11:26 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w55Hl-0002mp-6e\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:11:22 -0400","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-125-_LfA-75UNqqNP8V6mClv1w-1; Tue, 24 Mar 2026 13:11:18 -0400","by mail-wr1-f71.google.com with SMTP id\n ffacd0b85a97d-439ca4b3d0bso5190519f8f.3\n for ; Tue, 24 Mar 2026 10:11:18 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774372279;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9jLEOa/qe84fRiaJ28GBTBVjxDGNzKXW14RsxfehDEQ=;\n b=Vr/OFCo+h7Su+3rqidStNdc3EmR/Ktkpk01eZ7qxevo8QoMzkJSct8GBotsyFkaaOx0672\n l9bqeztbJHxT9hICS6zoig9GQwniEqtNagJ6u/1V2Q4kSvDHDmzSZV0JXvkQ7IoVN1dAX7\n abfJ9Q1o5noUHU9w/6mpbUzimJcrQDM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774372277; x=1774977077; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9jLEOa/qe84fRiaJ28GBTBVjxDGNzKXW14RsxfehDEQ=;\n b=fTf25mF3/9SwssFs6kaMnEfjP5Vi7Len8UM+ZN5yQ+hhHKclisr/J7IxwmiS+sMJIm\n HsaLBXQY80evh/+Ikh36jH+k+8XVGL6KQbwCH86BEjSPLuQeHhBg/ZjLJbgr0bniWNv2\n Z7GO9eQBkDAEPYMB4kyQ/wvcszpkyrjcuso2dBZsb3oYiSCQZjNKY42HscgyIQptqJbM\n StNloxhIL1wo+ANKYKESYOvOhy7i+xhaUW+8ULnhsQSFQPNFn2w7w5/i3Q1u3Pi6vhP0\n zC8GZ5DqRpOuh0VeL/NQAs3zEDHxesMhGBll3flSjKZRzoQYqFhY/jNVilhRRdOFWg1m\n Uqnw=="],"X-MC-Unique":"_LfA-75UNqqNP8V6mClv1w-1","X-Mimecast-MFC-AGG-ID":"_LfA-75UNqqNP8V6mClv1w_1774372277","ARC-Seal":"i=1; a=rsa-sha256; t=1774372277; cv=none;\n d=google.com; s=arc-20240605;\n b=bcbW22gB2QRMUONdbRBn96eLLCG9lgGcbcg5rOVcr+4xRTij8Enlh5+hy4LB0rLDb8\n 7+dYaFystfbL6yYmI6cJJE+s61n78cw8iIYy8xwULFCA2v1o1YP396HVl2PSRttXoP5/\n 7I6hT1+/WIJYZF5FbPggcyeW1pT6aL0A0uzMFGoDO0GnhU5K9WSanFtQ9KudrCIphR4d\n fHzXSFbGXsO8pCMXglNnNWpTCkn4ccWxLCBhqnRSStI0QGWR8/ENumrTy5E42yBQjG5g\n uTp1Ca6ZAfP50rv9nIZsgzEBVp7R7tRNyM6YHHHD9Wp8aAODA2v9cJ7cNjdliy1kXwxO\n HLOA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=9jLEOa/qe84fRiaJ28GBTBVjxDGNzKXW14RsxfehDEQ=;\n fh=Qpl77bHkcE0bYSjiKXT9vs9obKUyn+uhBwvH7ERnfRM=;\n b=IVmRucPDeBz+djjhu2Wttoq8OZh0Ss6SE5S2ltgDk+0NyQJJmeV9Ew7HRkX+C1KrC/\n VoQF/FDao79Y3rwU96k41/Urynbqn0zBbP/taRnuHM88tLRvi7MFIzX2kNK+3ObR8poI\n ksWl2eY6JKC6O8ohKIFLjS9tyvKhZH4d8q9XOESjILN8ZSk0YxqoiCPSDXZIChs/sFa4\n Vq12bvQKCa8pjZOmrqQIiuFUP2/n70EoB8AM/Loy52ydjqp2QxWj87sXB7yj+GpemSWD\n Uo1K8EpKwWBXP89sEONb0teomvV+hJpQcyjNzOVVpdFLMSs7lNJazHTd3eJFUbGzbdfx\n wnSg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774372277; x=1774977077;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9jLEOa/qe84fRiaJ28GBTBVjxDGNzKXW14RsxfehDEQ=;\n b=lHegDActCtpHcn//KKiah6KJWUZftAtpbbVUw/laPNdV2ov/B3xrOuhzETL+PMLXp6\n NLznse6wjqz6og0TGUdSObQ+yyFu5QuIO8lruyEH5IfSSeNShB4NzWoHMRpo0hGz7s8q\n oM6e3xz0cEja02KOuWlxjNUnD1bBDbAAdnfMWN5YaMzd1qUsG9QnRM1dDyEa6wPJXNfw\n vQJtCmIM0Mvh2YohNCu4CuaCG+6ZF+aYSmUaNPhkj4Gh90PEz7/pRZNjd+tJ+st4/5QR\n FxdxJOSSxHV9HzR6wgtlIVQTRn+Yj5R50k1b7lpM/BQWSZYpUOwamFU1Sg/uTN/BCMDZ\n chtw==","X-Gm-Message-State":"AOJu0Yz0YXNT/kvvE/xKw4ssD5lb7UMQErx1Wa/z2qWIrKRsLZUrp2fC\n WbOw5F5NEautFxdS/IPp+hT8Et1nF6z3nmdnbhI5fnmKnMv2bfVqVvg7k20OBN984ngoORiIbcz\n YURHyL/qk25lGAn847VtnZSQ16Mj01eCHloA3TuhH6Pr3vdButFXWn3rk3g6DmGsWaAsI2SEmeT\n BAl6XnWvCA0IjsgFkx7BdHzEqC/GSznrE=","X-Gm-Gg":"ATEYQzw23h/Cn1aA5BUAa7fTG7LpQ/69X8sDBj0nwovQeDjMnK/YesETgOm9cwR4ewl\n alcphToloCFmYkJ2FOLRVHjKEUbXJwixhBPTc+nL51yPuNtZo/2pA/g4Kf+Si8b4lDdIPPK75gW\n Himj/I6jy3gEf0Da1NrxKq8W2EkMk0x7BnpMLCvhTfTVoVg75PxcGQkQizZiMKKXeH3BGDuQXsy\n /T1pb/DyB4z3AjKGdKKgEW84UQFDzsiYwhonWrTCDIOdKJGW/IhbYkQRlh6ZQyPrhJI/zuh4qVI\n JM+G","X-Received":["by 2002:a05:6000:4205:b0:43b:5762:298f with SMTP id\n ffacd0b85a97d-43b88a25610mr344975f8f.36.1774372276821;\n Tue, 24 Mar 2026 10:11:16 -0700 (PDT)","by 2002:a05:6000:4205:b0:43b:5762:298f with SMTP id\n ffacd0b85a97d-43b88a25610mr344930f8f.36.1774372276335; Tue, 24 Mar 2026\n 10:11:16 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260324165705.785605-1-pbonzini@redhat.com>\n ","In-Reply-To":"","From":"Paolo Bonzini ","Date":"Tue, 24 Mar 2026 18:11:04 +0100","X-Gm-Features":"AQROBzDwiGcXnGbd4Z6NB3K-mrE8QK5XKd6kArL4nhVqkX-l_hyinO4YXElKs-k","Message-ID":"\n ","Subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3668592,"web_url":"http://patchwork.ozlabs.org/comment/3668592/","msgid":"","list_archive_url":null,"date":"2026-03-24T17:13:48","subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Tue, Mar 24, 2026 at 06:11:04PM +0100, Paolo Bonzini wrote:\n> On Tue, Mar 24, 2026 at 6:02 PM Daniel P. Berrangé wrote:\n> >\n> > On Tue, Mar 24, 2026 at 05:57:05PM +0100, Paolo Bonzini wrote:\n> > > The version is never set on 2.5+ machine types, so qemu_hw_version() and\n> > > qemu_set_hw_version() are not needed anymore.\n> > >\n> > > Signed-off-by: Paolo Bonzini \n> > > ---\n> > > include/hw/core/boards.h | 6 ------\n> > > include/qemu/hw-version.h | 15 ---------------\n> > > hw/ide/core.c | 2 +-\n> > > hw/scsi/megasas.c | 2 +-\n> > > hw/scsi/scsi-bus.c | 2 +-\n> > > hw/scsi/scsi-disk.c | 2 +-\n> > > system/vl.c | 4 ----\n> > > target/s390x/cpu_models.c | 2 +-\n> > > util/osdep.c | 12 ------------\n> > > 9 files changed, 5 insertions(+), 42 deletions(-)\n> > >\n> > > diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h\n> > > index f85f31bd90d..b8dad0a1074 100644\n> > > --- a/include/hw/core/boards.h\n> > > +++ b/include/hw/core/boards.h\n> > > @@ -197,11 +197,6 @@ typedef struct {\n> > > * used to provide @cpu_index to socket number mapping, allowing\n> > > * a machine to group CPU threads belonging to the same socket/package\n> > > * Returns: socket number given cpu_index belongs to.\n> > > - * @hw_version:\n> > > - * Value of QEMU_VERSION when the machine was added to QEMU.\n> > > - * Set only by old machines because they need to keep\n> > > - * compatibility on code that exposed QEMU_VERSION to guests in\n> > > - * the past (and now use qemu_hw_version()).\n> > > * @possible_cpu_arch_ids:\n> > > * Returns an array of @CPUArchId architecture-dependent CPU IDs\n> > > * which includes CPU IDs for present and possible to hotplug CPUs.\n> > > @@ -297,7 +292,6 @@ struct MachineClass {\n> > > const char *default_display;\n> > > const char *default_nic;\n> > > GPtrArray *compat_props;\n> > > - const char *hw_version;\n> > > ram_addr_t default_ram_size;\n> > > const char *default_cpu_type;\n> > > bool default_kernel_irqchip_split;\n> > > diff --git a/include/qemu/hw-version.h b/include/qemu/hw-version.h\n> > > index 730a8c904d9..a40a6c204a6 100644\n> > > --- a/include/qemu/hw-version.h\n> > > +++ b/include/qemu/hw-version.h\n> > > @@ -7,21 +7,6 @@\n> > > #ifndef QEMU_HW_VERSION_H\n> > > #define QEMU_HW_VERSION_H\n> > >\n> > > -/*\n> > > - * Starting on QEMU 2.5, qemu_hw_version() returns \"2.5+\" by default\n> > > - * instead of QEMU_VERSION, so setting hw_version on MachineClass\n> > > - * is no longer mandatory.\n> > > - *\n> > > - * Do NOT change this string, or it will break compatibility on all\n> > > - * machine classes that don't set hw_version.\n> > > - */\n> >\n> > I feel like we should be keeping a comment statement that\n> > this must never be changed due to ABI compat.\n> >\n> > > #define QEMU_HW_VERSION \"2.5+\"\n> \n> Ok, what about this:\n> \n> * Starting on QEMU 2.5, devices with a version string in their\n> * identification data return \"2.5+\" instead of QEMU_VERSION. Do\n> * NOT change this string as it is visible to guests.\n\nYep, with that comment\n\nReviewed-by: Daniel P. Berrangé \n\n\n> \n> > Also, is there any better place this can live now that this\n> > header file has a single #define and nothing else ?\n> \n> I could put it in a random qdev header that everyone includes already\n> - but I agree with Peter that it's better that it stays isolated, so\n> that it does not grow more uses.\n\nYep, ok.\n\n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SSMMc30T;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGqP0b1Sz1y1g\n\tfor ; Wed, 25 Mar 2026 04:14:25 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w55KN-0003I7-N4; Tue, 24 Mar 2026 13:14:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w55KJ-0003HP-4E\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:13:59 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w55KG-00038i-DD\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 13:13:58 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-466--IPO9RMoN0etPEqMqRD-qQ-1; Tue,\n 24 Mar 2026 13:13:53 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C0ECA18005B9\n for ; Tue, 24 Mar 2026 17:13:52 +0000 (UTC)","from redhat.com (unknown [10.44.33.93])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 9BA741955D71; Tue, 24 Mar 2026 17:13:51 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774372435;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Sj9CvwQhStEW/EWj8oEYuJ49nZPiTxQJh0LwrRwHvhY=;\n b=SSMMc30TIg9QCjUCODyQ+aseddsrK2aqx24FcgAHULe5gYAJkhVje4Yan2/YKiVlRUXBTH\n Id+pFSVntTWRQOgDwF9dsIg2gynHwCfBiEU+Z/abs7zLSMDaGIvf1aN2TCyf1+ag6e01SH\n KgI81Z5fs/zXbBUf4diDPv7zOEmZ+jE=","X-MC-Unique":"-IPO9RMoN0etPEqMqRD-qQ-1","X-Mimecast-MFC-AGG-ID":"-IPO9RMoN0etPEqMqRD-qQ_1774372433","Date":"Tue, 24 Mar 2026 17:13:48 +0000","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Paolo Bonzini ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","Message-ID":"","References":"<20260324165705.785605-1-pbonzini@redhat.com>\n \n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n ","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3668661,"web_url":"http://patchwork.ozlabs.org/comment/3668661/","msgid":"<3768bc38-1231-4f62-9ac8-c27e8bb66e7b@linaro.org>","list_archive_url":null,"date":"2026-03-24T19:18:26","subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 24/3/26 17:57, Paolo Bonzini wrote:\n> The version is never set on 2.5+ machine types, so qemu_hw_version() and\n> qemu_set_hw_version() are not needed anymore.\n> \n> Signed-off-by: Paolo Bonzini \n> ---\n> include/hw/core/boards.h | 6 ------\n> include/qemu/hw-version.h | 15 ---------------\n> hw/ide/core.c | 2 +-\n> hw/scsi/megasas.c | 2 +-\n> hw/scsi/scsi-bus.c | 2 +-\n> hw/scsi/scsi-disk.c | 2 +-\n> system/vl.c | 4 ----\n> target/s390x/cpu_models.c | 2 +-\n> util/osdep.c | 12 ------------\n> 9 files changed, 5 insertions(+), 42 deletions(-)\n\n\n> diff --git a/include/qemu/hw-version.h b/include/qemu/hw-version.h\n> index 730a8c904d9..a40a6c204a6 100644\n> --- a/include/qemu/hw-version.h\n> +++ b/include/qemu/hw-version.h\n> @@ -7,21 +7,6 @@\n> #ifndef QEMU_HW_VERSION_H\n> #define QEMU_HW_VERSION_H\n> \n> -/*\n> - * Starting on QEMU 2.5, qemu_hw_version() returns \"2.5+\" by default\n> - * instead of QEMU_VERSION, so setting hw_version on MachineClass\n> - * is no longer mandatory.\n> - *\n> - * Do NOT change this string, or it will break compatibility on all\n> - * machine classes that don't set hw_version.\n> - */\n> #define QEMU_HW_VERSION \"2.5+\"\n\nMaybe rename as QEMU_HW_VERSION_2_5P if we remove the \"do not change\nthis string\" comment.\n\n> \n> -/* QEMU \"hardware version\" setting. Used to replace code that exposed\n> - * QEMU_VERSION to guests in the past and need to keep compatibility.\n> - * Do not use qemu_hw_version() in new code.\n> - */\n> -void qemu_set_hw_version(const char *);\n> -const char *qemu_hw_version(void);\n> -\n> #endif","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CnLP9AYH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgKZs0M9rz1y1g\n\tfor ; Wed, 25 Mar 2026 06:18:45 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w57Gt-00047K-CI; Tue, 24 Mar 2026 15:18:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w57Gr-000454-HC\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:18:33 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w57Gp-00030G-Py\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:18:33 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-487035181a7so24318435e9.2\n for ; Tue, 24 Mar 2026 12:18:30 -0700 (PDT)","from [192.168.69.206] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48711764509sm69273445e9.13.2026.03.24.12.18.28\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 24 Mar 2026 12:18:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774379910; x=1774984710; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=J9ybZ6sHf7peVthVZMHJacmFgu+y7QATdzWCq7QjAmE=;\n b=CnLP9AYHC7SZdLP234GjX1mE8RCrwixFWKrglxftnrJPN4x9DYkurM5AyIk+ejj2VY\n CZFKMBK0yKgYsp/yLwc1mgM4Fz9ncNLWa3y8A3WBA1B8uHIQm+Hufc0HGitNBn+zEpJD\n XX1vO1IwPtdJkGvsW7acSmZs8Vfrzd8iZ/jpdDC0wIvdtG100Gb4WXEyjBCJ3NdnsXgC\n uafv6g+mejQTRDIIoWZS+MB1X0V4M/oWcDeK5Ud1e9EO410LrzZtZru3/pgUZbbWVaCI\n O99r6J99gPOsVksmQ3jpOG+tyBTCFO1VLW8wLMYZNmduFJvVTjJzbiAJPJhnGep1NWWs\n E9DA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774379910; x=1774984710;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=J9ybZ6sHf7peVthVZMHJacmFgu+y7QATdzWCq7QjAmE=;\n b=PrSPc6Ihm6p+gpTZWEcDfN8PFTqbxz4pMxUc4CQiuRsAYQegbnTJq8QEgaKpE7FH03\n IidRZGUn831MRbFkBnGAP77n6Qdm3y/4lJpxbQV7k2lnLY9+iWp4JbG71PKLyMoqZ8eJ\n jh3nNcoqa5j6aWP6kfoYu+uvnhBX264k8nbYR4DIvY0r4AVObbns+U88nsULHxVzTxPx\n NICQfcdBbxzBTPMDSNgiIq8ckW3VOkGO/5e7BePKdQN86uvgqF8AispsIDGcmNwUY9Zo\n Z0iTe2iz3iWdkRfSGZHRdi8YougpNii10bDq5Cuavg1GwgdF9oCqEb6SIY9tcvFxw2nJ\n ayrw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXliRYfIgtaHxB/NNne3A38i5BZjbElkGIsvxr78+zBMGvOHe9iHKiDJTTN3/4cB3noDKuxxELZzSIQ@nongnu.org","X-Gm-Message-State":"AOJu0Yx/8ho70w1O7tsqmvNSRKpoCWit3iS1YS4Pp3p4oIafX+K2M6OM\n 8eFEbc417TAASJw/4Ci/1u2EpWRUySpVbdJe4pNJkFm8jHX9l1KC9j/K6Bfkco5OUkE=","X-Gm-Gg":"ATEYQzwcfji6vtHhr/cHPB+aAmURywpJYu9MaMtf8HEFoltv7POuMu/Cr1nEy+0N6po\n aKFqTgVBczgnI0OcETyyAlJVJMZrVbC+7qnIgRtJfLzZ+Pmxqj8uvcKx9x7EVt21QscxQngBDCL\n YpDT35GLvaK/8OlEvhnLupHjR9gQvZPcvY5kGo0UnArOR+3vhi/ux66y4up2I4c3Bifux79Qm45\n 8P0f49FncxkPs9mBZVmiC4GEe9mlkzjDIypoY400TnwJrgxJcO5zcRonzGnaIOqReaUAg5xgY7+\n KDZ3Buk1uZTv8Sk6YrC4XwrfC/OMonYuVWQKlsC9TpeGuOy3RTJcNXd2GJWK2hxPs4i/jyLniBE\n PScUtuCAOTfTgGysNSn0nKp2gd/h3F77tmPDbPwNqEmFQ74Es10raIMC2zqoiQP745FA7yrI3aN\n +kAUv/Phn43xgiFYoCr6mFnKKbSStSOdB0G0fnQLWm+3XbFvKKnbShEL7U3Aprq7lEQQ==","X-Received":"by 2002:a05:600c:630d:b0:485:3586:1e28 with SMTP id\n 5b1f17b1804b1-48716034eb4mr12739625e9.18.1774379909486;\n Tue, 24 Mar 2026 12:18:29 -0700 (PDT)","Message-ID":"<3768bc38-1231-4f62-9ac8-c27e8bb66e7b@linaro.org>","Date":"Tue, 24 Mar 2026 20:18:26 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","To":"Paolo Bonzini , qemu-devel@nongnu.org","References":"<20260324165705.785605-1-pbonzini@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260324165705.785605-1-pbonzini@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3668848,"web_url":"http://patchwork.ozlabs.org/comment/3668848/","msgid":"","list_archive_url":null,"date":"2026-03-25T07:00:00","subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"Il mar 24 mar 2026, 20:18 Philippe Mathieu-Daudé ha\nscritto:\n\n> On 24/3/26 17:57, Paolo Bonzini wrote:\n> > The version is never set on 2.5+ machine types, so qemu_hw_version() and\n> > qemu_set_hw_version() are not needed anymore.\n> >\n> > Signed-off-by: Paolo Bonzini \n> > ---\n> > include/hw/core/boards.h | 6 ------\n> > include/qemu/hw-version.h | 15 ---------------\n> > hw/ide/core.c | 2 +-\n> > hw/scsi/megasas.c | 2 +-\n> > hw/scsi/scsi-bus.c | 2 +-\n> > hw/scsi/scsi-disk.c | 2 +-\n> > system/vl.c | 4 ----\n> > target/s390x/cpu_models.c | 2 +-\n> > util/osdep.c | 12 ------------\n> > 9 files changed, 5 insertions(+), 42 deletions(-)\n>\n>\n> > diff --git a/include/qemu/hw-version.h b/include/qemu/hw-version.h\n> > index 730a8c904d9..a40a6c204a6 100644\n> > --- a/include/qemu/hw-version.h\n> > +++ b/include/qemu/hw-version.h\n> > @@ -7,21 +7,6 @@\n> > #ifndef QEMU_HW_VERSION_H\n> > #define QEMU_HW_VERSION_H\n> >\n> > -/*\n> > - * Starting on QEMU 2.5, qemu_hw_version() returns \"2.5+\" by default\n> > - * instead of QEMU_VERSION, so setting hw_version on MachineClass\n> > - * is no longer mandatory.\n> > - *\n> > - * Do NOT change this string, or it will break compatibility on all\n> > - * machine classes that don't set hw_version.\n> > - */\n> > #define QEMU_HW_VERSION \"2.5+\"\n>\n> Maybe rename as QEMU_HW_VERSION_2_5P if we remove the \"do not change\n> this string\" comment.\n>\n\nMaybe, on the other hand *which* version is used as the baseline (2.5+) is\nan implementation detail. Even if we added QEMU_HW_VERSION_11_1+ tomorrow,\nthe baseline would stay the same. The comment is clear.\n\nPaolo\n\n\n> >\n> > -/* QEMU \"hardware version\" setting. Used to replace code that exposed\n> > - * QEMU_VERSION to guests in the past and need to keep compatibility.\n> > - * Do not use qemu_hw_version() in new code.\n> > - */\n> > -void qemu_set_hw_version(const char *);\n> > -const char *qemu_hw_version(void);\n> > -\n> > #endif\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dziy2l2r;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=h+VtpAZp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgdB60Gd3z1xy1\n\tfor ; Wed, 25 Mar 2026 18:01:50 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5IEf-0003pO-7c; Wed, 25 Mar 2026 03:01:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5IEe-0003pF-B4\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 03:01:00 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5IEc-0008LO-NN\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 03:01:00 -0400","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-64-Um3bhX5FOZ2EOT88FBUYHg-1; Wed, 25 Mar 2026 03:00:54 -0400","by mail-wr1-f69.google.com with SMTP id\n ffacd0b85a97d-439c112b1a4so2727246f8f.3\n for ; Wed, 25 Mar 2026 00:00:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774422056;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=fDWdFYschMvZsV6n8P91xQQUzluThfHYeAs7SXI1FuM=;\n b=dziy2l2rPaFuRaaiAb0hAqQ+yD+jMcdLaK19+5zJdUww2Vx++EJeMVKTl9KWZtAvGJoUK6\n OPSOswj5qg702lYUXEcxtGgVyqUQRqKoBlBHOn1dm0JMTxjjnThAVwCm4fW5qnOFYxhQdc\n vIbgOwl4cZFsUmhBPlUMT4w+DQpBmvE=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774422053; x=1775026853; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=fDWdFYschMvZsV6n8P91xQQUzluThfHYeAs7SXI1FuM=;\n b=h+VtpAZpFBFvJgBmVGvZgbILDjq3sTjxn8qPA9b810RGq1qh/ybjc54W67M/D7rOD1\n 6gTh3L8syzGBJ7vXeoOoDSiQ77Wb6Wr6gvDj8g4G3L+l/k8rMARlq8/6dslqnM+rlZSV\n P5GBD5BMjl8VJvzxy913MahsP4LLJ7jRWOiiMLHvf4473JAkPOOQ1tJr/KXrRSO0C/ca\n MOkJ/U9KICiLUxsgNGjUcadoQj+o4aHWy31+bcvDmCPA3XzgwYb1FerFbun4/mbHloUy\n v2TOK78bbfCpwC+wk3XWW3gTlMxYWmG5hKAWS3n5mFIU2MWcemZ7ZhbrRF/JlGxmZFHf\n QPpw=="],"X-MC-Unique":"Um3bhX5FOZ2EOT88FBUYHg-1","X-Mimecast-MFC-AGG-ID":"Um3bhX5FOZ2EOT88FBUYHg_1774422053","ARC-Seal":"i=1; a=rsa-sha256; t=1774422053; cv=none;\n d=google.com; s=arc-20240605;\n b=Wl99Eyie3ZPzHYlcOpNeTIGJPvoY98N20uMLbyTMDdZLw/2hg6CN21nmL0NEEkznUl\n lxgP6qCqdezLMi/VFLeJOlqZGIChd+ShkQ7fyecUjDvIi03PIev4yJoVKjETcTMhatbQ\n zaOYeT78d6Pf6rpfdcD7rH1mSQBUO5GQt1sCRPuNCDzcD3qEGO2uE2cAF8It1lYGywb/\n 7Ouct1Hl3ntJXUAL4F/s8KNNEFRBzgGkaJgCejU7MFoaKuF0ZgeEmYNfrJEiGu6/8utt\n sY1cxQByYSYe98S9yktcInOytXVRpTyY2oHzoYqPj9+0/OXZCmbBQGijP1GGOlPxA06y\n wH6g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=fDWdFYschMvZsV6n8P91xQQUzluThfHYeAs7SXI1FuM=;\n fh=z5zLVx7biUVgmF8IXR4zlw3g/GraE2IcqOjlGjNrAIE=;\n b=QGxEyhPLDP4HsWFv1bwdDz5oXrDgeVS7Jhhgs18oL45ooCoSeTPwImSpd4Ch1vu785\n ngkVN51i/L7njQTYYFdf6nEh9iONSKY+9lLzCFVmt6+kov1NTbAKvZ3tMxooEt5rG6q8\n 17UpFXYC41IF9pYk25Cak/kKVQF94s9dh3KpYYyoswdscl1cYhcF2haVTau2F8B/Hcli\n gTypRzkVTlJ+IgaaLZ53VczmlL5MUW/zd8erHd2XLdR3meNtwKtTcUJZAb/K1bdha4kH\n h0yfDEhfjNRy3l8OUzD7dHpNcYC3sIvKZpqKY/fplhSbsoYoHpFU9Hggv4w0tqLAY36F\n 9upg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774422053; x=1775026853;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fDWdFYschMvZsV6n8P91xQQUzluThfHYeAs7SXI1FuM=;\n b=WARHkE3l2e7f9IVGeCEIM4CHU2I0mbHFxoAzxgv/9PaDgfXrClPtltV3DuFW0QOC06\n 6SKD/velbc0jLiCD1o/ReKCbolqdS6o8Vo/YHfCuqq4eXc5l46iQpnV2OiL5AufUHz0C\n T/an3BlX68byTQ6oRY5P8cAP2xT71pfmffXFUFELz1keKA8hjVesCLs7gqI7gO7Wznl6\n 4SUOhMnlQdViZu/9zbQOx2gI1st+IMToSf8rosZWbDQ46XKVIVzVtc3wW6Q7s2u3Kis+\n YBlSTihkQBOuvaimQ9E5bR4rfEk4A0bqN5vNlGZcq+fhFp6pzVqQO6LXIui6uiZcHBfu\n VFKQ==","X-Gm-Message-State":"AOJu0Yx5p5Jrwi+XcCzzx3esfOc/9wL4R8s0URro5UH/exjKkNfvYQPw\n 4oaDehW5Q5p85QOMb+YXqICdMfxWBgVhMw6zhaoS7WTfiQ+3KfTZHw2UojkoX9mBKungvxKxgRO\n yZIrj7E/8CkKFS9kY12HDOf/LoAEkBWiquPqwvoOxpECMmGLmX4gax+TY6vvTbW4YD4lYucjhHQ\n caglYSeUNWbryJdInwrJFtBpgnLgollI2WqMS3AMA=","X-Gm-Gg":"ATEYQzwUJgS+l4pDK5jDteqfPn/aGaJ5XYWQ0G2LnL4c7MBZFStfuTU1e7tycD+yA9/\n zQjAdMtG1Li9qlNEumE7wnr4ACq3afNgnRYSSfI9baB2TcnA63avSaSivjiBMhWpwDD+RMAd1sh\n UvqdTh7RggIGJmlHwRph0kirxXp576e6FoSCM/L6DoF30Al0PiaipbntJwm1wGSx8U1E3HGsasZ\n hwYoxN9iSq5XUJqf7qJrudUvLI7GNtLODLbb02lHU+13mrjiP3hChPeR0NhOynVtFw7dW+B8GFB\n iTrf","X-Received":["by 2002:a05:6000:208a:b0:432:5c34:fb32 with SMTP id\n ffacd0b85a97d-43b889bd8b5mr3323888f8f.23.1774422052278;\n Wed, 25 Mar 2026 00:00:52 -0700 (PDT)","by 2002:a05:6000:208a:b0:432:5c34:fb32 with SMTP id\n ffacd0b85a97d-43b889bd8b5mr3323781f8f.23.1774422051566; Wed, 25 Mar 2026\n 00:00:51 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260324165705.785605-1-pbonzini@redhat.com>\n <3768bc38-1231-4f62-9ac8-c27e8bb66e7b@linaro.org>","In-Reply-To":"<3768bc38-1231-4f62-9ac8-c27e8bb66e7b@linaro.org>","From":"Paolo Bonzini ","Date":"Wed, 25 Mar 2026 08:00:00 +0100","X-Gm-Features":"AQROBzBpG1fKeeT6xTheY31xdtcnuQMQk8Baa19x2TLpwulhvD6rtUVcAo0zOAc","Message-ID":"\n ","Subject":"Re: [PATCH] treewide: replace qemu_hw_version() with QEMU_HW_VERSION","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"qemu-devel ","Content-Type":"multipart/alternative; boundary=\"00000000000010d05d064dd3d41d\"","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001,\n RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]