Cover Letter Detail
Show a cover letter.
GET /api/covers/814964/?format=api
{ "id": 814964, "url": "http://patchwork.ozlabs.org/api/covers/814964/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/1505745470-12208-1-git-send-email-mgamal@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505745470-12208-1-git-send-email-mgamal@redhat.com>", "list_archive_url": null, "date": "2017-09-18T14:37:47", "name": "[v4,0/3] x86_iommu: Fix segfault when starting on non-PCI machines", "submitter": { "id": 72367, "url": "http://patchwork.ozlabs.org/api/people/72367/?format=api", "name": "Mohammed Gamal", "email": "mgamal@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/1505745470-12208-1-git-send-email-mgamal@redhat.com/mbox/", "series": [ { "id": 3660, "url": "http://patchwork.ozlabs.org/api/series/3660/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3660", "date": "2017-09-18T14:37:47", "name": "x86_iommu: Fix segfault when starting on non-PCI machines", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/3660/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/814964/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mgamal@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwpY529WJz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 00:39:05 +1000 (AEST)", "from localhost ([::1]:37023 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dtxCR-0004i3-BX\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 10:39:03 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:55074)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mgamal@redhat.com>) id 1dtxBe-0004bh-4w\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:38:19 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mgamal@redhat.com>) id 1dtxBa-00056Z-55\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:38:14 -0400", "from mx1.redhat.com ([209.132.183.28]:47664)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mgamal@redhat.com>) id 1dtxBZ-000563-Vq\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:38:10 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DF37863E12\n\tfor <qemu-devel@nongnu.org>; Mon, 18 Sep 2017 14:38:08 +0000 (UTC)", "from mmorsy.remote.csb (unknown [10.40.205.53])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A9CB718519;\n\tMon, 18 Sep 2017 14:38:00 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com DF37863E12", "From": "Mohammed Gamal <mgamal@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 18 Sep 2017 16:37:47 +0200", "Message-Id": "<1505745470-12208-1-git-send-email-mgamal@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 18 Sep 2017 14:38:09 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when starting\n\ton non-PCI machines", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, ehabkost@redhat.com, mst@redhat.com, peterx@redhat.com,\n\tpbonzini@redhat.com, Mohammed Gamal <mgamal@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Starting qemu with\nqemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu\nleads to a segfault. The code assume PCI bus is present and\ntries to access the bus structure without checking.\n\nThe patch series moves the error checks from vtd_realize()\nand amdvi_realize() to the generic x86_iommu_realize() and\nadds a check for PCI bus presence.\n\nv3 --> v4:\n * Restore correct object_dynamic_cast() in x86_iommu_realize()\n * Remove redundant casting in callee functions. Implemented in\n a new patch\n\nMohammed Gamal (3):\n x86_iommu: Move machine check to x86_iommu_realize()\n intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls\n x86_iommu: check if machine has PCI bus\n\n hw/i386/amd_iommu.c | 13 ++-----------\n hw/i386/intel_iommu.c | 13 ++-----------\n hw/i386/x86-iommu.c | 13 +++++++++++++\n 3 files changed, 17 insertions(+), 22 deletions(-)" }