[{"id":1771513,"web_url":"http://patchwork.ozlabs.org/comment/1771513/","msgid":"<20170920023915.GP3617@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-20T02:39:15","subject":"Re: [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when\n\tstarting on non-PCI machines","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Mon, Sep 18, 2017 at 04:37:47PM +0200, Mohammed Gamal wrote:\n> Starting qemu with\n> qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu\n> leads to a segfault. The code assume PCI bus is present and\n> tries to access the bus structure without checking.\n> \n> The patch series moves the error checks from vtd_realize()\n> and amdvi_realize() to the generic x86_iommu_realize() and\n> adds a check for PCI bus presence.\n> \n> v3 --> v4:\n> * Restore correct object_dynamic_cast() in x86_iommu_realize()\n> * Remove redundant casting in callee functions. Implemented in\n> a new patch\n> \n> Mohammed Gamal (3):\n> x86_iommu: Move machine check to x86_iommu_realize()\n> intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls\n> x86_iommu: check if machine has PCI bus\n\nAfter patch 2 squashed to patch 1 (patch 2 itself is not valid; the\nproblem only appears after patch 1):\n\nReviewed-by: Peter Xu \n\n> \n> hw/i386/amd_iommu.c | 13 ++-----------\n> hw/i386/intel_iommu.c | 13 ++-----------\n> hw/i386/x86-iommu.c | 13 +++++++++++++\n> 3 files changed, 17 insertions(+), 22 deletions(-)\n> \n> -- \n> 1.8.3.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxkVS5fPBz9s06\n\tfor ;\n\tWed, 20 Sep 2017 12:39:59 +1000 (AEST)","from localhost ([::1]:46342 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duUvb-0007sc-Jj\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 22:39:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44908)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duUvC-0007sF-MD\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 22:39:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duUv7-0005He-DV\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 22:39:30 -0400","from mx1.redhat.com ([209.132.183.28]:55502)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duUv7-0005FT-60\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 22:39:25 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B80BD85547\n\tfor ; Wed, 20 Sep 2017 02:39:23 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6C27C5D6A3;\n\tWed, 20 Sep 2017 02:39:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B80BD85547","Date":"Wed, 20 Sep 2017 10:39:15 +0800","From":"Peter Xu ","To":"Mohammed Gamal ","Message-ID":"<20170920023915.GP3617@pxdev.xzpeter.org>","References":"<1505745470-12208-1-git-send-email-mgamal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1505745470-12208-1-git-send-email-mgamal@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 20 Sep 2017 02:39:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when\n\tstarting on non-PCI machines","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, thuth@redhat.com, mst@redhat.com,\n\tqemu-devel@nongnu.org, ehabkost@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]