Cover Letter Detail
Show a cover letter.
GET /api/covers/809756/?format=api
{ "id": 809756, "url": "http://patchwork.ozlabs.org/api/covers/809756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com>", "list_archive_url": null, "date": "2017-09-04T16:07:41", "name": "[v10,0/6] fsdev: qmp interface for io throttling", "submitter": { "id": 69852, "url": "http://patchwork.ozlabs.org/api/people/69852/?format=api", "name": "Pradeep Jagadeesh", "email": "pradeepkiruvale@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com/mbox/", "series": [ { "id": 1415, "url": "http://patchwork.ozlabs.org/api/series/1415/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1415", "date": "2017-09-04T16:07:42", "name": "fsdev: qmp interface for io throttling", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/1415/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/809756/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AXEymt+c\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmFGz5N8Zz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 02:12:11 +1000 (AEST)", "from localhost ([::1]:54756 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dotyr-0001fu-OE\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:12:09 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:46856)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeepkiruvale@gmail.com>) id 1dotvI-0007K0-FQ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:08:33 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeepkiruvale@gmail.com>) id 1dotvD-0008Qq-IW\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:08:28 -0400", "from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:37270)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <pradeepkiruvale@gmail.com>)\n\tid 1dotvD-0008Q7-Bx\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:08:23 -0400", "by mail-wm0-x243.google.com with SMTP id x189so707681wmg.4\n\tfor <qemu-devel@nongnu.org>; Mon, 04 Sep 2017 09:08:22 -0700 (PDT)", "from localhost.localdomain.localdomain ([217.110.131.66])\n\tby smtp.gmail.com with ESMTPSA id\n\tx67sm976582wma.7.2017.09.04.09.08.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 09:08:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=xLV447I6dO7lbS0RxSM1UqIYLvWujQxvw+vlxV0rDe8=;\n\tb=AXEymt+clRplqzWkj8LPMN8HMzQ+O3OuysL3KqO4jIpaH2nJizTPBRkRNVLuHENv+u\n\t4goF/wiqevLZCUi8kWVdOcdufbk7HaKV21M2AKqwCBSj/ujyJ7n3qAu+c7nEpqGWTHwH\n\t4mfcuEkghc5N93ukkbCOKXv6Q5jkJNXXMVOHoythcOGgMOogBVO+kR8MayGdswCH5iED\n\ta6kiKWwpV/Strptohu7IGZeUYiZrWef9wxWGBGuS6DgO4tAvyMuEDY9JwRfyC/N26UlX\n\ttFr1FabZMq9SleA4mT1VkgvVZAMUiBrMK0+3gn9JGRb22IhNBzxdBI1N5zxMwcUCxH/7\n\tF1YA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=xLV447I6dO7lbS0RxSM1UqIYLvWujQxvw+vlxV0rDe8=;\n\tb=SMbKE6dFqOERbQPjEeIno765LKntsK36VBBAAqZCGjS7Ufvt/5kRcxE0jNkENwD8JU\n\tfO7hbq5Y9X/X6rF4PEUr6ii0t9NjZmIIs2ojOSVDimNdt7V3t7X9ntbnn+ZpvKuh0jdm\n\tzCsfEwxIf5wT/v6Bkt9j3ejY/wGeaH3XaokjooUB8rNtpzQNOI8X0KJcPfwsq6Dl+h/x\n\taJWKKGybuzrpj6/r3JqlQ0RH7/PXZI0lMi4ZkUwFJUiKUgSAz50CWTo9uD4PGemNmf6M\n\tY1tsyU7EijoLE9XySQIBuG45IfCLgpnTJr5EVeTBCtHM9W+TmiMyDNwBZyf4juaL5tzo\n\tbwfA==", "X-Gm-Message-State": "AHPjjUiZA34RmKCrHX/ciirxiGgZ56jB+RY1EFwVMku5EVde+WjX2rMR\n\tdzpk8TAE4gv/sg==", "X-Google-Smtp-Source": "ADKCNb7mPiLPMLgSoUffQ8R2j2XeBsyiwhNVgiFOysRr44eyszFkXhT64rbpf3yJFzeqA3nr567kDA==", "X-Received": "by 10.28.45.1 with SMTP id t1mr784667wmt.17.1504541300994;\n\tMon, 04 Sep 2017 09:08:20 -0700 (PDT)", "From": "Pradeep Jagadeesh <pradeepkiruvale@gmail.com>", "X-Google-Original-From": "Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>", "To": "\"eric blake\" <eblake@redhat.com>,\n\t\"greg kurz\" <groug@kaod.org>", "Date": "Mon, 4 Sep 2017 12:07:41 -0400", "Message-Id": "<1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2a00:1450:400c:c09::243", "Subject": "[Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alberto garcia <berto@igalia.com>, Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org, \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>,\n\tPradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\tjani kokkonen <jani.kokkonen@huawei.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "These patches provide the qmp interface, to query the io throttle \nstatus of the all fsdev devices that are present in a vm.\nalso, it provides an interface to set the io throttle parameters of a\nfsdev to a required value. some of the patches also remove the duplicate\ncode that was present in block and fsdev files. \n\nPradeep Jagadeesh (6):\n throttle: factor out duplicate code\n qmp: Create IOThrottle structure\n throttle: move out function to reuse the code\n hmp: create a throttle initialization function for code reusability\n fsdev: QMP interface for throttling\n fsdev: hmp interface for throttling\n\n Makefile | 4 +\n blockdev.c | 97 +--------------------\n fsdev/qemu-fsdev-dummy.c | 11 +++\n fsdev/qemu-fsdev-throttle.c | 189 ++++++++++++++++++++++++++++++----------\n fsdev/qemu-fsdev-throttle.h | 9 +-\n fsdev/qemu-fsdev.c | 30 +++++++\n hmp-commands-info.hx | 18 ++++\n hmp-commands.hx | 19 ++++\n hmp.c | 79 +++++++++++++++--\n hmp.h | 4 +\n include/qemu/throttle-options.h | 6 ++\n include/qemu/throttle.h | 4 +-\n include/qemu/typedefs.h | 1 +\n monitor.c | 5 ++\n qapi-schema.json | 3 +\n qapi/block-core.json | 34 ++++++--\n qapi/fsdev.json | 81 +++++++++++++++++\n qmp.c | 14 +++\n util/throttle.c | 110 +++++++++++++++++++++++\n 19 files changed, 558 insertions(+), 160 deletions(-)\n create mode 100644 qapi/fsdev.json\n\nv0 -> v1:\n Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange\n Mainly renaming the functions and removing the redundant code.\n\nv1 -> v2:\n Addressed comments from Eric Blake and Greg Kurz.\n As per the suggestion I split the patches into smaller patches.\n Removed some more duplicate code.\n\nv2 -> v3:\n Addresssed comments from Alberto Garcia.\n Changed the comment from block to iothrottle in the iothrottle.json \n Added the dummy functions in qemu-fsdev-dummy.c to address the compilation\n issues that were observed.\n\nv3 -> v4:\n Addressed comments from Eric Blake and Greg Kurz\n Re-ordered the patches\n Added the dummy functions in qmp.c to address the cross compilation issues\n\nv4 -> v5:\n Addressed comments from Eric Blake and Greg Kurz\n Split the fsdev qmp patch into hmp and qmp related patches\n Moved the common functionalities to throttle.c instead of creating\n a new file\n\nv5 -> v6:\n Addressed comments from Greg Kurz and Markus Armbruster\n Split the commits to specific to hmp and throttle as suggested by Greg\n Moved ThrottleConfig typedef to qemu/typedefs.h\n Addressed compilation issue on FreeBSD by adding flags in qmp.c\n\nv6 -> v7:\n Addressed comments from Albert Garcia and Dr. David Alan Gilbert\n Fixed the hmp-commands-info.hx and hmp-commands.hx as per Dr. David's\n comments.\n Fixed the bug with the hmp fsdev_set_io_throttle and info fsdev_iothrottle \n\nv7 -> v8:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed unwanted headers from qmp-fsdev-throttle.h\n\nv8 -> v9:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed the iothrottle.json and pushed the iothrottle struct to\n block-core.json\n\nv9 -> v10:\n Addressed comments from Albert Garcia\n Fixed issue related to dynamically passing throttle configuration\n Removed some unused code" }