[{"id":1763651,"web_url":"http://patchwork.ozlabs.org/comment/1763651/","msgid":"<809da3cc-4051-cb39-7f6a-2355013d3f9a@redhat.com>","list_archive_url":null,"date":"2017-09-05T21:19:11","subject":"Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/04/2017 11:07 AM, Pradeep Jagadeesh wrote:\n> These patches provide the qmp interface, to query the io throttle \n> status of the all fsdev devices that are present in a vm.\n> also, it provides an interface to set the io throttle parameters of a\n> fsdev to a required value. some of the patches also remove the duplicate\n> code that was present in block and fsdev files. \n> \n> Pradeep Jagadeesh (6):\n> throttle: factor out duplicate code\n> qmp: Create IOThrottle structure\n> throttle: move out function to reuse the code\n> hmp: create a throttle initialization function for code reusability\n> fsdev: QMP interface for throttling\n> fsdev: hmp interface for throttling\n\nI know you're already up to v10, but your code changes conflict with\nManos throttling work, which has now landed on Kevin's branch:\n\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01051.html\n\nT: git git://repo.or.cz/qemu/kevin.git block\n\nHow hard is it for you to post a rebased v11 on top of Manos' work?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn03q6dC7z9sNq\n\tfor ;\n\tWed, 6 Sep 2017 07:20:06 +1000 (AEST)","from localhost ([::1]:33245 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpLGO-00018H-02\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 17:20:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57855)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpLFs-00011m-Uu\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 17:19:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpLFo-0006MH-5G\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 17:19:32 -0400","from mx1.redhat.com ([209.132.183.28]:44034)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpLFe-0006HZ-4l; Tue, 05 Sep 2017 17:19:18 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B92C072D69;\n\tTue, 5 Sep 2017 21:19:16 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9ECCD60F91;\n\tTue, 5 Sep 2017 21:19:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B92C072D69","To":"Pradeep Jagadeesh , greg kurz ","References":"<1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<809da3cc-4051-cb39-7f6a-2355013d3f9a@redhat.com>","Date":"Tue, 5 Sep 2017 16:19:11 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"6ijkiRs6wOgkSLPOdM9ervufAr2qio2dp\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 05 Sep 2017 21:19:17 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"kwolf@redhat.com\" , alberto garcia ,\n\tqemu block ,\n\tMarkus Armbruster , qemu-devel@nongnu.org,\n\t\"Dr. David Alan Gilbert\" ,\n\tPradeep Jagadeesh ,\n\tjani kokkonen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763984,"web_url":"http://patchwork.ozlabs.org/comment/1763984/","msgid":"<4cbf1e77-a32e-ec81-2eeb-31f3a596ae83@huawei.com>","list_archive_url":null,"date":"2017-09-06T10:12:41","subject":"Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 9/5/2017 11:19 PM, Eric Blake wrote:\n> On 09/04/2017 11:07 AM, Pradeep Jagadeesh wrote:\n>> These patches provide the qmp interface, to query the io throttle\n>> status of the all fsdev devices that are present in a vm.\n>> also, it provides an interface to set the io throttle parameters of a\n>> fsdev to a required value. some of the patches also remove the duplicate\n>> code that was present in block and fsdev files.\n>>\n>> Pradeep Jagadeesh (6):\n>> throttle: factor out duplicate code\n>> qmp: Create IOThrottle structure\n>> throttle: move out function to reuse the code\n>> hmp: create a throttle initialization function for code reusability\n>> fsdev: QMP interface for throttling\n>> fsdev: hmp interface for throttling\n>\n> I know you're already up to v10, but your code changes conflict with\n> Manos throttling work, which has now landed on Kevin's branch:\n>\n> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01051.html\n>\n> T: git git://repo.or.cz/qemu/kevin.git block\n>\n> How hard is it for you to post a rebased v11 on top of Manos' work?\n>\nHmm, I will try. No idea, how long its gonna take.\n\n-Pradeep","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnKGR2QWpz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 20:15:26 +1000 (AEST)","from localhost ([::1]:35259 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpXMh-0006gb-Np\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 06:15:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55096)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpXLU-0006Fx-GB\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 06:14:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpXLO-0000ty-J5\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 06:14:08 -0400","from lhrrgout.huawei.com ([194.213.3.17]:23075)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1dpXLG-0000n5-7M; Wed, 06 Sep 2017 06:13:54 -0400","from 172.18.7.190 (EHLO lhreml702-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DUW42282; Wed, 06 Sep 2017 10:12:53 +0000 (GMT)","from [127.0.0.1] (10.210.166.210) by lhreml702-cah.china.huawei.com\n\t(10.201.108.43) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 6 Sep 2017 11:12:42 +0100"],"To":"Eric Blake , Pradeep Jagadeesh\n\t, greg kurz ","References":"<1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<809da3cc-4051-cb39-7f6a-2355013d3f9a@redhat.com>","From":"Pradeep Jagadeesh ","Message-ID":"<4cbf1e77-a32e-ec81-2eeb-31f3a596ae83@huawei.com>","Date":"Wed, 6 Sep 2017 12:12:41 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<809da3cc-4051-cb39-7f6a-2355013d3f9a@redhat.com>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.166.210]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020201.59AFCA25.016F, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"8c614149b5ba8f55b11be506c14ad214","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"kwolf@redhat.com\" , alberto garcia ,\n\tqemu block , qemu-devel@nongnu.org,\n\tMarkus Armbruster ,\n\tjani kokkonen ,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]