Cover Letter Detail
Show a cover letter.
GET /api/covers/2226673/?format=api
{ "id": 2226673, "url": "http://patchwork.ozlabs.org/api/covers/2226673/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/cover/bmm.hhuo56j308.gcc.gcc-TEST.tkaminsk.46.1.0@forge-stage.sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<bmm.hhuo56j308.gcc.gcc-TEST.tkaminsk.46.1.0@forge-stage.sourceware.org>", "list_archive_url": null, "date": "2026-04-22T18:13:29", "name": "[v1,0/1] libstdc++: Implement formatter for ranges and range_formatter [PR109162]", "submitter": { "id": 93223, "url": "http://patchwork.ozlabs.org/api/people/93223/?format=api", "name": "tkaminsk via Sourceware Forge", "email": "forge-bot+tkaminsk@forge-stage.sourceware.org" }, "mbox": "http://patchwork.ozlabs.org/project/gcc/cover/bmm.hhuo56j308.gcc.gcc-TEST.tkaminsk.46.1.0@forge-stage.sourceware.org/mbox/", "series": [ { "id": 501070, "url": "http://patchwork.ozlabs.org/api/series/501070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501070", "date": "2026-04-22T18:13:29", "name": "libstdc++: Implement formatter for ranges and range_formatter [PR109162]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2226673/comments/", "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org", "sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g16vB2L3rz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 04:19:34 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 7C4F051A4320\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 18:19:32 +0000 (GMT)", "from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 63E864CCCA1F\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 18:15:40 +0000 (GMT)", "from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 37FB143427\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 18:15:40 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 7C4F051A4320", "OpenDKIM Filter v2.11.0 sourceware.org 63E864CCCA1F" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 63E864CCCA1F", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 63E864CCCA1F", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881740; cv=none;\n b=mbCW5XlhJrImUxhyG4hw505K+HWK2aTrNHGT/IESA+uAY1THpRsp3PV3UD5wLZpWf9ztD4pG6L8+jvx0uQE2O3AePrWPamqF2+MRUNxS966SBis15Hqp3fSpyEzW4i2LG7Y6T+0+hEqHp28xDhBG8wf+TAFQgDwYwwtsfIbC9Cg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881740; c=relaxed/simple;\n bh=/tkk2PWIWKCVsY5cvKTnTVbo2LugUjPlb9BL8bXNdW0=;\n h=From:Date:Subject:MIME-Version:To:Message-ID;\n b=tAtt8yqAa3d5ueWMejKsOYIN6qbhv1LpUeF0OeM33npYPwwMDJR4TsgauzPMF957qgMEAn05dGTN9ICoGpStTqJNrVGQdxFEAh7HPtRFpAZzyo21mJXRP2k+8j1djs2ZNtRWrdcdENzAdemkjU2mT6kwJkrsG8XLhKhEY3Pkglk=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "From": "tkaminsk via Sourceware Forge\n <forge-bot+tkaminsk@forge-stage.sourceware.org>", "Date": "Wed, 22 Apr 2026 18:13:29 +0000", "Subject": "[PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>", "Message-ID": "\n <bmm.hhuo56j308.gcc.gcc-TEST.tkaminsk.46.1.0@forge-stage.sourceware.org>", "X-Mailer": "batrachomyomachia", "X-Pull-Request-Organization": "gcc", "X-Pull-Request-Repository": "gcc-TEST", "X-Pull-Request": "https://forge.sourceware.org/gcc/gcc-TEST/pulls/46", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>,\n tkaminsk@gcc.gnu.org", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi gcc-patches mailing list,\ntkaminsk via Sourceware Forge <forge-bot+tkaminsk@forge-stage.sourceware.org> has requested that the following forgejo pull request\nbe published on the mailing list.\n\nCreated on: 2025-03-28 12:43:29+00:00\nLatest update: 2025-08-14 09:27:04+00:00\nChanges: 0 changed files, 0 additions, 0 deletions\nHead revision: tkaminsk/gcc ref refs/pull/46/head commit 44175139c8f54ddcc557971d5421188be53a81c7\nBase revision: gcc/gcc-TEST ref master commit b905ce8caf04253e02e153d60d6ea8f99d300af6 r15-9379-gb905ce8caf0425\nMerge base: 6fd19b2dbda453d3de57529ded2df9e62d1efdaa\nFull diff url: https://forge.sourceware.org/gcc/gcc-TEST/pulls/46.diff\nDiscussion: https://forge.sourceware.org/gcc/gcc-TEST/pulls/46\nRequested Reviewers:\n\nThis patch implements formatter specialization for input_ranges\nand range_formatter class form P2286R8, as adjusted by p2585r1.\nThe formatter for pair/tuple is not yet provided (making map unusable).\n\nTo indicate partial support we define __glibcxx_format_ranges macro\nvalue 1, without defining __cpp_lib_format_ranges.\n\nThis introduces an new _M_format_range member to internal __formatter_str,\nthat formats range as _CharT as string, according the to the format spec.\nThis function transform any contiguous range into basic_string_view direclty,\nby computing size if necessary. Otherwise, for ranges for which size can be\ncomputed (forward_range or sized_range) we use a stack buffer, if they are\nsufficiently small. Finally, we create a vector<_CharT> from the range,\nand format it content. (We use vector, as this moment, but should be replaced\nwith string, once from_range constructors are available).\n\nIn case when padding is specified, this is handled by firstly formatting\nthe content of the range to the temporary string object, and then then\nformatting content using __fomtter_str.\nHowever, this can be only implemented if the iterator of the\nbasic_format_context is internal type-erased iterator used by implementation.\nOtherwise a new basic_format_context would need to be created, which would\nrequire rebinding of handles stored in the arguments: note that format spec\nfor element type could retrive any format argument from format context,\nvisit and and user handle to format it. As basic_format_context provide no\nuser-facing constructor, the user are not able to cosntructor object of that\ntype with arbitrally iterators.\n\nThe signatures of the user-facing parse and format method of the provided\nformatters deviate from the standard by constraining types of params:\n* _CharT is constrained __formatter::__char\n* basic_format_parse_context<_CharT> for parse argument\n* basic_format_context<_Out, _CharT> for format second argument\nThe standard specifies last three of above as unconstrained types. This types\nare later passed to possibly user-provided formatter specializations, that are\nrequired via formattable concept to only accept above types.\n\nFinally, the formatter<input_range, _CharT> specialization is implemented\nwithout using specialization of range-default-formatter exposition only\ntemplate as base class, while providing same functionality.\n\n\tPR libstdc++/109162\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/std/format (__format::__Stackbuf_size)\n\t(__format::__has_debug_format): Define.\n\t(__format::_Separators): Define additional constants.\n\t(__format::_Spec::_M_parse_fill_and_align): Define overload accepting\n\tlist of excluded characters for fill, and forward existing overload.\n\t(__formatter_str::_M_format_range): Define.\n\t(__format::_Buf_sink) Use __Stackbuf_size for size of array.\n\t(__format::_Seps, __format::__is_map_formattable): Define.\n\t(std::range_formatter, std::formatter<_Rg, _CharT>): Implement.\n\t* src/c++23/std.cc.in (std::format_kind, std::range_format)\n\t(std::range_formatter): Export.\n\t* testsuite/std/format/formatter/lwg3944.cc: Guarded tests with\n\t__glibcxx_format_ranges.\n\t* testsuite/std/format/formatter/requirements.cc: Adjusted for standard\n\tbehavior.\n\t* testsuite/std/format/ranges/format_kind.cc: New test.\n\t* testsuite/std/format/ranges/formatter.cc: New test.\n\t* testsuite/std/format/ranges/sequence.cc: New test.\n\t* testsuite/std/format/ranges/string.cc: New test.\n\n\nChanged files:\n- A: libstdc++-v3/testsuite/std/format/ranges/format_kind.cc\n- A: libstdc++-v3/testsuite/std/format/ranges/formatter.cc\n- A: libstdc++-v3/testsuite/std/format/ranges/sequence.cc\n- A: libstdc++-v3/testsuite/std/format/ranges/string.cc\n- M: libstdc++-v3/include/std/format\n- M: libstdc++-v3/src/c++23/std.cc.in\n- M: libstdc++-v3/testsuite/23_containers/vector/bool/format.cc\n- M: libstdc++-v3/testsuite/std/format/formatter/lwg3944.cc\n- M: libstdc++-v3/testsuite/std/format/formatter/requirements.cc\n\n\nTomasz Kamiński (1):\n libstdc++: Implement formatter for ranges and range_formatter\n [PR109162]\n\n libstdc++-v3/include/std/format | 513 ++++++++++++++++--\n libstdc++-v3/src/c++23/std.cc.in | 6 +\n .../23_containers/vector/bool/format.cc | 6 +\n .../testsuite/std/format/formatter/lwg3944.cc | 4 +-\n .../std/format/formatter/requirements.cc | 14 +-\n .../std/format/ranges/format_kind.cc | 94 ++++\n .../testsuite/std/format/ranges/formatter.cc | 145 +++++\n .../testsuite/std/format/ranges/sequence.cc | 184 +++++++\n .../testsuite/std/format/ranges/string.cc | 223 ++++++++\n 9 files changed, 1123 insertions(+), 66 deletions(-)\n create mode 100644 libstdc++-v3/testsuite/std/format/ranges/format_kind.cc\n create mode 100644 libstdc++-v3/testsuite/std/format/ranges/formatter.cc\n create mode 100644 libstdc++-v3/testsuite/std/format/ranges/sequence.cc\n create mode 100644 libstdc++-v3/testsuite/std/format/ranges/string.cc" }