[{"id":3680788,"web_url":"http://patchwork.ozlabs.org/comment/3680788/","msgid":"","list_archive_url":null,"date":"2025-04-04T10:37:37","subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"content":"(tkaminsk) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -4793,0 +5518,4 @@\n> +\t _M_under.set_brackets(_Seps::_S_braces().substr(0, 1),\n> +\t\t\t\t_Seps::_S_braces().substr(1, 1));\n> + }\n> +\nset_brackets and set_separator should be present if `!_S_range_format_is_string`\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-878","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g16xw4gV7z1y2d\n\tfor ; Thu, 23 Apr 2026 04:21:56 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id A6DDD4C3181F\n\tfor ; Wed, 22 Apr 2026 18:21:54 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 1C6C24A98F21\n for ; Wed, 22 Apr 2026 18:15:42 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id D1A234342B\n for ; Wed, 22 Apr 2026 18:15:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org A6DDD4C3181F","OpenDKIM Filter v2.11.0 sourceware.org 1C6C24A98F21"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 1C6C24A98F21","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 1C6C24A98F21","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881742; cv=none;\n b=My3CsuOy7bLbtoQx85R6E+fyD7klaMcvSnkR7sa+4BA9CdJ8hGKgtEcy634BSEKCIBmNkTcVtLf1ZQH+OfVEYRq0O4xxc1I+u2TxzJwaWuYpG5f0gb8AdKI+yZ3Wh03Yzvmp6I/DdsY/PkWTQ1yU07sh7YIxI1ooEGyAXiYraPI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881742; c=relaxed/simple;\n bh=8PlqvsL8FQ9d1ChD01S2yG3Pxouwdg1hccnXBXsIiiw=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=jAT9JikVRFUOShLB+sKm/sQSrhPak8MC5nIu3Thh5YD70rA8RiGTZfC989ZdWvFNsdS5XE+Xow3zdQJrpFzgAgJZpUAiucD1hOUUoYjWyXDLZAJy1m6dg2ezN+voUpA4kAbyT9mDcdvz7WvWenUnhGRFdyWpWgyvzdDe5j/2GCc=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","From":"tkaminsk via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Fri, 04 Apr 2025 10:37:37 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-878","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680795,"web_url":"http://patchwork.ozlabs.org/comment/3680795/","msgid":"","list_archive_url":null,"date":"2025-03-29T18:11:01","subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"content":"(tkaminsk) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -1024,0 +1078,4 @@\n> +\t\t vector<_CharT> __buf(from_range, __rg);\n> +\t\t return format(_String_view(__buf), __fc);\n> +\t\t}\n> +\t else\nCheck random_access and do begin(), begin() + __n here.\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-824","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g171c0YJDz1yD5\n\tfor ; Thu, 23 Apr 2026 04:25:08 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 175C443C1C93\n\tfor ; Wed, 22 Apr 2026 18:25:06 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 00AA64A98F29\n for ; Wed, 22 Apr 2026 18:15:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id B85024342A\n for ; Wed, 22 Apr 2026 18:15:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 175C443C1C93","OpenDKIM Filter v2.11.0 sourceware.org 00AA64A98F29"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 00AA64A98F29","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 00AA64A98F29","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881742; cv=none;\n b=QTI0mtvt1P4XEoQRJ0oCAdTk7j0uRJqEzAAAF4zSIIFIU1gTTgmuy79busebCs6eLxh5xRS/ILpfM5wuZngt9KH3DMv+nYMckEWEOdkj459MjAN9h4BzfxZ97M8Jb81wqzQKIjbjBtNkaW3o8I7PX20U6UrtXkZCrfFhaMU1TL8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881742; c=relaxed/simple;\n bh=hhflmRMRCjquXyVUaYZYPPPX2KNKYaLWzzFc67T0oyQ=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=plYkIxXaxtiRkNi8VFwIipCNnW80jxNDsICeEzpusKDmA4ZrHfogFvcsGRoQZK2UbkbAvjMeYxH+mLSzE5sK06zPXLOXYJr9wyWMrMmSry26NgvXtDK0L7sWww3LyEajR9x6plZVXErDIpuTChVX/iZaWqVOI8a5h9RGH30yk6U=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","From":"tkaminsk via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Sat, 29 Mar 2025 18:11:01 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-824","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680797,"web_url":"http://patchwork.ozlabs.org/comment/3680797/","msgid":"","list_archive_url":null,"date":"2025-03-29T18:10:42","subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"content":"(tkaminsk) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -1024,0 +1080,4 @@\n> +\t\t}\n> +\t else\n> +\t\t{\n> +\t\t // preserve the computed size\nsubrange has range + size constructor that we could use here, that will keep size, without changing iterator types. counted iterator needs to also modify counter on each increment, which we can avoid.\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-822","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g173R5TX8z1yGs\n\tfor ; Thu, 23 Apr 2026 04:26:43 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9A4CF4902674\n\tfor ; Wed, 22 Apr 2026 18:26:40 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id CAC2E4CCCA21\n for ; Wed, 22 Apr 2026 18:15:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 9B33143429\n for ; Wed, 22 Apr 2026 18:15:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 9A4CF4902674","OpenDKIM Filter v2.11.0 sourceware.org CAC2E4CCCA21"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org CAC2E4CCCA21","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org CAC2E4CCCA21","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881741; cv=none;\n b=rHHAbTPA5p1qLS5BECLL2OnlJzbnZOmlhDayKyITq46iszo0ArjdzqoKP1vQrnw37mi3RuOgwpydDzeTfd/+Df0bnDtPL0SwbAV/mjKUI6OwfsfT9V02hPhRHD1s+5vgITtllbV8NIQRMGV5XBUCLP9G6UKT77n95z+FnT6eLS8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881741; c=relaxed/simple;\n bh=DdRae6XSAU/73YYNj87iil+ui/MY/uBnAL5rGYt8q/I=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=SROl8O0qfwOFcHwDeyACkhIu3hk0k0YYuXabn+UxucOoThxm14A5UD9jEokmMlFfJzGMRRhv/AFhK4c2kp5OE2oYuIfBNKAqsDSLkIxIQDPQopSLJyAT0afT1kkxypo5YzHVBpr5vyGLy/r2gGAeYpsoayi1nQ0Ik4OPgnY34KM=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","From":"tkaminsk via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Sat, 29 Mar 2025 18:10:42 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-822","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680798,"web_url":"http://patchwork.ozlabs.org/comment/3680798/","msgid":"","list_archive_url":null,"date":"2026-04-22T18:15:40","subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","submitter":{"id":93212,"url":"http://patchwork.ozlabs.org/api/people/93212/","name":"Lichenor Forgejo Bot via Sourceware Forge","email":"forge-bot+forge-bot@forge-stage.sourceware.org"},"content":"Sent patch series version 1 containing 1 patches to gcc-patches mailing list .\n[Cover letter](https://inbox.sourceware.org/gcc-patches/bmm.hhuo56j308.gcc.gcc-TEST.tkaminsk.46.1.0@forge-stage.sourceware.org)\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-5626","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g174Y3fQHz1yGs\n\tfor ; Thu, 23 Apr 2026 04:27:41 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id AFD1449B0BA2\n\tfor ; Wed, 22 Apr 2026 18:27:39 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 55F524D8D1E2\n for ; Wed, 22 Apr 2026 18:16:10 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 19BF84342E\n for ; Wed, 22 Apr 2026 18:15:42 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org AFD1449B0BA2","OpenDKIM Filter v2.11.0 sourceware.org 55F524D8D1E2"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 55F524D8D1E2","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 55F524D8D1E2","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881770; cv=none;\n b=BW2JAzmxQ4Ir3uMFGmsrqGRSx9UxAcCPf/jU+hvg8rNlHpam5X2ewzZQnfhIgiOv6XwtzAMHzwAnq6i8tDYqTSOeSZm21jplpy8dwnrlL3YjT7Nk7OC4rtMM9qtLU/LUuXtCycjR7vPpNAcYA/7+x6alxsC2uucyU8xz1awXqhs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881770; c=relaxed/simple;\n bh=u08nBgSBUvTFpjnpiQmE+bvHvwou7Rn/s2fAwGksZjg=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=RaQu7DQQz0mGqBbihKmLHWVMQ3Av6iPjefo+x8nIPWF0HRlNtGS+DemWY//TMlYc/7NfNt+Ye+UV63pEqkBF+W0eoB26PVrYR8JHMCpVpDEganaiUacCnVc7a/OnPhgCaecks7NwZzOPN8gEBxj/F+P6IFTQRPghYXHxz8tbYi4=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","From":"Lichenor Forgejo Bot via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Wed, 22 Apr 2026 18:15:40 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46","X-Comment":"\n https://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-5626","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680799,"web_url":"http://patchwork.ozlabs.org/comment/3680799/","msgid":"","list_archive_url":null,"date":"2025-04-04T14:54:46","subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"content":"(tkaminsk) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -4783,0 +5512,4 @@\n> + }\n> +\n> + constexpr void\n> + set_separator(basic_string_view<_CharT> __sep) noexcept\nI wonder if instead I should have `__format::__range_formatter` that would be used as base class for range_formatter, and here we will have either formatter_str or __range_formatter as base. This would eliminate need to declare `set_separator`, `set_brackets` and `parse`.\nFormat would remain. \n\n> +++ libstdc++-v3/include/std/format\n> @@ -4783,0 +5512,4 @@\n> + }\n> +\n> + constexpr void\n> + set_separator(basic_string_view<_CharT> __sep) noexcept\nInherriting for __formatter_str will expose it whole interface. I think we want to keep this class internal.\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-885","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g174w0MYrz1yGs\n\tfor ; Thu, 23 Apr 2026 04:28:00 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 11E984A98F0F\n\tfor ; Wed, 22 Apr 2026 18:27:58 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 08EAD4CD2009\n for ; Wed, 22 Apr 2026 18:16:07 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id ED4B74342C\n for ; Wed, 22 Apr 2026 18:15:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 11E984A98F0F","OpenDKIM Filter v2.11.0 sourceware.org 08EAD4CD2009"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 08EAD4CD2009","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 08EAD4CD2009","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881767; cv=none;\n b=Wq+gMvsqmV9r15+lWSCM0srWn1HBiJwVvbEwvurjUKAIUDUmLjHUKwutx2OSvgJjsFXIQS0SbMl4PxCRdtR6qsWGi7t1KFp7Hlz1NLkNrcMjdbZ6fkReugVcP4UNFzNibNpPbDCTEES7Rj/AyhNpTlPLrx+P7kAebtsxIoV6mSY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881767; c=relaxed/simple;\n bh=MPuUd4V8LJQVfYfU6h4Quwy7NsJ+22FmHU/YFyhSzFM=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=qjScqbeRDx/CKhlSk/0J8UJAjtbPAwDD0YxFF+U/oZLkBgjplPsVmyJLF2KBMMuHOjn9Iee9e7dQqYNlMHc7q9LF1YkwiTCG1v7oMzYlkea51PQS4hawSEiIisdOLsCNV5GxVcwEriu2CReZoeq6bw+a56gMtX+/8J8Mdp45aMY=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Implement formatter for ranges and\n range_formatter [PR109162]","From":"tkaminsk via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Fri, 04 Apr 2025 14:54:46 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46#issuecomment-885","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680801,"web_url":"http://patchwork.ozlabs.org/comment/3680801/","msgid":"","list_archive_url":null,"date":"2026-04-22T18:16:10","subject":"[SUMMARY] Re: [PATCH v1 0/1] libstdc++: Implement formatter for\n ranges and range_formatter [PR109162]","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"content":"This is a summary of discussions relative to the merge request created by (tkaminsk) titled\nlibstdc++: Implement formatter for ranges and range_formatter [PR109162]\nsince its creation.\n\nDescription: This patch implements formatter specialization for input_ranges\nand range_formatter class form P2286R8, as adjusted by p2585r1.\nThe formatter for pair/tuple is not yet provided (making map unusable).\n\nTo indicate partial support we define __glibcxx_format_ranges macro\nvalue 1, without defining __cpp_lib_format_ranges.\n\nThis introduces an new _M_format_range member to internal __formatter_str,\nthat formats range as _CharT as string, according the to the format spec.\nThis function transform any contiguous range into basic_string_view direclty,\nby computing size if necessary. Otherwise, for ranges for which size can be\ncomputed (forward_range or sized_range) we use a stack buffer, if they are\nsufficiently small. Finally, we create a vector<_CharT> from the range,\nand format it content. (We use vector, as this moment, but should be replaced\nwith string, once from_range constructors are available).\n\nIn case when padding is specified, this is handled by firstly formatting\nthe content of the range to the temporary string object, and then then\nformatting content using __fomtter_str.\nHowever, this can be only implemented if the iterator of the\nbasic_format_context is internal type-erased iterator used by implementation.\nOtherwise a new basic_format_context would need to be created, which would\nrequire rebinding of handles stored in the arguments: note that format spec\nfor element type could retrive any format argument from format context,\nvisit and and user handle to format it. As basic_format_context provide no\nuser-facing constructor, the user are not able to cosntructor object of that\ntype with arbitrally iterators.\n\nThe signatures of the user-facing parse and format method of the provided\nformatters deviate from the standard by constraining types of params:\n* _CharT is constrained __formatter::__char\n* basic_format_parse_context<_CharT> for parse argument\n* basic_format_context<_Out, _CharT> for format second argument\nThe standard specifies last three of above as unconstrained types. This types\nare later passed to possibly user-provided formatter specializations, that are\nrequired via formattable concept to only accept above types.\n\nFinally, the formatter specialization is implemented\nwithout using specialization of range-default-formatter exposition only\ntemplate as base class, while providing same functionality.\n\n\tPR libstdc++/109162\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/std/format (__format::__Stackbuf_size)\n\t(__format::__has_debug_format): Define.\n\t(__format::_Separators): Define additional constants.\n\t(__format::_Spec::_M_parse_fill_and_align): Define overload accepting\n\tlist of excluded characters for fill, and forward existing overload.\n\t(__formatter_str::_M_format_range): Define.\n\t(__format::_Buf_sink) Use __Stackbuf_size for size of array.\n\t(__format::_Seps, __format::__is_map_formattable): Define.\n\t(std::range_formatter, std::formatter<_Rg, _CharT>): Implement.\n\t* src/c++23/std.cc.in (std::format_kind, std::range_format)\n\t(std::range_formatter): Export.\n\t* testsuite/std/format/formatter/lwg3944.cc: Guarded tests with\n\t__glibcxx_format_ranges.\n\t* testsuite/std/format/formatter/requirements.cc: Adjusted for standard\n\tbehavior.\n\t* testsuite/std/format/ranges/format_kind.cc: New test.\n\t* testsuite/std/format/ranges/formatter.cc: New test.\n\t* testsuite/std/format/ranges/sequence.cc: New test.\n\t* testsuite/std/format/ranges/string.cc: New test.\n\nThe full and up to date discussion can be found at https://forge.sourceware.org/gcc/gcc-TEST/pulls/46\n\nThe merge request has been closed without being merged directly on the forge repository.\n\nOn 2025-03-29 18:10:42+00:00, (tkaminsk) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -1024,0 +1080,4 @@\n> +\t\t}\n> +\t else\n> +\t\t{\n> +\t\t // preserve the computed size\nsubrange has range + size constructor that we could use here, that will keep size, without changing iterator types. counted iterator needs to also modify counter on each increment, which we can avoid.\n\nOn 2025-03-29 18:11:00+00:00, (tkaminsk) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -1024,0 +1078,4 @@\n> +\t\t vector<_CharT> __buf(from_range, __rg);\n> +\t\t return format(_String_view(__buf), __fc);\n> +\t\t}\n> +\t else\nCheck random_access and do begin(), begin() + __n here.\n\nOn 2025-04-04 10:37:37+00:00, (tkaminsk) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -4793,0 +5518,4 @@\n> +\t _M_under.set_brackets(_Seps::_S_braces().substr(0, 1),\n> +\t\t\t\t_Seps::_S_braces().substr(1, 1));\n> + }\n> +\nset_brackets and set_separator should be present if `!_S_range_format_is_string`\n\nOn 2025-04-04 14:54:46+00:00, (tkaminsk) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/format\n> @@ -4783,0 +5512,4 @@\n> + }\n> +\n> + constexpr void\n> + set_separator(basic_string_view<_CharT> __sep) noexcept\nI wonder if instead I should have `__format::__range_formatter` that would be used as base class for range_formatter, and here we will have either formatter_str or __range_formatter as base. This would eliminate need to declare `set_separator`, `set_brackets` and `parse`.\nFormat would remain. \n> +++ libstdc++-v3/include/std/format\n> @@ -4783,0 +5512,4 @@\n> + }\n> +\n> + constexpr void\n> + set_separator(basic_string_view<_CharT> __sep) noexcept\nInherriting for __formatter_str will expose it whole interface. I think we want to keep this class internal.\n\n\nOn 2026-04-22 18:14:33+00:00, Lichenor Forgejo Bot (forge-bot) wrote:\n\n\nVersion 1 of this pull request has been stored. It includes the following commits:\n- libstdc++: Implement formatter for ranges and range_formatter [PR109162] - 44175139c8f54ddcc557971d5421188be53a81c7\n\n\n\nOn 2026-04-22 18:15:40+00:00, Lichenor Forgejo Bot (forge-bot) wrote:\n\nSent patch series version 1 containing 1 patches to gcc-patches mailing list .\n[Cover letter](https://inbox.sourceware.org/gcc-patches/bmm.hhuo56j308.gcc.gcc-TEST.tkaminsk.46.1.0@forge-stage.sourceware.org)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g179Y35Fvz1yD5\n\tfor ; Thu, 23 Apr 2026 04:32:01 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 72713443794D\n\tfor ; Wed, 22 Apr 2026 18:31:59 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id CCF8D4B358A2\n for ; Wed, 22 Apr 2026 18:16:39 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id EE09043428\n for ; Wed, 22 Apr 2026 18:16:10 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 72713443794D","OpenDKIM Filter v2.11.0 sourceware.org CCF8D4B358A2"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org CCF8D4B358A2","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org CCF8D4B358A2","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776881799; cv=none;\n b=AvlPTkSD/WPiBiPQ2XZBEAFxvJjvhB1oSxMr78ti2QV/xG1FUuU3WdF6KMQTZgb9bDjemGMpSuVjsethY/CaxtTKt/s09r3JggIZaWNttkexSGC/0Gq+gBzVG4gVLs35w6k3kxe4tf7Y0Ls0r3uaVrRLvnPqQXsLEGGv70+HE7c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776881799; c=relaxed/simple;\n bh=2MjOTspvCIGfkzVhsTCy5jaMS8ircPyyXQfgzwOf4B0=;\n h=Subject:From:To:Message-ID:MIME-Version:Date;\n b=i0WRBnqGCqzqsrJs7uNn43rb0cdVS4nphRn2oTIJYJ2Kz7Q7NxlVzWUqWF9pa6HSr/Q9m2FT1hDUAfSWNgk1fzWp+1gVyatbjVHFMreuUUg1uxz3UrTENFWHkXlt+7sXCRk2WLTRslXy3wf2Q/ZW96WhF1PufbiR8geLaj36CfY=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"[SUMMARY] Re: [PATCH v1 0/1] libstdc++: Implement formatter for\n ranges and range_formatter [PR109162]","From":"tkaminsk via Sourceware Forge\n ","To":"gcc-patches mailing list ","In-Reply-To":"\n ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/46","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","Date":"Wed, 22 Apr 2026 18:16:10 +0000 (UTC)","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]