Cover Letter Detail
Show a cover letter.
GET /api/covers/2224812/?format=api
{ "id": 2224812, "url": "http://patchwork.ozlabs.org/api/covers/2224812/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/cover/20260418221311.67583-1-ebiggers@kernel.org/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260418221311.67583-1-ebiggers@kernel.org>", "list_archive_url": null, "date": "2026-04-18T22:13:07", "name": "[v2,0/4] smb: client: Use AES-CMAC library", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/cover/20260418221311.67583-1-ebiggers@kernel.org/mbox/", "series": [ { "id": 500471, "url": "http://patchwork.ozlabs.org/api/series/500471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500471", "date": "2026-04-18T22:13:07", "name": "smb: client: Use AES-CMAC library", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500471/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2224812/comments/", "headers": { "Return-Path": "\n <linux-cifs+bounces-10902-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pUO/T1oe;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10902-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"pUO/T1oe\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fymHB10Gwz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 08:13:42 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C8FD3301E996\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 22:13:38 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CBCA0346773;\n\tSat, 18 Apr 2026 22:13:37 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A74B4255F28;\n\tSat, 18 Apr 2026 22:13:37 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id DB526C19424;\n\tSat, 18 Apr 2026 22:13:36 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776550417; cv=none;\n b=f/+h0JDBsMZwT6mp+dknw0Uew7nsCJ3CcfAvcQ4juhzNNJiQW2cCWkC5egZSxsAJpyjjd65mIpi+4j/AKq7uut0JUVwPbE4jMNQIta6KHOUELTaZjYA2prXDOPKz/ZJ1RLZh9A1NCbABIdx88kjEui1819N1dx5BUi5jqW5NNEg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776550417; c=relaxed/simple;\n\tbh=eOe3+zCYbTsR+dZksbeU88CmBAwOeZfSa3rrrUtEl7s=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Y8muq+hMXQPPSx5Y7d48CD9vy6wD+dQ7mzscIS3soV3R6l/dNPl/TMXwycepmQhXvBnQVHFhXWrmPcebm02otkL8jE32dlNkWg6mfGq1Yaqr4UsEvi0RRr/sAEvJHp40TDIAQ0Lh9bcVRrTvj2XMfMFOfGxwipqgOHZ2mSwvVYY=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=pUO/T1oe; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776550417;\n\tbh=eOe3+zCYbTsR+dZksbeU88CmBAwOeZfSa3rrrUtEl7s=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pUO/T1oe9VeVzZ89+1zS6jMbpL2AaS3HxjNVK5deRe+4QwfwfiYXbVpXGkM/+M7Mu\n\t SQd7/7E6dbwYn3no/Kw/2YIiRqvULxE22ijiZvfmURRbfcAsSDNDbGcgkXOwmgu1Ul\n\t 0kBM1IMAAIUqc7iPeo8wp53YbSTK0Xw+BN7pz9p19jFUM4iz3RoYe8VD76v8cX2+td\n\t L3+SIH7qq/f6zeyxmvY7ELLLJFh7++SQm9G2P7Od8rCm+oDnLUzBpbRica8T20Jfvb\n\t 7iSlHJKQ5B70ZFbdA2t8plAptYLsFq5lH1ZFl/dVPs97djR0Wavcw5AjS2ttVi4kFG\n\t K1tdPyyVxU5+A==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-cifs@vger.kernel.org,\n\tSteve French <sfrench@samba.org>", "Cc": "linux-crypto@vger.kernel.org,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tRonnie Sahlberg <ronniesahlberg@gmail.com>,\n\tShyam Prasad N <sprasad@microsoft.com>,\n\tTom Talpey <tom@talpey.com>,\n\tBharath SM <bharathsm@microsoft.com>,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH v2 0/4] smb: client: Use AES-CMAC library", "Date": "Sat, 18 Apr 2026 15:13:07 -0700", "Message-ID": "<20260418221311.67583-1-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "This series updates the SMB client to use the AES-CMAC library functions\nthat were recently added, instead of a \"cmac(aes)\" crypto_shash. As\nusual, this simplifies the code considerably and is much more efficient.\n\nThese patches were originally sent as patches 8-11 of the series\nhttps://lore.kernel.org/r/20260218213501.136844-1-ebiggers@kernel.org/\nThe only change from that version was adding tags and rebasing.\nI also added some microbenchmark results below.\n\nThis is intended to be taken through the smb tree, either 7.1 or 7.2\ndepending on maintainer preference.\n\nA few microbenchmarks that demonstrate improved performance:\n\n - Total cycles spent in generate_key() during SMB3 mount\n decreased from 20640 to 10780 (3 calls total).\n\n - Total cycles spent in smb3_calc_signature() during SMB3 mount\n decreased from 177620 to 73180 (32 calls & 4255 bytes total).\n\n - Total cycles spent in smb3_calc_signature() while writing 10MB file\n decreased from 27551180 to 26628360 (10 calls & 10001392 bytes total)\n\n - Total cycles spent in smb3_calc_signature() while reading 10MB file\n decreased from 28390900 to 27879340 (14 calls & 10001781 bytes total)\n\nNote that my \"before\" numbers were taken from current mainline which has\nmy changes that made the \"cmac(aes)\" crypto_shash a bit faster as well.\nSo the speedup vs v7.0 is actually even greater.\n\nEric Biggers (4):\n smb: client: Use AES-CMAC library for SMB3 signature calculation\n smb: client: Remove obsolete cmac(aes) allocation\n smb: client: Make generate_key() return void\n smb: client: Drop 'allocate_crypto' arg from smb*_calc_signature()\n\n fs/smb/client/Kconfig | 2 +-\n fs/smb/client/cifs_unicode.c | 1 +\n fs/smb/client/cifsencrypt.c | 62 ++++++-------------\n fs/smb/client/cifsfs.c | 1 -\n fs/smb/client/cifsglob.h | 7 +--\n fs/smb/client/cifsproto.h | 3 -\n fs/smb/client/misc.c | 57 -----------------\n fs/smb/client/sess.c | 11 ----\n fs/smb/client/smb2proto.h | 1 -\n fs/smb/client/smb2transport.c | 113 +++++++++-------------------------\n 10 files changed, 53 insertions(+), 205 deletions(-)\n\n\nbase-commit: 8541d8f725c673db3bd741947f27974358b2e163" }