[{"id":3679048,"web_url":"http://patchwork.ozlabs.org/comment/3679048/","msgid":"","list_archive_url":null,"date":"2026-04-19T01:36:39","subject":"Re: [PATCH v2 0/4] smb: client: Use AES-CMAC library","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"merged into cifs-2.6.git for-next pending additional testing and review\n\nOn Sat, Apr 18, 2026 at 5:13 PM Eric Biggers wrote:\n>\n> This series updates the SMB client to use the AES-CMAC library functions\n> that were recently added, instead of a \"cmac(aes)\" crypto_shash. As\n> usual, this simplifies the code considerably and is much more efficient.\n>\n> These patches were originally sent as patches 8-11 of the series\n> https://lore.kernel.org/r/20260218213501.136844-1-ebiggers@kernel.org/\n> The only change from that version was adding tags and rebasing.\n> I also added some microbenchmark results below.\n>\n> This is intended to be taken through the smb tree, either 7.1 or 7.2\n> depending on maintainer preference.\n>\n> A few microbenchmarks that demonstrate improved performance:\n>\n> - Total cycles spent in generate_key() during SMB3 mount\n> decreased from 20640 to 10780 (3 calls total).\n>\n> - Total cycles spent in smb3_calc_signature() during SMB3 mount\n> decreased from 177620 to 73180 (32 calls & 4255 bytes total).\n>\n> - Total cycles spent in smb3_calc_signature() while writing 10MB file\n> decreased from 27551180 to 26628360 (10 calls & 10001392 bytes total)\n>\n> - Total cycles spent in smb3_calc_signature() while reading 10MB file\n> decreased from 28390900 to 27879340 (14 calls & 10001781 bytes total)\n>\n> Note that my \"before\" numbers were taken from current mainline which has\n> my changes that made the \"cmac(aes)\" crypto_shash a bit faster as well.\n> So the speedup vs v7.0 is actually even greater.\n>\n> Eric Biggers (4):\n> smb: client: Use AES-CMAC library for SMB3 signature calculation\n> smb: client: Remove obsolete cmac(aes) allocation\n> smb: client: Make generate_key() return void\n> smb: client: Drop 'allocate_crypto' arg from smb*_calc_signature()\n>\n> fs/smb/client/Kconfig | 2 +-\n> fs/smb/client/cifs_unicode.c | 1 +\n> fs/smb/client/cifsencrypt.c | 62 ++++++-------------\n> fs/smb/client/cifsfs.c | 1 -\n> fs/smb/client/cifsglob.h | 7 +--\n> fs/smb/client/cifsproto.h | 3 -\n> fs/smb/client/misc.c | 57 -----------------\n> fs/smb/client/sess.c | 11 ----\n> fs/smb/client/smb2proto.h | 1 -\n> fs/smb/client/smb2transport.c | 113 +++++++++-------------------------\n> 10 files changed, 53 insertions(+), 205 deletions(-)\n>\n>\n> base-commit: 8541d8f725c673db3bd741947f27974358b2e163\n> --\n> 2.53.0\n>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=etdYbYDR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10909-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"etdYbYDR\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.160.171","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyrp96Wvgz1yDF\n\tfor ; Sun, 19 Apr 2026 11:37:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 5E8543038D32\n\tfor ; Sun, 19 Apr 2026 01:36:59 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5AC712550D5;\n\tSun, 19 Apr 2026 01:36:55 +0000 (UTC)","from mail-qt1-f171.google.com (mail-qt1-f171.google.com\n [209.85.160.171])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D7222541C\n\tfor ; Sun, 19 Apr 2026 01:36:52 +0000 (UTC)","by mail-qt1-f171.google.com with SMTP id\n d75a77b69052e-506a7bbe9d0so16374711cf.0\n for ;\n Sat, 18 Apr 2026 18:36:52 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776562615; cv=pass;\n b=G8lEBTLf1V4+NtXQzb64i6f96rVOC3nrpAOI4x8jwmqfd1hFKC52tum/Kj8GNTGdH8T2YdtDKMWKVdGuHyY9X3q/4v8IpmxCJDjyRip/z6QZNIATMnF9LtjZbz9ZAfWl996OZKHu0pQrCpkfAExnRi9K+JvVuPqowYAQ2TK7fTY=","i=1; a=rsa-sha256; t=1776562612; cv=none;\n d=google.com; s=arc-20240605;\n b=WvEuz6t67RFJKih1Yy7CkRbnNvFV4ZtgbPetzfaDaxISlJe9aD6VaBg2hFL0JGY3pK\n BKoQoUpG0yIT+41nJj/xhMXpb+vUXAaRnt8aSE3w04kIxn0WfO11TFzyJu0NuA9NpQ5a\n UJfH7FSgRwCJ1dghA1yvJFhzXBxOB8fQnK2B/kkLoDcDfTjj/Ik9tl03WHXaxYY1TjPW\n /ajY6L7LVQzO7z/X1iXCsNdAU8txLzHmJ8ffpbmJBvQo9/yhPAZC2kJ5X3+Oz69REFc+\n mfjQbR90+TgxBL6F9/6tOlkOuRqE2Sa0szNg70XHPdIo4oRqD0BhTQQTygjheMaNeAv9\n 6BFw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776562615; c=relaxed/simple;\n\tbh=SIuzGJEOyfdQbVHrkN9auEfohxql8b/XIH1Ni0aYNGo=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=fb6weles58MHt0R5h1hAaQmraHz/K0t8e4l50S4dECfKPcvArw4QGs8vOVHPdw08CPxLVg2S0UV/2TyOkJfYEXxK48WBE1iLsl478nyLW8ulSG4RknGQW9CtABwgm9cs5pKnVa0mUjESt22fqxZhXn6R4EU6qgJP9Dr3S7lolx4=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=8azCiZa6V4YdsfYQY+Iy8S7RLv+cv/K0CnDSyjduQcs=;\n fh=l4ThzsJjA/Nwhh97MRajyPCgWfVr8GIfKizMmBsb890=;\n b=X7+ED+Bhu37TMJSjr95jcn37jDbjqj7wcmKDE2bkaOvzjS3/M9qLWtxMf+qhJ4bDHx\n +KP1kCOXF2eT97IRlItmrH3KlcGXmiXT/5YFzwmqbFPHmZBMATqhaS6qgVa+4mCyCYHM\n J9pmfWaaNZtK6ypwSojxAmwZmc3hKfclU44LvASl487IOp+gEPIY9sEJb5tElzx72Gn4\n 5ChQg1CBH0Ree/geHkHT9Aq1tRHXmS3T5EzRAYeoED4ka/ciIWDznfm1rNAlqZ3s8T3/\n hTuhnrXIKpF+wNQuLEJ4kJHacJxS+2k4hrrTM/lalTJ/EA2DnfMAeO4KfuKzejPWTDip\n Rc7g==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=etdYbYDR; arc=pass smtp.client-ip=209.85.160.171","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776562612; x=1777167412;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8azCiZa6V4YdsfYQY+Iy8S7RLv+cv/K0CnDSyjduQcs=;\n b=etdYbYDRX1im72blh0xBhg8GPKvbYNqT+oGPIbsTa13vy3aB7hiWcEWCgmHQn1u4WB\n k31CXU6X3S2pbga6g89zBNZiCXxM7KPUC41lpasQIcVfOVYL8Pb5R70NMAjZh7+QV31t\n Mu/xhq1ewkerh3KzI3TP7z4er/++73tKqady7Kch+jcA1N2tV79aqmwQ+2nFBmg1I7Fe\n Cj9EFf0XVrAutsmbKzUDU2/0BF866alu5BM1Lb4mJ42PzMYbeRG774jbXuGFPNosZVnF\n AbzJZg6wZnpx49PFkV2mZPoMX+8M5fKT0RVRIyYI6Oy6qxfQMG0Nx22UkdflgLiJHCMH\n 7VyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776562612; x=1777167412;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8azCiZa6V4YdsfYQY+Iy8S7RLv+cv/K0CnDSyjduQcs=;\n b=fqs5wyKvMl4at+SixZVNdowBQvyi6BKBsrGCrKqhW9//EZl+oAclkMmiSAJzfk3/a6\n 4qyDhSicmbnBTtWMJ7c/3W/sqb5E5mNYHOGBYZN2obqe21F8aTY+svQxcvmM36NUgBJE\n 67G6VpV5BnwKUG+gvLTXgkiqSEO6/fQDOkXnIB2fpPwJL6LfWrojDrrDOl8mgAz2baqU\n OyrX/H8FY0FNjo+0n9K7VQZyili+A3pznDe67GbpJOCAHBOMhJMHp7bI+1m8HuBmAoy6\n AxQkV5T47MmmKqBLPNkHPDLndxqEwbtcV343Pe8PS+WFbCoRiEs0wJLd5Kv8sU5LNtWb\n 2mGA==","X-Gm-Message-State":"AOJu0YzzV9ZD6VeQK65jMxDuY5bVCtpVi2R6dYdH96A04F3C2c2Sb3wG\n\tEDZvGJD+Nw8B5Kid6T9sUCaqRwbrsAAH3qUHi8t9g9YYI4Nvfr/ypLiIvzs/w7F2AzE0+3RjPKr\n\tUlMT+np37q5qWdjOIsSYJ/OCFu3qFhxE=","X-Gm-Gg":"AeBDiesF3+HxOqtxjeiyK3a+gtz/3nC8a9MZJMOt/5pGWzBS2jccmj5R9ENt7rlB8fa\n\tkqv5+VLmS9ulhd60cGF+4aiD/hw6gUJJfRNFOx7NGqrHT3WPoTSNAojt/aLMPMqD6PxfAOzpniR\n\tlrxaf6CqO/9w9+X1JXP2/rR1Najre6/HBSza3+cue0w+22NS0M/PYlzbr9xJ2RTQ8IvhLwBQO4O\n\tOy95AQ2lG1NejHQBWGNMT0yHY8MgaZLAbWAeAorFlQ24opPsdsn1xuhrIB0HhO8/GbVmLD4ibIA\n\tQ7yEoTx5s69G8RyTrihQoBH9riOknNMi1inx6LQmnH9UKk8sAj4Pws7ML8Wf84hkvdqaN5w/CCs\n\tQ6Q6hfZcVr6a+mzkPR/C5cg8MOFZW/4waigPorfsMRtb4H+1+smoWVzeWJzT67xepqdsHApOT1P\n\t57DH+00iKz0MXFIk/+tYVurUn0po9zBK2g","X-Received":"by 2002:ac8:5807:0:b0:50d:7504:b719 with SMTP id\n d75a77b69052e-50e36ee7aefmr137108941cf.52.1776562611630; Sat, 18 Apr 2026\n 18:36:51 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260418221311.67583-1-ebiggers@kernel.org>","In-Reply-To":"<20260418221311.67583-1-ebiggers@kernel.org>","From":"Steve French ","Date":"Sat, 18 Apr 2026 20:36:39 -0500","X-Gm-Features":"AQROBzCK7srreg0o2SXwUbTa33baOj43xTQYmO1CQ0YZRMqB_en4VoZsbvby9rI","Message-ID":"\n ","Subject":"Re: [PATCH v2 0/4] smb: client: Use AES-CMAC library","To":"Eric Biggers ","Cc":"linux-cifs@vger.kernel.org, Steve French ,\n\tlinux-crypto@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org, Ard Biesheuvel ,\n\tPaulo Alcantara ,\n Ronnie Sahlberg ,\n\tShyam Prasad N , Tom Talpey ,\n\tBharath SM ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]