Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 816160,
    "url": "http://patchwork.ozlabs.org/api/1.2/patches/816160/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170920115813.63745-2-ubraun@linux.vnet.ibm.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>",
    "list_archive_url": null,
    "date": "2017-09-20T11:58:04",
    "name": "[net-next,01/10] net/smc: add missing dev_put",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "9bb23bc705022506212643434fc70e7d9a0b7156",
    "submitter": {
        "id": 2266,
        "url": "http://patchwork.ozlabs.org/api/1.2/people/2266/?format=api",
        "name": "Ursula Braun",
        "email": "ubraun@linux.vnet.ibm.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170920115813.63745-2-ubraun@linux.vnet.ibm.com/mbox/",
    "series": [
        {
            "id": 4092,
            "url": "http://patchwork.ozlabs.org/api/1.2/series/4092/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4092",
            "date": "2017-09-20T11:58:04",
            "name": "net/smc: updates 2017-09-20",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/4092/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/816160/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/816160/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxytv2BJtz9t2Q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 21:58:31 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751890AbdITL62 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 20 Sep 2017 07:58:28 -0400",
            "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46108 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751785AbdITL60 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 20 Sep 2017 07:58:26 -0400",
            "from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8KBthYq055217\n\tfor <netdev@vger.kernel.org>; Wed, 20 Sep 2017 07:58:26 -0400",
            "from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d3mf8vxeb-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <netdev@vger.kernel.org>; Wed, 20 Sep 2017 07:58:26 -0400",
            "from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <netdev@vger.kernel.org> from <ubraun@linux.vnet.ibm.com>;\n\tWed, 20 Sep 2017 12:58:23 +0100",
            "from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 20 Sep 2017 12:58:21 +0100",
            "from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8KBwKVB28573870; Wed, 20 Sep 2017 11:58:20 GMT",
            "from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 87EBDA4053;\n\tWed, 20 Sep 2017 12:54:21 +0100 (BST)",
            "from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3E8F2A4051;\n\tWed, 20 Sep 2017 12:54:21 +0100 (BST)",
            "from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tWed, 20 Sep 2017 12:54:21 +0100 (BST)"
        ],
        "From": "Ursula Braun <ubraun@linux.vnet.ibm.com>",
        "To": "davem@davemloft.net",
        "Cc": "netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, jwi@linux.vnet.ibm.com,\n\tschwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,\n\traspl@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com",
        "Subject": "[PATCH net-next 01/10] net/smc: add missing dev_put",
        "Date": "Wed, 20 Sep 2017 13:58:04 +0200",
        "X-Mailer": "git-send-email 2.13.5",
        "In-Reply-To": "<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>",
        "References": "<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>",
        "X-TM-AS-GCONF": "00",
        "x-cbid": "17092011-0040-0000-0000-000003FBA384",
        "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused",
        "x-cbparentid": "17092011-0041-0000-0000-0000209CD9A8",
        "Message-Id": "<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-20_03:, , signatures=0",
        "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709200163",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Hans Wippel <hwippel@linux.vnet.ibm.com>\n\nIn the infiniband part, SMC currently uses get_netdev which calls\ndev_hold on the returned net device. However, the SMC code never calls\ndev_put on that net device resulting in a wrong reference count.\n\nThis patch adds a dev_put after the usage of the net device to fix the\nissue.\n\nSigned-off-by: Hans Wippel <hwippel@linux.vnet.ibm.com>\nSigned-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>\n---\n net/smc/smc_ib.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c\nindex 547e0e113b17..0b5852299158 100644\n--- a/net/smc/smc_ib.c\n+++ b/net/smc/smc_ib.c\n@@ -380,6 +380,7 @@ static int smc_ib_fill_gid_and_mac(struct smc_ib_device *smcibdev, u8 ibport)\n \tndev = smcibdev->ibdev->get_netdev(smcibdev->ibdev, ibport);\n \tif (ndev) {\n \t\tmemcpy(&smcibdev->mac, ndev->dev_addr, ETH_ALEN);\n+\t\tdev_put(ndev);\n \t} else if (!rc) {\n \t\tmemcpy(&smcibdev->mac[ibport - 1][0],\n \t\t       &smcibdev->gid[ibport - 1].raw[8], 3);\n",
    "prefixes": [
        "net-next",
        "01/10"
    ]
}