[{"id":1778588,"web_url":"http://patchwork.ozlabs.org/comment/1778588/","msgid":"","list_archive_url":null,"date":"2017-10-02T20:36:29","subject":"RE: [PATCH net-next 01/10] net/smc: add missing dev_put","submitter":{"id":70907,"url":"http://patchwork.ozlabs.org/api/people/70907/","name":"Parav Pandit","email":"parav@mellanox.com"},"content":"Hi Ursula, Dave, Hans,\n\n> -----Original Message-----\n> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-\n> owner@vger.kernel.org] On Behalf Of Ursula Braun\n> Sent: Wednesday, September 20, 2017 6:58 AM\n> To: davem@davemloft.net\n> Cc: netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux-\n> s390@vger.kernel.org; jwi@linux.vnet.ibm.com; schwidefsky@de.ibm.com;\n> heiko.carstens@de.ibm.com; raspl@linux.vnet.ibm.com;\n> ubraun@linux.vnet.ibm.com\n> Subject: [PATCH net-next 01/10] net/smc: add missing dev_put\n> \n> From: Hans Wippel \n> \n> In the infiniband part, SMC currently uses get_netdev which calls dev_hold on\n> the returned net device. However, the SMC code never calls dev_put on that net\n> device resulting in a wrong reference count.\n> \n> This patch adds a dev_put after the usage of the net device to fix the issue.\n> \n> Signed-off-by: Hans Wippel \n> Signed-off-by: Ursula Braun \n> ---\n> net/smc/smc_ib.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c index\n> 547e0e113b17..0b5852299158 100644\n> --- a/net/smc/smc_ib.c\n> +++ b/net/smc/smc_ib.c\n> @@ -380,6 +380,7 @@ static int smc_ib_fill_gid_and_mac(struct smc_ib_device\n> *smcibdev, u8 ibport)\n> \tndev = smcibdev->ibdev->get_netdev(smcibdev->ibdev, ibport);\n> \tif (ndev) {\n> \t\tmemcpy(&smcibdev->mac, ndev->dev_addr, ETH_ALEN);\n> +\t\tdev_put(ndev);\n\nI am sorry for providing late comments. smc_ib_fill_gid_and_mac() is not coded correctly.\nFew fixes are needed.\n1. ULP such as SMC should not open code/deference any function pointer like get_netdev() of the IB device.\n2. Replace ib_query_gid(..., NULL)\nWith\nib_query_gid(..., gid_attr);\n\nUse gid_attr.ndev to get the MAC address.\nDo dev_put(gid_attr.ndev);\n\nCode should look like below,\n\nstruct ib_gid_attr gid_attr;\n\nrc = ib_query_gid(..., &gid_attr);\nif (rc || !gid_addr.ndev)\n\treturn -ENODEV;\nelse\n\tmemcpy(smcibdev->mac, ndev->dev_addr, ETH_ALEN);\ndev_put(gid_addr.ndev);","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"vyQzmJXA\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=parav@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5Yq91KWhz9t48\n\tfor ;\n\tTue, 3 Oct 2017 07:36:37 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751692AbdJBUgf (ORCPT );\n\tMon, 2 Oct 2017 16:36:35 -0400","from mail-eopbgr20067.outbound.protection.outlook.com\n\t([40.107.2.67]:55383\n\t\"EHLO EUR02-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751158AbdJBUgc (ORCPT );\n\tMon, 2 Oct 2017 16:36:32 -0400","from VI1PR0502MB3008.eurprd05.prod.outlook.com (10.175.21.22) by\n\tVI1PR0502MB3008.eurprd05.prod.outlook.com (10.175.21.22) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Mon, 2 Oct 2017 20:36:29 +0000","from VI1PR0502MB3008.eurprd05.prod.outlook.com\n\t([fe80::2c3a:7563:e2c1:e16f]) by\n\tVI1PR0502MB3008.eurprd05.prod.outlook.com\n\t([fe80::2c3a:7563:e2c1:e16f%14]) with mapi id 15.20.0077.018;\n\tMon, 2 Oct 2017 20:36:29 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=myFkg8zBEKrlkJ54VnNCGqxx9IPmQB8Ha/VPssmHnZM=;\n\tb=vyQzmJXA6vu/B0zsMQIDT7Yneo/9pASHN1oY558v40qBhe+pvLOeDeiU5nY6bxtRPsnHa/K1JjmqbDdcVO9uuIJOxIxq7voUnprmmbCyDimyWrH7NSHdCA2Gw6DoeQnW/SfDyvFMb9wN6yFHfU3tBtGQgAxgnr4CARrwNGTynYE=","From":"Parav Pandit ","To":"Ursula Braun ,\n\t\"davem@davemloft.net\" ","CC":"\"netdev@vger.kernel.org\" ,\n\t\"linux-rdma@vger.kernel.org\" ,\n\t\"linux-s390@vger.kernel.org\" ,\n\t\"jwi@linux.vnet.ibm.com\" ,\n\t\"schwidefsky@de.ibm.com\" ,\n\t\"heiko.carstens@de.ibm.com\" ,\n\t\"raspl@linux.vnet.ibm.com\" ","Subject":"RE: [PATCH net-next 01/10] net/smc: add missing dev_put","Thread-Topic":"[PATCH net-next 01/10] net/smc: add missing dev_put","Thread-Index":"AQHTMgftgWunmP/AWk6ET5hQauCUqaLRFMQQ","Date":"Mon, 2 Oct 2017 20:36:29 +0000","Message-ID":"","References":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>\n\t<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>","In-Reply-To":"<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"vyQzmJXA\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=parav@mellanox.com; "],"x-originating-ip":"[208.176.44.194]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR0502MB3008;\n\t6:F1aXOzwHuEn+vkHUab8lLbrodFiWCYakMEWzvXmY1twXzmoHsmc+5ViGEvkYMqf5VMUBVUdfi3WSVZqTeYCJgppifWos7YVkFOES1+icujLcTdvZJiJ242mBpEq95kJDZaoCv64el+QD5klWC/L2xBQ3UtIN5GxNVI7gvHjJwchhswcoyJDl1akfz6D0cEJ9ZukwakJ7PcpMQYyCknQm7l69P4bLr8aqpPQwxYc/YbpVxmKw3WAiWsUJCdo5y21SjvvZddS+iyrDiGAhNZg6F/Ur42MkkMTj0b9ZfwIrbQY2e3o/JQk5DmFKhtpr9RMeq4oQ8KGfC69zj0gJmsdzyg==;\n\t5:BTSg2Uf1xRx2efKR8TedXlk+TzAc41hIb48gTZ+8ILSznYWg0fRCQVpnZcE6uW2fAK127+zkuaZbaq6RRj/zzb3WdUWrNx2ayL8DEWZwtYOo3dUvZKtibVLhf6eiEnDiURvtGmS+TmMKPs/6/VQx7w==;\n\t24:syZ7RJmMOFjVYPLrxpfS0zKrme55yxqBBwxE1AIAO4Do02uQ0n+b0wLdLylqNjyi+5M/6uyQ54Lp2XQhCA7VfZK2KXX/2M9fv/mC2bwRLh4=;\n\t7:rqAhZwtl+cJdGVmXm6eG+2A+AH7fKFv545nwPP9Duap/ZYTSJk0JQmKKLT+7l0gnjgDtcXGqzRyfH8IoYNaj1A9J4jDysRnFhqIRUdXmtybO7XWZCeaXQKcXIfCvWCpkqRSQocCwflBg8VOhwyVBQBbxlrLOCSTTA714GYfNT4qC9TuPoB9oWQ2dNDApfSCfjoqibJYTnO5We0HIsocUpnkpS6DLR+1NL6UkkgwXgFY=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"7352edd2-c7a7-4ce0-07a0-08d509d542c1","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:VI1PR0502MB3008; ","x-ms-traffictypediagnostic":"VI1PR0502MB3008:","x-exchange-antispam-report-test":"UriScan:(9452136761055)(788757137089)(190383065149520)(104084551191319);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR0502MB3008; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR0502MB3008; ","x-forefront-prvs":"0448A97BF2","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(376002)(346002)(189002)(13464003)(199003)(377454003)(2906002)(110136005)(2900100001)(106356001)(97736004)(8936002)(4326008)(9686003)(54906003)(68736007)(25786009)(105586002)(5250100002)(66066001)(99286003)(2501003)(55016002)(3280700002)(6246003)(3660700001)(478600001)(316002)(2950100002)(53936002)(53546010)(74316002)(229853002)(101416001)(81166006)(76176999)(54356999)(81156014)(8676002)(305945005)(7736002)(6506006)(50986999)(6436002)(86362001)(33656002)(189998001)(3846002)(7696004)(575784001)(6116002)(102836003)(5660300001)(14454004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3008;\n\tH:VI1PR0502MB3008.eurprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"02 Oct 2017 20:36:29.4017\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR0502MB3008","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1778602,"web_url":"http://patchwork.ozlabs.org/comment/1778602/","msgid":"","list_archive_url":null,"date":"2017-10-02T20:39:56","subject":"RE: [PATCH net-next 01/10] net/smc: add missing dev_put","submitter":{"id":70907,"url":"http://patchwork.ozlabs.org/api/people/70907/","name":"Parav Pandit","email":"parav@mellanox.com"},"content":"> -----Original Message-----\n> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-\n> owner@vger.kernel.org] On Behalf Of Parav Pandit\n> Sent: Monday, October 02, 2017 3:36 PM\n> To: Ursula Braun ; davem@davemloft.net\n> Cc: netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux-\n> s390@vger.kernel.org; jwi@linux.vnet.ibm.com; schwidefsky@de.ibm.com;\n> heiko.carstens@de.ibm.com; raspl@linux.vnet.ibm.com\n> Subject: RE: [PATCH net-next 01/10] net/smc: add missing dev_put\n> \n> Hi Ursula, Dave, Hans,\n> \n> > -----Original Message-----\n> > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-\n> > owner@vger.kernel.org] On Behalf Of Ursula Braun\n> > Sent: Wednesday, September 20, 2017 6:58 AM\n> > To: davem@davemloft.net\n> > Cc: netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux-\n> > s390@vger.kernel.org; jwi@linux.vnet.ibm.com; schwidefsky@de.ibm.com;\n> > heiko.carstens@de.ibm.com; raspl@linux.vnet.ibm.com;\n> > ubraun@linux.vnet.ibm.com\n> > Subject: [PATCH net-next 01/10] net/smc: add missing dev_put\n> >\n> > From: Hans Wippel \n> >\n> > In the infiniband part, SMC currently uses get_netdev which calls\n> > dev_hold on the returned net device. However, the SMC code never calls\n> > dev_put on that net device resulting in a wrong reference count.\n> >\n> > This patch adds a dev_put after the usage of the net device to fix the issue.\n> >\n> > Signed-off-by: Hans Wippel \n> > Signed-off-by: Ursula Braun \n> > ---\n> > net/smc/smc_ib.c | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c index\n> > 547e0e113b17..0b5852299158 100644\n> > --- a/net/smc/smc_ib.c\n> > +++ b/net/smc/smc_ib.c\n> > @@ -380,6 +380,7 @@ static int smc_ib_fill_gid_and_mac(struct\n> > smc_ib_device *smcibdev, u8 ibport)\n> > \tndev = smcibdev->ibdev->get_netdev(smcibdev->ibdev, ibport);\n> > \tif (ndev) {\n> > \t\tmemcpy(&smcibdev->mac, ndev->dev_addr, ETH_ALEN);\n> > +\t\tdev_put(ndev);\n> \n> I am sorry for providing late comments. smc_ib_fill_gid_and_mac() is not coded\n> correctly.\n> Few fixes are needed.\n> 1. ULP such as SMC should not open code/deference any function pointer like\n> get_netdev() of the IB device.\n> 2. Replace ib_query_gid(..., NULL)\n> With\n> ib_query_gid(..., gid_attr);\n> \n> Use gid_attr.ndev to get the MAC address.\n> Do dev_put(gid_attr.ndev);\n> \n> Code should look like below,\n> \n> struct ib_gid_attr gid_attr;\n> \n> rc = ib_query_gid(..., &gid_attr);\n> if (rc || !gid_addr.ndev)\n> \treturn -ENODEV;\n> else\n> \tmemcpy(smcibdev->mac, ndev->dev_addr, ETH_ALEN);\n> dev_put(gid_addr.ndev);\n> --\n\nAlso,\nsmc_link_determine_gid() doesn't do dev_put(gattr.ndev) in for loop.\nPlease fix it as well.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"QCK+lCqp\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=parav@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5Yv74yQBz9ryQ\n\tfor ;\n\tTue, 3 Oct 2017 07:40:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752115AbdJBUkB (ORCPT );\n\tMon, 2 Oct 2017 16:40:01 -0400","from mail-eopbgr10073.outbound.protection.outlook.com\n\t([40.107.1.73]:54192\n\t\"EHLO EUR02-HE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751696AbdJBUj7 (ORCPT );\n\tMon, 2 Oct 2017 16:39:59 -0400","from VI1PR0502MB3008.eurprd05.prod.outlook.com (10.175.21.22) by\n\tVI1PR0502MB3007.eurprd05.prod.outlook.com (10.175.21.21) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Mon, 2 Oct 2017 20:39:56 +0000","from VI1PR0502MB3008.eurprd05.prod.outlook.com\n\t([fe80::2c3a:7563:e2c1:e16f]) by\n\tVI1PR0502MB3008.eurprd05.prod.outlook.com\n\t([fe80::2c3a:7563:e2c1:e16f%14]) with mapi id 15.20.0077.018;\n\tMon, 2 Oct 2017 20:39:56 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=VACk29hES9IVEVzlcPK3RWHrqVIq3AEi0yzeVwjy6BY=;\n\tb=QCK+lCqpj+UtXY8qT6tl51H1x0ba1g8x/RuCVZ+WUGJLrC47X26i76gV3TcPVJgA6n0PS22WqPAON8fJ5K56gJpjTorH0GT0WtsDqll0ie69eSYhTBGVryTn2RyTmMWy/q7LbXfiAcpdGTfcnRpwmAfBQa004/6iLyE4sj0Tcfg=","From":"Parav Pandit ","To":"Parav Pandit ,\n\tUrsula Braun ,\n\t\"davem@davemloft.net\" ","CC":"\"netdev@vger.kernel.org\" ,\n\t\"linux-rdma@vger.kernel.org\" ,\n\t\"linux-s390@vger.kernel.org\" ,\n\t\"jwi@linux.vnet.ibm.com\" ,\n\t\"schwidefsky@de.ibm.com\" ,\n\t\"heiko.carstens@de.ibm.com\" ,\n\t\"raspl@linux.vnet.ibm.com\" ","Subject":"RE: [PATCH net-next 01/10] net/smc: add missing dev_put","Thread-Topic":"[PATCH net-next 01/10] net/smc: add missing dev_put","Thread-Index":"AQHTMgftgWunmP/AWk6ET5hQauCUqaLRFMQQgAADzPA=","Date":"Mon, 2 Oct 2017 20:39:56 +0000","Message-ID":"","References":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>\n\t<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[208.176.44.194]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR0502MB3007;\n\t6:waLUNEhvvW6FH5B9ksV9zha2VnFH4DOI/EH5wiH07g3cDbwVu2EUwXnyKNLbOSuJFrgkFU3D4DJYFlH6nGU3rtoMg+X+0kwbbGMfrYBsuzY5bjkVcHf8jde5KqUOpLVebEkDCc86WMnKgbpUrg/sI0TlxObKiLOhpIrEil5FfGKAPrFfqQe9058N2GxOar/g4z7e8WPlNxhEyryYm7h8vphr1NCLytE6gzEbE17VpS3x+S3RIEk2FOuDuMuB/PXgm6m2mBcu6jNF4qS+L5HTLPin+CEnxiqvSdmKITEzAMdF9RGfrsYgyZUhU3eaqRwFnM8jGK9vhDP186ZxJQk4ng==;\n\t5:7HXFOgt2r3THX5Dt1VECCbZrL3pZNlmUzZWB3mES5CYCRIMzYBGhzi9YaYBMpSjgysfoZ2jo/1ncl/z7i8uhptY/0pl5sXJQWoeWZ1NJ9shMnTehl4hxT/ej+b59GOiCNxQKZwgTDVZ12bKzP2MGVw==;\n\t24:YFcNyobt9uW5yxgVF6MDLiJO8jzRf5oLK0VTnyGBrz/B6Hv3xlBdsNRWnysHGAygUO5CUorbwiGg/uWGr9R8FkQdjVIBJoRX4KSWgJPv87w=;\n\t7:G9n7ZBbOMuHzEm/N9TM1mqnUFTXatTMgAjCILl2qMMxDANr1rEXewOFYudhMiBE9i5mrvgpeBY8j3Y1PsojNlYZQXalGV/WH9CNTGoGV4s1UXpqqBoKKEHttYUFsyfDH8eGgpIQezgrRfTLRBKlRUUHWEqPqrscRk1a422MxZoAqoU+yJiWYKwgOWO+tfTNLwZFXducIq2W7/oWzQOscViHbj1IBXYot0CdDYotRTBY=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-ms-office365-filtering-correlation-id":"bc4ea95c-28eb-4f48-1ae9-08d509d5be2a","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:VI1PR0502MB3007; ","x-ms-traffictypediagnostic":"VI1PR0502MB3007:","x-exchange-antispam-report-test":"UriScan:(9452136761055)(788757137089)(190383065149520)(104084551191319);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR0502MB3007; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR0502MB3007; ","x-forefront-prvs":"0448A97BF2","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(346002)(376002)(13464003)(199003)(189002)(377454003)(106356001)(2906002)(66066001)(86362001)(3660700001)(575784001)(3280700002)(229853002)(2950100002)(6436002)(7696004)(105586002)(5660300001)(2900100001)(33656002)(189998001)(6506006)(54356999)(68736007)(14454004)(25786009)(101416001)(6246003)(76176999)(53936002)(50986999)(74316002)(4326008)(305945005)(478600001)(81156014)(81166006)(99286003)(55016002)(97736004)(8676002)(7736002)(316002)(54906003)(9686003)(8936002)(110136005)(2501003)(2940100002)(5250100002)(53546010)(3846002)(102836003)(6116002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3007;\n\tH:VI1PR0502MB3008.eurprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"QCK+lCqp\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=parav@mellanox.com; "],"spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"02 Oct 2017 20:39:56.4813\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR0502MB3007","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1780353,"web_url":"http://patchwork.ozlabs.org/comment/1780353/","msgid":"<7961df23-1603-7853-5f3e-f31095aebba0@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-10-05T07:54:08","subject":"Re: [PATCH net-next 01/10] net/smc: add missing dev_put","submitter":{"id":2266,"url":"http://patchwork.ozlabs.org/api/people/2266/","name":"Ursula Braun","email":"ubraun@linux.vnet.ibm.com"},"content":"On 10/02/2017 10:36 PM, Parav Pandit wrote:\n> Hi Ursula, Dave, Hans,\n> \n>> -----Original Message-----\n>> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-\n>> owner@vger.kernel.org] On Behalf Of Ursula Braun\n>> Sent: Wednesday, September 20, 2017 6:58 AM\n>> To: davem@davemloft.net\n>> Cc: netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux-\n>> s390@vger.kernel.org; jwi@linux.vnet.ibm.com; schwidefsky@de.ibm.com;\n>> heiko.carstens@de.ibm.com; raspl@linux.vnet.ibm.com;\n>> ubraun@linux.vnet.ibm.com\n>> Subject: [PATCH net-next 01/10] net/smc: add missing dev_put\n>>\n>> From: Hans Wippel \n>>\n>> In the infiniband part, SMC currently uses get_netdev which calls dev_hold on\n>> the returned net device. However, the SMC code never calls dev_put on that net\n>> device resulting in a wrong reference count.\n>>\n>> This patch adds a dev_put after the usage of the net device to fix the issue.\n>>\n>> Signed-off-by: Hans Wippel \n>> Signed-off-by: Ursula Braun \n>> ---\n>> net/smc/smc_ib.c | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c index\n>> 547e0e113b17..0b5852299158 100644\n>> --- a/net/smc/smc_ib.c\n>> +++ b/net/smc/smc_ib.c\n>> @@ -380,6 +380,7 @@ static int smc_ib_fill_gid_and_mac(struct smc_ib_device\n>> *smcibdev, u8 ibport)\n>> \tndev = smcibdev->ibdev->get_netdev(smcibdev->ibdev, ibport);\n>> \tif (ndev) {\n>> \t\tmemcpy(&smcibdev->mac, ndev->dev_addr, ETH_ALEN);\n>> +\t\tdev_put(ndev);\n> \n> I am sorry for providing late comments. smc_ib_fill_gid_and_mac() is not coded correctly.\n> Few fixes are needed.\n> 1. ULP such as SMC should not open code/deference any function pointer like get_netdev() of the IB device.\n> 2. Replace ib_query_gid(..., NULL)\n> With\n> ib_query_gid(..., gid_attr);\n> \n> Use gid_attr.ndev to get the MAC address.\n> Do dev_put(gid_attr.ndev);\n> \n> Code should look like below,\n> \n> struct ib_gid_attr gid_attr;\n> \n> rc = ib_query_gid(..., &gid_attr);\n> if (rc || !gid_addr.ndev)\n> \treturn -ENODEV;\n> else\n> \tmemcpy(smcibdev->mac, ndev->dev_addr, ETH_ALEN);\n> dev_put(gid_addr.ndev);\n> \n\nThanks, Parav!\nFollowing your fix ideas I plan to change the function into this one:\n\nstatic int smc_ib_fill_gid_and_mac(struct smc_ib_device *smcibdev, u8 ibport)\n{\n struct ib_gid_attr gattr;\n int rc;\n\n rc = ib_query_gid(smcibdev->ibdev, ibport, 0,\n &smcibdev->gid[ibport - 1], &gattr);\n /* the SMC protocol requires specification of the roce MAC address;\n * if net_device cannot be determined, it can be derived from gid 0\n */\n if (rc)\n return rc;\n\n if (gattr.ndev) {\n memcpy(&smcibdev->mac, gattr.ndev->dev_addr, ETH_ALEN);\n dev_put(gattr.ndev);\n } else {\n memcpy(&smcibdev->mac[ibport - 1][0],\n &smcibdev->gid[ibport - 1].raw[8], 3);\n memcpy(&smcibdev->mac[ibport - 1][3],\n &smcibdev->gid[ibport - 1].raw[13], 3);\n smcibdev->mac[ibport - 1][0] &= ~0x02;\n }\n return 0;\n}\n\nIf you agree, I will submit the corresponding patch including a\n\tSuggested-by: Parav Pandit \n\nRegards, Ursula","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y74mB5KCNz9t3h\n\tfor ;\n\tThu, 5 Oct 2017 18:54:18 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751441AbdJEHyQ (ORCPT );\n\tThu, 5 Oct 2017 03:54:16 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58434 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751369AbdJEHyO (ORCPT\n\t); Thu, 5 Oct 2017 03:54:14 -0400","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv957rb1K083492\n\tfor ; Thu, 5 Oct 2017 03:54:14 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ddbpa69s4-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 05 Oct 2017 03:54:13 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 5 Oct 2017 08:54:11 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 5 Oct 2017 08:54:10 +0100","from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com\n\t[9.149.105.60])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v957s9Qw19529818; Thu, 5 Oct 2017 07:54:09 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 65D3E42041;\n\tThu, 5 Oct 2017 08:50:00 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D2BF04203F;\n\tThu, 5 Oct 2017 08:49:59 +0100 (BST)","from oc0447013845.ibm.com (unknown [9.152.222.38])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 5 Oct 2017 08:49:59 +0100 (BST)"],"Subject":"Re: [PATCH net-next 01/10] net/smc: add missing dev_put","To":"Parav Pandit ","Cc":"\"davem@davemloft.net\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-rdma@vger.kernel.org\" ,\n\t\"linux-s390@vger.kernel.org\" ,\n\t\"jwi@linux.vnet.ibm.com\" ,\n\t\"schwidefsky@de.ibm.com\" ,\n\t\"heiko.carstens@de.ibm.com\" ,\n\t\"raspl@linux.vnet.ibm.com\" ","References":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>\n\t<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>\n\t","From":"Ursula Braun ","Date":"Thu, 5 Oct 2017 09:54:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","x-cbid":"17100507-0040-0000-0000-000003DF8903","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17100507-0041-0000-0000-000025E0F601","Message-Id":"<7961df23-1603-7853-5f3e-f31095aebba0@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-10-05_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1710050111","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1780685,"web_url":"http://patchwork.ozlabs.org/comment/1780685/","msgid":"","list_archive_url":null,"date":"2017-10-05T14:44:52","subject":"RE: [PATCH net-next 01/10] net/smc: add missing dev_put","submitter":{"id":70907,"url":"http://patchwork.ozlabs.org/api/people/70907/","name":"Parav Pandit","email":"parav@mellanox.com"},"content":"Hi Ursula,\r\n\r\n> -----Original Message-----\r\n> From: Ursula Braun [mailto:ubraun@linux.vnet.ibm.com]\r\n> Sent: Thursday, October 05, 2017 2:54 AM\r\n> To: Parav Pandit \r\n> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-\r\n> rdma@vger.kernel.org; linux-s390@vger.kernel.org; jwi@linux.vnet.ibm.com;\r\n> schwidefsky@de.ibm.com; heiko.carstens@de.ibm.com;\r\n> raspl@linux.vnet.ibm.com\r\n> Subject: Re: [PATCH net-next 01/10] net/smc: add missing dev_put\r\n> \r\n> \r\n> \r\n> On 10/02/2017 10:36 PM, Parav Pandit wrote:\r\n> > Hi Ursula, Dave, Hans,\r\n> >\r\n> >> -----Original Message-----\r\n> >> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-\r\n> >> owner@vger.kernel.org] On Behalf Of Ursula Braun\r\n> >> Sent: Wednesday, September 20, 2017 6:58 AM\r\n> >> To: davem@davemloft.net\r\n> >> Cc: netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux-\r\n> >> s390@vger.kernel.org; jwi@linux.vnet.ibm.com; schwidefsky@de.ibm.com;\r\n> >> heiko.carstens@de.ibm.com; raspl@linux.vnet.ibm.com;\r\n> >> ubraun@linux.vnet.ibm.com\r\n> >> Subject: [PATCH net-next 01/10] net/smc: add missing dev_put\r\n> >>\r\n> >> From: Hans Wippel \r\n> >>\r\n> >> In the infiniband part, SMC currently uses get_netdev which calls\r\n> >> dev_hold on the returned net device. However, the SMC code never\r\n> >> calls dev_put on that net device resulting in a wrong reference count.\r\n> >>\r\n> >> This patch adds a dev_put after the usage of the net device to fix the issue.\r\n> >>\r\n> >> Signed-off-by: Hans Wippel \r\n> >> Signed-off-by: Ursula Braun \r\n> >> ---\r\n> >> net/smc/smc_ib.c | 1 +\r\n> >> 1 file changed, 1 insertion(+)\r\n> >>\r\n> >> diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c index\r\n> >> 547e0e113b17..0b5852299158 100644\r\n> >> --- a/net/smc/smc_ib.c\r\n> >> +++ b/net/smc/smc_ib.c\r\n> >> @@ -380,6 +380,7 @@ static int smc_ib_fill_gid_and_mac(struct\r\n> >> smc_ib_device *smcibdev, u8 ibport)\r\n> >> \tndev = smcibdev->ibdev->get_netdev(smcibdev->ibdev, ibport);\r\n> >> \tif (ndev) {\r\n> >> \t\tmemcpy(&smcibdev->mac, ndev->dev_addr, ETH_ALEN);\r\n> >> +\t\tdev_put(ndev);\r\n> >\r\n> > I am sorry for providing late comments. smc_ib_fill_gid_and_mac() is not\r\n> coded correctly.\r\n> > Few fixes are needed.\r\n> > 1. ULP such as SMC should not open code/deference any function pointer like\r\n> get_netdev() of the IB device.\r\n> > 2. Replace ib_query_gid(..., NULL)\r\n> > With\r\n> > ib_query_gid(..., gid_attr);\r\n> >\r\n> > Use gid_attr.ndev to get the MAC address.\r\n> > Do dev_put(gid_attr.ndev);\r\n> >\r\n> > Code should look like below,\r\n> >\r\n> > struct ib_gid_attr gid_attr;\r\n> >\r\n> > rc = ib_query_gid(..., &gid_attr);\r\n> > if (rc || !gid_addr.ndev)\r\n> > \treturn -ENODEV;\r\n> > else\r\n> > \tmemcpy(smcibdev->mac, ndev->dev_addr, ETH_ALEN);\r\n> > dev_put(gid_addr.ndev);\r\n> >\r\n> \r\n> Thanks, Parav!\r\n> Following your fix ideas I plan to change the function into this one:\r\n> \r\n> static int smc_ib_fill_gid_and_mac(struct smc_ib_device *smcibdev, u8 ibport) {\r\n> struct ib_gid_attr gattr;\r\n> int rc;\r\n> \r\n> rc = ib_query_gid(smcibdev->ibdev, ibport, 0,\r\n> &smcibdev->gid[ibport - 1], &gattr);\r\n> /* the SMC protocol requires specification of the roce MAC address;\r\n> * if net_device cannot be determined, it can be derived from gid 0\r\n> */\r\n> if (rc)\r\n> return rc;\r\n> \r\n> if (gattr.ndev) {\r\n> memcpy(&smcibdev->mac, gattr.ndev->dev_addr, ETH_ALEN);\r\n> dev_put(gattr.ndev);\r\n> } else {\r\n> memcpy(&smcibdev->mac[ibport - 1][0],\r\n> &smcibdev->gid[ibport - 1].raw[8], 3);\r\n> memcpy(&smcibdev->mac[ibport - 1][3],\r\n> &smcibdev->gid[ibport - 1].raw[13], 3);\r\n> smcibdev->mac[ibport - 1][0] &= ~0x02;\r\nThis else part is not needed. You can fail the call as suggested above, inline below too.\r\nif (rc || !gid_addr.ndev)\r\n \treturn -ENODEV;\r\nThere must be valid netdev for RoCE gid.\r\nRest code looks fine.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"LfbG+xH6\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=parav@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7Ft51sSNz9t2h\n\tfor ;\n\tFri, 6 Oct 2017 01:45:01 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751332AbdJEOo6 (ORCPT );\n\tThu, 5 Oct 2017 10:44:58 -0400","from mail-db5eur01on0041.outbound.protection.outlook.com\n\t([104.47.2.41]:27088\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751043AbdJEOo4 (ORCPT );\n\tThu, 5 Oct 2017 10:44:56 -0400","from VI1PR0502MB3008.eurprd05.prod.outlook.com (10.175.21.22) by\n\tVI1PR0502MB3006.eurprd05.prod.outlook.com (10.175.21.20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Thu, 5 Oct 2017 14:44:53 +0000","from VI1PR0502MB3008.eurprd05.prod.outlook.com\n\t([fe80::2c3a:7563:e2c1:e16f]) by\n\tVI1PR0502MB3008.eurprd05.prod.outlook.com\n\t([fe80::2c3a:7563:e2c1:e16f%14]) with mapi id 15.20.0077.018;\n\tThu, 5 Oct 2017 14:44:52 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=U2Yg2zC+49R2jzk7BZREHsD7RDC8o00Oh0c6eUQw4QU=;\n\tb=LfbG+xH6UyLfBaGxmsmhUN+m8j7Gyh7cu1FmgTcjuuRAYyf4TH1yqAzj1sT0Wkix0c8jVI/zwtCtq5QOF8t8Jd3BGEa8+0wRswBkjsxudAsJVpSA97bU+4BhQBpAZJqnwCNbi/P7heaUcnQ/MLppnu38m5dt+qo5qnHk+mwZ42w=","From":"Parav Pandit ","To":"Ursula Braun ","CC":"\"davem@davemloft.net\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-rdma@vger.kernel.org\" ,\n\t\"linux-s390@vger.kernel.org\" ,\n\t\"jwi@linux.vnet.ibm.com\" ,\n\t\"schwidefsky@de.ibm.com\" ,\n\t\"heiko.carstens@de.ibm.com\" ,\n\t\"raspl@linux.vnet.ibm.com\" ","Subject":"RE: [PATCH net-next 01/10] net/smc: add missing dev_put","Thread-Topic":"[PATCH net-next 01/10] net/smc: add missing dev_put","Thread-Index":"AQHTMgftgWunmP/AWk6ET5hQauCUqaLRFMQQgAPlawCAAHGgQA==","Date":"Thu, 5 Oct 2017 14:44:52 +0000","Message-ID":"","References":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>\n\t<20170920115813.63745-2-ubraun@linux.vnet.ibm.com>\n\t\n\t<7961df23-1603-7853-5f3e-f31095aebba0@linux.vnet.ibm.com>","In-Reply-To":"<7961df23-1603-7853-5f3e-f31095aebba0@linux.vnet.ibm.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"LfbG+xH6\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=parav@mellanox.com; "],"x-originating-ip":"[208.176.44.194]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR0502MB3006;\n\t6:8aKqC5Ow7Sf3n0uWlw6UK6lxavLqLPhKp+cvD4wQhKb08McG29MJvFtqmDEmYdTVtM60WYWtA7iAFg/t7ugghRM3Yd8d/LHBJS8KdgWkqBFkAFixAz4Iz1HQkrc4zHkNn03+LYsjTH9SCuAoe+n1U6pRETepO1cIs/rP1epUBIf3i0AHi8pzgLiMNGxRYR3QcE2PQUsM5FPGkrLefe3FU+06Bh3G9EBcdx/DvoVQAMnuDjliMG4NQcncgWzpBteEx3W4p5iQG2RZLFbOkutaRximUMFGyTsOc8SxbCUXHbz4WcIa4kUUPA68G2GGlAUwQ+CMNCoL1FNiZPp3cIBkvw==;\n\t5:c2BxNzxshnQZKhhwClXQ3E04H3+xZszq4d5CQ1X9uAzxqsC3yNw0+nIT9+tUbYe7sVJh05TrpbwxGi5lhatsYl6YSW07VN1Baj7T0lWVHZCi0LXlScqAusbg97Il93SW625X9IUZVVLyuWjBxmgygQ==;\n\t24:OAdh5qDGiLgjTYS1tVzerpLd1C8Fuu1JH0fQMEy3M9Zv8MKISOVwFSCS/XR9OTi1h1Wmj+rfKdJcYFUoyc5SKDOgyCOeLEcxg6fJUcM//iA=;\n\t7:fwYAB8kKUSlawIjXcCmnCn1T3F1pKgAFBB/tCDJSMO/PYKdKTvHJouJnHQwnDKGZVDyox4DM4wAl6s1M1AmdukoFxUz9sOJfbHBXDb8hps8d63t6p5snqoI2ji8H3Qtmo3vzflBD+Zty45yDHTh5ukOauC4gySFQUE0rBPJNEI1xpmXlnxVi4j32PWgiX+yAiiFSkkRYoiAXIbR+9On3POYlXtGXvrQ6DLKIl/GBjwY=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"7a345f87-2ec9-4ae8-5aab-08d50bffa365","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:VI1PR0502MB3006; ","x-ms-traffictypediagnostic":"VI1PR0502MB3006:","x-exchange-antispam-report-test":"UriScan:(9452136761055)(788757137089)(190383065149520)(104084551191319);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR0502MB3006; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR0502MB3006; ","x-forefront-prvs":"04519BA941","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(39860400002)(377454003)(189002)(24454002)(199003)(13464003)(86362001)(2950100002)(6916009)(7696004)(33656002)(305945005)(74316002)(7736002)(50986999)(14454004)(105586002)(106356001)(76176999)(54356999)(2906002)(66066001)(68736007)(8936002)(25786009)(575784001)(3660700001)(3280700002)(8676002)(81156014)(81166006)(5660300001)(102836003)(6116002)(3846002)(101416001)(53936002)(6506006)(6436002)(97736004)(93886005)(229853002)(2900100001)(9686003)(55016002)(99286003)(6246003)(478600001)(5250100002)(4326008)(54906003)(189998001)(53546010)(316002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3006;\n\tH:VI1PR0502MB3008.eurprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"05 Oct 2017 14:44:52.6031\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR0502MB3006","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]