Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/814414/?format=api
{ "id": 814414, "url": "http://patchwork.ozlabs.org/api/1.2/patches/814414/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170915222218.6613-1-rosenp@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915222218.6613-1-rosenp@gmail.com>", "list_archive_url": null, "date": "2017-09-15T22:22:18", "name": "bgmac: Remove all offloading features, including GRO.", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "65718470a6879e7918b346e19e7c937bf77b7201", "submitter": { "id": 70304, "url": "http://patchwork.ozlabs.org/api/1.2/people/70304/?format=api", "name": "Rosen Penev", "email": "rosenp@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170915222218.6613-1-rosenp@gmail.com/mbox/", "series": [ { "id": 3394, "url": "http://patchwork.ozlabs.org/api/1.2/series/3394/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3394", "date": "2017-09-15T22:22:18", "name": "bgmac: Remove all offloading features, including GRO.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3394/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814414/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814414/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qTeWoTfB\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv8zj73x8z9sNr\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 16 Sep 2017 08:22:57 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751413AbdIOWWy (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 15 Sep 2017 18:22:54 -0400", "from mail-pf0-f194.google.com ([209.85.192.194]:32849 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751184AbdIOWWx (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 15 Sep 2017 18:22:53 -0400", "by mail-pf0-f194.google.com with SMTP id h4so1808240pfk.0\n\tfor <netdev@vger.kernel.org>; Fri, 15 Sep 2017 15:22:52 -0700 (PDT)", "from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\to30sm3396673pgc.83.2017.09.15.15.22.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 15 Sep 2017 15:22:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=G5XoevH1cZpOt4xSL6E9Ix5PDouRrsgOG7f96G/mEM0=;\n\tb=qTeWoTfBD/EYjUeRZuwOlgve0pntc3zS0u3B+FQkJuuNqi8AnKGRF3+cXofO33u4kk\n\tqhTd6lZBx9CPnpf5pdAPz67AOL9tw3MC939gDEumXhDcKYFeo6NgRphJmh2IHOxAldB6\n\tnmu7Wx1y1eXY29Fu20T1OSdrLhBqyu7mdHbOIDKiGrl2YuIXrJFOi+LMgAiLbZJwMBm2\n\tzuSw4GzZvM2cYMDxwy/7q+OWjI8TXG1vj1cCEBVj+6K+HtvE6Fl0fpPW17oQhKfwjHKc\n\tiThbDilYYz5u/VWlbFHel4PlTGh7hUOZRCGQAwiDkkkBkRNHM2xx0583mVE6P/bDdmEX\n\tAwHg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=G5XoevH1cZpOt4xSL6E9Ix5PDouRrsgOG7f96G/mEM0=;\n\tb=Lc+vRCM56ssuywFoPypwBZv+Q8CVourZpnDmHCKj37/9E3CWAusiOrD/D9sRBfsEFB\n\toPjg2Pj82G8yegNufAu+bowoPLTh3Hi/2TPnH8Zp0CaOTXFBYHgp3arGfT6QQY7/RDV1\n\t+AIYpDiO2Tt1bT2LVVKwznqzyFF5arr4z6nl0yMiRYaRYQ0SiLyPCSgwYnGBf8Aogacr\n\tDWKgRPz/8Wo82fx3mAt5SrATOqW1aQAs14b/WH0RKrYIBpp6wpqXQTyf2GP8KA0eAJE2\n\tXaW/zNlrsbIh0NX9pg3yFzNpBe1W9GpjLhQjC6NbGkStaUIviADWmjQJ1vLJpS/x5qVM\n\tpxfQ==", "X-Gm-Message-State": "AHPjjUgM/WkWo1wp9mrF3cB8KZtngyAeH2QL23gBj9kcAFMhegShNYYK\n\t0KCnR6guEe6L61tQMH8=", "X-Google-Smtp-Source": "ADKCNb6VZ4BaLCKZedOP6fQctWN8dsbWfiaZKiIlAsicusqXcztTFVGLGZpcRbuCA114brb8NtYzIA==", "X-Received": "by 10.98.61.17 with SMTP id k17mr26243785pfa.48.1505514172403;\n\tFri, 15 Sep 2017 15:22:52 -0700 (PDT)", "From": "Rosen Penev <rosenp@gmail.com>", "To": "netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name", "Cc": "Rosen Penev <rosenp@gmail.com>", "Subject": "[PATCH] bgmac: Remove all offloading features, including GRO.", "Date": "Fri, 15 Sep 2017 15:22:18 -0700", "Message-Id": "<20170915222218.6613-1-rosenp@gmail.com>", "X-Mailer": "git-send-email 2.13.5", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading features give no measurable benefit to speed or latency. Furthermore, disabling GRO actually improves iperf performance by a whoppimg 3mbps. Results:\n\nCurrently:\n\n[ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52410\n[ ID] Interval Transfer Bandwidth Reads Dist(bin=16.0K)\n[ 4] 0.00-10.02 sec 52.4 MBytes 43.8 Mbits/sec 641 75:181:12:1:1:0:0:371\n[ 5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52412\n[ 5] 0.00-10.02 sec 52.4 MBytes 43.8 Mbits/sec 629 51:194:13:1:0:1:0:369\n[ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52414\n[ 4] 0.00-10.02 sec 51.9 MBytes 43.4 Mbits/sec 695 126:203:1:0:0:0:2:363\n[ 5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52416\n[ 5] 0.00-10.01 sec 52.4 MBytes 43.9 Mbits/sec 626 57:186:10:0:0:0:0:373\n[ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52420\n[ 4] 0.00-10.02 sec 52.4 MBytes 43.8 Mbits/sec 605 36:179:16:1:0:1:0:372\n[ 5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52422\n\nAfter disabling everything - including GRO:\n\n[ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52440\n[ ID] Interval Transfer Bandwidth Reads Dist(bin=16.0K)\n[ 4] 0.00-10.01 sec 55.1 MBytes 46.2 Mbits/sec 672 180:82:0:0:1:0:0:409\n[ 5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52442\n[ 5] 0.00-10.01 sec 56.0 MBytes 46.9 Mbits/sec 636 117:96:0:0:1:0:0:422\n[ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52444\n[ 4] 0.00-10.01 sec 55.4 MBytes 46.4 Mbits/sec 675 172:92:0:0:1:0:0:410\n[ 5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52446\n[ 5] 0.00-10.01 sec 56.0 MBytes 46.9 Mbits/sec 633 119:90:0:1:1:0:0:422\n[ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52448\n[ 4] 0.00-10.01 sec 55.2 MBytes 46.3 Mbits/sec 688 157:123:0:0:2:0:0:406\n\nSigned-off-by: Rosen Penev <rosenp@gmail.com>\n---\n drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c\nindex 48d672b204a4..c2db5673b073 100644\n--- a/drivers/net/ethernet/broadcom/bgmac.c\n+++ b/drivers/net/ethernet/broadcom/bgmac.c\n@@ -1534,7 +1534,7 @@ int bgmac_enet_probe(struct bgmac *bgmac)\n \t\tgoto err_dma_free;\n \t}\n \n-\tnet_dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;\n+\tnet_dev->features &= NETIF_F_GRO;\n \tnet_dev->hw_features = net_dev->features;\n \tnet_dev->vlan_features = net_dev->features;\n \n", "prefixes": [] }