[{"id":1769501,"web_url":"http://patchwork.ozlabs.org/comment/1769501/","msgid":"<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>","list_archive_url":null,"date":"2017-09-15T22:54:50","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On September 15, 2017 3:22:18 PM PDT, Rosen Penev wrote:\n>On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading\n>features give no measurable benefit to speed or latency. Furthermore,\n>disabling GRO actually improves iperf performance by a whoppimg 3mbps.\n\nDo you have a way to generate gigabit tests and see what results you are getting? We probably are not going to see a 30% improvement just by extrapolation.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XRn0epVi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv9hn18Fgz9s82\n\tfor ;\n\tSat, 16 Sep 2017 08:55:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751229AbdIOWy4 (ORCPT );\n\tFri, 15 Sep 2017 18:54:56 -0400","from mail-pg0-f42.google.com ([74.125.83.42]:45819 \"EHLO\n\tmail-pg0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750871AbdIOWyz (ORCPT\n\t); Fri, 15 Sep 2017 18:54:55 -0400","by mail-pg0-f42.google.com with SMTP id 188so2284625pgb.2\n\tfor ; Fri, 15 Sep 2017 15:54:55 -0700 (PDT)","from [172.20.168.189] ([12.145.98.253])\n\tby smtp.gmail.com with ESMTPSA id\n\tt125sm4102341pgc.50.2017.09.15.15.54.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 15:54:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:subject:to:from:message-id;\n\tbh=t8q2W2ZSSuT5UQCgY9G57KWTllz8Ss30rrmDMjxm7WU=;\n\tb=XRn0epVi40gxl4J63lTPVu4Cq+3D5pxeGUXbswNd6qFn3aCv41bvkGJBvZz3FZcEgL\n\tp2ak3aLGywqmKu/tSHJcyFjCvaC1YlC5a2OSKyyI+xyyhtcVYesF4s1hyoFmIa5QAsAV\n\tVfmAMU4G/afa10+tjwfSJEqR3wTdnRMgI7UOALgzCISBoaByMdr6z2AJh8LkhnRVqhog\n\tLeu+gFX42CUO71ttDM6pyepgpn6W3AV5+nl4g28/nsn2gmfeTUOTWbmSBOMKygpis68A\n\tO0a1tfy7hirRm+DNkZtHfIbtpqUTWKrZP8GU0YamVGXjfu5k47dfU+jKJerYtDe5fjNg\n\tQ11w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:user-agent:in-reply-to:references\n\t:mime-version:content-transfer-encoding:subject:to:from:message-id;\n\tbh=t8q2W2ZSSuT5UQCgY9G57KWTllz8Ss30rrmDMjxm7WU=;\n\tb=jFpZ5MzOizeLe7owtED6ZI+CbCL42a7pZpihmDOBjJM90Gphv0horXTY1rrivQf1Vx\n\tAwWxxKX5Do7lkmx6RwBb8Gwyck9ls8EdO4OeKs8ODeiVp0VwgwhcA/DnR4/0nUi04/JR\n\tEt5Sk0nkdNOPT3ROgAcBDjHfMQlfTE86O6rWcphPEppmBsXtrLUwMntwzFVDryK6pkoH\n\teythC0frjbvAbj5Mg2OBJkaCb641uu1vBBoNItjh16eykxHMLg2AuqZoMaqNqsoGBk7D\n\tStvFn4PP62vk/ZBRCOgFijXJE6rMOC6RwPELYt60ZyYfYdxSA6zlKoQCflquw0LsgG8l\n\tsOWQ==","X-Gm-Message-State":"AHPjjUgGwDI1EgLBZCfkD7lgaPGTJbYi7T8xHxjr85pXVlOvwtgjSr79\n\t9L49+5gCW2aSYw==","X-Google-Smtp-Source":"ADKCNb4l5dFiqy1wPxD6BtHwbGnoxk6FlnJ9fExwWaLuR0pvxYduEi8pPrnOI/EDjt9CMQTm4HLSkw==","X-Received":"by 10.99.55.25 with SMTP id e25mr25322889pga.383.1505516094671; \n\tFri, 15 Sep 2017 15:54:54 -0700 (PDT)","Date":"Fri, 15 Sep 2017 15:54:50 -0700","User-Agent":"K-9 Mail for Android","In-Reply-To":"<20170915222218.6613-1-rosenp@gmail.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","To":"Rosen Penev , netdev@vger.kernel.org,\n\tzajec5@gmail.com, nbd@nbd.name","From":"Florian Fainelli ","Message-ID":"<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769502,"web_url":"http://patchwork.ozlabs.org/comment/1769502/","msgid":"<20170915.161403.2131524326226213839.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-15T23:14:03","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Rosen Penev \nDate: Fri, 15 Sep 2017 15:22:18 -0700\n\n> On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading features give no measurable benefit to speed or latency. Furthermore, disabling GRO actually improves iperf performance by a whoppimg 3mbps. Results:\n ...\n> -\tnet_dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;\n> +\tnet_dev->features &= NETIF_F_GRO;\n> \tnet_dev->hw_features = net_dev->features;\n\nThis doesn't disable GRO.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvB6z5wrNz9sBZ\n\tfor ;\n\tSat, 16 Sep 2017 09:14:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751516AbdIOXOK (ORCPT );\n\tFri, 15 Sep 2017 19:14:10 -0400","from shards.monkeyblade.net ([184.105.139.130]:59584 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751164AbdIOXOJ (ORCPT\n\t); Fri, 15 Sep 2017 19:14:09 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E580C133FDE72;\n\tFri, 15 Sep 2017 16:14:05 -0700 (PDT)"],"Date":"Fri, 15 Sep 2017 16:14:03 -0700 (PDT)","Message-Id":"<20170915.161403.2131524326226213839.davem@davemloft.net>","To":"rosenp@gmail.com","Cc":"netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"David Miller ","In-Reply-To":"<20170915222218.6613-1-rosenp@gmail.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 15 Sep 2017 16:14:06 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769513,"web_url":"http://patchwork.ozlabs.org/comment/1769513/","msgid":"<1505519728.8507.0.camel@gmail.com>","list_archive_url":null,"date":"2017-09-15T23:55:28","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"you're absolutely correct. will send an updated version shortly.\n\nOn Fri, 2017-09-15 at 16:14 -0700, David Miller wrote:\n> From: Rosen Penev \n> Date: Fri, 15 Sep 2017 15:22:18 -0700\n> \n> > On a linksys E1200v1 (actually a crossflashed E1000v2), the\n> offloading features give no measurable benefit to speed or latency.\n> Furthermore, disabling GRO actually improves iperf performance by a\n> whoppimg 3mbps. Results:\n> ...\n> > - net_dev->features = NETIF_F_SG | NETIF_F_IP_CSUM |\n> NETIF_F_IPV6_CSUM;\n> > + net_dev->features &= NETIF_F_GRO;\n> > net_dev->hw_features = net_dev->features;\n> \n> This doesn't disable GRO.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LwiG7qHn\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvC2Z2kN9z9sNc\n\tfor ;\n\tSat, 16 Sep 2017 09:55:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751413AbdIOXzc (ORCPT );\n\tFri, 15 Sep 2017 19:55:32 -0400","from mail-pg0-f51.google.com ([74.125.83.51]:48726 \"EHLO\n\tmail-pg0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751184AbdIOXzb (ORCPT\n\t); Fri, 15 Sep 2017 19:55:31 -0400","by mail-pg0-f51.google.com with SMTP id v66so2333454pgb.5\n\tfor ; Fri, 15 Sep 2017 16:55:31 -0700 (PDT)","from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\tr90sm4357593pfb.183.2017.09.15.16.55.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 15 Sep 2017 16:55:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=n8NguonFRiysWZG9yNndDK+FSJRiD0g1UgCoYf2aiS8=;\n\tb=LwiG7qHnjOPeF3RazYpH3PRwy/TCZYwj/q12zVywafoijB+r6NPWsbPEpBYIHHEuSC\n\tSgaDkU18AnPyYAConaAitwkdSZkODuLVcYKL0JIqLAU1wBP1pcuVNOM+V3k+xV72uEOC\n\tG45e96NI/Xgf04ZpffNbHAIaH1hzTV1NequZYJn39OJXDQODyHIw1elI6UKDgazelKBk\n\tHlZHqG8RP1MWBy1tqg28WmZ1b6qMuL5YVYVnU8TQMX7JVShwU4et0Srk/B1JZfTq0bFy\n\te6tdCcm7uiUVU9eIoaFp6SFNnlMiHq98Mg1QRSmx0uGOoLBKLjY5mAsu1JNG8gC9ZWlw\n\t95Wg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=n8NguonFRiysWZG9yNndDK+FSJRiD0g1UgCoYf2aiS8=;\n\tb=IEOTxTReAlpgqZsZ5+HNNW3HTBziMlHUwAnHzdy/6pnj4n/fpCT24rdI/tSEL9eNRB\n\tryy8bWK1NjT/T+xvh85jJIP5rN954tZ1X/fy6KvmZ41KwvGegnQh9TlnosYpYIa6SWLK\n\t7YWs1UlfiIkrHCX8iwnO2UABt/O+J2odj5F762sHd1YMC5UsxDSty8TyLiC8WrrSAE2Q\n\tWXGQ4kImUKh0bh2f6gGDkicNN/SYDQnSxdHT1z8kK6o18ObsuITtUwKv8xpTESq5d3A3\n\tPJS8TAoKR9FBj5FYNb+nFSRrpfjwiLyEOV02NP9QyKuO0xSiZqP3EzavYfdUc4tuAMcF\n\tiKMQ==","X-Gm-Message-State":"AHPjjUgFol+cWXpfQLW3qvvFERK8mEtMMEiT6UsiOobUorAypZIQiXnW\n\t9Cdk1fXeZgD0jg4BQMo=","X-Google-Smtp-Source":"ADKCNb5k68DzYxQsUY9tD8/+npvh7MGjnqGUma8i6LuDn3X6yJSmxbkCzNmyCcks+UuXUwDl2Uq1uw==","X-Received":"by 10.84.236.74 with SMTP id h10mr29145649pln.315.1505519730638; \n\tFri, 15 Sep 2017 16:55:30 -0700 (PDT)","Message-ID":"<1505519728.8507.0.camel@gmail.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"rosenp@gmail.com","To":"David Miller ","Cc":"netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name","Date":"Fri, 15 Sep 2017 16:55:28 -0700","In-Reply-To":"<20170915.161403.2131524326226213839.davem@davemloft.net>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<20170915.161403.2131524326226213839.davem@davemloft.net>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769516,"web_url":"http://patchwork.ozlabs.org/comment/1769516/","msgid":"<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-16T00:03:30","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote:\n> On September 15, 2017 3:22:18 PM PDT, Rosen Penev \n> wrote:\n> >On a linksys E1200v1 (actually a crossflashed E1000v2), the\n> offloading\n> >features give no measurable benefit to speed or latency. Furthermore,\n> >disabling GRO actually improves iperf performance by a whoppimg\n> 3mbps.\n> \n> Do you have a way to generate gigabit tests and see what results you\n> are getting? We probably are not going to see a 30% improvement just\n> by extrapolation.\n> \n+1\n\nIt seems silly to remove NETIF_F_SG | NETIF_F_IP_CSUM |\nNETIF_F_IPV6_CSUM from dev->features, yet leave the dead-code in the\ndriver to handle these features.\n\nAnd of course GRO was not removed, meaning the bench results were non\nconclusive.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"H+lBnaIE\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCD01FwQz9s7g\n\tfor ;\n\tSat, 16 Sep 2017 10:03:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751388AbdIPADc (ORCPT );\n\tFri, 15 Sep 2017 20:03:32 -0400","from mail-pg0-f47.google.com ([74.125.83.47]:47401 \"EHLO\n\tmail-pg0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751211AbdIPADb (ORCPT\n\t); Fri, 15 Sep 2017 20:03:31 -0400","by mail-pg0-f47.google.com with SMTP id d8so2343141pgt.4\n\tfor ; Fri, 15 Sep 2017 17:03:31 -0700 (PDT)","from ?IPv6:2620:15c:2c1:100:a152:36a5:194b:d6c7?\n\t([2620:15c:2c1:100:a152:36a5:194b:d6c7])\n\tby smtp.googlemail.com with ESMTPSA id\n\tq73sm4571154pfl.147.2017.09.15.17.03.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 17:03:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=isbjXyGvv3nlGmLMVeBL6+e7KSlgQN6sqkhUiwVycFc=;\n\tb=H+lBnaIEkRkX+kfhgdIq0oVBVm7To6Bu636EBh36qXeTfprdFqP0yEbgnJsJ7gcO6a\n\tL35KKQGCNw7kVk8c9H+vEWeqoPf4obnZp1JlEMzDDJchPlwsWqQyluLvg7pGNYphY8gh\n\ty6TNXzr21oWamhNMRAAlOhVF4tZugxIlFGjToBjq743tz4FKPLPmJteLEuwUcETxCkox\n\tInWGlgmuFAAnxTqFrPFmGsY88QZqbmf7FuzqKMiATHuj/RUW86Jf1ilD3MtJBIhkQM2W\n\tifjqfo72vRZjcIkYmTyus40wZgOwNOz8b6FcEKmt+NwQf3BHyZCGI+HiR9+ndcA6lhQe\n\tp8Qw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=isbjXyGvv3nlGmLMVeBL6+e7KSlgQN6sqkhUiwVycFc=;\n\tb=Df8MecWqG6N3+UhbaDuv8fjG3Kls+zTVbqkGlOaxHpyW82lEDUcMrIzJg1rp2BFLPZ\n\tuUlP0LmoiZnVjJJko8ouSbtFcF5J7KZDPllh3av0XpSSiWAqrEAQqcIF2DNEIKp8GmN7\n\t6DOFc7zn8gQNb+d2ogDQo3XPdA67REAOUShMZ1eihxAytnuF3gPAdP+G1ZtZ13TtYBui\n\t3eOb+ng34WsbNcxfa3eMFlXEodKAoJLr4hF9eeeoD5FC8YX7csIEjxvRwBFndnNJHdeK\n\tIxnByVKWslv8+DUf8DEAWwCrGFrCROy93ukdbA0PmVMIhDc4HtahoMn1Jb8tG4f4aEt0\n\tevJA==","X-Gm-Message-State":"AHPjjUjQaUmXv6PBkygEkI9hV8QaxH+UfH6jujH29eid6pVhq9jXuNjj\n\tY/1/s9RAoc0Xxg==","X-Google-Smtp-Source":"AOwi7QBqk52eYSgC1XcDafkfVHTU4i1IEd7+62GBN+Dr986bPqpOhC7UR6PLKZNrmyKVe2TpaG6abg==","X-Received":"by 10.159.198.10 with SMTP id f10mr13202351plo.14.1505520211354; \n\tFri, 15 Sep 2017 17:03:31 -0700 (PDT)","Message-ID":"<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"Eric Dumazet ","To":"Florian Fainelli ","Cc":"Rosen Penev , netdev@vger.kernel.org,\n\tzajec5@gmail.com, nbd@nbd.name","Date":"Fri, 15 Sep 2017 17:03:30 -0700","In-Reply-To":"<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769517,"web_url":"http://patchwork.ozlabs.org/comment/1769517/","msgid":"<1505520638.8507.2.camel@gmail.com>","list_archive_url":null,"date":"2017-09-16T00:10:38","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"Ok fair enough. Will only disable GRO in the driver.\n\nTests were done using \"ethtool -K eth0 gro off\" and on.\n\nOn Fri, 2017-09-15 at 17:03 -0700, Eric Dumazet wrote:\n> On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote:\n> > On September 15, 2017 3:22:18 PM PDT, Rosen Penev > >\n> > wrote:\n> > > On a linksys E1200v1 (actually a crossflashed E1000v2), the\n> > \n> > offloading\n> > > features give no measurable benefit to speed or latency.\n> > > Furthermore,\n> > > disabling GRO actually improves iperf performance by a whoppimg\n> > \n> > 3mbps.\n> > \n> > Do you have a way to generate gigabit tests and see what results\n> > you\n> > are getting? We probably are not going to see a 30% improvement\n> > just\n> > by extrapolation.\n> > \n> \n> +1\n> \n> It seems silly to remove NETIF_F_SG | NETIF_F_IP_CSUM |\n> NETIF_F_IPV6_CSUM from dev->features, yet leave the dead-code in the\n> driver to handle these features.\n> \n> And of course GRO was not removed, meaning the bench results were non\n> conclusive.\n> \n> \n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"A1Czvu4C\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCN60P3Xz9s3T\n\tfor ;\n\tSat, 16 Sep 2017 10:10:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751443AbdIPAKl (ORCPT );\n\tFri, 15 Sep 2017 20:10:41 -0400","from mail-pg0-f52.google.com ([74.125.83.52]:56562 \"EHLO\n\tmail-pg0-f52.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751201AbdIPAKk (ORCPT\n\t); Fri, 15 Sep 2017 20:10:40 -0400","by mail-pg0-f52.google.com with SMTP id 7so2338842pgd.13\n\tfor ; Fri, 15 Sep 2017 17:10:40 -0700 (PDT)","from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\tq77sm3725878pfa.173.2017.09.15.17.10.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 15 Sep 2017 17:10:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=usDod5CrgTGvdVKsZlM4Ctaf4R0ueR+839yu2qRzQng=;\n\tb=A1Czvu4CtUIP6v0Bhk4h/MB42dvqfFwi5GP6f0EOQt+pmrKLdXUvL7EawG5AI//84a\n\tyuVVRjkXCZBPiPq9v2MvzjWaI4MEn7RrG7f8htagdoI/qrs0VNxFabkWdNeGdHn+xeD8\n\to1pcnKiz6OG1skegemV5n+lmwUQkAIZqmouOEMKoP62x51FXOr+HQ4cX274PV2veyjvP\n\tfqNBzn3lNs+R86QhaAxv/kHMR+Eztbj9yyzW/jqYpy121wFVSyyytJQyBkMVG4OAcCej\n\tvH1kbfbRvotw6d1NM2+rTPOKRAa7Qqm5M3uIZCJDmY7ZGc+7Xr6fvjLardjpHMCvcZ3T\n\tT1Ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=usDod5CrgTGvdVKsZlM4Ctaf4R0ueR+839yu2qRzQng=;\n\tb=jbO4sC/WjqFsDplvlDDCXlNX2me7eN3+nymW81IZYNyL741EJfl+dR6IK/dmL8aXOG\n\tz59qvLPa8fIxLRwX2oygKT3M+QUH8wdHoeJbBItxpJqRHl//tV5OTdLYoRIrgek8a40q\n\tohQGSfho1aySh6OF3Bk/mwXSrCLG+mC4SWW4LH4yEE1VVjsP867alp23NHmDrC5zOFP0\n\tZwKOXIa1sycQLJo4kGJGfKanAr/ycXNcIOdke+Kj8x5+VMQ8iXXKZUjyKYNWc4S2s/En\n\t73BCs4n6Rpqhtl88j4x/AgaCVhzAyAtVNevBWxFwXNqRlh8VHiPxV4k+KhdsmiRyL7ZK\n\tnvJw==","X-Gm-Message-State":"AHPjjUjZA7HKDWTJZ/4We+DzKqDIfvNWsZtlWWcZzDx51QozPnzua9r5\n\tytqd5WxQ0IJ9kg==","X-Google-Smtp-Source":"ADKCNb7Jx9mdgDKnsBV0lO/5X5dDYRfghbSOMriI0ahAQQxRWWBS+PASuyYVKJLNb1dUAxEljtOfWQ==","X-Received":"by 10.99.127.27 with SMTP id a27mr26297674pgd.269.1505520640310; \n\tFri, 15 Sep 2017 17:10:40 -0700 (PDT)","Message-ID":"<1505520638.8507.2.camel@gmail.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"rosenp@gmail.com","To":"Eric Dumazet ,\n\tFlorian Fainelli ","Cc":"netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name","Date":"Fri, 15 Sep 2017 17:10:38 -0700","In-Reply-To":"<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>\n\t<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769523,"web_url":"http://patchwork.ozlabs.org/comment/1769523/","msgid":"<1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-16T00:18:15","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Fri, 2017-09-15 at 17:10 -0700, rosenp@gmail.com wrote:\n> Ok fair enough. Will only disable GRO in the driver.\n\nWell, do not even try.\n\nNETIF_F_SOFT_FEATURES is set by core networking stack in\nregister_netdevice(), ( commit 212b573f5552c60265da721ff9ce32e3462a2cdd\n)\n\nAbsolutely no driver disables GRO (excepts the ones playing with LRO)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jCwvxI67\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCYK054Rz9sRW\n\tfor ;\n\tSat, 16 Sep 2017 10:18:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751323AbdIPASS (ORCPT );\n\tFri, 15 Sep 2017 20:18:18 -0400","from mail-pf0-f170.google.com ([209.85.192.170]:53636 \"EHLO\n\tmail-pf0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751201AbdIPASR (ORCPT\n\t); Fri, 15 Sep 2017 20:18:17 -0400","by mail-pf0-f170.google.com with SMTP id x78so2207353pff.10\n\tfor ; Fri, 15 Sep 2017 17:18:17 -0700 (PDT)","from ?IPv6:2620:15c:2c1:100:a152:36a5:194b:d6c7?\n\t([2620:15c:2c1:100:a152:36a5:194b:d6c7])\n\tby smtp.googlemail.com with ESMTPSA id\n\ts17sm3779961pgq.25.2017.09.15.17.18.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 17:18:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mcjXK04ULzb6JkBf4SqMZzyUNEYv88CEjeLkcgDcQzA=;\n\tb=jCwvxI67meUUpOF//AYU4mRsmNTnWrkGz9rAMj/gVn7Kkx4QwDthH7UCpxhWkPBn4x\n\tiM/Li7x7BLpF83m8xgwJIh8zm4brqVxwRMjogoseylyrBQxue83H90Q+nZTN4b8p5kUe\n\tVKBnaSiOfoBYjvX4z4qxCf5LnPrlVPM1ivwd/hj2srbyiti1z5NKiOjaCd5cDNb/RqUe\n\tE0LtvrdU4yhpnTuJ1loGI7///m0PNbRDs9wMC0nkguYXQbDl2hXhnd8HR5MZN2KokIFC\n\tqlQ2uqKJ8Ze+2YSHhTyb0A/N+A46KSAeyb6pvYvGwWYaRXKMaoCNzRkWRt7/dcpB+sMj\n\tK9tQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mcjXK04ULzb6JkBf4SqMZzyUNEYv88CEjeLkcgDcQzA=;\n\tb=SdsAOamG8wyUuyjb2Ne1MHM9Sk2GTvA6BCHbagk6rNbi3oPPaLQ/4+kFlVZ647wpku\n\tqgS2Gx4tYB6w+mqE0cll4H3/J2jWGYttv3ZrPLLMffXDpZ4bfY1VwlWrH5+iSelNZkKh\n\t+duNhEtOylR7I46FqssaeFOvPAnLe04osdCIpRgBUaYBxwjIFc8n8ZkYKWFXT9mt5C/S\n\tmjEHUuSpoafGn4GmhlL1l4hJT+Ka0PIBXHVSKyvucdOYp1J/BHblUBds/eD8vIJvA9KS\n\tmozG+/TRpNKVrbIVMlCQJ2zq9NG4r9+8T6NUFMRZT6vONEPkn6Itx5PJCIOwa7Fyh+OF\n\tu5BA==","X-Gm-Message-State":"AHPjjUioBIgflmt+vX/WhSeEAaQ3vUlMFi9vsxABMvYQpG6E3DO0BL1R\n\tVTW5ujoy2jkpOA==","X-Google-Smtp-Source":"ADKCNb5S+IXGdENw3oee4vP/cij9Ds36BHtl8B73shv0drhWzEuCyiwElJnM8Q4sxAXMrnddMfnpdQ==","X-Received":"by 10.84.129.193 with SMTP id b59mr29454195plb.24.1505521097006; \n\tFri, 15 Sep 2017 17:18:17 -0700 (PDT)","Message-ID":"<1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"Eric Dumazet ","To":"rosenp@gmail.com","Cc":"Florian Fainelli , netdev@vger.kernel.org,\n\tzajec5@gmail.com, nbd@nbd.name","Date":"Fri, 15 Sep 2017 17:18:15 -0700","In-Reply-To":"<1505520638.8507.2.camel@gmail.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>\n\t<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505520638.8507.2.camel@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769526,"web_url":"http://patchwork.ozlabs.org/comment/1769526/","msgid":"<1505521453.2851.0.camel@gmail.com>","list_archive_url":null,"date":"2017-09-16T00:24:13","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"netif_receive_skb seems to have the same effect as \"ethtool -K eth0 gro\noff\".\n\nOn Fri, 2017-09-15 at 17:18 -0700, Eric Dumazet wrote:\n> On Fri, 2017-09-15 at 17:10 -0700, rosenp@gmail.com wrote:\n> > Ok fair enough. Will only disable GRO in the driver.\n> \n> Well, do not even try.\n> \n> NETIF_F_SOFT_FEATURES is set by core networking stack in\n> register_netdevice(), ( commit\n> 212b573f5552c60265da721ff9ce32e3462a2cdd\n> )\n> \n> Absolutely no driver disables GRO (excepts the ones playing with LRO)\n> \n> \n> \n> \n> \n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XUpL8Ljw\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCgp0zvJz9sRg\n\tfor ;\n\tSat, 16 Sep 2017 10:24:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751443AbdIPAYS (ORCPT );\n\tFri, 15 Sep 2017 20:24:18 -0400","from mail-pf0-f171.google.com ([209.85.192.171]:45404 \"EHLO\n\tmail-pf0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751201AbdIPAYR (ORCPT\n\t); Fri, 15 Sep 2017 20:24:17 -0400","by mail-pf0-f171.google.com with SMTP id q76so2225636pfq.2\n\tfor ; Fri, 15 Sep 2017 17:24:17 -0700 (PDT)","from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\tq13sm3828913pgt.87.2017.09.15.17.24.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 15 Sep 2017 17:24:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=eKfdtlOvbMIh7t1QmMEBCyIfQP3j8peGEAQdY1S2IZM=;\n\tb=XUpL8LjwFxfRAC2DBRSqNt9bRLaPGinNuTFhQP7SeUl7h2/m0A8xChmbbybnwVDH0q\n\t+tFgXVa/Kff1gfcoLXcq8TUw/WJwQIHjYDd9lt6RZ59wROv+eedOzzyb4CvfXfpZ2niS\n\to5Ye9UoevGz9R/rM6Gp8UvSswRfncOEYlKoFf8t97NBMrU9wGR838PXFuXW8MEsJ7Zn4\n\t9/6AYVgGgMwfXFg2gy3fAT/AB3ECB7jFPzKykf2NQfORzD7jBytoJqNlwGINqtPoFwGM\n\tdrco29eLk0dQOEOyr1yX4vFT4rxo7gWekrd70CXG7XG76vbMDlij0+xpJqQAXSBaP4IQ\n\t1QdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=eKfdtlOvbMIh7t1QmMEBCyIfQP3j8peGEAQdY1S2IZM=;\n\tb=rEQ700X9O0Cpc/ann4sT2E4Z657rVqqBDcINJBCnZJeA6ww+ROSXO77E+3+oa7bhP7\n\tf7w8uxAbaye4+MVW0t+Yvl5L4Y2MDs0N9UVwMnLqPGnE0El2iO/Ysm5q5v8Mr5B9Mk7v\n\tI0MJNghzrekaggXKtMfc91Ri62rC9f0BF2+7SchG7kJKUX3BIV5PuZBdjdLlq+ay6nIE\n\tsVF3AZiwsM3tnYih446gN2A7BsAAQyHHnoD1sG8SxxsGE35OXMnyONqsrGjix+whEQ+/\n\ta76ZD2yA0L1A8sda53IukGAIOa/SBikNCz9VkDrgO39b1gXvODp3Sva2Et7bWr5ETgVi\n\tN3Vg==","X-Gm-Message-State":"AHPjjUgnWld4ti5KVAgij1LfYcgvCVu423i9Bc7i1diZbMeqgZkc5sDe\n\t+1bRrErIVC/IxQ==","X-Google-Smtp-Source":"ADKCNb6WDUFIj7fxQf8+q8VerOkHLBDrT+Nq5RCwm4VMsw1gQhGF56qE6/BVHQhAIo8HLl8CcQxjaA==","X-Received":"by 10.99.157.200 with SMTP id\n\ti191mr25714869pgd.247.1505521457134; \n\tFri, 15 Sep 2017 17:24:17 -0700 (PDT)","Message-ID":"<1505521453.2851.0.camel@gmail.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"rosenp@gmail.com","To":"Eric Dumazet ","Cc":"Florian Fainelli , netdev@vger.kernel.org,\n\tzajec5@gmail.com, nbd@nbd.name","Date":"Fri, 15 Sep 2017 17:24:13 -0700","In-Reply-To":"<1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>\n\t<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505520638.8507.2.camel@gmail.com>\n\t<1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769527,"web_url":"http://patchwork.ozlabs.org/comment/1769527/","msgid":"<74955cf749601c3a7a938a6945a976f8@nuclearcat.com>","list_archive_url":null,"date":"2017-09-16T00:25:59","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":3838,"url":"http://patchwork.ozlabs.org/api/people/3838/","name":"Denys Fedoryshchenko","email":"nuclearcat@nuclearcat.com"},"content":"On 2017-09-16 03:18, Eric Dumazet wrote:\n> On Fri, 2017-09-15 at 17:10 -0700, rosenp@gmail.com wrote:\n>> Ok fair enough. Will only disable GRO in the driver.\n> \n> Well, do not even try.\n> \n> NETIF_F_SOFT_FEATURES is set by core networking stack in\n> register_netdevice(), ( commit 212b573f5552c60265da721ff9ce32e3462a2cdd\n> )\n> \n> Absolutely no driver disables GRO (excepts the ones playing with LRO)\nI believe also iperf is definitely inconclusive test.\nExcept iperf there is lot of different workloads and configurations, \nthat might have different results.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCjq216vz9sRW\n\tfor ;\n\tSat, 16 Sep 2017 10:26:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751445AbdIPA0D (ORCPT );\n\tFri, 15 Sep 2017 20:26:03 -0400","from nuclearcat.com ([144.76.183.226]:39844 \"EHLO nuclearcat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751201AbdIPA0D (ORCPT );\n\tFri, 15 Sep 2017 20:26:03 -0400","from localhost (localhost [127.0.0.1])\n\tby nuclearcat.com (Postfix) with ESMTP id C473967C08AF;\n\tSat, 16 Sep 2017 00:26:01 +0000 (UTC)","from nuclearcat.com ([127.0.0.1])\n\tby localhost (nuclearcat.com [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id COjleQU8PSiF; Sat, 16 Sep 2017 00:26:00 +0000 (UTC)","from germany.nuclearcat.com (localhost [127.0.0.1])\n\t(Authenticated sender: nuclearcat@nuclearcat.com)\n\tby nuclearcat.com (Postfix) with ESMTPA id 0053E67C0742;\n\tSat, 16 Sep 2017 00:25:59 +0000 (UTC)"],"X-Virus-Scanned":"Debian amavisd-new at nuclearcat.com","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","Date":"Sat, 16 Sep 2017 03:25:59 +0300","From":"Denys Fedoryshchenko ","To":"Eric Dumazet ","Cc":"rosenp@gmail.com, Florian Fainelli ,\n\tnetdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name,\n\tnetdev-owner@vger.kernel.org","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","In-Reply-To":"<1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>\n\t<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505520638.8507.2.camel@gmail.com>\n\t<1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>","Message-ID":"<74955cf749601c3a7a938a6945a976f8@nuclearcat.com>","X-Sender":"nuclearcat@nuclearcat.com","User-Agent":"Roundcube Webmail/1.3.1 ","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769554,"web_url":"http://patchwork.ozlabs.org/comment/1769554/","msgid":"<20170915.205611.1098466403199509032.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-16T03:56:11","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Dumazet \nDate: Fri, 15 Sep 2017 17:03:30 -0700\n\n> On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote:\n>> On September 15, 2017 3:22:18 PM PDT, Rosen Penev \n>> wrote:\n>> >On a linksys E1200v1 (actually a crossflashed E1000v2), the\n>> offloading\n>> >features give no measurable benefit to speed or latency. Furthermore,\n>> >disabling GRO actually improves iperf performance by a whoppimg\n>> 3mbps.\n>> \n>> Do you have a way to generate gigabit tests and see what results you\n>> are getting? We probably are not going to see a 30% improvement just\n>> by extrapolation.\n>> \n> +1\n> \n> It seems silly to remove NETIF_F_SG | NETIF_F_IP_CSUM |\n> NETIF_F_IPV6_CSUM from dev->features, yet leave the dead-code in the\n> driver to handle these features.\n> \n> And of course GRO was not removed, meaning the bench results were non\n> conclusive.\n\nMy sentiments exactly, I think this is a completely unwise change.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvJPG5pnwz9t16\n\tfor ;\n\tSat, 16 Sep 2017 13:57:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751722AbdIPD40 (ORCPT );\n\tFri, 15 Sep 2017 23:56:26 -0400","from shards.monkeyblade.net ([184.105.139.130]:36870 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751589AbdIPD4V (ORCPT\n\t); Fri, 15 Sep 2017 23:56:21 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 6F84C13408B3B;\n\tFri, 15 Sep 2017 20:56:14 -0700 (PDT)"],"Date":"Fri, 15 Sep 2017 20:56:11 -0700 (PDT)","Message-Id":"<20170915.205611.1098466403199509032.davem@davemloft.net>","To":"eric.dumazet@gmail.com","Cc":"f.fainelli@gmail.com, rosenp@gmail.com, netdev@vger.kernel.org,\n\tzajec5@gmail.com, nbd@nbd.name","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"David Miller ","In-Reply-To":"<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<20170915222218.6613-1-rosenp@gmail.com>\n\t<252FFED5-906E-4D1B-9E87-679D0CE801D4@gmail.com>\n\t<1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 15 Sep 2017 20:56:14 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]