Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/809557/?format=api
{ "id": 809557, "url": "http://patchwork.ozlabs.org/api/1.2/patches/809557/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com>", "list_archive_url": null, "date": "2017-09-04T07:45:28", "name": "[net,v2] gianfar: Fix Tx flow control deactivation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0e0f68b3f18f00eed9db33de089e6881182d14fd", "submitter": { "id": 68115, "url": "http://patchwork.ozlabs.org/api/1.2/people/68115/?format=api", "name": "Claudiu Manoil", "email": "claudiu.manoil@nxp.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com/mbox/", "series": [ { "id": 1328, "url": "http://patchwork.ozlabs.org/api/1.2/series/1328/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1328", "date": "2017-09-04T07:45:28", "name": "[net,v2] gianfar: Fix Tx flow control deactivation", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1328/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809557/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809557/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "spf=fail (sender IP is 192.88.158.2)\n\tsmtp.mailfrom=nxp.com; davemloft.net; dkim=none (message not signed)\n\theader.d=none; davemloft.net;\n\tdmarc=fail action=none header.from=nxp.com; " ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm22T2gq2z9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 4 Sep 2017 17:45:37 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753273AbdIDHpf (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 4 Sep 2017 03:45:35 -0400", "from mail-sn1nam01on0075.outbound.protection.outlook.com\n\t([104.47.32.75]:21920\n\t\"EHLO NAM01-SN1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1753259AbdIDHpe (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 4 Sep 2017 03:45:34 -0400", "from CY1PR03CA0028.namprd03.prod.outlook.com (10.174.128.38) by\n\tCO2PR03MB2262.namprd03.prod.outlook.com (10.166.92.143) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Mon, 4 Sep 2017 07:45:32 +0000", "from BL2FFO11FD030.protection.gbl (2a01:111:f400:7c09::141) by\n\tCY1PR03CA0028.outlook.office365.com (2603:10b6:600::38) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9 via Frontend Transport; Mon, 4 Sep 2017 07:45:31 +0000", "from az84smr01.freescale.net (192.88.158.2) by\n\tBL2FFO11FD030.mail.protection.outlook.com (10.173.161.40) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11\n\tvia Frontend Transport; Mon, 4 Sep 2017 07:45:31 +0000", "from fsr-ub1664-016.ea.freescale.net\n\t(fsr-ub1664-016.ea.freescale.net [10.171.71.216])\n\tby az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv847jSFT003696; Mon, 4 Sep 2017 00:45:29 -0700" ], "Received-SPF": "Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.158.2 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.158.2; helo=az84smr01.freescale.net;", "From": "Claudiu Manoil <claudiu.manoil@nxp.com>", "To": "<netdev@vger.kernel.org>", "CC": "\"David S . Miller\" <davem@davemloft.net>", "Subject": "[net v2] gianfar: Fix Tx flow control deactivation", "Date": "Mon, 4 Sep 2017 10:45:28 +0300", "Message-ID": "<1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131489847312328236;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()", "X-Forefront-Antispam-Report": "CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(48376002)(8936002)(5660300001)(50466002)(50226002)(85426001)(6916009)(305945005)(81156014)(81166006)(8676002)(97736004)(626005)(2351001)(106466001)(77096006)(4326008)(36756003)(110136004)(2906002)(104016004)(68736007)(86362001)(575784001)(50986999)(189998001)(69596002)(498600001)(5003940100001)(33646002)(356003)(53936002)(105606002)(47776003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2262;\n\tH:az84smr01.freescale.net; FPR:; SPF:Fail;\n\tPTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BL2FFO11FD030;\n\t1:Iz9YpztvUOpZxjvqHRjqyTYZYFDGq/9VDh48HgJryef44FwH0PMvhLvvLmIwfAkLow1okXWL0EaK1js7akZ0APLNKFEssLi9+Nc1UBOC6vsZGbrPXjA5dEpWXQq0Q0TK", "1; CO2PR03MB2262;\n\t3:QdUm0t2QznSCtByowDM4g9h9PQqjE7VNKwvezjs3ga1Ts1t2St4OQ7nXPe+6JKLcRT6wj+bAa6NdtLNb3Eem+2ermUTcGMQHhJDFwAOeTLc4lLsQJxYtGWk1JH501nAWzkMw5mGMinsrC3eT21lW6ehSaXDU7xD4mBbKCpC3pCqhEf1WG09kG5Cii8jbmD9bZaeN/obQ8QpyhhkIcnHga7suRuq9LcYF4JbL3dwigfA5KLH3d6WIsZ4q3bg4tDb/KyH/UE8iBejHm+4/PXUo2LoIWWr2HrfuhGsYpnC9n+ids5Bo7clYaRgX7ZqiCrl9wP5m7reXZ0bGyLrJAcksEw==;\n\t25:JJjMXfV+l+xQpQFt6TQekCKrIWH4H8Zb4vugUetedEgMf3sIJTUr0tlQrPQhp3QTJ+Pk5nxlcEeyvtmjqM4yhYRMMyQoP3/h3wbwvziG7aP9swd23C0R7BSVqMaxqMrfuLzUTZkV4dkL689XX83pTuhU3PewbvYrl375Qvz76zMYtWm0sic8X+RO/F3h1GKIRxi5+8N2sAedzUZx9ofg+gJZFQ8RyNnbgzkTK1ENEOOmePNhGBRNq955Iwtzv8pOkSGVZ9rkxZxdwRP080sltkEcs3cf9k129GOV4EGqyrnZcH/Kt5AqwTUekr2pw7mhX7Q3K9X/jYSWWyAzpjokBw==;\n\t31:MzmUbgxTC8/EBSBDzQCmIE33pibTMQqLp2SUeU29xjHoHfA05L4q5RHZV9K6Lqjfe5taTz2x4BxuiIQsBkbmfD9GJKPBtUx+XVKpdpewiHqleY1L+iWPuXTAGonwTfHcNp3nE94Su9o/uc8wjJPdGe06DOswivSulSWiVIcmb59OHz6WG8WRcE6qBG8M+halVSH0ANdYMltiJDUrXkAnJcp4NJA3h5e5yK/PDghlcTY=", "1; CO2PR03MB2262;\n\t4:d6n9z6iayiR/Os6FSsxNuGS7POaP1VnjEwutan/lPoTCPWMvYNrxNqoNo4vyTKgBjeT/UXOsc+TIq3oj11ZHdFbX+XFDlY6AuVonQ6GH/yo7Hydz1uNs37df/evlCQVie5qhRgW13E122f7lkB0azkEIZQ7ILHu0hYz3PyG8378Y1G8oRF3nvjFn+trUQ7MMz7pouIsfazTAlcxueOizzt7O5L/DP0/5zqbXD8ofhOPBzlA1uZ8D7pSkeiDXygJs2VEqmrUPDI3x2Ka8J92nG7EXYT0jMtH8+4kes3x388o=", "1; CO2PR03MB2262;\n\t23:vdfYQAl5SyIR6W0lY5JPJT5qI58Q1A9p3z9wu3LzGOBto7SApVpaIVYErYLuefObkWoCAy9UofI4ja7Au/YjRi5jv7i5OPhS2xNsiDDOMwz3gAx5KCFkajj5EBNMtSzG0XlkyiAiiqBywpudjRmByqM99CUmiEDyLQZ4MswIcBnuESKSKUjmvVr+cXv3sPg6fbtqMPQbRqEdnv1UNmdkfZHonPbjidwe6Rj4CGPqtVSR74NSMDRQsZ+lEb6y5F6AOmMnNNfDa9weKYr9PVBqOh9wRZmMwhU2enG8/KcReNuamf5gU6RHOPLoT9t6rla0CWrhOlBRUaT58/C82P9x/NsCnletPEo7FQQgeU1+xnK1N4u84uhvu3TZUvO4uiZpsbiQtPrFlRoj4JLzOn3RjdEw1naXEGUpLkUuF1UpYpwwQp04EGvY3WPNMyfJROX9TRdMTT8SwnA0wEQUxOIxTPRYz6hd9zjCGZZYUe4LcNgFoz7CKtcqBApxw9coMKj29XzmJUf3AlEzLw05cBvmYP0qPlU7gHp5MhsduxRsqCbo3HQKf+tAcFX60L5bs0NPm/nSy+3kn9D32YEX7M40IWDujq6BzKzIBnmBi2qdn0w0mQU2cCh7zQce7xg22vdBHLyqWwbas4YTXUAQJQaAOOoDw5GKWlYfuefd7O5euEiFpUIy/OxpYo7YgpMR+CJI/zDK4/v0xBzKxJx1HOPxqcxNGfun1JhUosTc0hAmuG43d5htydTrcdtRtETdlnKqv9Mn8udMXdsb+4/Q8CE7/WudBhTzPSnoqzAc9bdgNNoYIntnC99rZ3KHuapEJ5sD41WAskEbWJsFzjm0iyZZmSErOg845dnvmpN+Av5LZA/lZ0BuMsEVS3CiwAdYGnB6lcddCWhXe8ev+55c1OtjNToPgyJ33cCQu+dTjda00PpsSJnf70Ls5RpHPNsDIRKniivz4Pb1gTCnUVLze6jbf444VndtXgJBiNVItkkxdUoXo4dham5d3MMQHBAchPX6d2ZcmL6U2k/m2JmiMsD5h5bd1lVUQtK7Zao75htZvrKLIqcv5xQjVRVB9hAdCC3H", "1; CO2PR03MB2262;\n\t6:89am7Oz5Qs40lz2AAC6uIebuU8xWS5WpQ0jknlYwYpNTTeDnEHANfjZQPf8w5eV0Ab5wwhBsmiujyKMm0DUm9D5hziMcpmUEOT8yv2HGPjdw+ve4aB08v8eGVANKdcebhYCKCTUbeTtI17wHTsTqq1xUHZXqiY6GavnreKfExmVYjPTV7dtDozqmHYuCkUZ17mb98d41DODFKhOMXdp3IpEfhrYU09iPTIZfAjPEb5eXzWwuLdw2clCY+zQSVZi5ku0hWG638g+2U+IFMC7ntRB8OghpvnC0fBATn8MIwy614p1zRU1192pqKDJSfs9y9xKBcPnsSF8nCY4s3yStdQ==;\n\t5:vTrI3CP7WDBzk44CE0nfOMOu9UtPtyuaYCFHM49illhACbAUvmaRQjIas4z14JFCwxmf+pedhcrPRaQGP5mMderhY3HCheLMxY/MjaSmBTfSfxsizeqaWBDWwqnZXrjc0ahEWiZwr7fssNBpINbW1w==;\n\t24:lnuvAA/hIGLG2q6lwKn/iMcxn6qIRAuiBz3jZlacGcP1yB98SyObozZ2nQ4bBTWFlXE9Z1/TjrvT0B41aaTmPNjjI/K7S9qFm5HJFbC+HqQ=;\n\t7:W8nHIPrzIyXYYtC61MmGnByhOxK3sopAw+/O12pNSmZ0e7gZrfA1r2EpuwC8pnqzJwMaMB/BOzfQYsNJO+LlGnEle0fkISJmKUV79h/ehCAVeHWhxVgmMtdscFUjDgQ7A9HiLKr1cA5hsR6ufrpQuSqA7dCRseHuTVevT6g9QOOwpFodZTKlJarQgdNCex4PkwGXkMO2ePjmohMwVHHr+SyP7EEYbJ2g9W1rSXIgdxc=" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6252623c-17c1-4ce7-262c-08d4f368eb16", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CO2PR03MB2262; ", "X-MS-TrafficTypeDiagnostic": "CO2PR03MB2262:", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-Microsoft-Antispam-PRVS": "<CO2PR03MB2262A2E9E5927BAEC7E3FE6A96910@CO2PR03MB2262.namprd03.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6096035)(20161123559100)(20161123561025)(20161123556025)(20161123565025)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CO2PR03MB2262; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CO2PR03MB2262; ", "X-Forefront-PRVS": "0420213CCD", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Sep 2017 07:45:31.0144\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.158.2]; Helo=[az84smr01.freescale.net]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO2PR03MB2262", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The wrong register is checked for the Tx flow control bit,\nit should have been maccfg1 not maccfg2.\nThis went unnoticed for so long probably because the impact is\nhardly visible, not to mention the tangled code from adjust_link().\nFirst, link flow control (i.e. handling of Rx/Tx link level pause frames)\nis disabled by default (needs to be enabled via 'ethtool -A').\nSecondly, maccfg2 always returns 0 for tx_flow_oldval (except for a few\nold boards), which results in Tx flow control remaining always on\nonce activated.\n\nShould be queued for -stable, thanks.\n\nFixes: 45b679c9a3ccd9e34f28e6ec677b812a860eb8eb (\"gianfar: Implement PAUSE frame generation support\")\n\nSigned-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>\n---\nv2: \"Fixes\" tag formatting and removed CC: stable from comments.\n\n drivers/net/ethernet/freescale/gianfar.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c\nindex c4b4b0a..5be52d8 100644\n--- a/drivers/net/ethernet/freescale/gianfar.c\n+++ b/drivers/net/ethernet/freescale/gianfar.c\n@@ -3687,7 +3687,7 @@ static noinline void gfar_update_link_state(struct gfar_private *priv)\n \t\tu32 tempval1 = gfar_read(®s->maccfg1);\n \t\tu32 tempval = gfar_read(®s->maccfg2);\n \t\tu32 ecntrl = gfar_read(®s->ecntrl);\n-\t\tu32 tx_flow_oldval = (tempval & MACCFG1_TX_FLOW);\n+\t\tu32 tx_flow_oldval = (tempval1 & MACCFG1_TX_FLOW);\n \n \t\tif (phydev->duplex != priv->oldduplex) {\n \t\t\tif (!(phydev->duplex))\n", "prefixes": [ "net", "v2" ] }