[{"id":1763671,"web_url":"http://patchwork.ozlabs.org/comment/1763671/","msgid":"<20170905.143543.1026660660946884756.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T21:35:43","subject":"Re: [net v2] gianfar: Fix Tx flow control deactivation","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Claudiu Manoil \nDate: Mon, 4 Sep 2017 10:45:28 +0300\n\n> The wrong register is checked for the Tx flow control bit,\n> it should have been maccfg1 not maccfg2.\n> This went unnoticed for so long probably because the impact is\n> hardly visible, not to mention the tangled code from adjust_link().\n> First, link flow control (i.e. handling of Rx/Tx link level pause frames)\n> is disabled by default (needs to be enabled via 'ethtool -A').\n> Secondly, maccfg2 always returns 0 for tx_flow_oldval (except for a few\n> old boards), which results in Tx flow control remaining always on\n> once activated.\n> \n> Fixes: 45b679c9a3ccd9e34f28e6ec677b812a860eb8eb (\"gianfar: Implement PAUSE frame generation support\")\n> \n> Signed-off-by: Claudiu Manoil \n\nPlease do not put an empty line between Fixes: and other tags. All tags\nare equal and should be in one uninterrupted block of text.\n\nApplied, and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn0Pz3Xxpz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 07:35:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752520AbdIEVfo (ORCPT );\n\tTue, 5 Sep 2017 17:35:44 -0400","from shards.monkeyblade.net ([184.105.139.130]:39552 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752145AbdIEVfo (ORCPT\n\t); Tue, 5 Sep 2017 17:35:44 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id C34E9136AA450;\n\tTue, 5 Sep 2017 14:35:43 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 14:35:43 -0700 (PDT)","Message-Id":"<20170905.143543.1026660660946884756.davem@davemloft.net>","To":"claudiu.manoil@nxp.com","Cc":"netdev@vger.kernel.org","Subject":"Re: [net v2] gianfar: Fix Tx flow control deactivation","From":"David Miller ","In-Reply-To":"<1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com>","References":"<1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 14:35:43 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]