Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/801088/?format=api
{ "id": 801088, "url": "http://patchwork.ozlabs.org/api/1.2/patches/801088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1502694268-2995-1-git-send-email-david.wu@rock-chips.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>", "list_archive_url": null, "date": "2017-08-14T07:04:28", "name": "[U-Boot] rockchip: rk322x: Disable integrated macphy for saving power consuming", "commit_ref": "4c94aacd6298c47f0a75bfeff44353ad47252627", "pull_url": null, "state": "accepted", "archived": false, "hash": "792fe0bc569f64b337fb31ba8a09078dd2300291", "submitter": { "id": 68083, "url": "http://patchwork.ozlabs.org/api/1.2/people/68083/?format=api", "name": "David Wu", "email": "david.wu@rock-chips.com" }, "delegate": { "id": 69486, "url": "http://patchwork.ozlabs.org/api/1.2/users/69486/?format=api", "username": "ptomsich", "first_name": "Philipp", "last_name": "Tomsich", "email": "philipp.tomsich@theobroma-systems.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1502694268-2995-1-git-send-email-david.wu@rock-chips.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/801088/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/801088/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xW61s6Wnfz9rxm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 14 Aug 2017 17:00:17 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 769E0C21DCB; Mon, 14 Aug 2017 07:00:15 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5AC08C21DAA;\n\tMon, 14 Aug 2017 07:00:11 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 61EBFC21DAA; Mon, 14 Aug 2017 07:00:10 +0000 (UTC)", "from lucky1.263xmail.com (lucky1.263xmail.com [211.157.147.133])\n\tby lists.denx.de (Postfix) with ESMTPS id 4F4FBC21D7B\n\tfor <u-boot@lists.denx.de>; Mon, 14 Aug 2017 07:00:08 +0000 (UTC)", "from david.wu?rock-chips.com (unknown [192.168.167.163])\n\tby lucky1.263xmail.com (Postfix) with ESMTP id 7857B8F200;\n\tMon, 14 Aug 2017 15:00:03 +0800 (CST)", "from localhost.localdomain (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id 55494381;\n\tMon, 14 Aug 2017 14:59:53 +0800 (CST)", "from localhost.localdomain (unknown [58.22.7.114])\n\tby smtp.263.net (Postfix) whith ESMTP id 23635TD7CBN;\n\tMon, 14 Aug 2017 14:59:57 +0800 (CST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_BL,\n\tRCVD_IN_MSPIKE_L4 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0", "X-263anti-spam": "KSV:0;", "X-MAIL-GRAY": "1", "X-MAIL-DELIVERY": "0", "X-KSVirus-check": "0", "X-ABS-CHECKED": "4", "X-RL-SENDER": "david.wu@rock-chips.com", "X-FST-TO": "sjg@chromium.org", "X-SENDER-IP": "58.22.7.114", "X-LOGIN-NAME": "david.wu@rock-chips.com", "X-UNIQUE-TAG": "<78ff584ecbc7601605204b1512825256>", "X-ATTACHMENT-NUM": "0", "X-SENDER": "wdc@rock-chips.com", "X-DNS-TYPE": "0", "From": "David Wu <david.wu@rock-chips.com>", "To": "sjg@chromium.org,\n\tphilipp.tomsich@theobroma-systems.com", "Date": "Mon, 14 Aug 2017 15:04:28 +0800", "Message-Id": "<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>", "X-Mailer": "git-send-email 1.9.1", "Cc": "albert.u.boot@aribaud.net, wmc@rock-chips.com, u-boot@lists.denx.de,\n\tDavid Wu <david.wu@rock-chips.com>", "Subject": "[U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "Unfortunately, the integrated macphy default is enabled, which will\nincrease power consuming, if we do not use this PHY. So let's disable\nit at first, which will save power consuming. If we really use it, then\nenable it in driver level.\n\nSigned-off-by: David Wu <david.wu@rock-chips.com>\n---\n arch/arm/include/asm/arch-rockchip/grf_rk322x.h | 32 +++++++++++++++++++++++++\n arch/arm/mach-rockchip/rk322x-board.c | 8 +++++++\n 2 files changed, 40 insertions(+)", "diff": "diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk322x.h b/arch/arm/include/asm/arch-rockchip/grf_rk322x.h\nindex 26071c8..c0c0d84 100644\n--- a/arch/arm/include/asm/arch-rockchip/grf_rk322x.h\n+++ b/arch/arm/include/asm/arch-rockchip/grf_rk322x.h\n@@ -54,6 +54,32 @@ struct rk322x_grf {\n \tunsigned int os_reg[8];\n \tunsigned int reserved9[(0x604 - 0x5e4) / 4 - 1];\n \tunsigned int ddrc_stat;\n+\tunsigned int reserved10[(0x680 - 0x604) / 4 - 1];\n+\tunsigned int sig_detect_con[2];\n+\tunsigned int reserved11[(0x690 - 0x684) / 4 - 1];\n+\tunsigned int sig_detect_status[2];\n+\tunsigned int reserved12[(0x6a0 - 0x694) / 4 - 1];\n+\tunsigned int sig_detect_clr[2];\n+\tunsigned int reserved13[(0x6b0 - 0x6a4) / 4 - 1];\n+\tunsigned int emmc_det;\n+\tunsigned int reserved14[(0x700 - 0x6b0) / 4 - 1];\n+\tunsigned int host0_con[3];\n+\tunsigned int reserved15;\n+\tunsigned int host1_con[3];\n+\tunsigned int reserved16;\n+\tunsigned int host2_con[3];\n+\tunsigned int reserved17[(0x760 - 0x728) / 4 - 1];\n+\tunsigned int usbphy0_con[27];\n+\tunsigned int reserved18[(0x800 - 0x7c8) / 4 - 1];\n+\tunsigned int usbphy1_con[27];\n+\tunsigned int reserved19[(0x880 - 0x868) / 4 - 1];\n+\tunsigned int otg_con0;\n+\tunsigned int uoc_status0;\n+\tunsigned int reserved20[(0x900 - 0x884) / 4 - 1];\n+\tunsigned int mac_con[2];\n+\tunsigned int reserved21[(0xb00 - 0x904) / 4 - 1];\n+\tunsigned int macphy_con[4];\n+\tunsigned int macphy_status;\n };\n check_member(rk322x_grf, ddrc_stat, 0x604);\n \n@@ -516,4 +542,10 @@ enum {\n \tCON_IOMUX_PWM0SEL_SHIFT\t= 0,\n \tCON_IOMUX_PWM0SEL_MASK\t= 1 << CON_IOMUX_PWM0SEL_SHIFT,\n };\n+\n+/* GRF_MACPHY_CON0 */\n+enum {\n+\tMACPHY_CFG_ENABLE_SHIFT = 0,\n+\tMACPHY_CFG_ENABLE_MASK = 1 << MACPHY_CFG_ENABLE_SHIFT,\n+};\n #endif\ndiff --git a/arch/arm/mach-rockchip/rk322x-board.c b/arch/arm/mach-rockchip/rk322x-board.c\nindex b6543a5..c8e6c6c 100644\n--- a/arch/arm/mach-rockchip/rk322x-board.c\n+++ b/arch/arm/mach-rockchip/rk322x-board.c\n@@ -67,6 +67,14 @@ int board_init(void)\n \t\t CON_IOMUX_UART2SEL_MASK,\n \t\t CON_IOMUX_UART2SEL_21 << CON_IOMUX_UART2SEL_SHIFT);\n \n+\t/*\n+\t* The integrated macphy is enabled by default, disable it\n+\t* for saving power consuming.\n+\t*/\n+\trk_clrsetreg(&grf->macphy_con[0],\n+\t\t MACPHY_CFG_ENABLE_MASK,\n+\t\t 0 << MACPHY_CFG_ENABLE_SHIFT);\n+\n \treturn 0;\n }\n \n", "prefixes": [ "U-Boot" ] }