[{"id":1749238,"web_url":"http://patchwork.ozlabs.org/comment/1749238/","msgid":"","list_archive_url":null,"date":"2017-08-17T06:47:41","subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","submitter":{"id":64532,"url":"http://patchwork.ozlabs.org/api/people/64532/","name":"Kever Yang","email":"kever.yang@rock-chips.com"},"content":"Hi David,\n\n\nOn 08/14/2017 03:04 PM, David Wu wrote:\n> Unfortunately, the integrated macphy default is enabled, which will\n> increase power consuming, if we do not use this PHY. So let's disable\n> it at first, which will save power consuming. If we really use it, then\n> enable it in driver level.\n>\n> Signed-off-by: David Wu \n\nReviewed-by: Kever Yang \n\nThanks,\n- Kever\n> ---\n> arch/arm/include/asm/arch-rockchip/grf_rk322x.h | 32 +++++++++++++++++++++++++\n> arch/arm/mach-rockchip/rk322x-board.c | 8 +++++++\n> 2 files changed, 40 insertions(+)\n>\n> diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk322x.h b/arch/arm/include/asm/arch-rockchip/grf_rk322x.h\n> index 26071c8..c0c0d84 100644\n> --- a/arch/arm/include/asm/arch-rockchip/grf_rk322x.h\n> +++ b/arch/arm/include/asm/arch-rockchip/grf_rk322x.h\n> @@ -54,6 +54,32 @@ struct rk322x_grf {\n> \tunsigned int os_reg[8];\n> \tunsigned int reserved9[(0x604 - 0x5e4) / 4 - 1];\n> \tunsigned int ddrc_stat;\n> +\tunsigned int reserved10[(0x680 - 0x604) / 4 - 1];\n> +\tunsigned int sig_detect_con[2];\n> +\tunsigned int reserved11[(0x690 - 0x684) / 4 - 1];\n> +\tunsigned int sig_detect_status[2];\n> +\tunsigned int reserved12[(0x6a0 - 0x694) / 4 - 1];\n> +\tunsigned int sig_detect_clr[2];\n> +\tunsigned int reserved13[(0x6b0 - 0x6a4) / 4 - 1];\n> +\tunsigned int emmc_det;\n> +\tunsigned int reserved14[(0x700 - 0x6b0) / 4 - 1];\n> +\tunsigned int host0_con[3];\n> +\tunsigned int reserved15;\n> +\tunsigned int host1_con[3];\n> +\tunsigned int reserved16;\n> +\tunsigned int host2_con[3];\n> +\tunsigned int reserved17[(0x760 - 0x728) / 4 - 1];\n> +\tunsigned int usbphy0_con[27];\n> +\tunsigned int reserved18[(0x800 - 0x7c8) / 4 - 1];\n> +\tunsigned int usbphy1_con[27];\n> +\tunsigned int reserved19[(0x880 - 0x868) / 4 - 1];\n> +\tunsigned int otg_con0;\n> +\tunsigned int uoc_status0;\n> +\tunsigned int reserved20[(0x900 - 0x884) / 4 - 1];\n> +\tunsigned int mac_con[2];\n> +\tunsigned int reserved21[(0xb00 - 0x904) / 4 - 1];\n> +\tunsigned int macphy_con[4];\n> +\tunsigned int macphy_status;\n> };\n> check_member(rk322x_grf, ddrc_stat, 0x604);\n> \n> @@ -516,4 +542,10 @@ enum {\n> \tCON_IOMUX_PWM0SEL_SHIFT\t= 0,\n> \tCON_IOMUX_PWM0SEL_MASK\t= 1 << CON_IOMUX_PWM0SEL_SHIFT,\n> };\n> +\n> +/* GRF_MACPHY_CON0 */\n> +enum {\n> +\tMACPHY_CFG_ENABLE_SHIFT = 0,\n> +\tMACPHY_CFG_ENABLE_MASK = 1 << MACPHY_CFG_ENABLE_SHIFT,\n> +};\n> #endif\n> diff --git a/arch/arm/mach-rockchip/rk322x-board.c b/arch/arm/mach-rockchip/rk322x-board.c\n> index b6543a5..c8e6c6c 100644\n> --- a/arch/arm/mach-rockchip/rk322x-board.c\n> +++ b/arch/arm/mach-rockchip/rk322x-board.c\n> @@ -67,6 +67,14 @@ int board_init(void)\n> \t\t CON_IOMUX_UART2SEL_MASK,\n> \t\t CON_IOMUX_UART2SEL_21 << CON_IOMUX_UART2SEL_SHIFT);\n> \n> +\t/*\n> +\t* The integrated macphy is enabled by default, disable it\n> +\t* for saving power consuming.\n> +\t*/\n> +\trk_clrsetreg(&grf->macphy_con[0],\n> +\t\t MACPHY_CFG_ENABLE_MASK,\n> +\t\t 0 << MACPHY_CFG_ENABLE_SHIFT);\n> +\n> \treturn 0;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xXxch1PSrz9t3B\n\tfor ;\n\tThu, 17 Aug 2017 16:48:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CC985C21E7D; Thu, 17 Aug 2017 06:48:13 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 340D7C21EF0;\n\tThu, 17 Aug 2017 06:48:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid F0454C21EC1; Thu, 17 Aug 2017 06:48:08 +0000 (UTC)","from regular1.263xmail.com (regular1.263xmail.com [211.150.99.136])\n\tby lists.denx.de (Postfix) with ESMTPS id 06D79C21ECE\n\tfor ; Thu, 17 Aug 2017 06:48:07 +0000 (UTC)","from kever.yang?rock-chips.com (unknown [192.168.165.105])\n\tby regular1.263xmail.com (Postfix) with ESMTP id A1C915A;\n\tThu, 17 Aug 2017 14:48:02 +0800 (CST)","from smtp.263.net (va-smtp01.263.net [54.88.144.211])\n\tby smtp.263.net (Postfix) with ESMTP id 0B67D445;\n\tThu, 17 Aug 2017 14:48:01 +0800 (CST)","from [192.168.60.65] (localhost.localdomain [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTP id 0AD249F609;\n\tThu, 17 Aug 2017 14:47:48 +0800 (CST)","from [192.168.60.65] (unknown [103.29.142.67])\n\tby smtp.263.net (Postfix) whith ESMTP id 14189OCHLI1;\n\tThu, 17 Aug 2017 14:47:51 +0800 (CST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"kever.yang@rock-chips.com","X-FST-TO":"u-boot@lists.denx.de","X-SENDER-IP":"103.29.142.67","X-LOGIN-NAME":"kever.yang@rock-chips.com","X-UNIQUE-TAG":"<1a9e9f0d1f525ca84ac82684d3111abc>","X-ATTACHMENT-NUM":"0","X-SENDER":"yk@rock-chips.com","X-DNS-TYPE":"0","To":"David Wu , sjg@chromium.org,\n\tphilipp.tomsich@theobroma-systems.com","References":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","From":"Kever Yang ","Message-ID":"","Date":"Thu, 17 Aug 2017 14:47:41 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","Cc":"u-boot@lists.denx.de, albert.u.boot@aribaud.net, wmc@rock-chips.com","Subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1751054,"web_url":"http://patchwork.ozlabs.org/comment/1751054/","msgid":"","list_archive_url":null,"date":"2017-08-18T13:23:45","subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> Unfortunately, the integrated macphy default is enabled, which will\n> increase power consuming, if we do not use this PHY. So let's disable\n> it at first, which will save power consuming. If we really use it, then\n> enable it in driver level.\n> \n> Signed-off-by: David Wu \n> Reviewed-by: Kever Yang \n> ---\n> arch/arm/include/asm/arch-rockchip/grf_rk322x.h | 32 +++++++++++++++++++++++++\n> arch/arm/mach-rockchip/rk322x-board.c | 8 +++++++\n> 2 files changed, 40 insertions(+)\n> \n\nReviewed-by: Philipp Tomsich ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xYkMj1j6gz9t30\n\tfor ;\n\tFri, 18 Aug 2017 23:24:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid DEF23C22042; Fri, 18 Aug 2017 13:24:10 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1DBBAC22001;\n\tFri, 18 Aug 2017 13:23:51 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EA410C21DAA; Fri, 18 Aug 2017 13:23:48 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 9DDD4C21DAA\n\tfor ; Fri, 18 Aug 2017 13:23:48 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:64551\n\thelo=vpn-10-11-0-14.lan) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dihFZ-0003Er-Jo; Fri, 18 Aug 2017 15:23:45 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich ","To":"David Wu ","In-Reply-To":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","References":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","Message-Id":"","Date":"Fri, 18 Aug 2017 15:23:45 +0200","Cc":"albert.u.boot@aribaud.net, wmc@rock-chips.com, u-boot@lists.denx.de,\n\tDavid Wu ","Subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1751326,"web_url":"http://patchwork.ozlabs.org/comment/1751326/","msgid":"","list_archive_url":null,"date":"2017-08-18T16:08:41","subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> Unfortunately, the integrated macphy default is enabled, which will\n> increase power consuming, if we do not use this PHY. So let's disable\n> it at first, which will save power consuming. If we really use it, then\n> enable it in driver level.\n> \n> Signed-off-by: David Wu \n> Reviewed-by: Kever Yang \n> Reviewed-by: Philipp Tomsich \n> ---\n> arch/arm/include/asm/arch-rockchip/grf_rk322x.h | 32 +++++++++++++++++++++++++\n> arch/arm/mach-rockchip/rk322x-board.c | 8 +++++++\n> 2 files changed, 40 insertions(+)\n> \n\nAcked-by: Philipp Tomsich ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xYpgJ1b3Fz9t3p\n\tfor ;\n\tSat, 19 Aug 2017 02:38:36 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E6491C220D5; Fri, 18 Aug 2017 16:34:57 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9EAAAC220FC;\n\tFri, 18 Aug 2017 16:34:17 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D3820C220D8; Fri, 18 Aug 2017 16:34:02 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id E6216C2210B\n\tfor ; Fri, 18 Aug 2017 16:33:58 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:52943\n\thelo=vpn-10-11-0-14.lan) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dijpB-0007rz-59; Fri, 18 Aug 2017 18:08:41 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich ","To":"David Wu ","In-Reply-To":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","References":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","Message-Id":"","Date":"Fri, 18 Aug 2017 18:08:41 +0200","Cc":"albert.u.boot@aribaud.net, wmc@rock-chips.com, u-boot@lists.denx.de,\n\tDavid Wu ","Subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763290,"web_url":"http://patchwork.ozlabs.org/comment/1763290/","msgid":"","list_archive_url":null,"date":"2017-09-05T12:22:20","subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> Unfortunately, the integrated macphy default is enabled, which will\n> increase power consuming, if we do not use this PHY. So let's disable\n> it at first, which will save power consuming. If we really use it, then\n> enable it in driver level.\n> \n> Signed-off-by: David Wu \n> Reviewed-by: Kever Yang \n> Reviewed-by: Philipp Tomsich \n> Acked-by: Philipp Tomsich \n> ---\n> arch/arm/include/asm/arch-rockchip/grf_rk322x.h | 32 +++++++++++++++++++++++++\n> arch/arm/mach-rockchip/rk322x-board.c | 8 +++++++\n> 2 files changed, 40 insertions(+)\n> \n\nApplied to u-boot-rockchip/next, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmm9t0jLkz9sRm\n\tfor ;\n\tTue, 5 Sep 2017 22:24:34 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C51E5C21DA3; Tue, 5 Sep 2017 12:23:13 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 3EF4DC21D8B;\n\tTue, 5 Sep 2017 12:22:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 653DDC21F78; Tue, 5 Sep 2017 12:22:27 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 900BEC21EFE\n\tfor ; Tue, 5 Sep 2017 12:22:24 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:62039\n\thelo=vpn-10-11-0-14.lan) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dpCs0-0002L7-Ll; Tue, 05 Sep 2017 14:22:20 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich ","To":"David Wu ","In-Reply-To":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","References":"<1502694268-2995-1-git-send-email-david.wu@rock-chips.com>","Message-Id":"","Date":"Tue, 05 Sep 2017 14:22:20 +0200","Cc":"albert.u.boot@aribaud.net, wmc@rock-chips.com, u-boot@lists.denx.de,\n\tDavid Wu ","Subject":"Re: [U-Boot] rockchip: rk322x: Disable integrated macphy for saving\n\tpower consuming","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]