Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/797730/?format=api
{ "id": 797730, "url": "http://patchwork.ozlabs.org/api/1.2/patches/797730/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170804102033.27731-4-dja@axtens.net/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.2/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170804102033.27731-4-dja@axtens.net>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170804102033.27731-4-dja@axtens.net/", "date": "2017-08-04T10:20:33", "name": "[3/3] powerpc: replace vga_fixup() with generic code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "573094910f681f713cd2492f589a6f7e90f3ac7a", "submitter": { "id": 65792, "url": "http://patchwork.ozlabs.org/api/1.2/people/65792/?format=api", "name": "Daniel Axtens", "email": "dja@axtens.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170804102033.27731-4-dja@axtens.net/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/797730/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/797730/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xP36v1RT2z9s8P\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 4 Aug 2017 20:28:39 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xP36v04kmzDqgK\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 4 Aug 2017 20:28:39 +1000 (AEST)", "from mail-wr0-x244.google.com (mail-wr0-x244.google.com\n\t[IPv6:2a00:1450:400c:c0c::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xP2zC73GBzDqJp\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 4 Aug 2017 20:21:59 +1000 (AEST)", "by mail-wr0-x244.google.com with SMTP id g32so2693192wrd.5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 04 Aug 2017 03:21:59 -0700 (PDT)", "from localhost.localdomain (uk.sesame.canonical.com.\n\t[91.189.88.154]) by smtp.gmail.com with ESMTPSA id\n\tg93sm4037467wrd.11.2017.08.04.03.21.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 04 Aug 2017 03:21:56 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"A1iOqtb2\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"A1iOqtb2\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"A1iOqtb2\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ljvN5OwVJMTS/oV/Vtbg3wiSdG+YhKDLm16g+jeE4Ec=;\n\tb=A1iOqtb2iiRbcJ6T5t+JalYsEJkocVCP/q6BUUeWzh64aZ2FvBqpKLyHyNlXYsZAn0\n\t5QL4zK8cqclSaOtixP96XINgibdrYdC9lf0AuZk8yvCCCT12gkltnhCgT84ckb61evER\n\tx22m7cT8xOBfqb7bSeU1HSB1+YUClzmq7L7pk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ljvN5OwVJMTS/oV/Vtbg3wiSdG+YhKDLm16g+jeE4Ec=;\n\tb=lqAzciGHRc9tCLbOY7mN9VcaxtEEmh7X8Wx1RyEaTbIANjlxFgn1vrQBEI6wtaYZN7\n\t4Xq0HJdzM3IkGDCbZglCOiPCGQ6GUyRcsCx/OdH6YP+xtkmOY9aMGuL+WJL9EqWvT4EN\n\tIuwbIxKaTdP+gGCWU4VbYrpQVUJ99cfhoMn1jVhtemDWOg2ZZi9ck1m5fYDQy5vaqN8F\n\txRZkjnsi1DDgKyKxpjUVSrry/D+EB94GsjFw/2wB25H+Rfabr8Ee3GeppISVSpHob36/\n\tbvXyEfjpFeeAEy3ANdmyOwPaLguC/s8j0wMk0QOR2n8TFwMPHaduW0+UUTNK2XOA76P3\n\tUAEw==", "X-Gm-Message-State": "AIVw110tjIpRrEQupkYCYHsvq/7gA+xIspb1hM42DrQWdx7F7G3siJ2u\n\tND2F0nkgcUsKCTC7", "X-Received": "by 10.223.175.212 with SMTP id y20mr1246167wrd.267.1501842117191;\n\tFri, 04 Aug 2017 03:21:57 -0700 (PDT)", "From": "Daniel Axtens <dja@axtens.net>", "To": "linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org", "Subject": "[PATCH 3/3] powerpc: replace vga_fixup() with generic code", "Date": "Fri, 4 Aug 2017 20:20:33 +1000", "Message-Id": "<20170804102033.27731-4-dja@axtens.net>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170804102033.27731-1-dja@axtens.net>", "References": "<20170804102033.27731-1-dja@axtens.net>", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "gabriele.paoloni@huawei.com, airlied@linux.ie,\n\tBrian King <brking@linux.vnet.ibm.com>, will.deacon@arm.com,\n\tz.liuxinliang@hisilicon.com, bhelgaas@google.com,\n\talex.williamson@redhat.com, \n\tcatalin.marinas@arm.com, zourongrong@gmail.com, daniel.vetter@intel.com, \n\tDaniel Axtens <dja@axtens.net>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Currently, we do a PCI fixup to mark a default card so that Xorg\nautoconfiguration works.\n\nThere is a new generic method to do this sort of vga fixup, and\nit occurs by default.\n\nDrop our old method.\n\nThis method is different:\n - it will only mark a card as default if a driver is bound\n - the marking will happen at late_initcall time, or even later\n if a card is enabled later on (via an ENABLE hook). Currently\n things are enabled in a FINAL hook.\n\nThis *does* change behaviour under some circumstances.\n\nFor example, pseries_le_defconfig doesn't have DRM drivers for\nmany of the qemu GPU models, including the 'standard' vga. So\nwhen a VM with that GPU boots, no driver binds the GPU, and\nit does *not* get marked as default. Previously, it would have\nbeen marked as default.\n\nAs it turns out Xorg (at least Xorg v1.19.3) can still\nautoconfigure it, as Xorg is smart about OpenFirmware\nframebuffer devices.\n\nIf the right GPU driver is available, and the OpenFirmware fb\ndriver is removed, the device *is* marked as a boot GPU. (If the\nOpenFirmware driver is around, it enables the PCI device but\ndoesn't bind to it, making it ineligible to be the default card.\nThen, when the right driver is loaded, the enable hook doesn't fire\nbecause the card has already been enabled. Fun!) So everything\nworks as intended, I guess.\n\nCc: Brian King <brking@linux.vnet.ibm.com>\nSigned-off-by: Daniel Axtens <dja@axtens.net>\n\n---\n\nThis would benefit from some tests on real hardware.\n---\n arch/powerpc/kernel/pci-common.c | 16 ----------------\n 1 file changed, 16 deletions(-)", "diff": "diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\nindex 6cfaec107374..65cd5bad5ad6 100644\n--- a/arch/powerpc/kernel/pci-common.c\n+++ b/arch/powerpc/kernel/pci-common.c\n@@ -31,7 +31,6 @@\n #include <linux/irq.h>\n #include <linux/vmalloc.h>\n #include <linux/slab.h>\n-#include <linux/vga_default.h>\n \n #include <asm/processor.h>\n #include <asm/io.h>\n@@ -1741,18 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n }\n DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n-\n-static void fixup_vga(struct pci_dev *pdev)\n-{\n-\tu16 cmd;\n-\n-\tif (vga_default_device())\n-\t\treturn;\n-\n-\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n-\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY))\n-\t\tvga_set_default_device(pdev);\n-\n-}\n-DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n-\t\t\t PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n", "prefixes": [ "3/3" ] }