[{"id":1739927,"web_url":"http://patchwork.ozlabs.org/comment/1739927/","msgid":"<87efsnq217.fsf@concordia.ellerman.id.au>","date":"2017-08-07T07:18:12","subject":"Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Daniel Axtens writes:\n\n> Currently, we do a PCI fixup to mark a default card so that Xorg\n> autoconfiguration works.\n>\n> There is a new generic method to do this sort of vga fixup, and\n> it occurs by default.\n>\n> Drop our old method.\n>\n> This method is different:\n> - it will only mark a card as default if a driver is bound\n> - the marking will happen at late_initcall time, or even later\n> if a card is enabled later on (via an ENABLE hook). Currently\n> things are enabled in a FINAL hook.\n>\n> This *does* change behaviour under some circumstances.\n>\n> For example, pseries_le_defconfig doesn't have DRM drivers for\n> many of the qemu GPU models, including the 'standard' vga.\n\nShould we enable them/it?\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xQpn00wx3z9sR9\n\tfor ;\n\tMon, 7 Aug 2017 17:19:16 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xQpn0084BzDqvG\n\tfor ;\n\tMon, 7 Aug 2017 17:19:16 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xQpln3qY2zDqkF\n\tfor ;\n\tMon, 7 Aug 2017 17:18:13 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xQpln1X46z9s83;\n\tMon, 7 Aug 2017 17:18:13 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Daniel Axtens , linux-pci@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code","In-Reply-To":"<20170804102033.27731-4-dja@axtens.net>","References":"<20170804102033.27731-1-dja@axtens.net>\n\t<20170804102033.27731-4-dja@axtens.net>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Mon, 07 Aug 2017 17:18:12 +1000","Message-ID":"<87efsnq217.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"gabriele.paoloni@huawei.com, airlied@linux.ie, catalin.marinas@arm.com, \n\twill.deacon@arm.com, z.liuxinliang@hisilicon.com, bhelgaas@google.com,\n\talex.williamson@redhat.com, zourongrong@gmail.com,\n\tBrian King , daniel.vetter@intel.com,\n\tDaniel Axtens ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1740977,"web_url":"http://patchwork.ozlabs.org/comment/1740977/","msgid":"<87wp6fq8y5.fsf@linkitivity.dja.id.au>","date":"2017-08-07T23:01:06","subject":"Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Michael Ellerman writes:\n\n> Daniel Axtens writes:\n>\n>> Currently, we do a PCI fixup to mark a default card so that Xorg\n>> autoconfiguration works.\n>>\n>> There is a new generic method to do this sort of vga fixup, and\n>> it occurs by default.\n>>\n>> Drop our old method.\n>>\n>> This method is different:\n>> - it will only mark a card as default if a driver is bound\n>> - the marking will happen at late_initcall time, or even later\n>> if a card is enabled later on (via an ENABLE hook). Currently\n>> things are enabled in a FINAL hook.\n>>\n>> This *does* change behaviour under some circumstances.\n>>\n>> For example, pseries_le_defconfig doesn't have DRM drivers for\n>> many of the qemu GPU models, including the 'standard' vga.\n>\n> Should we enable them/it?\n\nHard to say.\n\nThe 'standard' vga module (bochs_drm) was blacklisted by Ubuntu -\napparently at IBM's request [0] - some years back. Even if you\nun-blacklist it, I had trouble with getting it and the openfirmware\nframebuffer driver to play nicely together. It may not be worth the\ntrouble for bochs_drm.\n\nThere's a better case for including some of the more modern drivers -\nmaybe QXL and virtio - but I wasn't able to test them: my particular\nbuild of qemu/TCG refused to start with them and I didn't feel like\nrebuilding/debugging qemu.\n\nIt would also be legitmate to say that you're focussing on headless use\nwith pseries_*defconfig and not include them: you need to bring in the\nDRM core if you want these drivers.\n\nHTH.\n\nRegards,\nDaniel\n\n[0] https://bugs.launchpad.net/ubuntu/+source/kmod/+bug/1378648\n\n>\n> cheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xRCjp71b8z9sNd\n\tfor ;\n\tTue, 8 Aug 2017 09:02:54 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xRCjp5XWSzDqkX\n\tfor ;\n\tTue, 8 Aug 2017 09:02:54 +1000 (AEST)","from mail-pg0-x241.google.com (mail-pg0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c05::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xRCgt09hPzDqkX\n\tfor ;\n\tTue, 8 Aug 2017 09:01:13 +1000 (AEST)","by mail-pg0-x241.google.com with SMTP id y192so1588552pgd.1\n\tfor ;\n\tMon, 07 Aug 2017 16:01:13 -0700 (PDT)","from localhost (124-171-162-147.dyn.iinet.net.au.\n\t[124.171.162.147]) by smtp.gmail.com with ESMTPSA id\n\ts123sm14804885pgs.2.2017.08.07.16.01.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 07 Aug 2017 16:01:10 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"GcbCp3xz\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"GcbCp3xz\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"GcbCp3xz\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version; bh=wGLjh7RlhEqKde9eVFz26gsLpdzPS/tVYD8D6F+/nNM=;\n\tb=GcbCp3xz/qurOq9w2XV61nOVHNDC/vIohe5i+aocEVNq4dXgntq8T1ta0lXN0iVxWI\n\tW9ukDujz86NS3v7OrqFqRIhOyJzmU60nP9jG+cmUJSc704kIlzGgH6eCYHEwR6KvLJAP\n\tGCfvPs/EsqtLrgjVbILIEeSme+Osir4f/Xxh0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=wGLjh7RlhEqKde9eVFz26gsLpdzPS/tVYD8D6F+/nNM=;\n\tb=jU3pCAdmCPHJ6pBaVHTIYC//UnHKr0jOv5YPrU0eaiwKivzBF02T5gQ6YYRMXNBrG5\n\tLof/aOaqeLecGG1qM7gjmNS+uMdxss8qB+JaahMK+D5PIE+zr1RLwcSMB3TdNkEmW1Rn\n\t1V/1OgSDIejY+q1/A+Pk4wVx8gxRwwHhisrVScgNdaYzDvsCQh7xWxKptZrBB9br0zwg\n\tmE3Ys6K/ulxC1djODHv/QKH1ADMzeJ1QkRj+FT0bY/MRaUtH7h4jANoIU5BgQ5h691TV\n\tXStI3Fx5wMQGSN3yDGEcRut4vIdOyUKzKDEcFSolzvLp5nQAeZ2cMsxC7xejOPF/8YS7\n\tfrTQ==","X-Gm-Message-State":"AHYfb5g2nwFJdxa1Vrx6SMhnl9z2Xx28WtkjcujdLOVd0w/DPxNIMF35\n\tdIZ1bcmr1bzE+eKhs0Wpww==","X-Received":"by 10.98.193.68 with SMTP id i65mr2335714pfg.142.1502146871145; \n\tMon, 07 Aug 2017 16:01:11 -0700 (PDT)","From":"Daniel Axtens ","To":"Michael Ellerman , linux-pci@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code","In-Reply-To":"<87efsnq217.fsf@concordia.ellerman.id.au>","References":"<20170804102033.27731-1-dja@axtens.net>\n\t<20170804102033.27731-4-dja@axtens.net>\n\t<87efsnq217.fsf@concordia.ellerman.id.au>","Date":"Tue, 08 Aug 2017 09:01:06 +1000","Message-ID":"<87wp6fq8y5.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"gabriele.paoloni@huawei.com, airlied@linux.ie, catalin.marinas@arm.com, \n\twill.deacon@arm.com, z.liuxinliang@hisilicon.com, bhelgaas@google.com,\n\talex.williamson@redhat.com, zourongrong@gmail.com,\n\tBrian King , daniel.vetter@intel.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1741347,"web_url":"http://patchwork.ozlabs.org/comment/1741347/","msgid":"<8760dynza0.fsf@concordia.ellerman.id.au>","date":"2017-08-08T10:12:55","subject":"Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Daniel Axtens writes:\n\n> Michael Ellerman writes:\n>\n>> Daniel Axtens writes:\n>>\n>>> Currently, we do a PCI fixup to mark a default card so that Xorg\n>>> autoconfiguration works.\n>>>\n>>> There is a new generic method to do this sort of vga fixup, and\n>>> it occurs by default.\n>>>\n>>> Drop our old method.\n>>>\n>>> This method is different:\n>>> - it will only mark a card as default if a driver is bound\n>>> - the marking will happen at late_initcall time, or even later\n>>> if a card is enabled later on (via an ENABLE hook). Currently\n>>> things are enabled in a FINAL hook.\n>>>\n>>> This *does* change behaviour under some circumstances.\n>>>\n>>> For example, pseries_le_defconfig doesn't have DRM drivers for\n>>> many of the qemu GPU models, including the 'standard' vga.\n>>\n>> Should we enable them/it?\n>\n> Hard to say.\n>\n> The 'standard' vga module (bochs_drm) was blacklisted by Ubuntu -\n> apparently at IBM's request [0] - some years back. Even if you\n> un-blacklist it, I had trouble with getting it and the openfirmware\n> framebuffer driver to play nicely together. It may not be worth the\n> trouble for bochs_drm.\n>\n> There's a better case for including some of the more modern drivers -\n> maybe QXL and virtio - but I wasn't able to test them: my particular\n> build of qemu/TCG refused to start with them and I didn't feel like\n> rebuilding/debugging qemu.\n\nYeah OK. Sounds like a bit of mess :)\n\nI'll leave it unless someone who knows Qemu/Gfx etc. tells me otherwise.\n\n> It would also be legitmate to say that you're focussing on headless use\n> with pseries_*defconfig and not include them: you need to bring in the\n> DRM core if you want these drivers.\n\nTrue. There's a bit of a tension there between making them useful\nconfigs for developers and also turning on as much code as possible so\nit gets tested.\n\nArguably we should have DRM enabled because the distros will.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xRVc70syvz9ryv\n\tfor ;\n\tTue, 8 Aug 2017 20:13:59 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xRVc703r8zDr3x\n\tfor ;\n\tTue, 8 Aug 2017 20:13:59 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xRVZw2s5gzDqp9\n\tfor ;\n\tTue, 8 Aug 2017 20:12:56 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xRVZw0QpBz9s72;\n\tTue, 8 Aug 2017 20:12:56 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Daniel Axtens , linux-pci@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code","In-Reply-To":"<87wp6fq8y5.fsf@linkitivity.dja.id.au>","References":"<20170804102033.27731-1-dja@axtens.net>\n\t<20170804102033.27731-4-dja@axtens.net>\n\t<87efsnq217.fsf@concordia.ellerman.id.au>\n\t<87wp6fq8y5.fsf@linkitivity.dja.id.au>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Tue, 08 Aug 2017 20:12:55 +1000","Message-ID":"<8760dynza0.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"gabriele.paoloni@huawei.com, airlied@linux.ie, catalin.marinas@arm.com, \n\twill.deacon@arm.com, z.liuxinliang@hisilicon.com, bhelgaas@google.com,\n\talex.williamson@redhat.com, zourongrong@gmail.com,\n\tBrian King , daniel.vetter@intel.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]