Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2235112/?format=api
{ "id": 2235112, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2235112/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-3-bcbec96357d9@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508-mips-octeon-missing-insns-v2-v3-3-bcbec96357d9@gmail.com>", "list_archive_url": null, "date": "2026-05-08T15:12:03", "name": "[v3,03/32] linux-user/mips, target/mips: honor MIPS_FIXADE for unaligned accesses", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4eb14b67ebd5c07aa50750f1de0f965a5524dea8", "submitter": { "id": 66301, "url": "http://patchwork.ozlabs.org/api/1.2/people/66301/?format=api", "name": "James Hilliard", "email": "james.hilliard1@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-3-bcbec96357d9@gmail.com/mbox/", "series": [ { "id": 503407, "url": "http://patchwork.ozlabs.org/api/1.2/series/503407/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503407", "date": "2026-05-08T15:12:00", "name": "target/mips: add missing Octeon user-mode support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/503407/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2235112/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2235112/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FscgSS2/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBt652k7hz1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 01:17:49 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wLMtA-0002fX-TH; Fri, 08 May 2026 11:13:18 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <james.hilliard1@gmail.com>)\n id 1wLMsz-0002bt-IP\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:08 -0400", "from mail-oa1-x36.google.com ([2001:4860:4864:20::36])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <james.hilliard1@gmail.com>)\n id 1wLMsw-0001by-Jl\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:04 -0400", "by mail-oa1-x36.google.com with SMTP id\n 586e51a60fabf-4042905015cso1611163fac.0\n for <qemu-devel@nongnu.org>; Fri, 08 May 2026 08:13:02 -0700 (PDT)", "from\n 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa\n (71-218-113-237.hlrn.qwest.net. [71.218.113.237])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-43557109b7dsm1897904fac.5.2026.05.08.08.13.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 08:13:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778253181; x=1778857981; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=LG3xb3bJPuwpo/t13YICuUERFJUEl2UkU1tw9cyZ50c=;\n b=FscgSS2/o9T4y8y6Z8fkocqCPKAMqZveE00QJhwBO0L/dS4bxwP4EfDAVfmbSa6mzc\n w9XafP+UfcU2WzoIjHmUcul67fzDSWVuRujAHtDjW/qdoLuniS7SZ5yLOkPHOqIjUpLL\n Dar4xyH/guryVf5X9hUK0oT7lhyxjJ/Rm6qAL5aI0+LVzeRDlsyAHTmErgxhAGMttM13\n Po/D6VqsUv4Th2YByvkut2OZLZ/DzBArehscUp7vON4SCNRoJso2VgNeHjNbPo12A3cu\n VzwFmP2cDNE1GwNbwwmWQw296LGm3yIPH1jzsH/RzNxw/MYACHVd8Ie/KUeZkyjv0dtK\n YgLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778253181; x=1778857981;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=LG3xb3bJPuwpo/t13YICuUERFJUEl2UkU1tw9cyZ50c=;\n b=oW7jbDNZu5YFUTy1ZrguLo1kKPzkB0iQVoeolFrhsWahtd6ulBJS+0JEl23keRHAqa\n s9O7m65dVS/f31QOdLzhE6j7Y0b9ryAcPsMH+vsqvHZ7Hp4OJAjZViUu6MXd1UhcFfkj\n w3/0zuZpgSlP1IBsMLUlbSv9CIOGTrYWUtuVE0mSchNXC/D2KVk5jzRbz/cinE5Yx+7T\n jhIFno2pzRzsEAxBFuwwsHhIdaZCZ565GbPdNIjFrFJ8MdkELe5E4jEPiIeImonw/Bo1\n bLdEz8H0laGwnUdWYxn5adpgZyg4UyuENE6mNBj59hq4NbF8ELBsR/5FZOyv1R3+BKFC\n Ighg==", "X-Gm-Message-State": "AOJu0Yx9q49NpkwIUn2kR6FZLvnkrJ+3awuakzN7ONLL6C3TerVYcgQX\n bwto12G3DoqYhZP6MwPFf6BdWXmHk7Ay0ElSvAX6Of13lHVmwqOBgFoHJ7TRXQ==", "X-Gm-Gg": "Acq92OGe781TiQNLEd0c8uOJE76bQX4pS7f7OUffISRW1MyG8DhiKdFsvjUjW4vjdKK\n PTcYPP+cegPdJReGF/xhEWWSKRK3lPR3S6ZVaykvbxCPQg0S91WbUWexcIgXwFJIVwxmkoQi3E4\n 1fANZscYGFaer1H13UyEYMNE1eW0MsWw0HpvrYAcWbW8ctum8e/VbAU/RV7hFDu89OoNi63r0gN\n TkJFJetbfuZ7nYqIu7NCyUF+Igtsg7XvEYRDPtHBF1oRiepGv61W70KGUBv5OIxDqEFI9KLnmae\n fcwjdFBg2W5lNO4F96dhJtaYm5Fd6W3Kiu3IyIHp2Ns/z/XZeVNDPTcze4ecdOutO+6wab0j4iV\n hWqaxiRGcY4ruC/zV8QhOT7uxtdNJ0z0bqFfWUJmGatG82L3NyvGZHVTLn7XRV939SzZIAPr8a2\n IKu4fxIXSVObnGrXquAGgn1Xjiif3E5oxUlRPycnErd8p3BxWxgEczKdDfNlSC39Oc38m5ltpsK\n pUsM1ULnblLIlmo1qxvY+K1en1Io7juYJTqor5PoRNxsTMgzFIBcPjTa/L9GR8WtiRzAOpeWz65\n bhLwFTGXGeEjaKugbZJhMD84cfObb89a6uH/ObGfyJxHOnqodCTDA8aH0KVPeL4vt2xSSoLSMcK\n Egl0dJA==", "X-Received": "by 2002:a05:6870:c2a2:b0:42c:61b:28e5 with SMTP id\n 586e51a60fabf-434f64e942fmr8551273fac.19.1778253181074;\n Fri, 08 May 2026 08:13:01 -0700 (PDT)", "From": "James Hilliard <james.hilliard1@gmail.com>", "Date": "Fri, 08 May 2026 09:12:03 -0600", "Subject": "[PATCH v3 03/32] linux-user/mips, target/mips: honor MIPS_FIXADE\n for unaligned accesses", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "\n <20260508-mips-octeon-missing-insns-v2-v3-3-bcbec96357d9@gmail.com>", "References": "\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>", "In-Reply-To": "\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Laurent Vivier <laurent@vivier.eu>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Aurelien Jarno <aurelien@aurel32.net>,\n Jiaxun Yang <jiaxun.yang@flygoat.com>,\n Aleksandar Rikalo <arikalo@gmail.com>, Huacai Chen <chenhuacai@kernel.org>,\n James Hilliard <james.hilliard1@gmail.com>, Helge Deller <deller@gmx.de>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>", "X-Mailer": "b4 0.15.2", "Received-SPF": "pass client-ip=2001:4860:4864:20::36;\n envelope-from=james.hilliard1@gmail.com; helo=mail-oa1-x36.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Linux/MIPS enables software fixups for user-mode unaligned scalar\naccesses by default through MIPS_FIXADE/TIF_FIXADE. QEMU linux-user did\nnot model that ABI, so MIPS guests took fatal AdEL/AdES exceptions unless\ntranslation was forced to use unaligned host accesses.\n\nKey MIPS translation blocks on the linux-user unaligned policy, implement\nsysmips(MIPS_FIXADE) to toggle that policy, and raise SIGBUS/BUS_ADRALN\nwhen fixups are disabled.\n\nSigned-off-by: James Hilliard <james.hilliard1@gmail.com>\n---\nChanges v2 -> v3:\n - Split MIPS_FLUSH_CACHE and MIPS_ATOMIC_SET into preparatory sysmips\n patches. (suggested by Richard Henderson)\n---\n linux-user/mips/cpu_loop.c | 5 +++++\n linux-user/mips/target_syscall.h | 1 +\n linux-user/mips64/target_syscall.h | 1 +\n linux-user/syscall.c | 8 ++++++++\n target/mips/cpu.c | 8 ++++++--\n target/mips/cpu.h | 4 ++++\n target/mips/tcg/translate.c | 6 +++++-\n 7 files changed, 30 insertions(+), 3 deletions(-)", "diff": "diff --git a/linux-user/mips/cpu_loop.c b/linux-user/mips/cpu_loop.c\nindex fa264b27ec..ff9d293c29 100644\n--- a/linux-user/mips/cpu_loop.c\n+++ b/linux-user/mips/cpu_loop.c\n@@ -161,6 +161,11 @@ done_syscall:\n case EXCP_DSPDIS:\n force_sig(TARGET_SIGILL);\n break;\n+ case EXCP_AdEL:\n+ case EXCP_AdES:\n+ force_sig_fault(TARGET_SIGBUS, TARGET_BUS_ADRALN,\n+ env->CP0_BadVAddr);\n+ break;\n case EXCP_INTERRUPT:\n /* just indicate that signals should be handled asap */\n break;\ndiff --git a/linux-user/mips/target_syscall.h b/linux-user/mips/target_syscall.h\nindex 9206694f4f..be6942445a 100644\n--- a/linux-user/mips/target_syscall.h\n+++ b/linux-user/mips/target_syscall.h\n@@ -11,6 +11,7 @@\n \n #define TARGET_FORCE_SHMLBA\n #define TARGET_SYSMIPS_FLUSH_CACHE 3\n+#define TARGET_SYSMIPS_FIXADE 7\n #define TARGET_SYSMIPS_ATOMIC_SET 2001\n \n static inline abi_ulong target_shmlba(CPUMIPSState *env)\ndiff --git a/linux-user/mips64/target_syscall.h b/linux-user/mips64/target_syscall.h\nindex e07687f8ac..c11d0a0888 100644\n--- a/linux-user/mips64/target_syscall.h\n+++ b/linux-user/mips64/target_syscall.h\n@@ -11,6 +11,7 @@\n \n #define TARGET_FORCE_SHMLBA\n #define TARGET_SYSMIPS_FLUSH_CACHE 3\n+#define TARGET_SYSMIPS_FIXADE 7\n #define TARGET_SYSMIPS_ATOMIC_SET 2001\n \n static inline abi_ulong target_shmlba(CPUMIPSState *env)\ndiff --git a/linux-user/syscall.c b/linux-user/syscall.c\nindex 3786a34041..551caa8e7c 100644\n--- a/linux-user/syscall.c\n+++ b/linux-user/syscall.c\n@@ -6663,9 +6663,17 @@ static abi_long do_sysmips_atomic_set(CPUArchState *env, abi_ulong addr,\n static abi_long do_sysmips(CPUArchState *env, abi_long cmd, abi_long arg1,\n abi_long arg2)\n {\n+ CPUState *cs = env_cpu(env);\n+\n switch (cmd) {\n case TARGET_SYSMIPS_ATOMIC_SET:\n return do_sysmips_atomic_set(env, arg1, arg2);\n+ case TARGET_SYSMIPS_FIXADE:\n+ if (arg1 & ~3) {\n+ return -TARGET_EINVAL;\n+ }\n+ cs->prctl_unalign_sigbus = !(arg1 & 1);\n+ return 0;\n case TARGET_SYSMIPS_FLUSH_CACHE:\n return 0;\n default:\ndiff --git a/target/mips/cpu.c b/target/mips/cpu.c\nindex f803d47763..19001d829c 100644\n--- a/target/mips/cpu.c\n+++ b/target/mips/cpu.c\n@@ -565,11 +565,15 @@ static int mips_cpu_mmu_index(CPUState *cs, bool ifunc)\n static TCGTBCPUState mips_get_tb_cpu_state(CPUState *cs)\n {\n CPUMIPSState *env = cpu_env(cs);\n+ uint32_t flags = env->hflags & MIPS_HFLAG_TB_MASK;\n+\n+#ifdef CONFIG_USER_ONLY\n+ flags |= TB_FLAG_UNALIGN * !cs->prctl_unalign_sigbus;\n+#endif\n \n return (TCGTBCPUState){\n .pc = env->active_tc.PC,\n- .flags = env->hflags & (MIPS_HFLAG_TMASK | MIPS_HFLAG_BMASK |\n- MIPS_HFLAG_HWRENA_ULR),\n+ .flags = flags,\n };\n }\n \ndiff --git a/target/mips/cpu.h b/target/mips/cpu.h\nindex cbb9b3e1b1..84d12b77f9 100644\n--- a/target/mips/cpu.h\n+++ b/target/mips/cpu.h\n@@ -1161,6 +1161,10 @@ typedef struct CPUArchState {\n #define MIPS_HFLAG_ELPA 0x4000000\n #define MIPS_HFLAG_ITC_CACHE 0x8000000 /* CACHE instr. operates on ITC tag */\n #define MIPS_HFLAG_ERL 0x10000000 /* error level flag */\n+#define MIPS_HFLAG_TB_MASK (MIPS_HFLAG_TMASK | MIPS_HFLAG_BMASK | \\\n+ MIPS_HFLAG_HWRENA_ULR)\n+\n+#define TB_FLAG_UNALIGN 0x40000000\n target_ulong btarget; /* Jump / branch target */\n target_ulong bcond; /* Branch condition (if needed) */\n \ndiff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c\nindex 54ed253a7d..cd6dc34176 100644\n--- a/target/mips/tcg/translate.c\n+++ b/target/mips/tcg/translate.c\n@@ -15070,6 +15070,7 @@ static void mips_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)\n {\n DisasContext *ctx = container_of(dcbase, DisasContext, base);\n CPUMIPSState *env = cpu_env(cs);\n+ uint32_t tb_flags = ctx->base.tb->flags;\n \n ctx->page_start = ctx->base.pc_first & TARGET_PAGE_MASK;\n ctx->saved_pc = -1;\n@@ -15092,7 +15093,7 @@ static void mips_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)\n ctx->CP0_LLAddr_shift = env->CP0_LLAddr_shift;\n ctx->cmgcr = (env->CP0_Config3 >> CP0C3_CMGCR) & 1;\n /* Restore delay slot state from the tb context. */\n- ctx->hflags = (uint32_t)ctx->base.tb->flags; /* FIXME: maybe use 64 bits? */\n+ ctx->hflags = tb_flags & MIPS_HFLAG_TB_MASK;\n ctx->ulri = (env->CP0_Config3 >> CP0C3_ULRI) & 1;\n ctx->ps = ((env->active_fpu.fcr0 >> FCR0_PS) & 1) ||\n (env->insn_flags & (INSN_LOONGSON2E | INSN_LOONGSON2F));\n@@ -15112,6 +15113,9 @@ static void mips_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)\n ctx->default_tcg_memop_mask = (!(ctx->insn_flags & ISA_NANOMIPS32) &&\n (ctx->insn_flags & (ISA_MIPS_R6 |\n INSN_LOONGSON3A))) ? MO_UNALN : MO_ALIGN;\n+ if (tb_flags & TB_FLAG_UNALIGN) {\n+ ctx->default_tcg_memop_mask = MO_UNALN;\n+ }\n \n /*\n * Execute a branch and its delay slot as a single instruction.\n", "prefixes": [ "v3", "03/32" ] }