[{"id":3688620,"web_url":"http://patchwork.ozlabs.org/comment/3688620/","msgid":"<36a1030a-e248-48be-b1f5-fb9d5836716b@linaro.org>","list_archive_url":null,"date":"2026-05-08T17:17:34","subject":"Re: [PATCH v3 03/32] linux-user/mips, target/mips: honor MIPS_FIXADE\n for unaligned accesses","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 10:12, James Hilliard wrote:\n> Linux/MIPS enables software fixups for user-mode unaligned scalar\n> accesses by default through MIPS_FIXADE/TIF_FIXADE. QEMU linux-user did\n> not model that ABI, so MIPS guests took fatal AdEL/AdES exceptions unless\n> translation was forced to use unaligned host accesses.\n> \n> Key MIPS translation blocks on the linux-user unaligned policy, implement\n> sysmips(MIPS_FIXADE) to toggle that policy, and raise SIGBUS/BUS_ADRALN\n> when fixups are disabled.\n> \n> Signed-off-by: James Hilliard\n> ---\n> Changes v2 -> v3:\n> - Split MIPS_FLUSH_CACHE and MIPS_ATOMIC_SET into preparatory sysmips\n> patches. (suggested by Richard Henderson)\n> ---\n> linux-user/mips/cpu_loop.c | 5 +++++\n> linux-user/mips/target_syscall.h | 1 +\n> linux-user/mips64/target_syscall.h | 1 +\n> linux-user/syscall.c | 8 ++++++++\n> target/mips/cpu.c | 8 ++++++--\n> target/mips/cpu.h | 4 ++++\n> target/mips/tcg/translate.c | 6 +++++-\n> 7 files changed, 30 insertions(+), 3 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eFn5nebF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBwn810g5z1yKd\n\tfor ; Sat, 09 May 2026 03:18:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLOpZ-0004qP-6P; Fri, 08 May 2026 13:17:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLOpY-0004px-3K\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:17:40 -0400","from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLOpW-0001O8-G5\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:17:39 -0400","by mail-oi1-x235.google.com with SMTP id\n 5614622812f47-466ec4c6846so859961b6e.3\n for ; Fri, 08 May 2026 10:17:37 -0700 (PDT)","from ?IPV6:2600:381:c938:6375:4b0a:aabe:cbe1:bd0c?\n ([2600:381:c938:6375:4b0a:aabe:cbe1:bd0c])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-4355736dbc0sm2281020fac.11.2026.05.08.10.17.35\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 10:17:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778260657; x=1778865457; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=kdKFsvptNMdDFxTJJA4MYZmwQKuq5ymwV+3pP7fpmN4=;\n b=eFn5nebFJHx8CnEP9M8OeaLzHKEUIXHOn8/pwZY17HH9yS+kewyK9U8K2ZC6JGh5RD\n OLZwOGCNg3syqH5DEu4GYZRDAK75lwG5Ze5OwTb/CQ1mFlzcaGeXqt+FKD3jRpMvQPsK\n zf3mpfbQQ2i3J59uMQ1tK++4TLx9sfDejnUHSx9uDQ4iB1091ZZNDQDQQpJxvbeiMs95\n XcfG0CjDVq6G3qhMFWazDsiN5sC98eyacJB/rd+HVjtQ6aFTmqm6nJzl0vObmfmaz1YD\n 6EBrSrUwxP6u+GvvBJDkKY7MTIl98lCkNMJ4E0LmE3qPIBq7INKL9eHd9nRGHn1OSVqP\n OW7g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778260657; x=1778865457;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=kdKFsvptNMdDFxTJJA4MYZmwQKuq5ymwV+3pP7fpmN4=;\n b=YCveeluKtmXiHwsEMmp2qOot/uz/mIk1j8G3RmzD8ydVLOKi6BLEZXWDcdOb6Uapmq\n WHhGbPGE2s2VybECs8TxG1BlFDMmm6h91UbTpNh1bswOgNlh/FnBUrX+8t0HaFaAStzF\n E/df3LlCjxo0MG8pHqrYTqV4wlcwLqywJ0T8ZndVTnBRLZac5VGatmtiAmmRoFc0APwq\n Tj1x6a4fh8zvADEgEhUryajGOzhltgypYUSXHkp/tUV61kKsLbjWhj7037GtG8+6cr7k\n JYJ+/yTh69I7//3rrnTAx8j8O+xYJqRdtuPS1ob8mHZBrDN5agqZQGDe5n7G53CZ/T1R\n yjwQ==","X-Gm-Message-State":"AOJu0YxrjhouoK3r32tXLrbq8xSZIybajmDWm6mXR7eKF6m/HgHcJ40F\n QU9gTkHw4lyXm54FKSGKXeWAbkSwmKyETpYWiHQDTxq/FX6tmYqy6Uo1ARGRpsxc/n1yp1jPz2o\n NYMVJ","X-Gm-Gg":"AeBDievJudhTa1NwO7PYimwndVI5PJB0k34rlHhXiIe2xIhzZSeq1Jb7HPoi+sQ00l5\n t/SpB45pIgCgbivph89Ozc1HQ2ECW0hcW9E1kVOyVL0Km0LmmmSIziTrSYOUfPK2Xyi4ilBA5Cn\n YmvkGcB+6B+kYiuVp9PGace02yXhi69aJfK7tVUYFE+6CeCkqTRjmej84NJB4crrAez0LLP9t5w\n JNwfZeE+UwptKUVDUbY1viK6N1TqCvt6pEJ95wCSV2L6b9NmK5nqMgCDFsUe9/NdEJDMeMvipkD\n qik8kI3rQyjwJHcK/fbOSLQPYe2gv0vcckUgIY+2b8rncJS9kgGPz1+wt+njGN4rOjRWkFGx2a9\n MFVvsPOdyrcqt3ukdTjQaptUE+7ds40RD8lxgm2PKyimFUCzUWHgWuYpp9a8AwgM11trGcsWvZ6\n an5LmXXSnDlDZ+joyBHf1E7w9JNCfoFYsC8wCvb3YP0ePkY9UvsmzALtEDkpyXVQEp+EYj4W8UI\n +RwyjfpgA==","X-Received":"by 2002:a05:6808:300c:b0:47b:bd7b:10de with SMTP id\n 5614622812f47-480420dcf12mr7482244b6e.7.1778260656760;\n Fri, 08 May 2026 10:17:36 -0700 (PDT)","Message-ID":"<36a1030a-e248-48be-b1f5-fb9d5836716b@linaro.org>","Date":"Fri, 8 May 2026 12:17:34 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 03/32] linux-user/mips, target/mips: honor MIPS_FIXADE\n for unaligned accesses","To":"qemu-devel@nongnu.org","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>\n <20260508-mips-octeon-missing-insns-v2-v3-3-bcbec96357d9@gmail.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-3-bcbec96357d9@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::235;\n envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x235.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]