Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2235111/?format=api
{ "id": 2235111, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2235111/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-11-bcbec96357d9@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508-mips-octeon-missing-insns-v2-v3-11-bcbec96357d9@gmail.com>", "list_archive_url": null, "date": "2026-05-08T15:12:11", "name": "[v3,11/32] target/mips: add Octeon SAA instruction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2e932f55a66c77697f813899367f89e6649ab71d", "submitter": { "id": 66301, "url": "http://patchwork.ozlabs.org/api/1.2/people/66301/?format=api", "name": "James Hilliard", "email": "james.hilliard1@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-11-bcbec96357d9@gmail.com/mbox/", "series": [ { "id": 503407, "url": "http://patchwork.ozlabs.org/api/1.2/series/503407/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503407", "date": "2026-05-08T15:12:00", "name": "target/mips: add missing Octeon user-mode support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/503407/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2235111/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2235111/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=EoSVpMyD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBt634q0Sz1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 01:17:47 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wLMtO-0002iI-7O; Fri, 08 May 2026 11:13:30 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <james.hilliard1@gmail.com>)\n id 1wLMt7-0002el-91\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:14 -0400", "from mail-oa1-x33.google.com ([2001:4860:4864:20::33])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <james.hilliard1@gmail.com>)\n id 1wLMt4-0001gb-R8\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:12 -0400", "by mail-oa1-x33.google.com with SMTP id\n 586e51a60fabf-42c0b0ffac1so1216936fac.2\n for <qemu-devel@nongnu.org>; Fri, 08 May 2026 08:13:10 -0700 (PDT)", "from\n 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa\n (71-218-113-237.hlrn.qwest.net. [71.218.113.237])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-43557109b7dsm1897904fac.5.2026.05.08.08.13.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 08:13:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778253189; x=1778857989; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=7+lYBCp3Rm8qO6ote7GQN5rQY0LcgGtx5r0KxlL36s4=;\n b=EoSVpMyD6rUW0BTq9RCD6l99RWdtEpps2khBLdSTCvwojnnicupHacbaejUV59Sgiz\n qD3t2CnUUIZjyaLQgTR0lBbu5ax/YkWm59QIyOYzb1uy7/PL/VHQYpjF8ISFf4K8NSCR\n Jc9vzRs4DKZlYI4YTogo8fOVAudVU/svg8Qgb+6Taq+mtHEKyCrceuK6whk5W4kTx/Gh\n qJUW/zGIM4xoj0tcGNWl2Ycj9OTIto+IfpsojlByBl0txdIhgZTnnAivSXKD7hmJnqib\n YMxokTxyOdkhQ7pf6Nm959kvjHrN3DNLOa8lgbh333OB6Lqnae/vuWFbk18ldt77ddDt\n zH5w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778253189; x=1778857989;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=7+lYBCp3Rm8qO6ote7GQN5rQY0LcgGtx5r0KxlL36s4=;\n b=AoEyhNjOTQ4hhy/E+Wb4qBD3T7yJ1qhEP/ravji6B0X27NtriHn+WJgiLaa52qHl8F\n Qganrzji/T+/+6VFqmQRi9eDThsJLtoDbokfKNvzfpJ5WOxQrGl5/6oZYC9bpDeMmn3N\n lRPaZ/VXbNkmxm/AYn8WDdqK2kK2dlZ80mzFc/M1ekExOqNB8QMW7k5p4+z5xIMrAhqS\n whMqFSFkmk+dGWnnybKl56tEHqgsBYiuxT5vma8G4dxeVSWyx9gw1NE81eKHDOp7zf1v\n ZCY2j4uEx0T98TZFZLCKVQY8UBmuHXLHDdIkXDK+Eg5VgKoYksTA15g9WnTm37z61eWK\n +oRQ==", "X-Gm-Message-State": "AOJu0YznnAvjOI34zxCtiNcgTLqCCTsIN9sAVjny2nAOUtUoiY50XKEa\n RySRt3z2Nv66BfIS2/SVGyJyHcedXT9gRmV46u61KWDoQZfeVFToCJPES1XclA==", "X-Gm-Gg": "AeBDievFl7UmZ05giic5n2PSyOZZdxyMx1DgtAkCbX58OCmkCeD5FlqPOVW8KLgHMlZ\n 1RKHEyXKfgQ3n0BNx6UM1L5qC2as9DnPGUmITc7ZlD7gE05LsPlpgGYPboLQmmbl1HWGNh66p+P\n 7UKUVSJ9l/bGoQ2uIov9Mo4bQmMKF6jxnPYIiOAiqoimbQTZTzgHq0eYQMPeXGrujZRVEVYyFGf\n 54CxOEdfId3ofX4lIbsmQKOqyQd0ofBoDs9v+ISDozNSvuqKd40NBbazc3OJhsPf1Mz7Z9gc5fz\n vgEEplwaqWogUjHTmGidT3RZ5WM8rtn/9+cl5qOn6ovcEQ1iFHlfom0lCo2MQuqCBhv/8z5GUfv\n VtpKiM9JnHSIRCYTBMNY/rF77qy2ZgKQsSJwBRnu/m+lhFA0ewPAdilS6qtv6RMZVShav00Jm03\n S0RjvH3+vYc0HlK9hl5NjKjoAiBP8UYqJLC3Ld5W1hIjNBgJwiIPzQ+vrT5JoC5TGJgKyyFC2Ms\n MiHpiCmzgrxQ5w5rQ1zFHG0Wf64+XFUCIOxfj/r0vi0pGu6v41Fy7DOhmerNGnjuvNQorV1dTiY\n grN2BvdaBy6lZrzkUjFgBX+thbNLpDzsrr+ZTFHI/jSWJH0OiVomVSSyCuYwpajp/UhFyxM=", "X-Received": "by 2002:a05:6808:181a:b0:479:faf5:ef4c with SMTP id\n 5614622812f47-480424d65eemr7902619b6e.32.1778253189039;\n Fri, 08 May 2026 08:13:09 -0700 (PDT)", "From": "James Hilliard <james.hilliard1@gmail.com>", "Date": "Fri, 08 May 2026 09:12:11 -0600", "Subject": "[PATCH v3 11/32] target/mips: add Octeon SAA instruction", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "\n <20260508-mips-octeon-missing-insns-v2-v3-11-bcbec96357d9@gmail.com>", "References": "\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>", "In-Reply-To": "\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Laurent Vivier <laurent@vivier.eu>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Aurelien Jarno <aurelien@aurel32.net>,\n Jiaxun Yang <jiaxun.yang@flygoat.com>,\n Aleksandar Rikalo <arikalo@gmail.com>, Huacai Chen <chenhuacai@kernel.org>,\n James Hilliard <james.hilliard1@gmail.com>, Helge Deller <deller@gmx.de>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>", "X-Mailer": "b4 0.15.2", "Received-SPF": "pass client-ip=2001:4860:4864:20::33;\n envelope-from=james.hilliard1@gmail.com; helo=mail-oa1-x33.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "SAA atomically adds rt to the naturally aligned 32-bit word at base and\ndiscards the old memory value.\n\nImplement it with TCG atomic_fetch_add_i32 using Octeon L2 transaction\nalignment semantics.\n\nSigned-off-by: James Hilliard <james.hilliard1@gmail.com>\n---\nChanges v2 -> v3:\n - Split SAA out of the combined Octeon arithmetic and memory\n instruction patch. (requested by Richard Henderson)\n---\n target/mips/tcg/octeon.decode | 4 ++++\n target/mips/tcg/octeon_translate.c | 27 +++++++++++++++++++++++++++\n 2 files changed, 31 insertions(+)", "diff": "diff --git a/target/mips/tcg/octeon.decode b/target/mips/tcg/octeon.decode\nindex db7d5f55f0..d6b241de42 100644\n--- a/target/mips/tcg/octeon.decode\n+++ b/target/mips/tcg/octeon.decode\n@@ -44,6 +44,10 @@ SNE 011100 ..... ..... ..... 00000 101011 @r3\n SEQI 011100 rs:5 rt:5 imm:s10 101110 &cmpi\n SNEI 011100 rs:5 rt:5 imm:s10 101111 &cmpi\n \n+&saa base rt\n+@saa ...... base:5 rt:5 ................ &saa\n+SAA 011100 ..... ..... 00000 00000 011000 @saa\n+\n &lx base index rd\n @lx ...... base:5 index:5 rd:5 ...... ..... &lx\n LWX 011111 ..... ..... ..... 00000 001010 @lx\ndiff --git a/target/mips/tcg/octeon_translate.c b/target/mips/tcg/octeon_translate.c\nindex c93eff59a5..19535768d2 100644\n--- a/target/mips/tcg/octeon_translate.c\n+++ b/target/mips/tcg/octeon_translate.c\n@@ -161,6 +161,33 @@ static bool trans_lx(DisasContext *ctx, arg_lx *a, MemOp mop)\n return true;\n }\n \n+static bool trans_saa(DisasContext *ctx, arg_saa *a, MemOp mop)\n+{\n+ TCGv_i64 addr = tcg_temp_new_i64();\n+ MemOp amo = mo_endian(ctx) | mop | MO_ALIGN;\n+\n+ gen_base_offset_addr(ctx, addr, a->base, 0);\n+\n+ if (mop == MO_UQ) {\n+ TCGv_i64 value = tcg_temp_new_i64();\n+ TCGv_i64 old = tcg_temp_new_i64();\n+\n+ gen_load_gpr(value, a->rt);\n+ tcg_gen_atomic_fetch_add_i64(old, addr, value, ctx->mem_idx, amo);\n+ } else {\n+ TCGv_i64 value = tcg_temp_new_i64();\n+ TCGv_i32 value32 = tcg_temp_new_i32();\n+ TCGv_i32 old = tcg_temp_new_i32();\n+\n+ gen_load_gpr(value, a->rt);\n+ tcg_gen_extrl_i64_i32(value32, value);\n+ tcg_gen_atomic_fetch_add_i32(old, addr, value32, ctx->mem_idx, amo);\n+ }\n+\n+ return true;\n+}\n+\n+TRANS(SAA, trans_saa, MO_UL);\n TRANS(LBX, trans_lx, MO_SB);\n TRANS(LBUX, trans_lx, MO_UB);\n TRANS(LHX, trans_lx, MO_SW);\n", "prefixes": [ "v3", "11/32" ] }