Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2224235/?format=api
{ "id": 2224235, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2224235/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417062954.1241900-3-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.2/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260417062954.1241900-3-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-04-17T06:29:52", "name": "[iwl-net,2/4] ice: fix autoneg disable when link partner doesn't support AN", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "c2ddc6e475391376121767a6c97ec0b9ddbea91d", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.2/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/1.2/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417062954.1241900-3-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 500242, "url": "http://patchwork.ozlabs.org/api/1.2/series/500242/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500242", "date": "2026-04-17T06:29:50", "name": "ice: fixes for pause reporting, autoneg, RDMA and EIPE", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500242/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224235/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224235/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5W34lU6x;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxlNx0NC0z1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 16:30:09 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 932C7608F8;\n\tFri, 17 Apr 2026 06:30:05 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id us1ewpwH5J3f; Fri, 17 Apr 2026 06:30:03 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id A7CCF60BFF;\n\tFri, 17 Apr 2026 06:30:03 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 17091396\n for <intel-wired-lan@lists.osuosl.org>; Fri, 17 Apr 2026 06:30:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 08D9040544\n for <intel-wired-lan@lists.osuosl.org>; Fri, 17 Apr 2026 06:30:02 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id GSC74mQyhk_W for <intel-wired-lan@lists.osuosl.org>;\n Fri, 17 Apr 2026 06:30:01 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B2C7640549\n for <intel-wired-lan@lists.osuosl.org>; Fri, 17 Apr 2026 06:30:00 +0000 (UTC)", "from orviesa004.jf.intel.com ([10.64.159.144])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2026 23:30:00 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa004.jf.intel.com with ESMTP; 16 Apr 2026 23:29:59 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org A7CCF60BFF", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org B2C7640549" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776407403;\n\tbh=BAVdXEdc+kEMMK5GDr62Q5KNVz2Hir6sxQPRqGYxj9Y=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=5W34lU6xHjY/BatTxxKGNJWLfm1eS8FvolUK1FPj3bt9OWElIqdDSR2g433KzTbWJ\n\t oOufaE64L46VHFF1Gr5S2oZcjNkRa0crtW0oA05RCea4UPl7oh/1pCsJ+liXiXkWOz\n\t 8b926CO+mTakFc+ZyX2DuvWON9168oYRV4Ec82pek/WNS0iZwlnmNu0r4naMcJzPPW\n\t WLQn968KyZ4MOwkp2rVz9n48sIc00MAs0/JabKKdTKB0NSKWLvyXIhPt8TgsEb/KKe\n\t hVDtaCtkhkcfYfIMX5PJBJxxsc9UMx9/pe3r0LhOdTzw7gGoNPc3AuTTvrulIo6HFm\n\t w1IaffafvgjSw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.8;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org B2C7640549", "X-CSE-ConnectionGUID": [ "rtnCPW+ZRUiP4wkuTNIRhw==", "JJmhOj7/RSKCkBkovQMohw==" ], "X-CSE-MsgGUID": [ "6UywVrfYSfC3jHdLxQZ+5g==", "9fOiDqdaTaKO+Dwy6EXiyA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11761\"; a=\"94987403\"", "E=Sophos;i=\"6.23,183,1770624000\"; d=\"scan'208\";a=\"94987403\"", "E=Sophos;i=\"6.23,183,1770624000\"; d=\"scan'208\";a=\"235329569\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tKonrad Knitter <konrad.knitter@intel.com>", "Date": "Fri, 17 Apr 2026 08:29:52 +0200", "Message-ID": "<20260417062954.1241900-3-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260417062954.1241900-1-aleksandr.loktionov@intel.com>", "References": "<20260417062954.1241900-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776407400; x=1807943400;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=edbHUJHOaA58QasrhNxyc7+ghy9rcKSjYx+XG+RjX4w=;\n b=hQToS5VT11hTfTNul6njittgyjS3Xpar+CnhBKSMQ2Nxvvj8xruObX8F\n f0ffyjAS/ukLNjTGA7O+cZ5hjbGrhrRhY46znRkPYZqa3zeWCMX2/lnaG\n SRwjjZTClFiwQlz9JsadpKYC7GcJr+cR4ZPEHCK8Ivi3EHoAj+6wygdRr\n FSM84LWefREfan9I+GvvpHLvkVkKWFQyMy4unUJNhkV/WVxim/BU/QhjC\n iQA3dv6xeHqxQFeGnDVcn4/unCLzYRgpq9sVQydXecEeVXvK5X1wNNrK0\n m/rxqNhD09Kd1IorfSOPmtVBt/iwLmUYzOSGcoVbEUABbEM03WiqFQMaV\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=hQToS5VT" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable when\n link partner doesn't support AN", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Konrad Knitter <konrad.knitter@intel.com>\n\nDisabling autonegotiation was silently ignored when autoneg had not yet\ncompleted (ICE_AQ_AN_COMPLETED was not set), leaving the configuration\nunchanged with no error. This could prevent link from forming if the\nlink partner requires non-autoneg mode.\n\nExtend the condition to also allow disabling autoneg when the link\npartner reports no AN ability (ICE_AQ_LP_AN_ABILITY clear). Gate the\nICE_AQ_LP_AN_ABILITY check on the link being up so that stale or\nzeroed an_info when link is down does not produce a false positive.\nIntroduce the helper ice_autoneg_disable_allowed() to make the check\nexplicit.\n\nFixes: f1a4a66d2310 (\"ice: fix set pause param autoneg check\")\nSigned-off-by: Konrad Knitter <konrad.knitter@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 26 ++++++++++++++++++--\n 1 file changed, 24 insertions(+), 2 deletions(-)\n\n--\n2.52.0", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 30d2550..e41fc8d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -2509,6 +2509,28 @@ ice_ksettings_find_adv_link_speed(const struct ethtool_link_ksettings *ks)\n \treturn adv_link_speed;\n }\n\n+/**\n+ * ice_autoneg_disable_allowed - check if autoneg can be disabled\n+ * @p: port info\n+ *\n+ * Check if autonegotiation can be disabled based on link state.\n+ * ICE_AQ_LP_AN_ABILITY is only valid when the link is up; gate that\n+ * check accordingly to avoid false positives from stale link data.\n+ *\n+ * Return: true if autoneg has completed, or if the link is up and the\n+ * link partner does not advertise autonegotiation capability.\n+ */\n+static bool ice_autoneg_disable_allowed(struct ice_port_info *p)\n+{\n+\tu8 an_info = p->phy.link_info.an_info;\n+\n+\tif (an_info & ICE_AQ_AN_COMPLETED)\n+\t\treturn true;\n+\t/* ICE_AQ_LP_AN_ABILITY is only valid when link is up */\n+\treturn (p->phy.link_info.link_info & ICE_AQ_LINK_UP) &&\n+\t !(an_info & ICE_AQ_LP_AN_ABILITY);\n+}\n+\n /**\n * ice_setup_autoneg\n * @p: port info\n@@ -2547,8 +2569,8 @@ ice_setup_autoneg(struct ice_port_info *p, struct ethtool_link_ksettings *ks,\n \t\t\t}\n \t\t}\n \t} else {\n-\t\t/* If autoneg is currently enabled */\n-\t\tif (p->phy.link_info.an_info & ICE_AQ_AN_COMPLETED) {\n+\t\t/* If autoneg completed or link partner does not support AN */\n+\t\tif (ice_autoneg_disable_allowed(p)) {\n \t\t\t/* If autoneg is supported 10GBASE_T is the only PHY\n \t\t\t * that can disable it, so otherwise return error\n \t\t\t */\n", "prefixes": [ "iwl-net", "2/4" ] }