[{"id":3679445,"web_url":"http://patchwork.ozlabs.org/comment/3679445/","msgid":"<20260420155409.GT280379@horms.kernel.org>","list_archive_url":null,"date":"2026-04-20T15:54:09","subject":"Re: [Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable\n when link partner doesn't support AN","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Fri, Apr 17, 2026 at 08:29:52AM +0200, Aleksandr Loktionov wrote:\n> From: Konrad Knitter \n> \n> Disabling autonegotiation was silently ignored when autoneg had not yet\n> completed (ICE_AQ_AN_COMPLETED was not set), leaving the configuration\n> unchanged with no error. This could prevent link from forming if the\n> link partner requires non-autoneg mode.\n> \n> Extend the condition to also allow disabling autoneg when the link\n> partner reports no AN ability (ICE_AQ_LP_AN_ABILITY clear). Gate the\n> ICE_AQ_LP_AN_ABILITY check on the link being up so that stale or\n> zeroed an_info when link is down does not produce a false positive.\n> Introduce the helper ice_autoneg_disable_allowed() to make the check\n> explicit.\n> \n> Fixes: f1a4a66d2310 (\"ice: fix set pause param autoneg check\")\n\nAI generated code review [1] flags that this does not seem to be\nthe right Fixes tag and that the following seems more appropriate:\n\nFixes: 48cb27f2fd18 (\"ice: Implement handlers for ethtool PHY/link operations\")\n\n[1] https://netdev-ai.bots.linux.dev/ai-local.html\n\n> Signed-off-by: Konrad Knitter \n> Signed-off-by: Aleksandr Loktionov \n\nThe above not withstanding, this looks looks to me:\n\nReviewed-by: Simon Horman \n\n\nI somehow feel obliged to acknowledge that Sashiko has provided\nreview of this patch. However, I don't believe any of the\nissues flagged there should block progress of this patch.\n\nYou may wish to look over that review for possible follow-up activity.\n\n...","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=NPMGyMzk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzqmT6Dwhz1yD4\n\tfor ; Tue, 21 Apr 2026 01:54:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1DEDE610F6;\n\tMon, 20 Apr 2026 15:54:16 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id O_SKgILYaRUN; Mon, 20 Apr 2026 15:54:15 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5F54C6105F;\n\tMon, 20 Apr 2026 15:54:15 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id AAA42355\n for ; Mon, 20 Apr 2026 15:54:14 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 909BA6105F\n for ; Mon, 20 Apr 2026 15:54:14 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id u6ikNOBX7-FG for ;\n Mon, 20 Apr 2026 15:54:13 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n by smtp3.osuosl.org (Postfix) with ESMTPS id BBB4660AA1\n for ; Mon, 20 Apr 2026 15:54:13 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 6DBEB4368A;\n Mon, 20 Apr 2026 15:54:13 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 10939C19425;\n Mon, 20 Apr 2026 15:54:11 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5F54C6105F","OpenDKIM Filter v2.11.0 smtp3.osuosl.org BBB4660AA1"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776700455;\n\tbh=J7o/8KgJizxABEXyLEkezDlutD4Gutygp+NZfiPyNo8=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=NPMGyMzkBrxwxbj6IGt399h8WTmEP6ZVu1L8oaWEypcPsbjDWe0pC4Qwk2/IGSXy2\n\t 8KeZCghKx+pYatRkrR11bpz1D6EmQ21adVEZvqYfi3VE3EFAxDwSNEuEEzfIcm3sC5\n\t ji2jqOIGlfG04QFfbRZQOVHUgBoK9AOi/ISS8SmmJF5i9LViOEQzro4jan8PgLOHHe\n\t g77TcCZWWiPC43HwDM2HvK455PQO02lNf45jMpOb650B16RxDJJ7cxJK/F99R3+8gV\n\t B49lkEM7Acf/TbJaOfctE0tAw0iWAEN+hIA0zuKW7TrccabomFMXS2x7VnRt6XCQOO\n\t /y5HM0Br69EsA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31;\n helo=sea.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org BBB4660AA1","Date":"Mon, 20 Apr 2026 16:54:09 +0100","From":"Simon Horman ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Konrad Knitter ","Message-ID":"<20260420155409.GT280379@horms.kernel.org>","References":"<20260417062954.1241900-1-aleksandr.loktionov@intel.com>\n <20260417062954.1241900-3-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260417062954.1241900-3-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776700453;\n bh=KjHyxxjPDBim6sQ9KYPdRWv3pfyjQHkMzJZQEGKI5R0=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=md5E8DjZIOSFg8J9sBuryhu60e/wjXlftP7tYt1NXoHXTc9pfr9SQohuJfb3bmkM2\n ftBxgWfg9FHJtRzqdQTWfijvvXCDRWQe0TGGpSCktRyA24k3A49qAhiL32mlYT9Mt5\n MvjhQcGoccQLUkUEnxtyZHTy+XA5hK66+4w8Lc6NiVPpIDM3gj4zrbleVx8MQbFJ57\n dKZI5TB6U1h2q/GmhVwdQf+4rbrOCD7SqkIe6y5bCwPN/HEmIqTn9zywFZQg2o6VT9\n d7TzPUtNFhnyVG84SCeAKDgKrIxUjFErptquIX8jI/uBn5UC3l77XSJUOFjOBu5B0I\n m572eY2mik9KQ==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=md5E8DjZ"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable\n when link partner doesn't support AN","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]