Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232469/?format=api
{ "id": 2232469, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232469/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260504144455.3674272-1-ravi@prevas.dk/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260504144455.3674272-1-ravi@prevas.dk>", "date": "2026-05-04T14:44:55", "name": "boot: image-fit.c: check target, not source, for 8-byte alignment when loading FDT", "commit_ref": "55b152e6f0204e0b769f66ffd40ad02081f9bff0", "pull_url": null, "state": "accepted", "archived": false, "hash": "acea8f9a0951a57b0ea16c83f2b0117fea6a9da8", "submitter": { "id": 89443, "url": "http://patchwork.ozlabs.org/api/1.1/people/89443/?format=api", "name": "Rasmus Villemoes", "email": "ravi@prevas.dk" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/1.1/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260504144455.3674272-1-ravi@prevas.dk/mbox/", "series": [ { "id": 502675, "url": "http://patchwork.ozlabs.org/api/1.1/series/502675/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502675", "date": "2026-05-04T14:44:55", "name": "boot: image-fit.c: check target, not source, for 8-byte alignment when loading FDT", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502675/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232469/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232469/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256\n header.s=selector1 header.b=HSb6glJV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.b=\"HSb6glJV\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk", "phobos.denx.de;\n spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=prevas.dk;" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8PZL3HV2z1yJ9\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 00:45:14 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E3D1B84374;\n\tMon, 4 May 2026 16:45:08 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 199C1845E9; Mon, 4 May 2026 16:45:07 +0200 (CEST)", "from MRWPR03CU001.outbound.protection.outlook.com\n (mail-francesouthazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c207::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0C4CD84255\n for <u-boot@lists.denx.de>; Mon, 4 May 2026 16:45:02 +0200 (CEST)", "from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:681::18)\n by DU4PR10MB8976.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:567::6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Mon, 4 May\n 2026 14:45:00 +0000", "from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8]) by AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8%6]) with mapi id 15.20.9870.023; Mon, 4 May 2026\n 14:45:00 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Nz4LhwwwvgjZVPK2UMBLMRn2N9V8khbenUMdWVOT3kytawHkigPHlHubW/zhXkGwkDWK0mpV3uRmpZPYsIlSeAHqh8cJSIHp8PzetdXmRGt6n4mTgLe+z2sqhX4taPCKdGmRGiK4ZoX1zSM3C2s7qewAmrJaHQrzfSwY3rvOamsBngdH+NOQhDoH6XYBvT0s0Z6gcDt9p2xp4GQDGgMN22KZDTEkatLjNjsEMF2A1Q+ddKbL3NKJ/b0L01nd7+6DWBPE+XaUA/bWCQ+b039vdfH1bqMnsTAUOejpbUk2x2zNVPgVOmDN9own0mmdcfd3iCrBxrqwgq0HXnuXZGE7Gw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=y3h82BTIRWKJQuSDJeBFjIR+fNTr2s8y+uqx5QJimgA=;\n b=H6Fkm2H17gcya+/2akRUoReqOmLotjcyk4ANr3A1B15Attgd8+EApgQ5XK4mMdtnsJb03aDjc4EvLZdlYBX49XzaSiheb3lDnViSatpg8DMXbeauS6B18zc21eEWBdVrLJ7cp/vxIAdSdGyzerkIk+0sztUV8eHm38rI+OJkaco96sptQMoQCDGtjJk3E/lUWf1zVbnA1neVfZTKkE7IwcJGcgEN3FNhy7W3saJRyRQUEMF9KZctHBlObHQ80ZpPp/ujM5AmUpzDgUtoQALePzkZ/AOuWU00+2GQ61X6/1tj1zTnHC6A7y4b9kyVIMVRMyb8E6LRTKtkNklU3vxo/A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk;\n dkim=pass header.d=prevas.dk; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=y3h82BTIRWKJQuSDJeBFjIR+fNTr2s8y+uqx5QJimgA=;\n b=HSb6glJVW/V2R0Q5ZmlxF1jtNmhOgfkj7iOqdtJ0odRgK6Zt0TJojiNe/8YHdL3sjsxhgO3r3nvaOPMzROhLHDUD/yu+fUwBI0V272OdTzDPSYTDo+JNOTDxOBifSqtWEC+/8vZeX3tiG+Maaw3yLT+lknwtVoSvpFG0kiekxkY=", "From": "Rasmus Villemoes <ravi@prevas.dk>", "To": "u-boot@lists.denx.de", "Cc": "Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Tom Rini <trini@konsulko.com>, Rasmus Villemoes <ravi@prevas.dk>", "Subject": "[PATCH] boot: image-fit.c: check target, not source,\n for 8-byte alignment when loading FDT", "Date": "Mon, 4 May 2026 16:44:55 +0200", "Message-ID": "<20260504144455.3674272-1-ravi@prevas.dk>", "X-Mailer": "git-send-email 2.53.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "CPAP307CA0006.DNKP307.PROD.OUTLOOK.COM\n (2603:10a6:380:3::14) To AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:681::18)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS5PR10MB8243:EE_|DU4PR10MB8976:EE_", "X-MS-Office365-Filtering-Correlation-Id": "782fae66-743a-44e7-e20b-08dea9ebb7da", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|1800799024|366016|52116014|376014|18002099003|56012099003|38350700014;", "X-Microsoft-Antispam-Message-Info": "\n MYtJnuo656zjnmBABUIJzsFzcJwrb6B82tI9KgrVEXj5cy3MdNAlNxIIGcwr0qJvIgD+GZ8tSo4NJk40HVVp1GRWF+RAxrQujoEmFybUqO4NHfuo4l2VxcYz1NXRV3kXf8AIsslsjAYeGT3ILbMaLnEecuaHx/V7SBMpJKV+lQO6D5B1UNYtWMyMSj70UdYky6vOPmfMBjwygNLnSNqYQ24Q12kG41BT3HDxKeq14umSVVDIUu6kiNgCn7wF4XrvAO8RA3AB5fIClAX1lIUQiucdp4kykb+pAUf425IUewQ1LuVXGeJJaO8n3MG55BHNm/FIGeFJnRF1XUSkDFZlE16GLg4WyqWHFo71N8g/J5SBtbVkJEdPnGs3C5zVS+KxgkN0yuEdTEXYPeJ+KfaYuEsO5oDZkA2vL7yvBy/8QtWjzvVGNw6CQ9p790aISxHXOsJy4Sb3buC5ENrVKcyYGELwXA3GzSOdJr0LPtQcpCzelSS3iJvMd7xG4Sju7ChBWbiNTLppNZn7ZSgwLl7RGfPWeYyss9OyXi19/CvSesVbcoY2ZyELR336JKr1rIv178DKL5O9USdXXr+oQD8T1iS3NiEPi4t5jH+1NlJQeLVd/FsK3ClwfImDYRENxw1fiCgdcLx1kGYZ9YqsR/LegUmMzsKuqQOFUtrhpu+t9nEuPnpGjcGvn3yRF7AErP8LOUwFx3VT0p7Y2R6vDwETg7nBtkMMl/rvCdYtvKyr6JI5UQmnEOBRETQfv7yZZ727", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(52116014)(376014)(18002099003)(56012099003)(38350700014);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n WE64dfIqSt5MbcbLmgVxUBy9d+m1LK1TOrJ4+xp3+1NAtPAzl8V4nK1G+pIhuXYx3Q+PD/30T3gA+DMVHkDsl4bOFLuj0Ad/HXx+3Pk3hJuGXweZmmiDGpd7vN2z5LjKa7PtciUb21FJC1k9HC4J8GCyJ+uned/izmL5ES9kBIEiYglpaGG+mt7pqkDIsXo750g1KtN1XbzNKuZwuSkZKBbuC3qnWco7K0JJHjE6LTmv7RCEbfh3ummGYo6/KeW/V86kmOe/gNCfZ5GbvTcFzoqrwWHd6Fzzr2f8gsmnBAOnf/wUWslRNJAro9zjdvMpkYb8xUEjt8nZgtorW+dM5HQg9e1kSzP+2sDNdJtolSlv6qY3y3S+/+cH712vNZ5HXencozbfXObRTdN7VSMmplDkDpJXbwcfBFp2uttBDtNLr65A1c6UNIeOsjLwPvAt7CkGbHmcUZQDyNt3wWOOD1ZHVM6Zzm5jm0vaiJpRSTH/uOe7yqHstw5S0I8UNJAJjCbfybfvncgke21Y8cBgBj1voVkUXVAnP2vvRT6HuIXtZ22gfduSRJ95EOVZRuZbkZux+0dkZ70QESO1P5+6CQp4tMHL/vc/Bqy7Skk2rB7XliWLyWmMdCnBhcsI5glCsgz2ePnkiitrwQlxayX5nr1MY0pAHytpo4VKNW3rWQChtcrafEgqAOiBVoNWZVpSF4xIXbefmsDOpz5TKnZ2yeLnVPThe3p+kYKvHsfMUR4f4V4RqfJCI7H/EPqduySuNdaYTgTekhGuZmTjUknv69msS1RiVg3uFnHB8WCA+o7xlhf8NhWG/FKKEjtjFMmoEWVWLnhBBpxTOxpJixbkOVC4P1KZWUWEQMDj22PAt8HoN8EtOrHMpKd+FPRa32FLNvyEHM3opJbLcSgt7InXT4X+D50j+QNorPOmKSSXtCbtUc/eFFc9UF5179TOdRyzU6zUFM8l0UpmWogXgqql9BkpcpSjMGLERzxJ8e85oy9BoEmqdw8ZnoBiRbeaF8use6cYpgGbqXqYmVBNtPacsGYLK0HS2ObrrSFn1u+G3pPKBT+qSOouYGtSuxIvYGOVNIW4JTOFUOs0Id0o+ggciWTNzMvAxG1YvPqUCcQF6hMs5QUVp/7rKcinlic5dco4liWQH45iql6U9nld6UUyNWYztWxuKpsHc9sp5HhHnW8W6sWlFk7LNJuTNA50SgrjKRLDiaDIDjG6UYgIQUAGcYnPEWdBNBVFoImXFK8Jj4H7oLm0UJFb1Ed87eLjovUutur4BU4rCzm45O9n32MM42cIbO9FHen/RG50TbdDT4pi9+JfUvJecu4T7SpEm8l1VbMwKnWdi/8IAPZUSUip6oGDsGqVOUXy5eEfxwYK0ZuydbCxP3C+Qc83qcxvsBM3D4kInHYg8kADRW1q/YwxcjeCp+1w9H8Uf5qCt7E5zcwuHtRbder4jY2W2RITX5GpQ1bTggp4ou3M5kYP0p8C9JDT8qSZWXo4f9ZFXwq2eL3RXMSFurtcBFIUg60Xc0/QZDtwVA/nlXoIiinb7Eq7tnWdZ3my9IrFUR5CPNQod+vt3877nkJ8AN/Qu88xur7ZCkr+P3bXzOkAUeInpDDhuELPmi6JNvJcwvm/p6VuR4b5EVqYCIc72BbLH0oLKVuamaRswIPzvYyjJS8KxYgElBq+AJBk9alLB6GHEgkViQli/X6e5ak/M7nqlfeS/JPnufS8jP2QvIzs9ZF1IsMCzGDjMkbsQeHLoBTIUMHUbZQ=", "X-OriginatorOrg": "prevas.dk", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 782fae66-743a-44e7-e20b-08dea9ebb7da", "X-MS-Exchange-CrossTenant-AuthSource": "AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 May 2026 14:45:00.2344 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "d350cf71-778d-4780-88f5-071a4cb1ed61", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 5QQOovTgeBSeiHMSZAVbv/0t1chSJXnKn8HNcZb2kjxckbjmlV+aJfFyMBbraYfGuR4MeGYs41/ZnRcRD9mjZWkYxdQ6Iwo0d97kFzt60nU=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU4PR10MB8976", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "A number of our boards no longer boot with v2026.04, ironically as a\nresult of the effort to ensure 8-byte alignment of the dtb passed to\nthe kernel and getting rid of the fdt_high=0xffffffff.\n\nThe problem exists when the FIT image does specify a (properly\naligned) load address to use for the fdt. For example, we have\n\n\tfdt-am335x-boneblack.dtb {\n\t\tdescription = \"Flattened Device Tree blob\";\n\t\tdata = /incbin/(...);\n\t\t...\n\t\tload = <0x88000000>;\n\t}\n\nNow, with v2026.04 and depending on just exactly where that data ends\nup, in a good case we see\n\n Loading fdt from 0x8a8c6e10 to 0x88000000\n Booting using the fdt blob at 0x88000000\n Working FDT set to 88000000\n Loading Kernel Image to 86008000\n WARNING:\n The 'fdt_high' environment variable is set to ~0. This is known to cause\n boot failures due to placement of DT at non-8-byte-aligned addresses.\n This system will likely fail to boot. Unset the 'fdt_high' environment\n variable and submit a fix upstream.\n Using Device Tree in place at 88000000, end 8801af2f\n Working FDT set to 88000000\n Starting kernel ...\n [ 0.000000] Booting Linux on physical CPU 0x0\n\nand the board boots (though with that ominous warning). However,\nmodifying the .its file a little, e.g. just removing the word \"blob\"\nfrom the description, we end up with\n\n Loading fdt from 0x8a8c6e14 to 0x88000000\n Booting using the fdt blob at 0x9df94718\n Working FDT set to 9df94718\n Loading Kernel Image to 86008000\n WARNING:\n The 'fdt_high' environment variable is set to ~0. This is known to cause\n boot failures due to placement of DT at non-8-byte-aligned addresses.\n This system will likely fail to boot. Unset the 'fdt_high' environment\n variable and submit a fix upstream.\n Failed to reserve memory for fdt at 0x9df94718\n FDT creation failed!\n resetting ...\n\nNotice how the \"Loading fdt from\" line still claims to load the fdt to\nthat 0x88000000 address, but since this \"else if\" clause looks at the\nsource address (buf) and comes before the \"else if (load != data)\"\nclause, we end up doing the \"allocate another buffer to use as target\"\ninstead of actually copying to 0x88000000, but then the \"fdt_high=~0\"\nlogic in boot_relocate_fdt() obviously fails to do an lmb-reservation\nof that area, and the boot fails.\n\nWhen there's no load= property in the fdt node, this should not change\nanything. But when there is, it is the alignment of that target which\nis relevant, not the alignment of the fdt blob within the FIT\nimage. With this patch applied, we instead get the expected\n\n Loading fdt from 0x8a8c6e14 to 0x88000000\n Booting using the fdt blob at 0x88000000\n Working FDT set to 88000000\n Loading Kernel Image to 86008000\n WARNING:\n The 'fdt_high' environment variable is set to ~0. This is known to cause\n boot failures due to placement of DT at non-8-byte-aligned addresses.\n This system will likely fail to boot. Unset the 'fdt_high' environment\n variable and submit a fix upstream.\n Using Device Tree in place at 88000000, end 8801af2f\n Working FDT set to 88000000\n\n Starting kernel ...\n\nSigned-off-by: Rasmus Villemoes <ravi@prevas.dk>\n---\n\nNote: We will change our boot flow and get rid of fdt_high=~0, if\nnothing else then to get rid of the warning, even though it feels\nslightly exaggerated given that we have in fact taken the 8-byte\nalignment requirement into consideration in setting that load=\nproperty. But this still seems like something that should be applied.\n\n boot/image-fit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/boot/image-fit.c b/boot/image-fit.c\nindex 067ad236081..db64a1ee46d 100644\n--- a/boot/image-fit.c\n+++ b/boot/image-fit.c\n@@ -2311,7 +2311,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n \t\t}\n \t\tlen = load_end - load;\n \t} else if (load_op != FIT_LOAD_IGNORED && image_type == IH_TYPE_FLATDT &&\n-\t\t ((uintptr_t)buf & 7)) {\n+\t\t (load & 7)) {\n \t\tloadbuf = aligned_alloc(8, len);\n \t\tload = map_to_sysmem(loadbuf);\n \t\tmemcpy(loadbuf, buf, len);\n", "prefixes": [] }