[{"id":3687877,"web_url":"http://patchwork.ozlabs.org/comment/3687877/","msgid":"","list_archive_url":null,"date":"2026-05-07T15:30:58","subject":"Re: [PATCH] boot: image-fit.c: check target, not source, for 8-byte\n alignment when loading FDT","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rasmus,\n\nOn 2026-05-04T14:44:55, Rasmus Villemoes wrote:\n> boot: image-fit.c: check target, not source, for 8-byte alignment when loading FDT\n>\n> A number of our boards no longer boot with v2026.04, ironically as a\n> result of the effort to ensure 8-byte alignment of the dtb passed to\n> the kernel and getting rid of the fdt_high=0xffffffff.\n>\n> The problem exists when the FIT image does specify a (properly\n> aligned) load address to use for the fdt. For example, we have\n>\n> fdt-am335x-boneblack.dtb {\n> description = \"Flattened Device Tree blob\";\n> data = /incbin/(...);\n> ...\n> load = <0x88000000>;\n> }\n>\n> Now, with v2026.04 and depending on just exactly where that data ends\n> up, in a good case we see\n>\n> Loading fdt from 0x8a8c6e10 to 0x88000000\n> [...]\n>\n> boot/image-fit.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\n> diff --git a/boot/image-fit.c b/boot/image-fit.c\n> @@ -2311,7 +2311,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n> }\n> len = load_end - load;\n> } else if (load_op != FIT_LOAD_IGNORED && image_type == IH_TYPE_FLATDT &&\n> - ((uintptr_t)buf & 7)) {\n> + (load & 7)) {\n> loadbuf = aligned_alloc(8, len);\n> load = map_to_sysmem(loadbuf);\n> memcpy(loadbuf, buf, len);\n\nFixes: 8fbcc0e0e839 (\"boot: Assure FDT is always at 8-byte aligned address\")\n\nBTW the file already uses IS_ALIGNED(x, 8) a few lines up in\nboot_get_fdt_fit_into_buffer() so you could use !IS_ALIGNED(load, 8)\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Mq6hFUEy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Mq6hFUEy\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBGSC2z9Lz1yCg\n\tfor ; Fri, 08 May 2026 01:31:23 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0B68884A79;\n\tThu, 7 May 2026 17:31:15 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D101A84AFA; Thu, 7 May 2026 17:31:13 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n [IPv6:2a00:1450:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 31FFB84A7B\n for ; Thu, 7 May 2026 17:31:11 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id\n a640c23a62f3a-bc23bebd345so189560766b.1\n for ; Thu, 07 May 2026 08:31:11 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1778167870; cv=none;\n d=google.com; s=arc-20240605;\n b=hSjLN5g9u7K6Ai8uS9MoEIf0U7FJZ8gSskw0vwesdPCb/qWjp/XrZyUzuU8IRV3zZj\n NhVrV1ip3/Li/BZghIcsq0mBMUWm6RTaEP7sP5Q1rgmW0adgPzxfUhxe1reCepqXOax5\n JnZlbTppzvrpRVaDOvKm+fgDeVF/6ZMHvp0WYVxx6jyxgFVmCEjvsncVTnHAlqUfKEQx\n ylZaXxZrnBOwTuhjyIk/+Qjm9vIPjg2LLsVj5jCV4g2dYE5l9u6BTjyYYmckxjHIRDaP\n TCWOCrW0Rf6+J8M6T98CSZhCDMQP0kBHq8/E+d2Z/PDxarw66a8b7KYCYHjUadat3YDx\n 4R7w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=iu852Ff196ydzXaHxvC8GWPNpFpEq1sm/XEICjKFslY=;\n fh=mMjfHynJFJmcWd2ujY9HOYbDsUWJsRgAYR53jQaIBb4=;\n b=AZzoFIxGCTuxTjedK1WCiiadajagcA/iL5wRIT7Pmo9vjUvnwJmoJSavOjxQrDqVNK\n mdatPEYKgm2klPOFihEZLGha8W+RZfytsKyNszuQK9Go2aG6uusk0ZPZt/QXcwCAadGJ\n fshUclI51RV6pUgvxcNcCpjvEduCyiix1PmDKFGqBqh4f94xhW8GlXRlbqSJZbm2CVO4\n TOw5aGmmc2rmwowiVRxMMK5dvdoYDMA1reMucrM2MUp+4rAJKbITByoqaDvDjAekBCiU\n HH13a9ONXui9fMQFeEiPyvNCTyCjmitdHzmP1keEJQlj7jwLfmlaK9ci2it+wlkHfeNU\n Dvjg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1778167870; x=1778772670; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=iu852Ff196ydzXaHxvC8GWPNpFpEq1sm/XEICjKFslY=;\n b=Mq6hFUEy3H/b5+u+hmSGyG/8h88K7kyJ4lKxDp1X5VcnLS+NC/VX5g0ZutWuSFp6qm\n chkNgCG+EiDPXe70Ee/YkLlaoKTduvpghdcCTvEyqSsX4DppqG4/VvwcKg22k02N7gVc\n epuHUAVj5nK1IiHhk6tWwstX5/5JjH8erCLzw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778167870; x=1778772670;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=iu852Ff196ydzXaHxvC8GWPNpFpEq1sm/XEICjKFslY=;\n b=muGBrzfzi+HlZ2j7O5lx09fusDgakhg3hCccouHWbCNnfoqFbgAVapkk86+G4wdtl1\n GHWosbykQfeitWhxIxdIf3tfqwrZ+FUEG0n/rr4Rszk8xbeh1MIfqyOKkSWvVxV0q4hX\n aENGNdE6xAwxS68wWB1HsJ9SWCanzo4kz5xpMykShol1QMcvOonX4i36qG+xAe5xZqDf\n RXopT4W7UmB5mUfjTEh63ng4lpbbCqZuXjpW6ZksTgwZ+NzUcYF+46Uj4wZ2ks7vf9mh\n e8zv4zYVGdojauCx1XRcy0iZf5d2w+48dme20mNCwFu6gr7sEDEOfaRzpLFBrR6CEAS+\n 3Llw==","X-Gm-Message-State":"AOJu0YzK5zsVeudk2HnnHY/68wVnBoe6eh0OE7pJcRt4X16mPbb3J0EH\n GMSEoIagLdPrkWbHFFKlZUGeLvwAX3Y2SGbnFCL7oIfBlXkB/sFMl6HmCw4k0tG49M/mUVAG5PW\n Jv6uBoWcYGHyAWsMm5rVo8xZYApsbPBXr8MwxBylj","X-Gm-Gg":"AeBDieu2W8faJLbBcCRi9GtLtiaOmlPWuV/W/oLbRc/uBgR9zDNvtgctrvHiZckTu72\n RRNW72mKCg9HHm0fUqEB8ja1A+vYTdGSBrcOuVgiwRSG9dQ+wqhPJL9NeZtHvdkYFBz2wEO6kZM\n NFJV/BPP2ww9cZRCvxG0mGLBkhAq2XnwgiSkeCjK7sVuDtb0PM9zLQvu+kEBtrIjM2HcUfw/1Jy\n AfczKlxX5tOp9+V8bpHkJr20zi1QCCAt/T/Tk1Rm1/xWgITF88NfpOJZhXuSfoQSRQEdPhKt19e\n yQyna6IvkdupQRSsfjZ9e73XSNM=","X-Received":"by 2002:a17:907:e157:20b0:b9d:14e9:d06d with SMTP id\n a640c23a62f3a-bc84ce749a5mr155195766b.8.1778167870319; Thu, 07 May 2026\n 08:31:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20260504144455.3674272-1-ravi@prevas.dk>","In-Reply-To":"<20260504144455.3674272-1-ravi@prevas.dk>","From":"Simon Glass ","Date":"Thu, 7 May 2026 09:30:58 -0600","X-Gm-Features":"AVHnY4LMVZMuq1-Q28kGll9QoXXwdPGAakj4S4t1dLx3a8XNiNvrUWXyHsi5yrw","Message-ID":"\n ","Subject":"Re: [PATCH] boot: image-fit.c: check target, not source, for 8-byte\n alignment when loading FDT","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Marek Vasut ,\n Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3688771,"web_url":"http://patchwork.ozlabs.org/comment/3688771/","msgid":"<177828208021.1997265.17149806959979415026.b4-ty@konsulko.com>","list_archive_url":null,"date":"2026-05-08T23:14:40","subject":"Re: [PATCH] boot: image-fit.c: check target, not source, for\n 8-byte alignment when loading FDT","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Mon, 04 May 2026 16:44:55 +0200, Rasmus Villemoes wrote:\n\n> A number of our boards no longer boot with v2026.04, ironically as a\n> result of the effort to ensure 8-byte alignment of the dtb passed to\n> the kernel and getting rid of the fdt_high=0xffffffff.\n> \n> The problem exists when the FIT image does specify a (properly\n> aligned) load address to use for the fdt. For example, we have\n> \n> [...]\n\nApplied to u-boot/master, thanks!\n\n[1/1] boot: image-fit.c: check target, not source, for 8-byte alignment when loading FDT\n commit: 55b152e6f0204e0b769f66ffd40ad02081f9bff0","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=f4/mbcI2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"f4/mbcI2\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC4j85lR5z1yCg\n\tfor ; Sat, 09 May 2026 09:15:24 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5222A84E03;\n\tSat, 9 May 2026 01:14:48 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8254A84C9E; Sat, 9 May 2026 01:14:46 +0200 (CEST)","from mail-oi1-x234.google.com (mail-oi1-x234.google.com\n [IPv6:2607:f8b0:4864:20::234])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4176A84CF3\n for ; Sat, 9 May 2026 01:14:42 +0200 (CEST)","by mail-oi1-x234.google.com with SMTP id\n 5614622812f47-47bdee5bfc4so1761173b6e.1\n for ; Fri, 08 May 2026 16:14:42 -0700 (PDT)","from [127.0.1.1] (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7e367be1168sm2005082a34.5.2026.05.08.16.14.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 16:14:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1778282081; x=1778886881; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:date:message-id:subject\n :references:in-reply-to:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qfeJ8vbjC3Xa+OzUSqHeik4vqpRJpnrfSpsJHWkplgg=;\n b=f4/mbcI2m4c3ea6PiX3bV89E5fKr8H86mRFaKuoeUkXpxONCmyml3XQh3DgL7nTqTk\n bYP/F91pQfoLcdng3mVDV3oDtjEflyBKY/SJaH5xwAZQ2FmZL84lOerDKHhmIffiUlET\n 7CkNULkbzlt3j7tOB3ftDb5yW8b5YWBoiljV0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778282081; x=1778886881;\n h=content-transfer-encoding:mime-version:date:message-id:subject\n :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=qfeJ8vbjC3Xa+OzUSqHeik4vqpRJpnrfSpsJHWkplgg=;\n b=AkIro2u6MjXC9DHW6UWb82HoegJ9U/f10Pxk+eM+kpKB0hzP/nT4rW09kh7/cdq4pb\n w2NkeYeifXkFHPiRPvgHMCsQEJ7PUdPcSeahh5UtSC7vwcQI3XHTeMlLBW9f3c+fHp+P\n +t1U91y9g9dMBfjT6HMKVrC3QlqtDP3s0dk8dTWlIhSbvL5xBANX5UhOx47l+TjQsmMJ\n r6+qq8PE5GkXyYlaUjjBIN1Vh1vpnTwUpI+rRmSSOfj9ZOwOtOmwYrM4IP35dbHWYMT/\n 1XdUFBfgxquwNYHKwsIsnrT90MzbWabcMnPEtvgNwywLAUQTbGwta7L8C0Iw7rVdSNIl\n KXDw==","X-Gm-Message-State":"AOJu0YyZdfsIRE+9GlHCjCGKt48rrxardHE0RHOM4haBCaJILWvCb1Fi\n UD3VVgxtd6YrXT4Vu1O439GMdjcyU5N9yiGU9yK3i0yu/L/CqCjiDfXph7YwFh05ob4=","X-Gm-Gg":"AeBDieuAtK4i6KNNM8kczgjtGqClUafbMZMhXAtlqX7qBPyTuzZBkjw+ojVRfGgbaoc\n UD8SECkAOJmmBQh57zLaUCGW+frbYi0l78eef72qqiLVSbXojeFyrb0edtq2ZTMgoRcyTAJcLXq\n PDFKcIulvUFKZ6huqrFE4CR1UryzbALGZcjg+rAoby3DmIaf7UzK4G6MfFhSevJihSZq0SIjdKt\n 5lgdIezpgBgzp1vOuU5tfu87jIaGwz1cQ8PW+p78f5396MkzmObCb0ljqAQP1Zgv7AR90UhOzZI\n Rj/BlgXvNG8peZkR4Fac9ucz+AoDKnWDhcmVjEV1gDFPkx5Bipna8fjVP7xVDDfl9BC+QNZr/0d\n m1nTGAWnKgiRxeJ+MSrwL+0kAn8hMDZh0DhXwL+5r3ervfiNs5WWIIdpQm/GOdrhVoTMwfEUcFC\n KxPp8TtCxiY8oocyDQurMvOcxGcbYgHxvz+9mQuoLS6bAjqp2MPk8gT5QmYOCwRezCqENq56XJ1\n 3u1c+z/Cmf/Fw7EbtRIhRa7N7h38X2FGSImi3VJMu6AwPi2sA==","X-Received":"by 2002:a05:6808:3022:b0:467:d71:7f1a with SMTP id\n 5614622812f47-48061c39d5emr4692190b6e.21.1778282080894;\n Fri, 08 May 2026 16:14:40 -0700 (PDT)","From":"Tom Rini ","To":"u-boot@lists.denx.de, Rasmus Villemoes ","Cc":"Marek Vasut ","In-Reply-To":"<20260504144455.3674272-1-ravi@prevas.dk>","References":"<20260504144455.3674272-1-ravi@prevas.dk>","Subject":"Re: [PATCH] boot: image-fit.c: check target, not source, for\n 8-byte alignment when loading FDT","Message-Id":"<177828208021.1997265.17149806959979415026.b4-ty@konsulko.com>","Date":"Fri, 08 May 2026 17:14:40 -0600","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"b4 0.14.3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]