Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230658/?format=api
{ "id": 2230658, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230658/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/f4cd2bc906b1ce9c0bf54bcd81f6e6c010157658.1777505809.git.ashamil435@gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/1.1/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<f4cd2bc906b1ce9c0bf54bcd81f6e6c010157658.1777505809.git.ashamil435@gmail.com>", "date": "2026-04-29T23:37:39", "name": "hugepages: close fd on error path in __get_thp_mode", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "75df9942f0bc09b53e8aa902b0b6456a5e8a0eb2", "submitter": { "id": 93241, "url": "http://patchwork.ozlabs.org/api/1.1/people/93241/?format=api", "name": "Shamil Abdulaev", "email": "ashamil435@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/f4cd2bc906b1ce9c0bf54bcd81f6e6c010157658.1777505809.git.ashamil435@gmail.com/mbox/", "series": [ { "id": 502168, "url": "http://patchwork.ozlabs.org/api/1.1/series/502168/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=502168", "date": "2026-04-29T23:37:39", "name": "hugepages: close fd on error path in __get_thp_mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502168/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230658/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230658/checks/", "tags": {}, "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=dzA3IvLh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=dzA3IvLh", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "sourceware.org; spf=pass smtp.mailfrom=gmail.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=2a00:1450:4864:20::132" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5YdW53GMz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 09:38:07 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B32F64BB58BD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 23:38:04 +0000 (GMT)", "from mail-lf1-x132.google.com (mail-lf1-x132.google.com\n [IPv6:2a00:1450:4864:20::132])\n by sourceware.org (Postfix) with ESMTPS id BAC5D4BB3B98\n for <libc-alpha@sourceware.org>; Wed, 29 Apr 2026 23:37:45 +0000 (GMT)", "by mail-lf1-x132.google.com with SMTP id\n 2adb3069b0e04-5a3fcb2c718so239378e87.0\n for <libc-alpha@sourceware.org>; Wed, 29 Apr 2026 16:37:45 -0700 (PDT)", "from oops-lab ([62.152.34.188]) by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a74a769586sm927880e87.64.2026.04.29.16.37.41\n for <libc-alpha@sourceware.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 16:37:42 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org B32F64BB58BD", "OpenDKIM Filter v2.11.0 sourceware.org BAC5D4BB3B98" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org BAC5D4BB3B98", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org BAC5D4BB3B98", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777505866; cv=none;\n b=JKXeTHTK5E6jbqrq30B05WsFJEtxxmSlxgd6mYDuQlv5D+odvOh1DdCeKPSNSvICAOdFwZp/7HWvnUj0ptfgZ/+/Gwfx0ZNLmbTnE8dEfmeV8VxXV8ZweKAEnKMi8xPhSxHvox9+OwES/M+YKEFmHLMhynSNBJaxuzCS7gWvUSQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777505866; c=relaxed/simple;\n bh=v9UrriERa1dOKpmHzNNAIrSLWng/xr9sAs0m3ZGpeiI=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=rHVbXziDc5qPStuPgckksZKnSIW+tt7iDCNJH+rnD7WLkx+FmmwTD4XIBbqHJSr0XRIV3X1jG3eTR5g+1gyDX3aokpKqLvCZK6401RVQ+3a8k0ztIilaL/Ip3jsot6+ogsfZB6J5/aN3MXGN9scSU3Tv8tt+qsjDNyRgOZ0NZ2c=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777505864; x=1778110664; darn=sourceware.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=Jmerkb86HKoNeX5oTvwFB/hZocP+p61vhUTkga1cph0=;\n b=dzA3IvLhyVWRoriQ9cEHkv0Xm0DNkFHKZbLQBVadFjCpAAe3YS6vbUttqkQe+EPFRW\n +GT3XlcwSRicWm85AgOLCrwLYi2KX4JHSjpbSc5qQNmVSnAXviBIr6ll4kBVtQPs8nia\n pPU+heg06F2AWOvvPM5VdZoNYfIMzzjg+WrsCUaSWTxkeufkaW7Bg9JtXDkjm0Um3jxr\n MPO0QHlgb+LE933ONddfSj5ztXjBRd7ZMEsmKf4LvfkZ2N7RcbVNY/Kg1NzhWTMCt0V9\n 6wTqJ8WDkAqW3Lf5nmHzvdpGgGTjduN7AjZhTK7VyrxDQ1YNXR4i9BP12E3MeThMMFLw\n VSOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777505864; x=1778110664;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Jmerkb86HKoNeX5oTvwFB/hZocP+p61vhUTkga1cph0=;\n b=klzJywB1e6cecMlguT/qY0kR68gHWJ2ib4UI3N7lIyp5BvVlUeWl/1pY55bSegE+o+\n uw5niMhMqg3bqfu3LIqWSb/yIz02przkC1WzB7HjKnOsvXhW3XS+XWzGDztNNBjJ8tGT\n 2Tz/14KUCrO95Sc+8YsobYm8KziwfAapYw2w8EZbJWXqbWMHfiJYKDq+echI358gZtbt\n LjnBqgwDWRgmTTycSHPYS231Hx6sTtKZl6ZeSNAdx48xfrsba7GCsUzRCs5doHYrZVBm\n arOEFUkZlefIjenK5DubyEQB3PZn6icpUFGxU/VxXWw/4wjByoxdkvrVA5ObTwJcb2BP\n tHHg==", "X-Gm-Message-State": "AOJu0Yxi5QP9YeiD+URBiPww0BQpIz/Kott7dZcfjSStrnX2Iy6SpfZ/\n 26OU1W6kaKzMwcECTL9boKfIrWc32gV7EXZ+j1hca9MaZmV0RBNwflqnNEzlQ/YNu8o=", "X-Gm-Gg": "AeBDietyiEEOIUFvVkxpz0tJBKze5bkJTa4Hai6wC/1dwO/DXCKgL4Tsgsq9W7Aa+kX\n qg7SrAqjWKphtdYfY4OSLnOeeMJ35nh/WHUWHkLbM5LBUwgIRa5oULyd2Y+M8w6FQmcfKqlTh0v\n ENCI9utJgZHdSOuVqo0dnqelt/LwiCUPYQ/YM6zkC6MSzSomM1aVs88vSyoXNlYWebGva4HbkWl\n QKPE4geT+oYXaG6rZbFVxVhqniUK9i+vM+C62RpSuyQR5xsREvShuAXAIiVXw9K4VMXw2lLOgcy\n xV7nRyuYDR78gsI8KJJtXDhlEMzLJ/CK4SVqcdXttUkK4clUo28jl4FqOcDKFGk16ozUwn8yH9j\n wQxyW2YgzhNLIOwFPe4adghd9TaG+Cxim/VIMq1YTzuQLjZjGErUBMFrPvuUtmYFZho+BQ///yr\n ti2JwvJHKWdWUGsBEX4mHHcuqn4U3K5kSu1P9RdCj9TxGisAALsxhXS0igulAQsEF6d1ACiTp5J\n VcM8R+28YXY0gCszP/b0xld", "X-Received": "by 2002:a05:6512:3b22:b0:5a3:f305:a50f with SMTP id\n 2adb3069b0e04-5a8522d9438mr102306e87.30.1777505863539;\n Wed, 29 Apr 2026 16:37:43 -0700 (PDT)", "From": "Shamil Abdulaev <ashamil435@gmail.com>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH] hugepages: close fd on error path in __get_thp_mode", "Date": "Thu, 30 Apr 2026 02:37:39 +0300", "Message-ID": "\n <f4cd2bc906b1ce9c0bf54bcd81f6e6c010157658.1777505809.git.ashamil435@gmail.com>", "X-Mailer": "git-send-email 2.54.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "If __read_nocancel fails or overflows the buffer, the function returned\nwithout closing the /sys/kernel/mm/transparent_hugepage/enabled fd.\n\nFound while investigating BZ #34083.\n\nSigned-off-by: Shamil Abdulaev <ashamil435@gmail.com>\n---\n sysdeps/unix/sysv/linux/hugepages.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/sysdeps/unix/sysv/linux/hugepages.c b/sysdeps/unix/sysv/linux/hugepages.c\nindex 707a75c2a2..46e05151a3 100644\n--- a/sysdeps/unix/sysv/linux/hugepages.c\n+++ b/sysdeps/unix/sysv/linux/hugepages.c\n@@ -61,10 +61,10 @@ __get_thp_mode (void)\n \n char str[sizeof(mode_always)];\n ssize_t s = __read_nocancel (fd, str, sizeof (str));\n+ __close_nocancel (fd);\n if (s >= sizeof str || s < 0)\n return thp_mode_not_supported;\n str[s] = '\\0';\n- __close_nocancel (fd);\n \n if (s == sizeof (mode_always) - 1)\n {\n", "prefixes": [] }