[{"id":3684344,"web_url":"http://patchwork.ozlabs.org/comment/3684344/","msgid":"","list_archive_url":null,"date":"2026-04-29T23:45:20","subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Thu, Apr 30, 2026 at 7:38 AM Shamil Abdulaev wrote:\n>\n> If __read_nocancel fails or overflows the buffer, the function returned\n> without closing the /sys/kernel/mm/transparent_hugepage/enabled fd.\n>\n> Found while investigating BZ #34083.\n>\n> Signed-off-by: Shamil Abdulaev \n> ---\n> sysdeps/unix/sysv/linux/hugepages.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/sysdeps/unix/sysv/linux/hugepages.c b/sysdeps/unix/sysv/linux/hugepages.c\n> index 707a75c2a2..46e05151a3 100644\n> --- a/sysdeps/unix/sysv/linux/hugepages.c\n> +++ b/sysdeps/unix/sysv/linux/hugepages.c\n> @@ -61,10 +61,10 @@ __get_thp_mode (void)\n>\n> char str[sizeof(mode_always)];\n> ssize_t s = __read_nocancel (fd, str, sizeof (str));\n> + __close_nocancel (fd);\n> if (s >= sizeof str || s < 0)\n> return thp_mode_not_supported;\n> str[s] = '\\0';\n> - __close_nocancel (fd);\n>\n> if (s == sizeof (mode_always) - 1)\n> {\n> --\n> 2.54.0\n>\n\nLGTM.\n\nReviewed-by: H.J. Lu \n\nThanks.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=pP3Fc8nd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=pP3Fc8nd","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=2607:f8b0:4864:20::535"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Ypz5c2Sz1yGq\n\tfor ; Thu, 30 Apr 2026 09:46:19 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id D18104BBC083\n\tfor ; Wed, 29 Apr 2026 23:46:17 +0000 (GMT)","from mail-pg1-x535.google.com (mail-pg1-x535.google.com\n [IPv6:2607:f8b0:4864:20::535])\n by sourceware.org (Postfix) with ESMTPS id 5FA514BB5939\n for ; Wed, 29 Apr 2026 23:45:57 +0000 (GMT)","by mail-pg1-x535.google.com with SMTP id\n 41be03b00d2f7-c798fc1a28cso90559a12.3\n for ; Wed, 29 Apr 2026 16:45:57 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org D18104BBC083","OpenDKIM Filter v2.11.0 sourceware.org 5FA514BB5939"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 5FA514BB5939","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 5FA514BB5939","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777506357; cv=pass;\n b=frrOwXcQy55x7oFPYaU6BHxsy6zSz0mtO13fsBBl8Sbldx5wCoCSo4Vmv+y3kRmB3YZKQFkHe3HnfbcNAv7PhJiE4rq0lCap00WgraOAARD4Fz3DmkphZWAcqXgFPPOP+di8zKDvgyQ5/opNtIXPgQdzV1KNFKcZogGL+2DqfmU=","i=1; a=rsa-sha256; t=1777506356; cv=none;\n d=google.com; s=arc-20240605;\n b=EVhe9/GxlSKDNcOD2NOpOFm1uyRz6+POWXOMIlzn+KMuVad9cMDNhZpIxCX8QnBU8f\n 7ktWQK28Mkj5pmJtf/uWac5ODEibjBogthk6t69g0XkBLbanMgsvgUcKA5NcvtIq9IU8\n N2Pd00G45Pf+geMaaPIlnrSnpqFkGn1/JKH3AvsmKUwrpgQuGPy5GZYX67eiZeKHVd/V\n 4Pdm+TecDXigJS7G4nuFFNgdfqbVSnInRzKa68AOU90tsTuap+wPYfMq2T0wEazUyj6k\n SqwDdB/PaifvZOEjmczHD/32u6A3Xz1L4ga9bZThfMGqNZYXknRXdTwAVv3a8N8WCWqI\n SkfQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777506357; c=relaxed/simple;\n bh=Uo6BZ5O3IX1fnxsxFZwkBom/QfF6kceJuQPvL3rWwvg=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=fUxwCrxPrnPoWql/jCHZByiaHg/VseNW9cAUopCOBAp+C0vIEcVryy6y8IEMvjXGxTc7xUDx06N1WB4PFE4etreyBE3HQHprq2nkdWAGpM75XJOfyi88/Qqz1GMSgheXw4l0BaxrD949rvkc9DA2vXim0Av3WSY2aXVUFai69PM=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=irwbtKpEXHxd2sq2G2CWxHnDgZmfu/5Aya6Giw7L5L8=;\n fh=wySXbLpfkRLIAADWUhtLVg/AwD4q5PVbEI5Up0gmkxE=;\n b=G9Q1EdId7CI1XEXUx1e/Fwwptw6IteRC3LEXKelcS10670NwI1NvNQiSSsbKWgnt3k\n 1suRktGg0StPohU9NZFdgJs0h02h454lnhginwyEs6ZYrpNHfFwYDsDZkp4hLxFOHQSG\n kh2d77kliIBf9ZKjuyZ9yRKP84LyRPzzczCuH0pKdiXymeVraCAmvqoZM7Vn17u8Mip3\n sSOR7Kf++NP8xoXx5jfmJQbV12HNkge2W4T8JtklAwXoIujBTpIi8sWsGtYMP6TGttHV\n nUlPDVXaTXnTzJZ/nvg2CkSf6w4Iuk4TOVDE0/JM2zMnvHnta/3rDKWwciSqIQsavnrB\n Fg6g==; darn=sourceware.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777506356; x=1778111156; darn=sourceware.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=irwbtKpEXHxd2sq2G2CWxHnDgZmfu/5Aya6Giw7L5L8=;\n b=pP3Fc8ndG6Kuw+pfH3IlxWYyoBvM8SDhVApY8t9mz//pfgsDAd3mz3r5B1K5xxFXEO\n NjxqDD8fhTEVbr1vdfCLgHer1hVtk5KO98z+v7DnpmjH8Mm8kgkwplS6SlCqvOA52qyK\n EDK/dlVblDw14JyOkDBBRziVNYeAR1/PrhXdo0iUe0b63eMntIG9S+z5pqbWFyQ0pKsv\n eQpnzbpmPpynMv35Qjc8ZDYOzO+lC691k1s47l6SZ/vvdi/+2u4z/W1qlq9lFK+l5pNJ\n U650UvYLvN87/nGdbLIJQrdlGgFXKPgm9JLsSUn8mDH5ViI/5DC1Lnr+zVEqLBnkgvBD\n kNNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777506356; x=1778111156;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=irwbtKpEXHxd2sq2G2CWxHnDgZmfu/5Aya6Giw7L5L8=;\n b=gYNzI+7ckP2NS5QigFu8y/oZsb4pVJ+xVoF0OI3Faof0LkAT8C7RXncpWfC8g/qzsT\n 5N7Jj1HHfokjW7jAugkQNe/MJLOXUQ7PelUyznfNyLeop3QIvuoHXrpAznZ9fyeP2hIl\n 7AFVwtxR1Twh13Q3zc85YlDVcyd0/R9fm7D6VWohGO8AkLb1X4LYfDg+yfeznVlysqFz\n raHzYE2ib1vGz+FGE2BauojzGhVm+kEVMNQxKeEcLIzd/g0ddDHh4clTiFzU8g3kq0Ib\n vn3Y8c+jMCsdezdcGA07gT/VGnYNxnk6yYVw2c63FzmC6g5DTm/aUA7Ob30wSG/xHAXH\n nhPQ==","X-Gm-Message-State":"AOJu0YxfRRmcBGGFqa2dTbZRM9Y9rBnF9uQXEsmp+2MnOLc1ygiftQDO\n 5YXssqsZIUxIT3WhMOS/p3bldbU1I1+tpqmPXwpYzkYRYvQp/iEbK+azsfT5B29BFJsTQV36ACt\n d3epGV3k9GDaDDZEEMcPmFJS83Ocm0mg=","X-Gm-Gg":"AeBDievjUfjmL6P/C61N7ANjAZDNRo6C1hfjdzYr6cvYRH7EYOPJicy9UkwkksTJT4M\n EilVBquD4r0akfqurOeUq6/rsTFHvPxOgI5vOsRpkWYerKP7Qpcc/9JJBfWu/9qWiX+5/Pe0orx\n JCQ2pXCrO+J6wNFKtjhQ8/lQYRcsxUlVBFi7muRagUtJZJ1jiqW1m5NKFeBrebILTIHnkbvl6/W\n KzGYR4iJo4aB4iECLPsrJhdB+1cnNesQoJh8Fd0iZG/UuGVwjx+BHL5kZJm9Bghwqkcz6jAUGEi\n 5DXX33IrI4eX9/KjcA==","X-Received":"by 2002:a05:6a20:a104:b0:3a2:fbf9:d823 with SMTP id\n adf61e73a8af0-3a3cf56f0ecmr560511637.8.1777506356239; Wed, 29 Apr 2026\n 16:45:56 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"\"H.J. Lu\" ","Date":"Thu, 30 Apr 2026 07:45:20 +0800","X-Gm-Features":"AVHnY4JU3mQ1-ZfAhgYkmzaqZXrvCTdgYJ07OSfc8Kn3g3vQbgai-8XesAozZVo","Message-ID":"\n ","Subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","To":"Shamil Abdulaev ","Cc":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}},{"id":3684658,"web_url":"http://patchwork.ozlabs.org/comment/3684658/","msgid":"","list_archive_url":null,"date":"2026-04-30T12:19:45","subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","submitter":{"id":93241,"url":"http://patchwork.ozlabs.org/api/people/93241/","name":"Shamil Abdulaev","email":"ashamil435@gmail.com"},"content":"H.J. Lu :\n\n> On Thu, Apr 30, 2026 at 7:38 AM Shamil Abdulaev \n> wrote:\n> >\n> > If __read_nocancel fails or overflows the buffer, the function returned\n> > without closing the /sys/kernel/mm/transparent_hugepage/enabled fd.\n> >\n> > Found while investigating BZ #34083.\n> >\n> > Signed-off-by: Shamil Abdulaev \n> > ---\n> > sysdeps/unix/sysv/linux/hugepages.c | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/sysdeps/unix/sysv/linux/hugepages.c\n> b/sysdeps/unix/sysv/linux/hugepages.c\n> > index 707a75c2a2..46e05151a3 100644\n> > --- a/sysdeps/unix/sysv/linux/hugepages.c\n> > +++ b/sysdeps/unix/sysv/linux/hugepages.c\n> > @@ -61,10 +61,10 @@ __get_thp_mode (void)\n> >\n> > char str[sizeof(mode_always)];\n> > ssize_t s = __read_nocancel (fd, str, sizeof (str));\n> > + __close_nocancel (fd);\n> > if (s >= sizeof str || s < 0)\n> > return thp_mode_not_supported;\n> > str[s] = '\\0';\n> > - __close_nocancel (fd);\n> >\n> > if (s == sizeof (mode_always) - 1)\n> > {\n> > --\n> > 2.54.0\n> >\n>\n> LGTM.\n>\n> Reviewed-by: H.J. Lu \n>\n> Thanks.\n>\n> --\n> H.J.\n>\n\nThanks for the review!\n\nI don't have commit access to glibc -- could you push this on my behalf\nwhen convenient? Happy to rebase or address anything if needed.\n\nThanks,\nShamil\n\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hd/pGs9r;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hd/pGs9r","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=2607:f8b0:4864:20::735"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5tY715blz1xqf\n\tfor ; Thu, 30 Apr 2026 22:20:24 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 96CF44A97362\n\tfor ; Thu, 30 Apr 2026 12:20:21 +0000 (GMT)","from mail-qk1-x735.google.com (mail-qk1-x735.google.com\n [IPv6:2607:f8b0:4864:20::735])\n by sourceware.org (Postfix) with ESMTPS id AF8AE4900308\n for ; Thu, 30 Apr 2026 12:20:01 +0000 (GMT)","by mail-qk1-x735.google.com with SMTP id\n af79cd13be357-8f83efb5729so93387085a.1\n for ; Thu, 30 Apr 2026 05:20:01 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 96CF44A97362","OpenDKIM Filter v2.11.0 sourceware.org AF8AE4900308"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org AF8AE4900308","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org AF8AE4900308","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777551601; cv=pass;\n b=Q3zjUIW1x7rqFKUvAGeZYMAmdwB+2gtbUq2soDPYKN5LeZKWes2XA+UnwPcXvowXSri55MOMMVpo2fdNbGXSmCNnEgTuNmfQo07UcsS0me+MdzTw7JWDucm5RSGbOPNOCkfDvoaAA0VU9pdZEqHBASkr6nOWe6msy41YCiD1Rgc=","i=1; a=rsa-sha256; t=1777551601; cv=none;\n d=google.com; s=arc-20240605;\n b=Q/LNqf+j0eKry4D9f9lj3RZdZJxe8mG0XQvNfgS6+USDTeNr1eLkWre4pXPtw1v70T\n DsiayFh8gZWqQy2BHBEoFgGR3Kou4cBfWwKxnxLGnYyR8+hTVTQbZ67dmmRIWuPjNsIA\n J/L4cJskIuu3vwrafDXRYaCDMSwMyDEh54jnL+v2DhTYRxEONhaeFsmgmmUVn3+BZv6N\n aAUBT4jkZocKkoFEB0yhe0nZsfMErWAOQV6rZsEKSv7CWR3UvZV0C0K9H5+WNZ9GJFzz\n lvc5LLMw+XpLdap8nnIj3yX1OVkaP+o2hl8nL5ogD30xI6p1e7AsRGXueQlT0vxt0Vp8\n u+lA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777551601; c=relaxed/simple;\n bh=iU1WT31HEvSX206yYwxjobONZ6Z4g9npIrl/IPndduQ=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=CfgdyYANAa3HG9tp4vqXJ8qCkIg9tZuTjfabc1EXy/vLAy64SBaCMaMIP2WQUZNaMmPOgnLdIg9lE2Mr3Z1e1nT8cJ82l0y66BOeX6MHzCS3+N9TilL+/KiYfyngX+c8gpgQIMyKRG59La7ytRVgfh7C3ls+6sI0SHwQxspiQRg=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=GkGUsfcN5sgvyGs6eQ5DM2BN6kugVsAf0X0/6UGYoKQ=;\n fh=TFpZ20//l1H9WTIDaYk/Xy8kvuhOZY04tdQZze6A/SM=;\n b=axlGcLVeWxwjtlFXBJeJVzrqetp9YSFYt8gzS0zGZH6rU+m+u9NYS+sy/SWCLMK31Q\n I6/hDDW0xzWLyJCbdzywdhupeFu3ilG4gcnJaZNkEoYdRHmfcMa4pIOSfKszMrh2OBG2\n DH/HozLQNXV1RXF/Z6AlJN+xGGUfNgwIMg91A35hRd4ajaMmXPztaHe/IFpbVFifX3vs\n UFIf4Hara3xJUnITg1sFoBVDO2LYlg54IkwdVywb7HobpuAktlZjHsiOdSl0KclhvsjP\n 85+JK33Pcc/K87BsYQJlCv8/KdJwTIjNG8p5jizER+715tLBELdTtkKcHn5vA9zXkinS\n 5kdQ==; darn=sourceware.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777551601; x=1778156401; darn=sourceware.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=GkGUsfcN5sgvyGs6eQ5DM2BN6kugVsAf0X0/6UGYoKQ=;\n b=hd/pGs9r1IJF/xtpietDhLPCLzc9LFGjs5P9Q7c++DhV8AUQafkzPiMu6Bz5ZZnx7C\n A2qRlryxO1EfGZfD6hIb+EyYeQ3tZL/ne58+Q/CEcb+p39R9YZIoZScHd1YUWvzsHPxd\n ylL4iHGHEJnNvCsIudJEgrCRnV6RfqelxCrzYHSzk4RZrQQzzJk12BBpMYHbNBOVQD8i\n wcwdpG3jAMsqKngN4PS0dqTyYZxrOqMq64Can8lZlLq62B5d0IlV6Y/xC/b50oOsoiGg\n lWApAQOG9dbfIUv0Y+9RHHS41zbdVeIPLmKcRVeCjcyHZ48pfZJevDwBkHpE+5n+9t8+\n 9tVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777551601; x=1778156401;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=GkGUsfcN5sgvyGs6eQ5DM2BN6kugVsAf0X0/6UGYoKQ=;\n b=YhW1LkCBq3iThjiZO6HOmBMBuvXZlBIagTON5uwvEYJeMso0tUxMjuDMTP4LbZWNPA\n PW6Hzxqzq4/+lbejeoOEi0Clvmqg/PDqisTEVb0cziqgahBgP0+3IKDN3PbHlxSqUlYv\n nAEKY7/nK7HYv8+3KNPGY83M73pOPE3CA42kmMZ4Tsitk7TZ5cckXUZWR2/9d6wNOuim\n ft57ow4juXMLGdVHVJHONxUzHJtbcb0GypTWcnjBMR+aBjnPY1RA5q6OdYNy3OQuZT/M\n s9tIV7FlAGdVTFe+APDvf+OxkOmqJCBtR9JHNB5MEUtbx55YnajMVGc08aOE2stWhd8o\n Pq0g==","X-Gm-Message-State":"AOJu0Yyzuoowov/TFPFgZPQVjonMVf0BCeS9nKOsJT3XAvjukwLKQu8k\n Tzsn2489o8qwzz7Z1vXMyR56W3SRnvqJBc7PLKt09ehvsyHiZXPnQ6ieS9TKRH8sD1uwEHxiW5j\n y9RtDOWZTi0knInbqw+TxiQvhtwzbNeU=","X-Gm-Gg":"AeBDieut/c6d0UiwSUeKAC5AhYcPSJhO4vuOrQsSLuKx3idadYKwrJAhZSEgY171oFO\n W3qGwULviYeiZd22Wm5WqpAA4vlQYoMdXFNHLOJSQPmAj1+xTcTOa1RaYtbHbCh9d+ZLlVU1w8v\n 0gxj4XybmUQPWy5Yvsd5Uya1+iKpIK7dwuYDGB413rwk5RrtzgGJHJx4wR499DKpNgqdIdDl2CX\n Dwh1HiUv6n6HQgljG3BTAKO0TakOa3t19QTrKbeFXyWm1fok4J87RvRaFy/R57gbUte5YVBukp3\n YXrZtX87fs/AQJv6h2t1xuWM1RtNn9l4dpKPt0yamyosdNlYn87MpF/m+feFhSN3x99WtpxCCrm\n OaoxkcU2Dxl4KJEQk5w==","X-Received":"by 2002:a05:622a:494:b0:509:1009:e7a6 with SMTP id\n d75a77b69052e-5102ae75721mr37029491cf.43.1777551600976; Thu, 30 Apr 2026\n 05:20:00 -0700 (PDT)","MIME-Version":"1.0","References":"\n \n ","In-Reply-To":"\n ","From":"Shamil Abdulaev ","Date":"Thu, 30 Apr 2026 15:19:45 +0300","X-Gm-Features":"AVHnY4KOub1HDQ94AxKHEdn6z303ilye4R8xfQa809YnifV7T7XFqbGABvXc0Mw","Message-ID":"\n ","Subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","To":"\"H.J. Lu\" ","Cc":"libc-alpha@sourceware.org","Content-Type":"multipart/alternative; boundary=\"000000000000bf0b480650ac7b14\"","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}},{"id":3684661,"web_url":"http://patchwork.ozlabs.org/comment/3684661/","msgid":"","list_archive_url":null,"date":"2026-04-30T12:22:36","subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 30/04/26 09:19, Shamil Abdulaev wrote:\n> H.J. Lu >:\n> \n> On Thu, Apr 30, 2026 at 7:38 AM Shamil Abdulaev > wrote:\n> >\n> > If __read_nocancel fails or overflows the buffer, the function returned\n> > without closing the /sys/kernel/mm/transparent_hugepage/enabled fd.\n> >\n> > Found while investigating BZ #34083.\n> >\n> > Signed-off-by: Shamil Abdulaev >\n> > ---\n> >  sysdeps/unix/sysv/linux/hugepages.c | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/sysdeps/unix/sysv/linux/hugepages.c b/sysdeps/unix/sysv/linux/hugepages.c\n> > index 707a75c2a2..46e05151a3 100644\n> > --- a/sysdeps/unix/sysv/linux/hugepages.c\n> > +++ b/sysdeps/unix/sysv/linux/hugepages.c\n> > @@ -61,10 +61,10 @@ __get_thp_mode (void)\n> >\n> >    char str[sizeof(mode_always)];\n> >    ssize_t s = __read_nocancel (fd, str, sizeof (str));\n> > +  __close_nocancel (fd);\n> >    if (s >= sizeof str || s < 0)\n> >      return thp_mode_not_supported;\n> >    str[s] = '\\0';\n> > -  __close_nocancel (fd);\n> >\n> >    if (s == sizeof (mode_always) - 1)\n> >      {\n> > --\n> > 2.54.0\n> >\n> \n> LGTM.\n> \n> Reviewed-by: H.J. Lu >\n> \n> Thanks.\n> \n> -- \n> H.J.\n> \n> \n> Thanks for the review!\n> \n> I don't have commit access to glibc -- could you push this on my behalf\n> when convenient? Happy to rebase or address anything if needed.\n> \n> Thanks,\n> Shamil\n> \n\nI will do it.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=yDRmQGs3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=yDRmQGs3","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","sourceware.org; spf=pass smtp.mailfrom=linaro.org","server2.sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::122c"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5tc953Svz1xqf\n\tfor ; Thu, 30 Apr 2026 22:23:05 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B8463436F7C2\n\tfor ; Thu, 30 Apr 2026 12:23:02 +0000 (GMT)","from mail-dl1-x122c.google.com (mail-dl1-x122c.google.com\n [IPv6:2607:f8b0:4864:20::122c])\n by sourceware.org (Postfix) with ESMTPS id 2DDBF4371D59\n for ; Thu, 30 Apr 2026 12:22:43 +0000 (GMT)","by mail-dl1-x122c.google.com with SMTP id\n a92af1059eb24-12dbd0f8063so479906c88.0\n for ; Thu, 30 Apr 2026 05:22:43 -0700 (PDT)","from ?IPV6:2804:1b3:a7c0:44cb:1515:6c52:b4a9:e795?\n ([2804:1b3:a7c0:44cb:1515:6c52:b4a9:e795])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12de3269acasm7096129c88.12.2026.04.30.05.22.38\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 30 Apr 2026 05:22:38 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B8463436F7C2","OpenDKIM Filter v2.11.0 sourceware.org 2DDBF4371D59"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 2DDBF4371D59","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 2DDBF4371D59","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777551763; cv=none;\n b=uMATt0PdAD6xI6eHRCN9TWkFsTu6BIGRno77QCRzMpD1Qik30n255wZYYnNk7Hsur/bq4VGmNxpfAoIMKpjH8KDi3n2iQwB5DVa7vnmohnfg9Z4eYj350VU8vtcXhAndRBDHXlHH9ZtShC8H3pgfc4+wT4psdt6JAqlmaDPzk2U=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777551763; c=relaxed/simple;\n bh=NC4HQeZQG9HYgUIZVEkWBZiFZUi+4jFNirTyUDRlvaY=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=B/g2/3uoGY+lHrEmjt6H8TpSud+ZqQZpUP0rfiXRUypYewILJTd/peuPMXmhuf6ACHbM96uU3zOfrVSxo/x8KhhvC7dMYuJSKAAVlQQC3CovOKacI868oKFstNSP7zbuQRhzDPsM9V8Iou4kbHBN2L0LVaasHpRDu18JaqGlOH8=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777551762; x=1778156562; darn=sourceware.org;\n h=content-transfer-encoding:in-reply-to:organization:from\n :content-language:references:to:subject:user-agent:mime-version:date\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=nxglP611psjOrNFEZvm6Hic48fCy29TqHJu0Qimsikc=;\n b=yDRmQGs3G2yLQg82x1I6miScunY1oauBQtHdFnaoP/o/xbeKNvFsHspBoWnKKYLgtZ\n wIdQnxeAR3sUTcPvb1BnRPFK9B3IdGX0LmoP4otcRfroCrE8CUEbg20xfZmy4T5eBDU1\n 9CfZ8g5bywgM7cSB70uT1kCrEmPDWhSy9koLdtrqYWhLFJy8+9HyReaP373hhkUa4GO/\n XMMffOsthaIbHhTPuZWjBY8smu/iDVo/9zacgHIw/GBISjPlg+IK3H2CLQq9OHhVzZKx\n H8deBzufWA2D9RFmsYsWj2k4PJ2N6wCEUbLHf6oRdJLHKezgpSrqlZHXidAXt+mxG9Zq\n grsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777551762; x=1778156562;\n h=content-transfer-encoding:in-reply-to:organization:from\n :content-language:references:to:subject:user-agent:mime-version:date\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nxglP611psjOrNFEZvm6Hic48fCy29TqHJu0Qimsikc=;\n b=Sb9vHpg7VaZBDeMmRdrcu1Ac10bzf5on75Zkce7O8ROA1aRzSzFOvZeu2+1zLfoTI8\n n4V0DL9b/xj70XCLwDM5EODg2XT3C4xA0GqTJkGvsdaca+gd3lRO+gPsFJ3jAYNnTQOp\n bPkUSEnoJZzOFxzovN2ZtcOMjoRJR3qqlMAK8vBI70WYXhP41Puaq+fTjFdDlVGsf71n\n nUj8gb4BgtxqghulToAKmg/t2pmFp7k9bZtdH5v9tFFd3qlkIBpBjwYqaJZeShBGHBbF\n qX+yotGYL5ygX+uGXusNU8YyCY0YaHaeuJ1asvxL75YM1hHFTwbqWdCNBf8vwQFR9yBs\n tZ0g==","X-Gm-Message-State":"AOJu0YwZdQygtnapHoLvfqqs7ksnd3DdBtY/QNILjhG5eAbLyZyRaR6W\n QaMQkGfFE0uxr0f3htKYNtzeYAq4cPkCZcRrUb1E7jd495KFmbfFm5KzXEWq8xzDV9uuHQYvToS\n LkoID","X-Gm-Gg":"AeBDieuehbhUubsUrmCr7rDAcZNG0nvY1Cl1+utiK5Y93q4woVg0WSMNDdOCs9j5NZv\n a1MYA6am4+YWYo2NYswFa8O+aJMqsqMmmrmfwjEmUyiYCo66rdX+mvxWZEz4PlpY49Q7W759+FK\n 8aBAmqcPfIOf7YrFqqiSMBKRJsTpN2BGew6Z3yFvPg6PvRPXgQFzIcB6Hk0ERNb6AQpNHtVtv7b\n 9n2jXFLVTvmjjgPnS/LWVjOxHNrXKJEvao5FhpnErclB4YepUGU/gkCyU6TxKx9KTRTNvHUAT9N\n V5Ig0R4DLzFhoJPTI29sv0Afpy1iTrZrtDWe5ixb2dcpaFRLnscOsYg6ajpsccbtSf+ElgcbWRF\n WoQbDPfEKwW849JpSpranRTWioWhMh4FCNscVN8mU9tDnk+IFBBfb9YBMWkosSxe6TWwNk4RGoY\n reMbccYj0DCvHXvYOKDjznsrv8PpaUJJ6MrKzx5UKdgj+2jHLfUV6nkCAWINM1KJ9idLNk3vRs2\n JkYs/sLLwYhLUQDfnxoHkooqp/v9D0niR0vFgBqTCeM","X-Received":"by 2002:a05:7022:3d06:b0:12d:b205:c737 with SMTP id\n a92af1059eb24-12deac7bb6bmr1152037c88.17.1777551761706;\n Thu, 30 Apr 2026 05:22:41 -0700 (PDT)","Message-ID":"","Date":"Thu, 30 Apr 2026 09:22:36 -0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","To":"libc-alpha@sourceware.org","References":"\n \n \n ","Content-Language":"en-US","From":"Adhemerval Zanella Netto ","Organization":"Linaro","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}},{"id":3684662,"web_url":"http://patchwork.ozlabs.org/comment/3684662/","msgid":"","list_archive_url":null,"date":"2026-04-30T12:25:40","subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Thu, Apr 30, 2026 at 8:20 PM Shamil Abdulaev wrote:\n>\n> H.J. Lu :\n>>\n>> On Thu, Apr 30, 2026 at 7:38 AM Shamil Abdulaev wrote:\n>> >\n>> > If __read_nocancel fails or overflows the buffer, the function returned\n>> > without closing the /sys/kernel/mm/transparent_hugepage/enabled fd.\n>> >\n>> > Found while investigating BZ #34083.\n>> >\n>> > Signed-off-by: Shamil Abdulaev \n>> > ---\n>> > sysdeps/unix/sysv/linux/hugepages.c | 2 +-\n>> > 1 file changed, 1 insertion(+), 1 deletion(-)\n>> >\n>> > diff --git a/sysdeps/unix/sysv/linux/hugepages.c b/sysdeps/unix/sysv/linux/hugepages.c\n>> > index 707a75c2a2..46e05151a3 100644\n>> > --- a/sysdeps/unix/sysv/linux/hugepages.c\n>> > +++ b/sysdeps/unix/sysv/linux/hugepages.c\n>> > @@ -61,10 +61,10 @@ __get_thp_mode (void)\n>> >\n>> > char str[sizeof(mode_always)];\n>> > ssize_t s = __read_nocancel (fd, str, sizeof (str));\n>> > + __close_nocancel (fd);\n>> > if (s >= sizeof str || s < 0)\n>> > return thp_mode_not_supported;\n>> > str[s] = '\\0';\n>> > - __close_nocancel (fd);\n>> >\n>> > if (s == sizeof (mode_always) - 1)\n>> > {\n>> > --\n>> > 2.54.0\n>> >\n>>\n>> LGTM.\n>>\n>> Reviewed-by: H.J. Lu \n>>\n>> Thanks.\n>>\n>> --\n>> H.J.\n>\n>\n> Thanks for the review!\n>\n> I don't have commit access to glibc -- could you push this on my behalf\n> when convenient? Happy to rebase or address anything if needed.\n>\n>\n\nDone.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PQT17ucL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PQT17ucL","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=2607:f8b0:4864:20::52d"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5thJ00cSz1yHZ\n\tfor ; Thu, 30 Apr 2026 22:26:39 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 243CC4B99F54\n\tfor ; Thu, 30 Apr 2026 12:26:38 +0000 (GMT)","from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com\n [IPv6:2607:f8b0:4864:20::52d])\n by sourceware.org (Postfix) with ESMTPS id 209CB4A97362\n for ; Thu, 30 Apr 2026 12:26:18 +0000 (GMT)","by mail-pg1-x52d.google.com with SMTP id\n 41be03b00d2f7-c797d5ad36bso303378a12.2\n for ; Thu, 30 Apr 2026 05:26:18 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 243CC4B99F54","OpenDKIM Filter v2.11.0 sourceware.org 209CB4A97362"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 209CB4A97362","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 209CB4A97362","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777551978; cv=pass;\n b=mtsvUvtyrHVM6/9oMrq1i0geVWF901ko7+imZpMhJ3q2XW9IUEMB3NrXMpDwLJDwD4KTGTHkmFf8V5A9PsU3nyOoDrTsbH3NdNedjSEghtEQpXZ5OxhASmBUWEuFr99lwTGjafIseEOCyp+0sJfN6Fd0aAznE9sdMDHV+rqhfWE=","i=1; a=rsa-sha256; t=1777551977; cv=none;\n d=google.com; s=arc-20240605;\n b=JkDmxeqhMQl3UUeX8xU4Zim/b+7DUkzUpCgFOUKJ/nLwQQMYTxnVLB1uJECcQu4pv9\n 58Gh+bvTQlDtBdo7zTCSCZ9R8eggr4wtSNnVS31wU1y9MPL78FaaS2ePiuI2moODQTZk\n 7h3nIUm6pp7o/5+p/TlR78YmqInGf1/PJidtPu8TsyxdDTY7lpwyARHKvZ/J91BlFPfj\n Vx1V4quz042CpJ3MDoMFWxgCdomL1CYqm92SAiae26yxd+tY8PSpcDLWW1lFlPuHh/hc\n kPYnPGMDM8zTnmb5kJjJDPqIR4r4AndhNzab6Q2Afsm3H3tpsrjvyXR9kUrW+AQL0Cj8\n HgxQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777551978; c=relaxed/simple;\n bh=BCP3fH5obcklg/LLRYsTn9q7JwYqAWnemFGnYwtHC4A=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=uQPcXzeKvfTeG8uNwYfX1AtmYmhtQNYFLWfS82dLHIMNvypEDjy4vCWGy0XKR9UQz/tIREdQ2+/1n2PzpUI0FCoWgiwA6+5+/guQfSdiLaMu9I5iNdtNSq5So/7zie8W8m2hncl9WHqngpPn1RxKV5yjWdLkpRDu4ituhhRV81Y=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=8njd9cGAcPNmBcIHYu5RBufMo+LfdwXEC/Aer7wltZc=;\n fh=wySXbLpfkRLIAADWUhtLVg/AwD4q5PVbEI5Up0gmkxE=;\n b=eAoVfWzlAAZTstYx7xZmh9ojxsor8zGM6FSczFRTW8i7tqoxupe9X74IVZ9drhyYqC\n aifgYEem+5Ieuk3er6gZ4xNndW43/4UlXt+7QnscFa3OCAKWr3UeXqwQ4mWyP3eu10bG\n F52be2foBfiJ22IbEA2sFiEiOwkHtDr5WK7i1blVz5FUFlOx1l9v4dTFX2aeLljiQ66V\n vPHWBkjTOIGON3KauMkSWi2L3Da7EJUDktkfJ+gAnr/bBVF8vG7GmCO2+dvvgk5vrVbq\n DRrP+FKm/65/TrizRwkBt5QEyfLa81lX++DCHJ3zkGYQn8+nD581b1x8K1ZS+B7aTx1l\n syDQ==; darn=sourceware.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777551977; x=1778156777; darn=sourceware.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8njd9cGAcPNmBcIHYu5RBufMo+LfdwXEC/Aer7wltZc=;\n b=PQT17ucLCH8NF9PE0iVzIZZJ3FvtrVF97w0AS5vkobjfRHdYEYr8DWUXpbPVWfueo5\n N0Oo4u/xuk4TB5byix/YUb42R/iAPYDbTa03J7knFvvR0c4FyE0C/CqeTO69514BQlci\n Cy8eKNCuTknLfZMdpMT6KlaU91zmHUaENLT/G/DlnbwqWyL6C0ULtL8/HhNfWHECS6ya\n evKcgbNu+ozpRSqgFWAZadypYHLai+TMyqNbG6K/AqYkvfEjn11vuJyvE6KOdak7yfuo\n kdEzDkiuOEwnDjLcbK2mrvkB2/f7RKPtf4bzmyCvxp/InshjxlsYECSNpwyA2z1jNptu\n RJVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777551977; x=1778156777;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8njd9cGAcPNmBcIHYu5RBufMo+LfdwXEC/Aer7wltZc=;\n b=LJCGANb+Q2LLIfkhUjFs+H+dIwrDqEzegvJSh3ZX/gUfJXM9CBPrzfALoXGWzzG+up\n FcWqg/NQrv9L1Ijwz/a7dqTn1D8IdDDt37MJy/7qA/5wE2t7M2Wsnbc4KY/e9bV2fGkk\n wWXdhhVUJ3MirpFkLEfnRh3ieTeJ44L1rXYQxb7AJ6dRuqkZ+eQr3RT50QfEmtzObGa9\n kx0l07dl4j2+FQ5RxamaJ85R+8vRMZLm/DZkbTEaDcPEbvrfELFQtrTZiV/L7rfMraGg\n qU9sp+A0HCx9zgyXNLw6focNsC0B/RT1XmIQ4BLKa9e/zA7EliSYnXvOMjH7DghS10JL\n 0tNw==","X-Gm-Message-State":"AOJu0YxG+nKw9kA+gzSOawfq3WeummEjlZiVjfjhBLe/4wCK+WcdXg08\n Bl/GHKM31o7vYh1EY+FbOpDQphOFIEiSg8oFy/dF3czNA4xh/BmpGTLD0XSjAbBAzZLznvhkE2k\n Le83wF6jAGDossIVqvV1dpxCbh83UfLU=","X-Gm-Gg":"AeBDiesik8ERXoi/rB4nUCQAMDomHtSbWYFDHlRUkz0sFqCYbAwh9X86zgy/aP7DjIg\n tAlVlSoYTtjqtWAQZJvhwjYia0+1L4mCioG9Yd0Oh3WQD8ziivwvJjTvmyJDw3lxJx7RFQO/Biy\n xkujXYvN959s1X2FwnwiYlkSymLhnlZU3ExZdrEolRB0hhBZOqCoIHeGff8bT3r3ACuDEh5CvLX\n uiFuDxBTBHEDvBPOa4iZ7/KsYbR2zRSnx9HIQgiVl/9MTiVjkw1tgsUhxYPYTuy0xEgNVIkI7uC\n MbBZI1b00Nm789L7og==","X-Received":"by 2002:a05:6300:2109:b0:3a3:1071:89f0 with SMTP id\n adf61e73a8af0-3a3cf512f7bmr3378629637.2.1777551976932; Thu, 30 Apr 2026\n 05:26:16 -0700 (PDT)","MIME-Version":"1.0","References":"\n \n \n ","In-Reply-To":"\n ","From":"\"H.J. Lu\" ","Date":"Thu, 30 Apr 2026 20:25:40 +0800","X-Gm-Features":"AVHnY4LV-d-A-UV_FEOMpQin22V24IhH5h-HXqtq3W_DV5Tl1pSMtAWz0eYXYP0","Message-ID":"\n ","Subject":"Re: [PATCH] hugepages: close fd on error path in __get_thp_mode","To":"Shamil Abdulaev ","Cc":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}}]