Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230569/?format=api
{ "id": 2230569, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230569/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-10-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429210830.594724-10-berrange@redhat.com>", "date": "2026-04-29T21:08:30", "name": "[9/9] qom: drop user_creatable_add_type method", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "50ff16deb655e0f3e6e7d48921661e1b2f6adff7", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.1/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-10-berrange@redhat.com/mbox/", "series": [ { "id": 502152, "url": "http://patchwork.ozlabs.org/api/1.1/series/502152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502152", "date": "2026-04-29T21:08:21", "name": "qom: misc cleanups / fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502152/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230569/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230569/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=O7gylcU+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VLN2dXTz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:09:48 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIC9U-0007bx-9V; Wed, 29 Apr 2026 17:09:00 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9R-0007Vh-1h\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:57 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9P-0004F5-4M\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:56 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-676-HOSWMhwtNOq4AKH4Ln1Glg-1; Wed,\n 29 Apr 2026 17:08:53 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 34D01195605C\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 21:08:52 +0000 (UTC)", "from berrange.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A7346300019F; Wed, 29 Apr 2026 21:08:50 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496934;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=19Mg2EdExOT050N3vQjL+MBdUKKskeVvo0VAIBOOz8Q=;\n b=O7gylcU+ISMfAYTMNsL+RZKMEIsjfVbvdImlWX+6dr4Pa67AusDBAJ1n0ndtDmYTW3q/SW\n +SW/6WS8+LyVFuaBseYZ3onD/AMu+DKCfCz9UXkniSpWlbANrpRXmjkAvMQTq0V6nlvoya\n T+Y7tfc6/7RtAB/fs0MB44zjP1gN/XY=", "X-MC-Unique": "HOSWMhwtNOq4AKH4Ln1Glg-1", "X-Mimecast-MFC-AGG-ID": "HOSWMhwtNOq4AKH4Ln1Glg_1777496932", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH 9/9] qom: drop user_creatable_add_type method", "Date": "Wed, 29 Apr 2026 22:08:30 +0100", "Message-ID": "<20260429210830.594724-10-berrange@redhat.com>", "In-Reply-To": "<20260429210830.594724-1-berrange@redhat.com>", "References": "<20260429210830.594724-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "12", "X-Spam_score": "1.2", "X-Spam_bar": "+", "X-Spam_report": "(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This can be replaced by object_new_with_props_from_qdict, which does\nfunctionally the same job, but the caller does not own the returned\nreference, instead the parent object owns it.\n\nIn one case we can use object_new_with_props_from_qdict_owned instead\nsince the object is not intended to have any parent.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n authz/listfile.c | 4 +-\n include/qom/object_interfaces.h | 18 ---------\n qom/object_interfaces.c | 70 ++-------------------------------\n tests/unit/check-qom-proplist.c | 5 +--\n 4 files changed, 7 insertions(+), 90 deletions(-)", "diff": "diff --git a/authz/listfile.c b/authz/listfile.c\nindex 13741d5a72..23655f8663 100644\n--- a/authz/listfile.c\n+++ b/authz/listfile.c\n@@ -79,8 +79,8 @@ qauthz_list_file_load(QAuthZListFile *fauthz, Error **errp)\n \n v = qobject_input_visitor_new(obj);\n \n- ret = (QAuthZ *)user_creatable_add_type(TYPE_QAUTHZ_LIST,\n- NULL, pdict, v, errp);\n+ ret = QAUTHZ(object_new_with_props_from_qdict_parentless(\n+ TYPE_QAUTHZ_LIST, pdict, v, errp));\n \n cleanup:\n visit_free(v);\ndiff --git a/include/qom/object_interfaces.h b/include/qom/object_interfaces.h\nindex 02b11a7ef0..e2b8615617 100644\n--- a/include/qom/object_interfaces.h\n+++ b/include/qom/object_interfaces.h\n@@ -69,24 +69,6 @@ bool user_creatable_complete(UserCreatable *uc, Error **errp);\n */\n bool user_creatable_can_be_deleted(UserCreatable *uc);\n \n-/**\n- * user_creatable_add_type:\n- * @type: the object type name\n- * @id: the unique ID for the object\n- * @qdict: the object properties\n- * @v: the visitor\n- * @errp: if an error occurs, a pointer to an area to store the error\n- *\n- * Create an instance of the user creatable object @type, placing\n- * it in the object composition tree with name @id, initializing\n- * it with properties from @qdict\n- *\n- * Returns: the newly created object or NULL on error\n- */\n-Object *user_creatable_add_type(const char *type, const char *id,\n- const QDict *qdict,\n- Visitor *v, Error **errp);\n-\n /**\n * user_creatable_add_qapi:\n * @options: the object definition\ndiff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\nindex e0a3cd8d0f..7080f85f95 100644\n--- a/qom/object_interfaces.c\n+++ b/qom/object_interfaces.c\n@@ -44,75 +44,11 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)\n }\n }\n \n-Object *user_creatable_add_type(const char *type, const char *id,\n- const QDict *qdict,\n- Visitor *v, Error **errp)\n-{\n- ERRP_GUARD();\n- Object *obj;\n- ObjectClass *klass;\n- Error *local_err = NULL;\n-\n- if (id != NULL && !id_wellformed(id)) {\n- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, \"id\", \"an identifier\");\n- error_append_hint(errp, \"Identifiers consist of letters, digits, \"\n- \"'-', '.', '_', starting with a letter.\\n\");\n- return NULL;\n- }\n-\n- klass = module_object_class_by_name(type);\n- if (!klass) {\n- error_setg(errp, \"invalid object type: %s\", type);\n- return NULL;\n- }\n-\n- if (!object_class_dynamic_cast(klass, TYPE_USER_CREATABLE)) {\n- error_setg(errp, \"object type '%s' isn't supported by object-add\",\n- type);\n- return NULL;\n- }\n-\n- if (object_class_is_abstract(klass)) {\n- error_setg(errp, \"object type '%s' is abstract\", type);\n- return NULL;\n- }\n-\n- assert(qdict);\n- obj = object_new_with_class(klass);\n- object_set_props_from_qdict(obj, qdict, v, &local_err);\n- if (local_err) {\n- goto out;\n- }\n-\n- if (id != NULL) {\n- object_property_try_add_child(object_get_objects_root(),\n- id, obj, &local_err);\n- if (local_err) {\n- goto out;\n- }\n- }\n-\n- if (!user_creatable_complete(USER_CREATABLE(obj), &local_err)) {\n- if (id != NULL) {\n- object_property_del(object_get_objects_root(), id);\n- }\n- goto out;\n- }\n-out:\n- if (local_err) {\n- error_propagate(errp, local_err);\n- object_unref(obj);\n- return NULL;\n- }\n- return obj;\n-}\n-\n void user_creatable_add_qapi(ObjectOptions *options, Error **errp)\n {\n Visitor *v;\n QObject *qobj;\n QDict *props;\n- Object *obj;\n \n v = qobject_output_visitor_new(&qobj);\n visit_type_ObjectOptions(v, NULL, &options, &error_abort);\n@@ -124,9 +60,9 @@ void user_creatable_add_qapi(ObjectOptions *options, Error **errp)\n qdict_del(props, \"id\");\n \n v = qobject_input_visitor_new(QOBJECT(props));\n- obj = user_creatable_add_type(ObjectType_str(options->qom_type),\n- options->id, props, v, errp);\n- object_unref(obj);\n+ object_new_with_props_from_qdict(ObjectType_str(options->qom_type),\n+ object_get_objects_root(),\n+ options->id, props, v, errp);\n qobject_unref(qobj);\n visit_free(v);\n }\ndiff --git a/tests/unit/check-qom-proplist.c b/tests/unit/check-qom-proplist.c\nindex 954c898ce1..89de92b7d9 100644\n--- a/tests/unit/check-qom-proplist.c\n+++ b/tests/unit/check-qom-proplist.c\n@@ -461,10 +461,9 @@ static void test_dummy_createlist_parentless(void)\n static bool test_create_obj(QDict *qdict, Error **errp)\n {\n Visitor *v = qobject_input_visitor_new_keyval(QOBJECT(qdict));\n- Object *obj = user_creatable_add_type(TYPE_DUMMY, \"dev0\", qdict, v, errp);\n-\n+ Object *obj = object_new_with_props_from_qdict(\n+ TYPE_DUMMY, object_get_objects_root(), \"dev0\", qdict, v, errp);\n visit_free(v);\n- object_unref(obj);\n return !!obj;\n }\n \n", "prefixes": [ "9/9" ] }