[{"id":3684285,"web_url":"http://patchwork.ozlabs.org/comment/3684285/","msgid":"<177749881571.809163.14770089192117728910.b4-review@b4>","list_archive_url":null,"date":"2026-04-29T21:40:15","subject":"Re: [PATCH 9/9] qom: drop user_creatable_add_type method","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Wed, 29 Apr 2026 22:08:30 +0100, Daniel P. Berrangé wrote:\n> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\n> index e0a3cd8d0f7..7080f85f95f 100644\n> --- a/qom/object_interfaces.c\n> +++ b/qom/object_interfaces.c\n> @@ -44,75 +44,11 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)\n> [ ... skip 14 lines ... ]\n> - error_append_hint(errp, \"Identifiers consist of letters, digits, \"\n> - \"'-', '.', '_', starting with a letter.\\n\");\n> - return NULL;\n> - }\n> -\n> - klass = module_object_class_by_name(type);\n\nobject_new_with_props*() does not load from module. I don't think it\nmatters for now (module objects are not user-creatable?), but is this\nintended?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WiH9sY+I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5W2d2Kckz1yHZ\n\tfor ; Thu, 30 Apr 2026 07:41:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wICeC-0007b9-MM; Wed, 29 Apr 2026 17:40:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wICeB-0007b0-Jg\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:40:43 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wICeA-0001c4-8U\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:40:43 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-680--idBsSE_ODmQGT43Q02Xpw-1; Wed,\n 29 Apr 2026 17:40:39 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 845071956080\n for ; Wed, 29 Apr 2026 21:40:38 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0EDB91954193; Wed, 29 Apr 2026 21:40:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777498841;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=uSCwF4rg6kFWa5r3IcDH4B9gtIusqUU/p2UjBXq+OAQ=;\n b=WiH9sY+ILdH5s2cTVFalFTKh265JuQEhGk4dwOAgENn3ZlslxaYFB72Epv4GvOniMy7pP2\n Z9jqHkPu5uhHw4ybuFZW58YygkvH5Eec3XPwy8Hf3LfSH03OWaV8yC+C6/Do+Y+n2nNLdl\n JKA8VH6K45UsnJ6DwAbXR1cK6nFl5DY=","X-MC-Unique":"-idBsSE_ODmQGT43Q02Xpw-1","X-Mimecast-MFC-AGG-ID":"-idBsSE_ODmQGT43Q02Xpw_1777498838","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 9/9] qom: drop user_creatable_add_type method","From":"marcandre.lureau@redhat.com","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"qemu-devel@nongnu.org, Paolo Bonzini ","In-Reply-To":"<20260429210830.594724-10-berrange@redhat.com>","References":"<20260429210830.594724-1-berrange@redhat.com>\n <20260429210830.594724-10-berrange@redhat.com>","Date":"Thu, 30 Apr 2026 01:40:15 +0400","Message-Id":"<177749881571.809163.14770089192117728910.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=821;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=pYxSuNaUcSrgPZhl6X51nvL+n/9IY2dDIYivt/DHxbU=;\n b=kA0DAAoB2ujhCXWWnOUByyZiAGnyesWjWMtbHMSggw6E/9BJCBIxhAaugFivyaLW6Kavo1dc3\n okCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp8nrFAAoJENro4Ql1lpzlk9YP/RIS\n DpisucvFnQH9hPVUe7NGoRCX8Hxth1QxmcV4/oClU9MSMoVLx/ckKHgNgAFlENhLWqlzJtAxUAy\n vXpBMTKatKgmGVzcgH0/Ev7zlTGAmL6uEbiKjSqJ67KQenUWsRSmR74N8DOCuxoMyIBrPH9TyOM\n 1BnWtICbgRvSDxgipI+N7y5CJX7b3Z/tOzncoSiIr0ofi74R8L/Fa/l8DdpYxy25d78inUEgkTu\n nQjUz9y6GzQXR9mqmHIdRU0KcqSpG0PRCpBOpSq75z5kcxBkJbDVXyC3cOtlaVhqhnb8ge1oOrm\n wMCV3o6VT528inE1b9kH0Eefcy6ojKXHQCqwbkny+rdml/+z5o+7RY5AC9DOxUAE+UcjJUXIeaM\n KIp3H2xjilN/Kz8MAx7LR5unxuRqnoaFtcYhWNkA9KeVShEZTHSmWJlnFw9yixNHTGPfdLnxp13\n Kes3ob1X46oYa6SNdsaiGfQi9a862SuVWNNl3M1JqeyeHIE+ksGw9DR9iyqyCvRObvcejjtZrvC\n Cdae+LTuyMDBECwUzZ2qPNvQJu12YZC1uF/71kBXY91B0lHFrlBxaK8QsMdC+I/M4Pid6gaKSAa\n e6XmkVeAQrnjjUzLKcwtnt80i0k3/IuT7tkQgElYNbEToqAmFLA0JejEY2BPrNvHxiIO+ImBLR6\n o/moF","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3684506,"web_url":"http://patchwork.ozlabs.org/comment/3684506/","msgid":"","list_archive_url":null,"date":"2026-04-30T07:54:29","subject":"Re: [PATCH 9/9] qom: drop user_creatable_add_type method","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Apr 30, 2026 at 01:40:15AM +0400, marcandre.lureau@redhat.com wrote:\n> On Wed, 29 Apr 2026 22:08:30 +0100, Daniel P. Berrangé wrote:\n> > diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\n> > index e0a3cd8d0f7..7080f85f95f 100644\n> > --- a/qom/object_interfaces.c\n> > +++ b/qom/object_interfaces.c\n> > @@ -44,75 +44,11 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)\n> > [ ... skip 14 lines ... ]\n> > - error_append_hint(errp, \"Identifiers consist of letters, digits, \"\n> > - \"'-', '.', '_', starting with a letter.\\n\");\n> > - return NULL;\n> > - }\n> > -\n> > - klass = module_object_class_by_name(type);\n> \n> object_new_with_props*() does not load from module. I don't think it\n> matters for now (module objects are not user-creatable?), but is this\n> intended?\n\nNo, that is an over-sight. This was not supposed to loose any\nfunctionality. We should allow user creatable objects to be\nput into modules.\n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dEKT1DE2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5mgF5sLVz1xqf\n\tfor ; Thu, 30 Apr 2026 17:55:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIMEq-0000jJ-JD; Thu, 30 Apr 2026 03:55:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMER-0000eu-1M\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 03:54:48 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMEO-0008NX-Dv\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 03:54:45 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-zlBN439oPAazxMuzO_Suig-1; Thu,\n 30 Apr 2026 03:54:35 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 71312195604F\n for ; Thu, 30 Apr 2026 07:54:34 +0000 (UTC)","from redhat.com (unknown [10.44.48.62])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 23AE119560A6; Thu, 30 Apr 2026 07:54:32 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777535677;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iI9YM6eedaHPqJ5PzVHEvplFKMdAkmMS50r3AaQ/KZg=;\n b=dEKT1DE2NbmR/yJ8181Uq1q48jJHuN22M3dDVpB/5K2N3YFhO0kYy0NFdKCVv4GGiwJnuY\n zg93SsETZaXHGV364RexR2dcUVXsr7iliQNFWWjaAEDJw2VBqB1Fycd7NFGtlhGFJiuDjf\n 9d5kw5nsw2tu0rxkeWZOphsNTPvu5sw=","X-MC-Unique":"zlBN439oPAazxMuzO_Suig-1","X-Mimecast-MFC-AGG-ID":"zlBN439oPAazxMuzO_Suig_1777535674","Date":"Thu, 30 Apr 2026 08:54:29 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"marcandre.lureau@redhat.com","Cc":"qemu-devel@nongnu.org, Paolo Bonzini ","Subject":"Re: [PATCH 9/9] qom: drop user_creatable_add_type method","Message-ID":"","References":"<20260429210830.594724-1-berrange@redhat.com>\n <20260429210830.594724-10-berrange@redhat.com>\n <177749881571.809163.14770089192117728910.b4-review@b4>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<177749881571.809163.14770089192117728910.b4-review@b4>","User-Agent":"Mutt/2.3.1 (2026-03-20)","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]