Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230566/?format=api
{ "id": 2230566, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230566/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-7-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429210830.594724-7-berrange@redhat.com>", "date": "2026-04-29T21:08:27", "name": "[6/9] qom: move object_set_prop_keyval into object.c", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "61f3a2817e6557074070793be0bc1770d10db447", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.1/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-7-berrange@redhat.com/mbox/", "series": [ { "id": 502152, "url": "http://patchwork.ozlabs.org/api/1.1/series/502152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502152", "date": "2026-04-29T21:08:21", "name": "qom: misc cleanups / fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502152/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230566/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230566/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NLoEL/Cz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VKk50bKz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:09:14 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIC9R-0007VS-8z; Wed, 29 Apr 2026 17:08:57 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9N-0007Lq-0g\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:53 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9I-0004Dv-SH\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:51 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-2WGvkuWrMM2ihsrx_s0z1Q-1; Wed,\n 29 Apr 2026 17:08:47 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 41DD5195609F\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 21:08:46 +0000 (UTC)", "from berrange.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C678C300019F; Wed, 29 Apr 2026 21:08:44 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496928;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Jqdq5nRRPqYHke78GS6zG6n5tV3IIu7WzZNe/sdNwxU=;\n b=NLoEL/Czs3vwSyUifCJpVoLlYmx2DcSEiykg8EOhiOwF5U8JAbKC9SRvXNnaiU4DqxO7Il\n U6t6tWYBerHSNi7TaPWhFAFqI+s8kzV1/HRQ1aJHIHsqW+O7Xp07aqJhqsLp1CWqATbGMA\n g7NT3CfG3nroJ2//XGCyb6GS+2sZ1NA=", "X-MC-Unique": "2WGvkuWrMM2ihsrx_s0z1Q-1", "X-Mimecast-MFC-AGG-ID": "2WGvkuWrMM2ihsrx_s0z1Q_1777496926", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH 6/9] qom: move object_set_prop_keyval into object.c", "Date": "Wed, 29 Apr 2026 22:08:27 +0100", "Message-ID": "<20260429210830.594724-7-berrange@redhat.com>", "In-Reply-To": "<20260429210830.594724-1-berrange@redhat.com>", "References": "<20260429210830.594724-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "12", "X-Spam_score": "1.2", "X-Spam_bar": "+", "X-Spam_report": "(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This matches the location of the object_set_props and object_set_propv\nmethods, since this method is not inherently tied to the user creatable\ninterface. As part of this, object_set_props_from_qdict is also exposed\nas a public API since it is still called from object_interfaces.c.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n include/qom/object.h | 47 +++++++++++++++++++++++++++--------------\n qom/object.c | 37 ++++++++++++++++++++++++++++++++\n qom/object_interfaces.c | 36 -------------------------------\n 3 files changed, 68 insertions(+), 52 deletions(-)", "diff": "diff --git a/include/qom/object.h b/include/qom/object.h\nindex 20a04cc4a9..1b2b2702fc 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -748,6 +748,37 @@ bool object_set_props(Object *obj, Error **errp, ...) G_GNUC_NULL_TERMINATED;\n */\n bool object_set_propv(Object *obj, va_list vargs, Error **errp);\n \n+/**\n+ * object_set_props_from_qdict:\n+ * @obj: a QOM object\n+ * @qdict: a dictionary with the properties to be set\n+ * @v: a visitor to iterate over @dict\n+ * @errp: pointer to error object\n+ *\n+ * For each key in the dictionary, set the corresponding\n+ * property in @obj.\n+ *\n+ * Returns: %true on success, %false on error.\n+ */\n+bool object_set_props_from_qdict(Object *obj, const QDict *qdict,\n+ Visitor *v, Error **errp);\n+\n+/**\n+ * object_set_props_from_keyval:\n+ * @obj: a QOM object\n+ * @qdict: a dictionary with the properties to be set\n+ * @from_json: true if leaf values of @qdict are typed, false if they\n+ * are strings\n+ * @errp: pointer to error object\n+ *\n+ * For each key in the dictionary, parse the value string if needed,\n+ * then set the corresponding property in @obj.\n+ *\n+ * Returns: %true on success, %false on error.\n+ */\n+bool object_set_props_from_keyval(Object *obj, const QDict *qdict,\n+ bool from_json, Error **errp);\n+\n /**\n * object_initialize:\n * @obj: A pointer to the memory to be used for the object.\n@@ -914,22 +945,6 @@ type_init(do_qemu_init_ ## type_array)\n */\n bool type_print_class_properties(const char *type);\n \n-/**\n- * object_set_props_from_keyval:\n- * @obj: a QOM object\n- * @qdict: a dictionary with the properties to be set\n- * @from_json: true if leaf values of @qdict are typed, false if they\n- * are strings\n- * @errp: pointer to error object\n- *\n- * For each key in the dictionary, parse the value string if needed,\n- * then set the corresponding property in @obj.\n- *\n- * Returns: %true on success, %false on error.\n- */\n-bool object_set_props_from_keyval(Object *obj, const QDict *qdict,\n- bool from_json, Error **errp);\n-\n /**\n * object_class_dynamic_cast_assert:\n * @klass: The #ObjectClass to attempt to cast.\ndiff --git a/qom/object.c b/qom/object.c\nindex 2671c471ab..c44e2b2eff 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -23,7 +23,9 @@\n #include \"qapi/qobject-input-visitor.h\"\n #include \"qapi/forward-visitor.h\"\n #include \"qapi/qapi-builtin-visit.h\"\n+#include \"qobject/qdict.h\"\n #include \"qobject/qjson.h\"\n+#include \"qobject/qdict.h\"\n #include \"qemu/id.h\"\n #include \"qapi/qmp/qerror.h\"\n #include \"trace.h\"\n@@ -847,6 +849,41 @@ bool object_set_propv(Object *obj,\n return true;\n }\n \n+bool object_set_props_from_qdict(Object *obj, const QDict *qdict,\n+ Visitor *v, Error **errp)\n+{\n+ ERRP_GUARD();\n+ const QDictEntry *e;\n+\n+ if (!visit_start_struct(v, NULL, NULL, 0, errp)) {\n+ return false;\n+ }\n+ for (e = qdict_first(qdict); e; e = qdict_next(qdict, e)) {\n+ if (!object_property_set(obj, e->key, v, errp)) {\n+ goto out;\n+ }\n+ }\n+ visit_check_struct(v, errp);\n+out:\n+ visit_end_struct(v, NULL);\n+\n+ return *errp == NULL;\n+}\n+\n+bool object_set_props_from_keyval(Object *obj, const QDict *qdict,\n+ bool from_json, Error **errp)\n+{\n+ bool ret;\n+ Visitor *v;\n+ if (from_json) {\n+ v = qobject_input_visitor_new(QOBJECT(qdict));\n+ } else {\n+ v = qobject_input_visitor_new_keyval(QOBJECT(qdict));\n+ }\n+ ret = object_set_props_from_qdict(obj, qdict, v, errp);\n+ visit_free(v);\n+ return ret;\n+}\n \n Object *object_dynamic_cast(Object *obj, const char *typename)\n {\ndiff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\nindex 50736b80c8..e0a3cd8d0f 100644\n--- a/qom/object_interfaces.c\n+++ b/qom/object_interfaces.c\n@@ -44,42 +44,6 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)\n }\n }\n \n-static bool object_set_props_from_qdict(Object *obj, const QDict *qdict,\n- Visitor *v, Error **errp)\n-{\n- ERRP_GUARD();\n- const QDictEntry *e;\n-\n- if (!visit_start_struct(v, NULL, NULL, 0, errp)) {\n- return false;\n- }\n- for (e = qdict_first(qdict); e; e = qdict_next(qdict, e)) {\n- if (!object_property_set(obj, e->key, v, errp)) {\n- goto out;\n- }\n- }\n- visit_check_struct(v, errp);\n-out:\n- visit_end_struct(v, NULL);\n-\n- return *errp == NULL;\n-}\n-\n-bool object_set_props_from_keyval(Object *obj, const QDict *qdict,\n- bool from_json, Error **errp)\n-{\n- bool ret;\n- Visitor *v;\n- if (from_json) {\n- v = qobject_input_visitor_new(QOBJECT(qdict));\n- } else {\n- v = qobject_input_visitor_new_keyval(QOBJECT(qdict));\n- }\n- ret = object_set_props_from_qdict(obj, qdict, v, errp);\n- visit_free(v);\n- return ret;\n-}\n-\n Object *user_creatable_add_type(const char *type, const char *id,\n const QDict *qdict,\n Visitor *v, Error **errp)\n", "prefixes": [ "6/9" ] }