[{"id":3684287,"web_url":"http://patchwork.ozlabs.org/comment/3684287/","msgid":"<177749881570.809163.1931324275553253319.b4-review@b4>","list_archive_url":null,"date":"2026-04-29T21:40:15","subject":"Re: [PATCH 6/9] qom: move object_set_prop_keyval into object.c","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Wed, 29 Apr 2026 22:08:27 +0100, Daniel P. Berrangé wrote:\n> diff --git a/qom/object.c b/qom/object.c\n> index 2671c471ab2..c44e2b2eff4 100644\n> --- a/qom/object.c\n> +++ b/qom/object.c\n> @@ -23,7 +23,9 @@\n> #include \"qapi/qobject-input-visitor.h\"\n> #include \"qapi/forward-visitor.h\"\n> #include \"qapi/qapi-builtin-visit.h\"\n> +#include \"qobject/qdict.h\"\n> #include \"qobject/qjson.h\"\n> +#include \"qobject/qdict.h\"\n\ndouble-included","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DDflbL6T;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5W2d3CWzz1yK1\n\tfor ; Thu, 30 Apr 2026 07:41:11 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wICe9-0007ai-1o; Wed, 29 Apr 2026 17:40:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wICe6-0007aS-Fn\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:40:38 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wICe4-0001bn-5H\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:40:37 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-GhD7BgPvOne4Q7XhGh-BWQ-1; Wed,\n 29 Apr 2026 17:40:33 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9229B1800366\n for ; Wed, 29 Apr 2026 21:40:32 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 26DF1180045E; Wed, 29 Apr 2026 21:40:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777498835;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=KbTZ2/A31vu8u5Fk63E89SiOYzPV3tayMh7vwYj5E5w=;\n b=DDflbL6TQPF7+ovsFgztI/CYkGVJwPf9ZQmZbWMPMA04zHnGMZH3oKUVOG+IdEmR+hFf16\n oUZjGYsGerRBQqQ8ULdWgmoSLMndOweLmqa14Q8aAajFumpgT6UYUQb1zkx8Zx6D8h8j/q\n 9VAcSLaBerotFKeAzCVwExzFpQZBw7o=","X-MC-Unique":"GhD7BgPvOne4Q7XhGh-BWQ-1","X-Mimecast-MFC-AGG-ID":"GhD7BgPvOne4Q7XhGh-BWQ_1777498832","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 6/9] qom: move object_set_prop_keyval into object.c","From":"marcandre.lureau@redhat.com","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"qemu-devel@nongnu.org, Paolo Bonzini ","In-Reply-To":"<20260429210830.594724-7-berrange@redhat.com>","References":"<20260429210830.594724-1-berrange@redhat.com>\n <20260429210830.594724-7-berrange@redhat.com>","Date":"Thu, 30 Apr 2026 01:40:15 +0400","Message-Id":"<177749881570.809163.1931324275553253319.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=528;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=qVBvMaqWiSGckAh0pYehlbLc/P8sERtJ/XAVYaiKziU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nrFz7jF7o4kHUeMK2V3at+E9ZpL/qU6upli9\n RFsR+VsyHeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJ6xQAKCRDa6OEJdZac\n 5TkiEACl2ywhHMJu3MrWuTXsYJ51X9xaCFPYD9dE3dzOXAGHk/NU701Y6fBrQXXHShju4WOQcJd\n P4yOjBUQ7jwCs8/jG1+Dh2KwYBomW7xfYrFuKB2EXwq610xZjlRCbr7d/MBhbk8MK1eaqJqmHon\n qtnvabrKCMHnBcvPpIS50++gS2Zh3cSzMkSccIcYQ2FHYlGWvwFqroIygtt0b0k/VC5uVOy1aOg\n YUd/ZEsUVd2NKkjmJ40Ixhi+Ei/+DJoifo9MZooNHhBYrIp3y3o/i4cKxWk9R1GAK1Aug0B4Hj7\n akxCQ6gdem9RHRvm0eJBr928CoC3O0Kj75AeadeIpw52psXYFWUq/HgCF0jGiHNhf5FZ/AN4CEW\n zeieAEUJHEGPhpw8aq7zbZFpLHPkaCQQgAMi0OF412wz/d/ljUIZc77xHfrCGn6nf1J9Qrlf6O4\n BHPrTTp2bLtgtaOp+4M5jRpfT/xrmqFeh6VClu47px5qYmEHR93jdLH7t5T7KxO0L7lI0vyM13m\n ujPSPKM2xWqmIscfVOjzXcQcbcJXx/wiKvFNgFB3aXUZy/icEOniQeHUyZq2gt4CvJs4bWGQNX3\n QceAdmzf++Qb8J4pFkj9xuvwdviEIvK/v1xTZQUq/oNBSFYVLspVZxj6SiU1mktMUTC1Bs8tMZt\n 955sWtz0aErAgOA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]