Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229107/?format=api
{ "id": 2229107, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229107/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-9-c413f3605311@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427-qom-tests-v1-9-c413f3605311@redhat.com>", "date": "2026-04-27T19:42:08", "name": "[09/41] RFC hw/remote: guard listener unregister in finalize", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "04c225de24b951a29e62f7ad3e6707a351e81cf0", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-9-c413f3605311@redhat.com/mbox/", "series": [ { "id": 501716, "url": "http://patchwork.ozlabs.org/api/1.1/series/501716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716", "date": "2026-04-27T19:42:03", "name": "Fix various QOM object life-cycle issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501716/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229107/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229107/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QVqupSye;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DXt5T3pz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 05:44:30 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHRs7-0001kZ-W6; Mon, 27 Apr 2026 15:44:00 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRrf-0001Fs-UP\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:33 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRrb-0007nw-P5\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:29 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-yCwMi048NfGGtorr2jsrJg-1; Mon,\n 27 Apr 2026 15:43:20 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 28DC519560AD; Mon, 27 Apr 2026 19:43:19 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9D3C81800349; Mon, 27 Apr 2026 19:43:17 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319005;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4FfbGAaXb/Oy6tWZC1/CKBN/B78na+K25Zj2q9/5zhY=;\n b=QVqupSye8CI4Y0DpoO4NuitxFdO/jsXZDn7HMFgDYjN7tfDl3jgx8FuRy1UQYkFUG4SMzW\n q9P4M9WJwj3TxCmdIKuQo1EqujNgTWCbCbCdvodWAsCpyqn356/oVMukl9TmbXvyVLkDGi\n 1Xma8FkN7S/4Jrva3RL6KluKeZBTKqc=", "X-MC-Unique": "yCwMi048NfGGtorr2jsrJg-1", "X-Mimecast-MFC-AGG-ID": "yCwMi048NfGGtorr2jsrJg_1777318999", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 27 Apr 2026 23:42:08 +0400", "Subject": "[PATCH 09/41] RFC hw/remote: guard listener unregister in finalize", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260427-qom-tests-v1-9-c413f3605311@redhat.com>", "References": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "In-Reply-To": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n jag.raman@oracle.com, Elena Ufimtseva <elena.ufimtseva@oracle.com>,\n Jagannathan Raman <jag.raman@oracle.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1108;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=HH5UXO7Edv6cxrRxb3xlPtP6qMYIGzXppxNCDLNUXEA=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUiV+S5EUisFrZViZ+m3Nvqw0to9nqOnaOc\n tRJUi6J4laJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5UUkD/9zXw3TYjSmRzTZpwlOtteDS9BC4gvxSY5EseEfOP+gPCIVtJti4fK1AwLPFy/C9SSE1ya\n HA39QXEnaRB3NeV77F5J9uS6H556gpMUUo4xz3pOWCZqeP80a1GuvXMlusBfWDy/sW1uwhQ+22y\n 8Sw7mbkQqAvMFK4zvZ34v5ROjhYnObYWwGZIBebGQJPVqGyNpdWcCyOrTnxWPbFMNKrQv0/p8Nd\n XnoCp3JUo8Yamsq1ismFUqkbIJ3/WC9iiylo1JIjOogcw+qq7O13AWcXG8G8SgCcVijQzcT++oU\n P2rWXFarjSvWozuaKlSL/1aR8Cj5OS/ZJUVlOQS08nihrVDKrumC1QgMQ0JcOs7snCFlSeGBaRe\n byWTwZE8VjG+ctxAdF4wKlIdqExGGVbwrQuOkdc89HdgOsJZiwBGR/xS+qsIezrTjOVRAuSo5SJ\n t7Ft0sxrigmGnQvzG11NV0VTxa9SlQ0gndXVHozDKJtgPE3HfgvH2YemHCzBM98QC7Py+PXb3zA\n Q42EFweeI2NPMCLPScnD3NxUwHu3bZB7uHtck0VZ7nMWsSUGCWcP8eP7vNpq6PEG9c0Oyx3oXBO\n AcsIiXnjz9VYB0GV+EegxIA98AGKWzme4f5jtamgBSQD57AQ5FdYl0Eo/I7Ekr+3RdzUoofhwOs\n EqxLL68PBMJwHBA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Guard the unregister by checking whether the listener callback was\nset, which only happens right before registration.\n\nThis is probably better addressed by \"[PATCH] qdev: test if DeviceListener\nis in use\". Just adding this patch for completeness.\n\nCc: jag.raman@oracle.com\nFixes: c7d80c7c1d9 (\"multi-process: Associate fd of a PCIDevice with its object\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/remote/remote-obj.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c\nindex 86192dc8dad..4e74ae76158 100644\n--- a/hw/remote/remote-obj.c\n+++ b/hw/remote/remote-obj.c\n@@ -154,7 +154,9 @@ static void remote_object_finalize(Object *obj)\n RemoteObjectClass *k = REMOTE_OBJECT_GET_CLASS(obj);\n RemoteObject *o = REMOTE_OBJECT(obj);\n \n- device_listener_unregister(&o->listener);\n+ if (o->listener.unrealize) {\n+ device_listener_unregister(&o->listener);\n+ }\n \n if (o->ioc) {\n qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);\n", "prefixes": [ "09/41" ] }