[{"id":3682930,"web_url":"http://patchwork.ozlabs.org/comment/3682930/","msgid":"","list_archive_url":null,"date":"2026-04-27T19:58:39","subject":"Re: [PATCH 09/41] RFC hw/remote: guard listener unregister in\n finalize","submitter":{"id":71309,"url":"http://patchwork.ozlabs.org/api/people/71309/","name":"Jagannathan Raman","email":"jag.raman@oracle.com"},"content":"On 4/27/26 3:42 PM, Marc-André Lureau wrote:\n> Guard the unregister by checking whether the listener callback was\n> set, which only happens right before registration.\n>\n> This is probably better addressed by \"[PATCH] qdev: test if DeviceListener\n> is in use\". Just adding this patch for completeness.\n>\n> Cc: jag.raman@oracle.com\n> Fixes: c7d80c7c1d9 (\"multi-process: Associate fd of a PCIDevice with its object\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/remote/remote-obj.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c\n> index 86192dc8dad..4e74ae76158 100644\n> --- a/hw/remote/remote-obj.c\n> +++ b/hw/remote/remote-obj.c\n> @@ -154,7 +154,9 @@ static void remote_object_finalize(Object *obj)\n> RemoteObjectClass *k = REMOTE_OBJECT_GET_CLASS(obj);\n> RemoteObject *o = REMOTE_OBJECT(obj);\n> \n> - device_listener_unregister(&o->listener);\n> + if (o->listener.unrealize) {\n> + device_listener_unregister(&o->listener);\n> + }\n> \n> if (o->ioc) {\n> qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);\n>\nHi Marc-Andre,\n\nI submitted a patch a short while back concerning this: \nhttps://patchew.org/QEMU/20260427162700.89750-1-jag.raman@oracle.com/\n\nDo you want to stick to your patch, or want me to proceed with mine \n(while addressing feedback from Peter Maydell)? I'm OK with either approach.\n\nBest regards,\n\nJag","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256\n header.s=corp-2025-04-25 header.b=juoNDiaJ;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-oracle-onmicrosoft-com\n header.b=qOQNsGt8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Dtm0gkdz1yHv\n\tfor ; Tue, 28 Apr 2026 06:00:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHS6W-0004Al-NC; Mon, 27 Apr 2026 15:58:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHS6T-0003wx-Q4\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:58:50 -0400","from mx0a-00069f02.pphosted.com ([205.220.165.32])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHS6R-00038J-Us\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:58:49 -0400","from pps.filterd (m0333521.ppops.net [127.0.0.1])\n by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63REMvXO1326882; Mon, 27 Apr 2026 19:58:46 GMT","from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta01.appoci.oracle.com [130.35.100.223])\n by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4drmha45uq-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 19:58:46 +0000 (GMT)","from pps.filterd\n (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.7/8.18.1.7)\n with ESMTP id 63RJuKgw006490; Mon, 27 Apr 2026 19:58:45 GMT","from co1pr03cu002.outbound.protection.outlook.com\n (mail-westus2azon11010007.outbound.protection.outlook.com [52.101.46.7])\n by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id\n 4drm2hqcsc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 19:58:45 +0000 (GMT)","from IA4PR10MB8301.namprd10.prod.outlook.com (2603:10b6:208:55e::6)\n by PH0PR10MB4599.namprd10.prod.outlook.com (2603:10b6:510:39::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Mon, 27 Apr\n 2026 19:58:41 +0000","from IA4PR10MB8301.namprd10.prod.outlook.com\n ([fe80::de06:e5db:6e3c:f8e0]) by IA4PR10MB8301.namprd10.prod.outlook.com\n ([fe80::de06:e5db:6e3c:f8e0%3]) with mapi id 15.20.9846.025; Mon, 27 Apr 2026\n 19:58:41 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=\n corp-2025-04-25; bh=K2Iq0dtSb6jIVKNFIiVXu/OXzTgoXR+YP7NA84yWD0I=; b=\n juoNDiaJcYEpE8OcgC3IYF/MvMaWPnTndVDUVYEy1ib2B8vrj24EHcigM16f+fw1\n cJvXRB26W2gyWAcRxxJu+NYoYJjCzSHSyJdNsCede70eVdRsQu6H6ADTvgmwF64Q\n jqNe0UTbte29spP3tJm+PidYbAoPmDx2X+fB9ZOo9J/m0AMH+19hUR7F/tlRV3rY\n 3/J4uf9H5JQkS4V2/8B3u1X7JSS8Mknc1HzCfcGiwzo8C5R1UmR+WXxjCU7OSynr\n qvIMjJRfYujjiCcP4sthqXZWZfmDR4pfFqyaMT8EURxSQ3s7VCi2BdDpOAdqhWXq\n wDt3VtH2bzKrwZT7/EErYQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=K2Iq0dtSb6jIVKNFIiVXu/OXzTgoXR+YP7NA84yWD0I=;\n b=qOQNsGt8JpNMvC77BAEf7m7sQsH4L9Dfxh9OasMNwXLykR/svQb7zdRLRFjH/UnLctRXt8kB3Nk5e8u+9sLfB/ARi9cgiLFcn6b5s7EjURi9xvwugL97m9BZR4aak2sXbYKf+fhMcsTVYfGnpkLQmftP2GC5+qz47ZNYHsGqDc8="],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=pjKDssh6sj011YcwqZ59DcsreuGtQ6xN6Tmbqe6/2vg5Dyng2zmPqTi7x80XeIaaR8a4MqE9GrJSmNDD6Z2zgvjD4AyyFGbcP2NOVIaxoce8EVOKrEXc0oWPvcn1deD79UKqwWDAUsFwAwVz1bXIrAUZvT/rKQvmF66WrDyMyGTo6eBc4Ul20rM+lGunQwwwzVghbiT9T+GBN1TyQ6a19HWF14vc4edAXQdzkkuO3aocQquFksTJTA5RqTLIZV0bvGJKRrBwcU+G3lefYD59RsPq7MMDmCpuDKq9DgUBqUsoIZJR1oEGCmjd9zOIn4y6w43DzXtR7rPGhpKMo/9r0w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=K2Iq0dtSb6jIVKNFIiVXu/OXzTgoXR+YP7NA84yWD0I=;\n b=hXeqo2ccWBbGYboiLY7Ly/e+V36D4sRTFiOKsGn36sHSnWhFghr9WKD+7RVlTc1sGUybHl5y+kGCssD67hwmZsgZBN4qHkw3zVy9U3Vngn3nJVL9j6VrsYSsYmlhVHM7r308NN58Vg9WKQE8SY3oz2jT77NKue8/xOyhdFipT3xU/i0GNnpQpzNKTR+MaPF1YpohNKkyrGilnzX8Acsb5k7ccn4cGaGCEL/2sjlaJI/TUyVYEUvvLke02RwTFKkp4EZjCEByLKC41+2P8WcmzNnjb/3YwQFcmpEgcSrS1+p0PrdafYXYGDEZoefqmk1+fc4sn6qP13v4stV6Mirkhw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;\n dkim=pass header.d=oracle.com; arc=none","Message-ID":"","Date":"Mon, 27 Apr 2026 15:58:39 -0400","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/41] RFC hw/remote: guard listener unregister in\n finalize","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Elena Ufimtseva ","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-9-c413f3605311@redhat.com>","Content-Language":"en-US","From":"Jagannathan Raman ","In-Reply-To":"<20260427-qom-tests-v1-9-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"CH0P221CA0024.NAMP221.PROD.OUTLOOK.COM\n (2603:10b6:610:11c::20) To IA4PR10MB8301.namprd10.prod.outlook.com\n (2603:10b6:208:55e::6)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"IA4PR10MB8301:EE_|PH0PR10MB4599:EE_","X-MS-Office365-Filtering-Correlation-Id":"a224607b-7b02-4745-9803-08dea4976158","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|366016|1800799024|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n RxZOYa+1ZPvCywEdkluzBl9rksrPKq9AxAKY5iCqGX6Tg9ITMHMIiW/watzdxHZBEYxJGJzDcPuUiEQcNZ8aUZOYnbmlQGiCn6/X9p+co4h/UzD2oQfIHGFwj88OsKyd/hXWmjwuaXVYT9Au8aCUEv4/qQojejQVYGEGSWzU/3TZ0ytXlHA9n4ZP9jfisXSblgON7fSIdmKeTp14Frm2RMWwywYlRzyn9VAHYr+BRs9Cc5GiQk6eySvD8q7HPDvM+2L8jQiDmiNu0rTpAo8S9u5/kbG+eCUld4rbu0GMWGUAPRdixHFDqd49KzC5Vtser5pHwesMpuwxkyz0yosby+oUXAW+c/sHCkJ/9W37LL712oXjK9uwWor7nCWNHSuX9VI/ETEjtokOMaph83lsdE/Q5kdOM1C+3VJV2+5ppyvDp63uuWRk9ok4HCW5ZYI9r1/VTecw5vb217aZmTGcH5meu0FX/2DhDPa5N4q3h4FvEC52WrCH1/e59nbFQSl1h8mY30GRtdfz4i2hOCI97UXzDvWp6ibZILLgq1mnXDF0HJeY6uAHdqPGYGFBUueoLJpc7u4JkON/5czd+cp0etsX/De2RnbnOeazXfXGSrYPHDyvgmti1Ms4ksXJs4aLClFZlt8QszHzbOxjX68WJTgJJKYi5LEPqhWsMSo54qOiXQyR/od69qV2D6GKeeif","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA4PR10MB8301.namprd10.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?AEC3k2fCCeVpDqbbfD9MHknwcSWM?=\n\t=?utf-8?q?vKAi28CgChhFcvoyjpa+Sy0puJ15OHm6UBsIAnLdmgPF3u5yBo0vQJPz3hv4XeGJ7?=\n\t=?utf-8?q?vnoqUzoGdh+7jwzdrqUDBNzop/XLlpUn558FMC5hAo8wXNvjmXw7FAfmtCbFWZDs1?=\n\t=?utf-8?q?kE9GZrM209lQTFFkwCgZkJddrkPeqCfyMtFsRB0+wOtYsnR9irxALL4zwx5WNHA8u?=\n\t=?utf-8?q?0vDSYgR2ew6ZcKvXrBWW3n4xI0nLLeqyKEesGG+2J/zL14Z3dGB7jd2uAfCAWoUtF?=\n\t=?utf-8?q?RC4RK9e75RgDjXYuZqDY552kBpRw7qDdIJeWLboxikb7Yqo5Szg7VuT5JO+DBqwEu?=\n\t=?utf-8?q?6PvMasex+xjXYmq+GKBAeXZBdVz4xVF9UMhjMD0RS4J005mIxR4x1h4PE4vTPKZhv?=\n\t=?utf-8?q?hTQbyansa12PFO0BYmD/+VnX/iJeWHj6Fyqld9AZMbdoD2syP0jMxKfkEuYHcpm/p?=\n\t=?utf-8?q?ZoJmPdIq+MOuxnC1Ibnpz09Yr1hzV11zOYZg/B1e9pr7wTppYpZ/co7QGlpoSpSwr?=\n\t=?utf-8?q?Vca4Dzb6TfWAbkeVbosfzRUyF27oSavY7iOzj9TBzr7gzX/dnlSvNk3/77zKtM+Sv?=\n\t=?utf-8?q?wxv3JXJOQnqt2ITfaYSJmMtm2VG1YEt5XFP6aBlhmXGPLAJOYjTE8zC7P8WxR0DOG?=\n\t=?utf-8?q?6MfuKxrj5kr24wTt/cRFtFBeapZGdmPleUZzDxfYzZMVwM4U6qIBEuYGlssIMT3ic?=\n\t=?utf-8?q?0T0Jz5hAYRomk6wAaub76gDT3s8QaNnpK7vMJbAFId1Bqztwkp3Z3XIShRbBEIMV4?=\n\t=?utf-8?q?qISZllfSaMCvVS8LYLkHcIbdBNKexCCoKK1izkd3wode9HZVjTAHMNjbYF/WoSpev?=\n\t=?utf-8?q?+XYj1kKWoxE/o9WtllE194W6lj5l9m+4y+IgwbPs4Hik4NDkbJzKqccFS2x5XICjE?=\n\t=?utf-8?q?nypdE/tyQTvZv5t1Q5Lj7jmUwFumJdTQCKFa92fCGd0TdG1Yn4wmFc19XY0stypoR?=\n\t=?utf-8?q?RsB8oCxpN6VmlYnkX2jvb8JTzV7AMR+YrmTMvhd9HVcM2qH1PzZDX4I5LP2FE0xnS?=\n\t=?utf-8?q?AOQmH3i6KFbkKK0yxyMsd/2fEk7D9iJRxu3Zz6TuibkbWVofYcyiykiIr1lpCTl71?=\n\t=?utf-8?q?2W5VVq3FpOa446IMnx8Kezn10AE21BGUxJhjF6+1t+BThbaH4gvufFTUf3/k5BrNp?=\n\t=?utf-8?q?CMpqzdyY7JqOB6W4J9rYyJ6VbeZHvs8nurI64ctrDRSCbT7jMRQ8hZDXBibUVAlu5?=\n\t=?utf-8?q?b6/9wFk5dJuwp/xLaLlfFO/LwCZLbKlpQL1A8Z05uOaegoBW9biUcTUvAi55R7qIr?=\n\t=?utf-8?q?orXa9ChERLGXBRsoLETJoK2n3IO/fb5mzg0zmHn/O087JgHpbypK+CunWtBkdn4HC?=\n\t=?utf-8?q?2BKLrP/xwi1QfauOSfxzybSqrFw2ZldMiUOlYwivYuRfv+LdGm+zVcygGwU8eHMS7?=\n\t=?utf-8?q?NMVeU4iERNSubrx3YTFFypjT2R+X0xj6CItHxxDdRVl9ZAN/dncdSniBhR/Q22gEM?=\n\t=?utf-8?q?nbi+01o7oUE8K35vg0E/wUXHBa1ZVphROx0kuLDrhmqjyx0CLEvf6AkGiCXIsmVUq?=\n\t=?utf-8?q?8o0dPtMWYav+Ed5yShB4FC+whG6GjdmmkjhH40Mp1WDG6sKsS0Yx0r9ZdMU4sqSCm?=\n\t=?utf-8?q?ejDHPRLYgwC9KmpDTg2Q25nxbNfGrK5kCt4S/83uK9Q3TZ2jx58Frn0qwQ/IGcYlF?=\n\t=?utf-8?q?FKHD9ybXeKeXvzn+emBrwvaPGd68EVaQ=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n NQ84wZKNdd4ywE9W13LUuFCyHWBiPR40Z8uypB3EUhpd73hEUgpsEo/ZcGBcmZMojjI5s59JB1jLnKoe+BC5e41l0NiIyjgsPNKqVhmXiqJPZR9h4FaruVkP/JELpJn5gr/Tzcq7XhHjTd0Ke3nqtQ+nRszCvpQBpG38zguPGrRZYc1I9y7N2yoZB/MqIaWrqCdkIFF4Hs5FKtci0EnvsNmyqnWZt2njZQsqE1BmLbfyOQU3Psaup9OZSbw6ou/M1YzFHbXEcdMkOBU4c/x4kYRSTWgWDCAg4q+GmergTmS0ZXOVNPV0VQjvKRzB70oRe1mJmi6WuysqObHblonKKA==","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0":"\n yBbVi+SDoIXyGWmutQUqFo3xLlGdFzc8SUgRWNxI368FEhk6xS5jDFMwYDKN4nemJwlFS9Qg11SpbJNqTFOAyUUh37ckIEphEoTtYZ06eiYK5dnHeuWowzlbfoBPUAh23dRHHXjz/n5S5STEYh/QmA3UBL6BcFmAO9l7O1aEeHvS9Kcp4vLQd70vBvFhKeluSk48s1TIHbZ8DYKoQzaTIxyFKb/PScrzW2NklbqlVRMqUPyWOVhMNef5Vff5ypv+wlB6Qks4gmla3Oq3TxYm+Y4tAUBKGzW6GZLWiunAfyktG5k0a3isHmB8D7sBRNNo68xVAFzh+wLamUodI7eOF7ZdkQTh8ZYySWytSc9Gf6Amcaz2D5ptPUsF6rtURYq+UyhK530iv1fZU2ZJAduj2S+aWKFP8JlmhBJ5TJ3ig8VxREh63ucyShg6yHysiaymFQGWqcuRWo4skPVHqFVQtpAXbDC5crjeyN9LWdHLVEXnQbXX1G3cmsfLUzkxzd2GcHWIwhsHXFHWlqKsaF2vlsbWIbJ95tF6QQR3RxuIbUtMQRN/LNpXaZKCnczU5XjIhltREnBMPBhGvIjQJtV5YjqntKM2cBAqfzuXQub/FnA=","X-OriginatorOrg":"oracle.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a224607b-7b02-4745-9803-08dea4976158","X-MS-Exchange-CrossTenant-AuthSource":"IA4PR10MB8301.namprd10.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"27 Apr 2026 19:58:41.4552 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"4e2c6054-71cb-48f1-bd6c-3a9705aca71b","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n nHo1kX2eE85ESxbSeoB2RsSHH3dgZrKVwIvYtBWCpzmgvwDsJnlaQI6sPjh43FdNuuqYkRc0uUTC+ZRnMCEpKw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH0PR10MB4599","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 suspectscore=0\n mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0\n lowpriorityscore=0\n malwarescore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx\n scancount=1 engine=8.19.0-2604200000 definitions=main-2604270212","X-Proofpoint-GUID":"sr9GN1PNweKaFzGuRRC3X1RjdMn6IrkV","X-Proofpoint-ORIG-GUID":"sr9GN1PNweKaFzGuRRC3X1RjdMn6IrkV","X-Authority-Analysis":"v=2.4 cv=CrOPtH4D c=1 sm=1 tr=0 ts=69efbff6 b=1 cx=c_pps\n a=zPCbziy225d3KhSqZt3L1A==:117\n a=zPCbziy225d3KhSqZt3L1A==:17\n a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19\n a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=jiCTI4zE5U7BLdzWsZGv:22 a=x0eKOSpe3m1H3M0S9YoZ:22 a=GaQpPoNlAAAA:8\n a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=4skM9U2y3GkL2T6Yt7MA:9 a=3ZKOabzyN94A:10\n a=QEXdDO2ut3YA:10 a=xF5q_uoM5gZT5J3czcBi:22 cc=ntf awl=host:12309","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI3MDIxMiBTYWx0ZWRfXxmaIHuVTSG9K\n WNh178HP1H+C3ybt71xwid3iZRduufynwUivElj9Z4o68RVplHb+hN6PGpVQIpp6FQdSyGsWJ53\n DSNfLIJDO9kHV92wfIZLtfl/InheNzRFs1FEgOZ1dbMRdfDas17tus+ypKyOkhq+gBtEOcxeRNH\n +PyfHvwarZSQqemYUt98qzrWD5XTDqFVhiYNld1A+uo/T6xUfkr6/gDUWNBKuSCfk6tL8bvaXMg\n nPkEf5Sdjsm1bfugUlkxMLLQ+4xz0QTvAouCG2fEmxGjSuvDVTapYW2eOKUge/wQfyEwgM5n9OW\n zByh41W/PGXUm4KJ1x61M3mPlq1qol25eV3OOmHjnhVwgAPx9I2CuUkVTh7ARAWkd9QMKZi2PMT\n t5EPqNAx6vMJ+E734o0l+E9C6BxttoQjaZ0Jq/dbnSQPgCs/ogZ5gUs1IBhOiWVsUqIvOcQyecu\n 2/RpL8olYz2ltz6iDCtEQ7PR1Nlfb+Puq+Sd82C8=","Received-SPF":"pass client-ip=205.220.165.32;\n envelope-from=jag.raman@oracle.com;\n helo=mx0a-00069f02.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3683355,"web_url":"http://patchwork.ozlabs.org/comment/3683355/","msgid":"","list_archive_url":null,"date":"2026-04-28T10:17:17","subject":"Re: [PATCH 09/41] RFC hw/remote: guard listener unregister in\n finalize","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"Hi\n\nOn Tue, Apr 28, 2026 at 12:02 AM Jagannathan Raman wrote:\n>\n>\n> On 4/27/26 3:42 PM, Marc-André Lureau wrote:\n> > Guard the unregister by checking whether the listener callback was\n> > set, which only happens right before registration.\n> >\n> > This is probably better addressed by \"[PATCH] qdev: test if DeviceListener\n> > is in use\". Just adding this patch for completeness.\n> >\n> > Cc: jag.raman@oracle.com\n> > Fixes: c7d80c7c1d9 (\"multi-process: Associate fd of a PCIDevice with its object\")\n> > Signed-off-by: Marc-André Lureau \n> > ---\n> > hw/remote/remote-obj.c | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c\n> > index 86192dc8dad..4e74ae76158 100644\n> > --- a/hw/remote/remote-obj.c\n> > +++ b/hw/remote/remote-obj.c\n> > @@ -154,7 +154,9 @@ static void remote_object_finalize(Object *obj)\n> > RemoteObjectClass *k = REMOTE_OBJECT_GET_CLASS(obj);\n> > RemoteObject *o = REMOTE_OBJECT(obj);\n> >\n> > - device_listener_unregister(&o->listener);\n> > + if (o->listener.unrealize) {\n> > + device_listener_unregister(&o->listener);\n> > + }\n> >\n> > if (o->ioc) {\n> > qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);\n> >\n> Hi Marc-Andre,\n>\n> I submitted a patch a short while back concerning this:\n> https://patchew.org/QEMU/20260427162700.89750-1-jag.raman@oracle.com/\n>\n> Do you want to stick to your patch, or want me to proceed with mine\n> (while addressing feedback from Peter Maydell)? I'm OK with either approach.\n\nI'd be happy to review/take your patch. Then I might include it in\nfuture iterations of this series if you don't mind.\nYou may consider adding the Fixes: trailer.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=S/5JoyvC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4bx92V1Pz1yHX\n\tfor ; Tue, 28 Apr 2026 20:18:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHfVW-0003ma-96; Tue, 28 Apr 2026 06:17:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHfVV-0003lo-0H\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 06:17:33 -0400","from mail-dy1-x1329.google.com ([2607:f8b0:4864:20::1329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHfVT-0000v9-95\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 06:17:32 -0400","by mail-dy1-x1329.google.com with SMTP id\n 5a478bee46e88-2ecf9e398f4so2968370eec.1\n for ; Tue, 28 Apr 2026 03:17:30 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1777371449; cv=none;\n d=google.com; s=arc-20240605;\n b=ChdzLu0Bz4QBXxQhSHuaPyc7y9OZmoPUIRMN2A6edDa+qpE2HJVtqZ//4MZmyT4/ym\n 5fYPNwrXQ/idJu/YQQ9qs2NUpn+i8E6x1iy7Yj4JuQU1r1b/fkUa6gPiHANireV8AYkd\n 3o6SMczB2RrIFHBRRcHstcoPAp+Nmy1xyBR8syXsCPmQSc5hoTXMQJ9rNMmrpDxMmn9n\n 27nHeDc8DWGekRBnonnP6PWPPvijYKr2Ay4ur2g+8dzqdnXijWdaCXIn/ek2btN5yEPW\n +UuKcdX0BrMk1aBTPCZMekcCbwsbz9eZTvkPZ6pFW9/De9Zz6vdwWidA+do2qEItxmbu\n fkvw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=1Mi1yJ503u+Doo3QDs87pihdsS2ollrbbDsZdS44yPo=;\n fh=BCuY/beMqJdGc2e0khfFuFCQpH3R3sHADBiZ/molWiI=;\n b=BTxNozscZ72vsbcH1ZmUiD1XCm+2ufKddPEX/KS+OQDxxzr8/sTIGHL88IdEASAhTi\n XMLd/+HJtA/XeaIuWk23SOp9WhJLGHHeSoaNc3VSFo+eMYgV/nqeuxkvcvEdDRR2stiB\n c4jfzTlrH7o/rFBoFE+KyA93NzZqdDcZeef9f/vnrZv1UmiiJorJxYbLzFDgx6X0eAu+\n oeb/yIzFT07tshwaavhzx6bae01q0KFQ99UiH3sUbwxirUB53QGRIrCF3S/QbqRWFOSW\n 6e8onveBSiIa17bZiAwdY0xuPMhzpubG64ifyqI2ujyRTwhe87nwhdydei5jIV9l7mab\n sQlQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777371449; x=1777976249; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1Mi1yJ503u+Doo3QDs87pihdsS2ollrbbDsZdS44yPo=;\n b=S/5JoyvCVxMRPWe5aB16JKSte++s6SSB/v07RT1bzI8BKNo0ICYbZxh/0EdCbqUJdO\n z7jZcN7KUdEEDKf61L/57y6MDaLWM0E2e9/2ouoI/BA6mqDt7lIzB+oew8zzzcwZMIEl\n KWI+EwANmiakiicr6xhhAArPFrDNG1TgX1nSHrVY6rVeVjsRSBcr9He8285PEISUtIhU\n q6VCOPsye6/mLTh8Djbbmx5CWt8IvsPbYPMXaFvPBeew28MnaJaJFAHlkhBUDGLTsLJQ\n JVf4+8A7EpR/UqETkfoKCAYcen6FYVBINKZNjIVjomrgP+VxSWvRS3BQoRX26+jkCQA8\n f1Zg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777371449; x=1777976249;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1Mi1yJ503u+Doo3QDs87pihdsS2ollrbbDsZdS44yPo=;\n b=kmaQRbAC2EVAjWCBP2Nfw3NWstbG9/GJHdYq/6/TcfdQo0l26Y++OR66etZCyIQRlZ\n zgGcRGmVVJEWzZrhrdgCkSAzb2/Uz/pg+Z4r8XDXAxeZeZt02cBSKpKl37LTyoVRsp15\n PX9zkO3YK4yJ4xwMB6K4cefwfc5fzI9ooi6Kxlgs+3JyhVy1nmCaMug6DvsQ6fEyD6q2\n LoBF9FuoY+a8tiIuI6lkYMtQr7TNNDHZuv4c7wlj+8qsvNexMQCfIbilM94VxEHGGmFW\n GhL1uA9FgR0gQWQZ5LW7RtQ2UfeL9dhaTZTWGIwCj5TCt6eawlCzIX3Khn14WURu7rZK\n ILFw==","X-Gm-Message-State":"AOJu0YxsneXN4VLjl+rwMnXj/b7Haq5/xixh29n6VQqOxkUKRd4oOpsQ\n HbXyvCThzkikoWiLur2c0cl43KTIIrAPgAXfsKK631ejo2lHLfHTAFct+ganDrhDLrrt+/m/9Sv\n i52zufGZgGojGJjoLhFaC4BKAcuLGLm4=","X-Gm-Gg":"AeBDiesC3TRH8UMYRmiC0S6XNZUKYZONnrAl+biQcq9bAqSp54AxNHtVvGa7EnSJQow\n qscSlSKAm62a6ZUE/pP77GgpY2vPBrO0wpJQWzDcYfgsEvtclpKiqPX4TlkVmmPjYewHPqNYcRr\n ivIRMOyoUjT58kp7fhFco8sa2sFsVAYt18n2LGMbEcvHIB9q+7/u/yr8JU8ft2LJEYDYw417YIP\n xw77N2UFq4Sjyl5QtkECDfQasNERtiWRV2HhaGKrz44kPrfWkOSkwmCuJjhx5oTnHaZkefWhNO4\n 9fRXyMSAi5+1NU1Fs1NFgxODs0gsT1dUCaYCuOkjuGVzRCu0R0xetHyG+LqZBA==","X-Received":"by 2002:a05:7300:724e:b0:2c9:1943:e7ff with SMTP id\n 5a478bee46e88-2ed09fd8f72mr1259921eec.10.1777371449172; Tue, 28 Apr 2026\n 03:17:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-9-c413f3605311@redhat.com>\n ","In-Reply-To":"","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Tue, 28 Apr 2026 14:17:17 +0400","X-Gm-Features":"AVHnY4IVlViS2gdkhfWI73L2OXgq_sDxGMrBSpLtRsgpxArKMyzwYAnV7JU4GXQ","Message-ID":"\n ","Subject":"Re: [PATCH 09/41] RFC hw/remote: guard listener unregister in\n finalize","To":"Jagannathan Raman ","Cc":"qemu-devel@nongnu.org, armbru@redhat.com,\n Elena Ufimtseva ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1329;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-dy1-x1329.google.com","X-Spam_score_int":"-16","X-Spam_score":"-1.7","X-Spam_bar":"-","X-Spam_report":"(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001,\n FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]