Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229037/?format=api
{ "id": 2229037, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229037/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260427171734.621893-1-pavrampu@linux.ibm.com/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/1.1/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427171734.621893-1-pavrampu@linux.ibm.com>", "date": "2026-04-27T17:17:34", "name": "memcontrol04: Fix test failure by keeping pagecache children alive", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "ad30630915b839041ae4d92d37d13d085704b52b", "submitter": { "id": 91766, "url": "http://patchwork.ozlabs.org/api/1.1/people/91766/?format=api", "name": "Pavithra", "email": "pavrampu@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260427171734.621893-1-pavrampu@linux.ibm.com/mbox/", "series": [ { "id": 501695, "url": "http://patchwork.ozlabs.org/api/1.1/series/501695/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=501695", "date": "2026-04-27T17:17:34", "name": "memcontrol04: Fix test failure by keeping pagecache children alive", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501695/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229037/comments/", "check": "warning", "checks": "http://patchwork.ozlabs.org/api/patches/2229037/checks/", "tags": {}, "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=BaF95RkB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g49Hk4T9hz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 03:17:54 +1000 (AEST)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 28DBB3E2541\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 19:17:51 +0200 (CEST)", "from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 9EE273D0338\n for <ltp@lists.linux.it>; Mon, 27 Apr 2026 19:17:47 +0200 (CEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 98FB1600348\n for <ltp@lists.linux.it>; Mon, 27 Apr 2026 19:17:46 +0200 (CEST)", "from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63RE0AaJ3076657\n for <ltp@lists.linux.it>; Mon, 27 Apr 2026 17:17:44 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn44hrs8-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)\n for <ltp@lists.linux.it>; Mon, 27 Apr 2026 17:17:44 +0000 (GMT)", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63RH8qHA003073\n for <ltp@lists.linux.it>; Mon, 27 Apr 2026 17:17:43 GMT", "from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8avpa32-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)\n for <ltp@lists.linux.it>; Mon, 27 Apr 2026 17:17:42 +0000 (GMT)", "from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63RHHd6b38535486\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 17:17:39 GMT", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 2CB8E20040;\n Mon, 27 Apr 2026 17:17:39 +0000 (GMT)", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id AF82F20043;\n Mon, 27 Apr 2026 17:17:37 +0000 (GMT)", "from li-49acbccc-2994-11b2-a85c-d51b89e344f1.ibm.com.com (unknown\n [9.124.220.170])\n by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Mon, 27 Apr 2026 17:17:37 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=pp1; bh=pOoThPiGeEU/6PGcavVAnaSJ9nVK4euDi8TAD4siJ\n CM=; b=BaF95RkBAav1DKyJ3oqfdMZeP2135trA06NzD80jM+qcFdxaoz0O0joAM\n 6J60+ld7sDhHhhZm73VxMxj9Z2AI5xYA4vZPwlVRhmE871FUbcWDZMZbagVPKANS\n OLJQKwUg+dyejN77ypR22WNPRKnPvAi2wzb1m4vZO2hSDOZjRFVxkM4AYa95/1Mq\n vOGaqVvhSNtjd3j5WA8WfTsl6q8Z7PkRJCEEnZ8O/U8WSJj59PrgS/gbJkCJozT6\n epS0+iT+UHrJQ7dVFpXBrCS5zGbnMOnKlWevvmYiveNkqia8tgFyniTux9WJpddf\n dp/iJVStr04ZotNgh8IRJ1Jh05fLA==", "From": "Pavithra <pavrampu@linux.ibm.com>", "To": "ltp@lists.linux.it", "Date": "Mon, 27 Apr 2026 22:47:34 +0530", "Message-ID": "<20260427171734.621893-1-pavrampu@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "X-Proofpoint-ORIG-GUID": "Lu7qWg5LtHzCS8HKYRt4xsyKbcIxUFro", "X-Authority-Analysis": "v=2.4 cv=Ft81OWrq c=1 sm=1 tr=0 ts=69ef9a38 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=41JfSkleQcHGdEibQjgA:9", "X-Proofpoint-GUID": "Lu7qWg5LtHzCS8HKYRt4xsyKbcIxUFro", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDI3MDE4NCBTYWx0ZWRfX1QIqEXB/oS/Q\n U69a6Icsj6OXnrzG6h5Pl06ExLAkTkXTaV+d1JcwVXQ7OhsfJwDR5MiiJ5izk/0+IY5iZAtT57z\n WxWuAIwWIn09Az0nIcGSZdsqg0C+JwIydzCxpJ02TVWMTfqaun++BTpbkwdVk9L6WN0jn4Anse/\n 5AQFWX49kzesEzqJzkeg0Wc+S+SmC9f+i9iis51dFLyXJyQmWNkcbxejfNc0BPOPq4ifJe9G0/p\n UozHSXZ2ThGLQ/Bu++3mDHFR2JA/TjQtMGECR7WGtOGBxSF8l5sEUHrnriiNMf+Yo9wOE5vzJr6\n hjmn581jzmrojXmmo88loJki/7hifp9IWuYRfJAqYrJ89MSHKAZ6ftnXIDbOOFlnAX73VUEgoLj\n FXSNOlcG4zO/W40TysbtXbzpC3o/BcqY/jRvjgR+Hqa29e9Q0/DZpxMDdVZc0ExyIzaEOM1jkPH\n 2VhgyqKzsEsOEn+oKZg==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0\n clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270184", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DMARC_PASS,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled\n version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-2.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH] memcontrol04: Fix test failure by keeping pagecache\n children alive", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "Cc": "pavrampu@linux.ibm.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "The test was failing with memory.current values much lower than expected:\n TFAIL: (A/B/C memory.current=6684672) ~= 34603008\n TFAIL: (A/B/D memory.current=5373952) ~= 17825792\n\nRoot cause:\nChild processes allocating pagecache were exiting immediately after\nallocation (via tst_reap_children()), causing the pagecache to be\nfreed before the test could measure memory.current values.\n\nFix:\nModified alloc_pagecache_in_child() to keep children alive during test:\n- Added TEST_DONE checkpoint for child lifecycle coordination\n- Parent waits for CHILD_IDLE checkpoint before proceeding\n- Child signals CHILD_IDLE after allocation and fsync\n- Child waits for TEST_DONE to keep memory allocated during test\n- Modified cleanup_sub_groups() to wake waiting children before cleanup\n- Changed alloc_anon_in_child() to use SAFE_WAITPID() for specific child\n\nThis matches the pattern used in memcontrol03.c and ensures pagecache\nremains allocated during memory pressure testing, allowing correct\nmemory.current measurements.\n\nSigned-off-by: Sachin Sant <sachinp@linux.ibm.com>, Pavithra <pavrampu@linux.ibm.com>\n---\n .../kernel/controllers/memcg/memcontrol04.c | 22 ++++++++++++++++---\n 1 file changed, 19 insertions(+), 3 deletions(-)", "diff": "diff --git a/testcases/kernel/controllers/memcg/memcontrol04.c b/testcases/kernel/controllers/memcg/memcontrol04.c\nindex 715cc5bcd..d0188a1da 100644\n--- a/testcases/kernel/controllers/memcg/memcontrol04.c\n+++ b/testcases/kernel/controllers/memcg/memcontrol04.c\n@@ -47,7 +47,8 @@ static struct tst_cg_group *leaf_cg[4];\n static int fd = -1;\n \n enum checkpoints {\n-\tCHILD_IDLE\n+\tCHILD_IDLE,\n+\tTEST_DONE,\n };\n \n enum trunk_cg {\n@@ -67,6 +68,16 @@ static void cleanup_sub_groups(void)\n {\n \tsize_t i;\n \n+\tfor (i = ARRAY_SIZE(leaf_cg); i > 0; i--) {\n+\t\tif (!leaf_cg[i - 1])\n+\t\t\tcontinue;\n+\n+\t\tTST_CHECKPOINT_WAKE2(TEST_DONE,\n+\t\t\t\t ARRAY_SIZE(leaf_cg) - 1);\n+\t\ttst_reap_children();\n+\t\tbreak;\n+\t}\n+\n \tfor (i = ARRAY_SIZE(leaf_cg); i > 0; i--) {\n \t\tif (!leaf_cg[i - 1])\n \t\t\tcontinue;\n@@ -88,7 +99,7 @@ static void alloc_anon_in_child(const struct tst_cg_group *const cg,\n \tconst pid_t pid = SAFE_FORK();\n \n \tif (pid) {\n-\t\ttst_reap_children();\n+\t\tSAFE_WAITPID(pid, NULL, 0);\n \t\treturn;\n \t}\n \n@@ -107,7 +118,7 @@ static void alloc_pagecache_in_child(const struct tst_cg_group *const cg,\n \tconst pid_t pid = SAFE_FORK();\n \n \tif (pid) {\n-\t\ttst_reap_children();\n+\t\tTST_CHECKPOINT_WAIT(CHILD_IDLE);\n \t\treturn;\n \t}\n \n@@ -117,6 +128,11 @@ static void alloc_pagecache_in_child(const struct tst_cg_group *const cg,\n \t\tgetpid(), tst_cg_group_name(cg), size);\n \talloc_pagecache(fd, size);\n \n+\tSAFE_FSYNC(fd);\n+\n+\tTST_CHECKPOINT_WAKE(CHILD_IDLE);\n+\tTST_CHECKPOINT_WAIT(TEST_DONE);\n+\n \texit(0);\n }\n \n", "prefixes": [] }