[{"id":3682846,"web_url":"http://patchwork.ozlabs.org/comment/3682846/","msgid":"<20260427172935.3996-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-27T17:29:35","subject":"Re: [LTP] memcontrol04: Fix test failure by keeping pagecache\n children alive","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Pavithra,\n\nOn Mon, 27 Apr 2026, Pavithra wrote:\n> memcontrol04: Fix test failure by keeping pagecache children alive\n\n> Signed-off-by: Sachin Sant , Pavithra \n\nEach contributor must have their own Signed-off-by line:\n\n Signed-off-by: Sachin Sant \n Signed-off-by: Pavithra \n\nThis is a bug fix; please add a Fixes: tag pointing to the commit that\nintroduced the broken behaviour.\n\n> +\tfor (i = ARRAY_SIZE(leaf_cg); i > 0; i--) {\n> +\t\tif (!leaf_cg[i - 1])\n> +\t\t\tcontinue;\n> +\n> +\t\tTST_CHECKPOINT_WAKE2(TEST_DONE,\n> +\t\t\t\t ARRAY_SIZE(leaf_cg) - 1);\n> +\t\ttst_reap_children();\n> +\t\tbreak;\n> +\t}\n\nARRAY_SIZE(leaf_cg) - 1 = 3 assumes all three pagecache children were\ncreated. If cleanup() is invoked during partial setup, TST_CHECKPOINT_WAKE2\nwill time out waiting for missing processes and emit a spurious TBROK.\nTrack the number of children actually spawned and wake only that many.\n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=L/aWbm2/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g49YP0gJsz1yHX\n\tfor ; Tue, 28 Apr 2026 03:29:45 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id D479E3E253F\n\tfor ; Mon, 27 Apr 2026 19:29:42 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 2BA5E3C9F01\n for ; Mon, 27 Apr 2026 19:29:38 +0200 (CEST)","from mail-ot1-x341.google.com (mail-ot1-x341.google.com\n [IPv6:2607:f8b0:4864:20::341])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id C1D6A60071C\n for ; Mon, 27 Apr 2026 19:29:37 +0200 (CEST)","by mail-ot1-x341.google.com with SMTP id\n 46e09a7af769-7d4c383f2fcso8802021a34.0\n for ; Mon, 27 Apr 2026 10:29:37 -0700 (PDT)","from\n runnervmeorf1.0w0tfn3qdpzejc0fgepyjequzf.gx.internal.cloudapp.net\n ([20.29.29.22]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7de9866b88csm34125a34.15.2026.04.27.10.29.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 10:29:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777310976; x=1777915776; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NqpSPugwwWbZ1ppuZka6xHCPWHcJ/j2V60NBejxVsyo=;\n b=L/aWbm2/dK5n2g7jqCLHaiAOge/9CCo0tYK0Y5KN7Iup6YqAseT3IkSSKtjiRAlQEk\n NTYL/xsfpD5dcfxHeYTvmPvsw9xFjY59J/RdxwsfC0g7SitEL3wrpD4vEfzz/DhR3HM1\n 6B2vZoC/o7mBe78+rvITd7lB7tV3iQQ5Za2BzajGXS4mK2KLhXywR10myxh+onG+R7UN\n GR9BopKZXMaqAlcxp7PXqz5xehTP4UF5Wp6OeTfw04hlJwO/QbEGewJLeTdeevlXItiO\n s/aZ7EB574gKK7zfi6v1kImcTNVpQe9D4kJB5PJxU+L6pj83HfhhfNGJGXU8PZ69aeU0\n 2b5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777310976; x=1777915776;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=NqpSPugwwWbZ1ppuZka6xHCPWHcJ/j2V60NBejxVsyo=;\n b=HBKu22CgEYccpYL7oSKVgZ1ogWJFoK/FWILm070qBo94qWSn+rWrUFIakY+tDn3h2D\n H2y34oanaVN/YZovne/VUOPzBMdNlLxzb0v/nrg+seKOO15cEIpHwOmlJ70ALbB8UML/\n SZ9WjvESjBZ6dqGvRHg9O3t/IJ9vchLaBwvBoFuiFp8AzGyXR73/+ub6OON8zxogesWu\n Yp0ypcvjtStGkGB895atIb3wKZfAPD5rMXSTJCI9Ie7S2Clhnz0Oion8sTYjKmWAw5Xk\n OB+V0AMbIY8PeWsp7OwGYh1EN1ZcyG3Hd6OmFCVIA7lI3rTgid0kCOnkYJM6TCWoRG+n\n rnyA==","X-Gm-Message-State":"AOJu0YyIl94G1BKRAfzbhbOQ0ACD1HO2mfomfNnlc0nVYqJf9/+6PJ7O\n Slv7zc1dwhU25Kh0ljvahjdj1omIFxYGwOZCb4TFTu1Sh+ANGud9Wd38","X-Gm-Gg":"AeBDievKn6keAjoNI2HDUevHvpUjZmo1xngyQjncj4XN/GHPPvP/S9Itou70stlVgSa\n wtwx1DSfYR3/RQeRhuppEkXbtxQOR3EdUXGBOmP8pbeueOtDBSto76isygjsZyH+g/wnrc6wZm8\n bGCCNNHN9TwgZTgDbqvdsPaSTi8qXXKhTskQsDrbVMpKZ9aeUv3YRQR3qbU8WGW7zTyzVHyZDZM\n N7NHVbow89QwLCdD3PflZgPgCOfdOc/bolLy7371d4YZcHVLsFErJimWxx60cBcvjfG8yVEeDr9\n EOb7bDg5MkaC6CtTaYo3HbK03TkTecFVYh9ypMabOnijyypPfkpy809mnstrTROJjkwBTYDHRAk\n iDPwakIZTVa1eShQXmSebEg3iXZZ4rkMpXKLHMfEJhz+5X3PVp6tc0ltPeLvD2mJS9N54UiRAuL\n uATe2g3a1kLZlZrPSADFGJGnEprNZrWO2dLEXQ75jdnzZdL5nksTjN7A9CbguzM+j0WOa03jdCd\n b1jGPSldcwxPhqTixXd1g/dEW5HczUT0wEJoSj47BTFUJO1sNmzZkInAQ==","X-Received":"by 2002:a05:6830:2b29:b0:7dc:cba3:e8f2 with SMTP id\n 46e09a7af769-7de98932736mr22612a34.19.1777310976431;\n Mon, 27 Apr 2026 10:29:36 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Pavithra ","Date":"Mon, 27 Apr 2026 17:29:35 +0000","Message-ID":"<20260427172935.3996-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260427171734.621893-1-pavrampu@linux.ibm.com>","References":"<20260427171734.621893-1-pavrampu@linux.ibm.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] memcontrol04: Fix test failure by keeping pagecache\n children alive","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]