Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2227426/?format=api
{ "id": 2227426, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2227426/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423170229.64655-13-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260423170229.64655-13-philmd@linaro.org>", "date": "2026-04-23T17:02:24", "name": "[12/16] target/arm: Remove vcpu_dirty=true assigments in hvf_handle_exception()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6af86f32b1ac089dd2116565da918f0dc0394f28", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423170229.64655-13-philmd@linaro.org/mbox/", "series": [ { "id": 501223, "url": "http://patchwork.ozlabs.org/api/1.1/series/501223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501223", "date": "2026-04-23T17:02:12", "name": "accel/hvf: Assorted collection of patches queued before v11 release", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501223/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227426/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227426/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZZ1vcM/D;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1jC41pjgz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 03:05:20 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFxTt-0002h0-Rh; Thu, 23 Apr 2026 13:04:49 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFxTG-0001dF-7V\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:04:15 -0400", "from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFxTA-0005kM-LQ\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:04:09 -0400", "by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-43d75312379so5076075f8f.1\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 10:04:04 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4412150a092sm19901683f8f.23.2026.04.23.10.04.01\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 23 Apr 2026 10:04:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776963843; x=1777568643; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+igmwACxKAAriU8rkOxPQALcbbgJ0c+NUQHQmbA0Oqs=;\n b=ZZ1vcM/DKMfjIYSbz6C3eQXOE8LBX/M9ZKEqsHfphitZgcPIf+YBKQyIAgkvycPL+B\n Uj411BXVUL/Elfh1EBoUwGsgYZ7+HmNo35hRkC1cqL/dcuqD0oU28FxXZAQBf1RvfrT0\n 4sbRYJJCJQKBb9sUPSpkdoamo1+Q+DHYZzx+QgffIV3ZeP0fKo+xNedD12z1qvaakelq\n YCFCXp44Wu1KkfjicB6Z6Ag7sPumz/BlAv5bqF8TSSzV91YaCVmMV5aBVaRnjzMIgNr9\n r79mztr0X9HSZg9GrnGLS5eziFhJF/VulCImlHuzHrm7UegCpUiGIh8PAjHLO8SnrpA5\n KC/g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776963843; x=1777568643;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=+igmwACxKAAriU8rkOxPQALcbbgJ0c+NUQHQmbA0Oqs=;\n b=enR8W0W7JM4kYhSGauFyU9kN8yHTFyP7RcOc1B6SGAazur539tJIBMdbU6RtUw8p0V\n ZCYhqntJa9Cmy4FEoeJ6bAzfrgit3s0fl+109cntU59U0uCI58hLv6aq/3DGj45j9URs\n ZM/etl+o79zgwDSLTjsIkiMCLV5gaU9/7AsnN3LRVHLsvz7Bawi2pCvVncjEPXspH9mO\n sDYUTd6vXnm4o8KgM7Ihl8dKGk3ElCuF1ucDGMLHVfW0Cz//UaDP0uYtUvhTZtvmSkU+\n hkSFrkZAiva/pEjKPk6AqIohhx2F2TO7UxJd9xtiOJXh1F7JwzgxNRwg4NIQYKUNba8l\n yPtw==", "X-Gm-Message-State": "AOJu0YwJ2UrNgjdK+Ht+SLoT54qdAXhQl7NtozhDH8W+jf27G3O85bEZ\n Mr129ejDpaiLSKaiQF10c2Fo5vOAu0Oc1W7fPCcZDl9z89zoLoJuAVp8KsLf8edAgNv56od/ByH\n SjB9kM0g=", "X-Gm-Gg": "AeBDievdoy+QRrdWbY82QoTD0X35FTBQGA1fKryevqJ/+inJ9jP+aIKFq54tRXV+xtg\n v2g/R13iqDaK8kuBibYzGmh4Y0jJY4r5+0CoY6ypw4atd7ZjutMYskpsoVzBC//0CYa88s8AVWi\n 1IJWROGV1BSCFW6Q0THcWKF/Gc5D2D9VCNQjEHX+kDgDJIFWu3XiSmfrMAmadgPndsqgs+YX+Cd\n YhQQxJbrcvebGemc/5W9yAoRYiSVCOK8wvgpcSjyxYILLOP0kkxSBA2a1a7AliKMAUZ4u9W/gxd\n uCMSppjivHiyupv1yU7Nj4yEfTo8Nht7OXj5HQG/AE8ZoDQQab/KWfGiJ/xKuNKMI7tDtS0m9v6\n xrwB2yFfm4ES2jPBP5Vjq12ErrGgSkLom4/VhH+J+0iJWV0gJxzrS44rp/W9ixP2Om9PRnsj7CA\n gz2bq0E2Ddic2BH0iF1VjyrjyTE87mW8+v8Z6WyNnP80b7yMKnFkQ+cf+MZKiiZkdpUCeLd7xpo\n wZAEAoWWXI=", "X-Received": "by 2002:a5d:64e5:0:b0:43d:7606:5a47 with SMTP id\n ffacd0b85a97d-43fe3f358a5mr43126165f8f.2.1776963842597;\n Thu, 23 Apr 2026 10:04:02 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Roman Bolshakov <rbolshakov@ddn.com>,\n Jonathan Cameron <jonathan.cameron@huawei.com>, Mads Ynddal <mads@ynddal.dk>,\n qemu-arm@nongnu.org, Mohamed Mediouni <mohamed@unpredictable.fr>,\n Peter Maydell <peter.maydell@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@csgraf.de>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Alex?=\n\t=?utf-8?q?_Benn=C3=A9e?= <alex.bennee@linaro.org>", "Subject": "[PATCH 12/16] target/arm: Remove vcpu_dirty=true assigments in\n hvf_handle_exception()", "Date": "Thu, 23 Apr 2026 19:02:24 +0200", "Message-ID": "<20260423170229.64655-13-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423170229.64655-1-philmd@linaro.org>", "References": "<20260423170229.64655-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Commit 2a425aae0b5 (\"target/arm: ensure PSCI register updates\nare flushed\") manually sets %vcpu_dirty in hvf_handle_exception(),\nbut these calls follow calls to cpu_synchronize_state() which\nitself sets %vcpu_dirty. Better have the generic CPU API handle\nthis, but add a pair of assertions when serializing the accelerator\nstate to be safe.\n\nSuggested-by: Alex Bennée <alex.bennee@linaro.org>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n target/arm/hvf/hvf.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\nindex 2fb768048b8..f2c5bde5983 100644\n--- a/target/arm/hvf/hvf.c\n+++ b/target/arm/hvf/hvf.c\n@@ -737,6 +737,8 @@ int hvf_arch_get_registers(CPUState *cpu)\n hv_simd_fp_uchar16_t fpval;\n int i, n;\n \n+ assert(!cpu->vcpu_dirty);\n+\n for (i = 0; i < ARRAY_SIZE(hvf_reg_match); i++) {\n ret = hv_vcpu_get_reg(cpu->accel->fd, hvf_reg_match[i].reg, &val);\n *(uint64_t *)((void *)env + hvf_reg_match[i].offset) = val;\n@@ -888,6 +890,8 @@ int hvf_arch_put_registers(CPUState *cpu)\n hv_simd_fp_uchar16_t fpval;\n int i, n;\n \n+ assert(cpu->vcpu_dirty);\n+\n /*\n * Set SVCR first because changing it will zero out Z/P (including NEON)\n * regs\n@@ -2239,7 +2243,6 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)\n /* SMCCC 1.3 section 5.2 says every unknown SMCCC call returns -1 */\n env->xregs[0] = -1;\n }\n- cpu->vcpu_dirty = true;\n } else {\n trace_hvf_unknown_hvc(env->pc, env->xregs[0]);\n hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized(), 1);\n@@ -2256,7 +2259,6 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)\n /* SMCCC 1.3 section 5.2 says every unknown SMCCC call returns -1 */\n env->xregs[0] = -1;\n }\n- cpu->vcpu_dirty = true;\n } else {\n trace_hvf_unknown_smc(env->xregs[0]);\n hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized(), 1);\n", "prefixes": [ "12/16" ] }