[{"id":3681703,"web_url":"http://patchwork.ozlabs.org/comment/3681703/","msgid":"<69b840fd-e274-4069-b472-5bdc40b1c0a2@linaro.org>","list_archive_url":null,"date":"2026-04-23T22:38:22","subject":"Re: [PATCH 12/16] target/arm: Remove vcpu_dirty=true assigments in\n hvf_handle_exception()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/24/26 03:02, Philippe Mathieu-Daudé wrote:\n> Commit 2a425aae0b5 (\"target/arm: ensure PSCI register updates\n> are flushed\") manually sets %vcpu_dirty in hvf_handle_exception(),\n> but these calls follow calls to cpu_synchronize_state() which\n> itself sets %vcpu_dirty. Better have the generic CPU API handle\n> this, but add a pair of assertions when serializing the accelerator\n> state to be safe.\n> \n> Suggested-by: Alex Bennée\n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> target/arm/hvf/hvf.c | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=D+ZHVdpV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1rc453S5z1y2d\n\tfor ; Fri, 24 Apr 2026 08:39:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wG2gv-00027y-Jk; Thu, 23 Apr 2026 18:38:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG2gt-00027M-RQ\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 18:38:35 -0400","from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wG2gs-0005U6-BI\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 18:38:35 -0400","by mail-pj1-x1032.google.com with SMTP id\n 98e67ed59e1d1-35da2d35eccso5039747a91.0\n for ; Thu, 23 Apr 2026 15:38:33 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3614186a52csm26887253a91.4.2026.04.23.15.38.27\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 15:38:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776983912; x=1777588712; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=GcyBCWSwuqG+v+Hc0b6p7lbRTqkOioJq0+pQQRDLbPk=;\n b=D+ZHVdpVjf47RX4jWBbL9C7ooNkdEA19zfI92XVez620cvyBcTnHLqziaG7fmDjaP6\n ICNo30hK1Q/Ec6tEe+zbyi8WbcOU2kqzIJDWR4PFVNIGbXT/zHeoQNRkgarRejrGLaM3\n a75hH5ZmeQsTbGS30Hfpi/+IW4vBLXFgDZSYvdFsuOYuPC8x6LrBQ8JHU5DWYP8uwujG\n S55cyPVnIXqXU4/Fc0GrGaaxAGs5XU1xSKWpM8Wy11hsBPs5tIsA5850JxMYNlI6x8Ym\n ndgbsF+UC5TLNuGG1Sex1zAlelSL9X+s6IYovJJRFeBtfnOx8RdNSvu6lxD+Ldndnhav\n YiXg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776983912; x=1777588712;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=GcyBCWSwuqG+v+Hc0b6p7lbRTqkOioJq0+pQQRDLbPk=;\n b=pCbT4fJ4LnsuHuBs5eB3WwqS67lkBkAQ29swM2ZxvycIfIIUrXPVxRWP8agIZ+Ql3Q\n NHiUANWavJFxsJ7FYbk3pm6Okym3fisbcXv+yxL/UozFUv0wCWAVR/JsLw5cYrYxaDWx\n NVp/BcjIQOnsAIIWzABuU3k2R5OFpdUVAeuS9rdGFpfrvmGAVxX1NchwEBq2g6y2iNlP\n lS8lB59HV5ClZf5ldQLByOM9HEsOcYaHK/RKY8iyAe6UfDrvaptUcrLxHBVSjxPVZFk8\n pK58TEkPc/U61pLyrIeQyHyVzOsiHZ7FXICXondV5LmM290lO1zJ9jrEd4aki+gtmCFB\n FhlA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8eI8FdGIiPUEQyy3COi/6PA9bpaQkeBD3FLWLSut8FAmegQSRahwHp6OWsqDCnp9FYKNQ9/a4YgZH5@nongnu.org","X-Gm-Message-State":"AOJu0YyBS2/dFQyxNWShesoOe/a5Mm6tEbNprD2rcSqURzNqBkj2itDs\n 6WDeLkHC9GXyoROokeT4BbpFXsltQ9bjt35t6IC3Nc/OwLM1nCKJH89+h4JsnjfgfDw=","X-Gm-Gg":"AeBDiesjfsuQ4VMptQW9gofNmdBnpl+Uww4alE+cOdY+9I7hJKW2HSjJ/jMHbOeZXtr\n BTiBQIlDFrLCCAz67f3V7MnQ76zzGPZcNMszacgMeghGhtCOr6cNo85pUwN+ViH2OI4z9YNEXEc\n w46ld9nhek/+SaPFb5Uq/9xLjpNtLWbm4iy+1cs5NF0jTceYtG2bIXTpIQl4UiugdsN2g8+tOvS\n CacTTrD7bTgQkolv4WpF2QKRLAyvGvMIFh+1X0O5kabeXzVtwgtPX0C04vqOlNnyTi03JbZG0YT\n VW7xthj78GsEf/ZsmPB4RgdZorKoMAdBWB6pz0iiuq5gkK+chjwvzrn6mwcpqlIRwAkPm1I0ziW\n iI+kovcZtAthcmiytF6Llmexb6OLZYrqCW9WngPdqspYjZwuiBrHMvu1rfc9mSlXhpIFkksZJ8r\n +vxYcLLEU96BwNw//81RtaWHLTLp/RHlza+hUpPGhLUCLJNAV+qA==","X-Received":"by 2002:a17:90b:5890:b0:35e:5723:85e3 with SMTP id\n 98e67ed59e1d1-361403f12ddmr30141119a91.9.1776983912389;\n Thu, 23 Apr 2026 15:38:32 -0700 (PDT)","Message-ID":"<69b840fd-e274-4069-b472-5bdc40b1c0a2@linaro.org>","Date":"Fri, 24 Apr 2026 08:38:22 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 12/16] target/arm: Remove vcpu_dirty=true assigments in\n hvf_handle_exception()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Roman Bolshakov ,\n Jonathan Cameron , Mads Ynddal ,\n qemu-arm@nongnu.org, Mohamed Mediouni ,\n Peter Maydell ,\n Paolo Bonzini , Alexander Graf ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ","References":"<20260423170229.64655-1-philmd@linaro.org>\n <20260423170229.64655-13-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423170229.64655-13-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1032;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]